[ovs-git] [openvswitch/ovs] d46285: netdev-dpdk: Consistent variable naming.

GitHub noreply at github.com
Fri Apr 8 02:56:50 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: d46285a2206f33177c20f15278c73b3bd906a4b9
      https://github.com/openvswitch/ovs/commit/d46285a2206f33177c20f15278c73b3bd906a4b9
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2016-04-07 (Thu, 07 Apr 2016)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: Consistent variable naming.

In different functions we use different variable names ('netdev_', 'netdev',
'dev', 'vhost_dev', ...) for the same objects.

This commit changes the code to comply with the following convention:

'struct netdev':'netdev'
'struct netdev_dpdk':'dev'
'struct virtio_net':'virtio_dev'
'struct netdev_rxq':'rxq'
'struct netdev_rxq_dpdk':'rx'

Also, 'dev->up.' is replaced by 'netdev->', where 'netdev' was already
defined.

Suggested-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Tested-by: Ilya Maximets <i.maximets at samsung.com>
Acked-by: Ilya Maximets <i.maximets at samsung.com>
Acked-by: Mark Kavanagh <mark.b.kavanagh at intel.com>


  Commit: d17f4f082c1e7f09414157b652af0be93334f29e
      https://github.com/openvswitch/ovs/commit/d17f4f082c1e7f09414157b652af0be93334f29e
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2016-04-07 (Thu, 07 Apr 2016)

  Changed paths:
    M lib/dpif-netdev.c

  Log Message:
  -----------
  dpif-netdev: Proper error handling in do_add_port().

This fixes multiple error path mistakes in do_add_port, none of which
has been a problem in practice so far. This change will make it easier
for a following commit to return in case of error.

Also, this removes an unneeded special case for tunnel ports.

Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Tested-by: Ilya Maximets <i.maximets at samsung.com>
Acked-by: Ilya Maximets <i.maximets at samsung.com>
Acked-by: Mark Kavanagh <mark.b.kavanagh at intel.com>


  Commit: 490e82afe1f9855856cfe1bd31509ca53037c743
      https://github.com/openvswitch/ovs/commit/490e82afe1f9855856cfe1bd31509ca53037c743
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2016-04-07 (Thu, 07 Apr 2016)

  Changed paths:
    M lib/dpif-netdev.c

  Log Message:
  -----------
  dpif-netdev: Keep count of elements in port->rxq[].

This will ease deleting a port with no open rxqs.

Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Tested-by: Ilya Maximets <i.maximets at samsung.com>
Acked-by: Ilya Maximets <i.maximets at samsung.com>
Acked-by: Mark Kavanagh <mark.b.kavanagh at intel.com>


  Commit: 71f634cfea19046d46aceb2e0f7d73aefed9e882
      https://github.com/openvswitch/ovs/commit/71f634cfea19046d46aceb2e0f7d73aefed9e882
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2016-04-07 (Thu, 07 Apr 2016)

  Changed paths:
    M lib/dpif-netdev.c
    M tests/bridge.at

  Log Message:
  -----------
  dpif-netdev: Remove useless dpif-dummy/delete-port appctl.

It is only used in the testsuite and it can be replaced by a dpctl
command.

Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Tested-by: Ilya Maximets <i.maximets at samsung.com>
Acked-by: Ilya Maximets <i.maximets at samsung.com>
Acked-by: Mark Kavanagh <mark.b.kavanagh at intel.com>


  Commit: 62453dada95c0b2d91525700008aa9899e5c98a8
      https://github.com/openvswitch/ovs/commit/62453dada95c0b2d91525700008aa9899e5c98a8
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2016-04-07 (Thu, 07 Apr 2016)

  Changed paths:
    M lib/dpif-netdev.c

  Log Message:
  -----------
  dpif-netdev: Do not keep refcount for ports.

Only the main thread will delete ports after pausing every other
thread.  There's no need to keep count.

Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Tested-by: Ilya Maximets <i.maximets at samsung.com>
Acked-by: Ilya Maximets <i.maximets at samsung.com>
Acked-by: Mark Kavanagh <mark.b.kavanagh at intel.com>


Compare: https://github.com/openvswitch/ovs/compare/f274a0470849...62453dada95c


More information about the git mailing list