[ovs-git] [openvswitch/ovs] 8be420: ovsdb: Properly handle error returned from from re...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 8be420879d4fcfdb2a8aa68bb47b7c7c1cf83844
      https://github.com/openvswitch/ovs/commit/8be420879d4fcfdb2a8aa68bb47b7c7c1cf83844
  Author: Andy Zhou <azhou at ovn.org>
  Date:   2016-08-31 (Wed, 31 Aug 2016)

  Changed paths:
    M ovsdb/replication.c

  Log Message:
  -----------
  ovsdb: Properly handle error returned from from reset_database()

Fix a memory leak in case of error. The error object was not properly
disposed.  Since the error to reset DB is not expected, log it and
exit.

Signed-off-by: Andy Zhou <azhou at ovn.org>
Acked-by: Ben Pfaff <blp at ovn.org>


  Commit: 3109b4e127facbed2bb8dea38efdb008d2c0c5c1
      https://github.com/openvswitch/ovs/commit/3109b4e127facbed2bb8dea38efdb008d2c0c5c1
  Author: Andy Zhou <azhou at ovn.org>
  Date:   2016-08-31 (Wed, 31 Aug 2016)

  Changed paths:
    M ovsdb/ovsdb-server.c
    M ovsdb/replication.c
    M ovsdb/replication.h
    M tests/ovsdb-server.at

  Log Message:
  -----------
  ovsdb: Add blacklist_tables

Currently, 'sync-exclude-tables' command line options are simply stored
in a string. Change the implementation to store it in an shash instead
to improve modularity.

One additional benefit of this change is that errors can be detected
and reported to user earlier.  Adde a 'dryrun' option to
set_blacklist_tables() API to make this feature available to the
command line option parsing and unixctl command parsing.

Signed-off-by: Andy Zhou <azhou at ovn.org>
Acked-by: Ben Pfaff <blp at ovn.org>


  Commit: 599c0f4487b9a632ff835b78a40f51f396586be2
      https://github.com/openvswitch/ovs/commit/599c0f4487b9a632ff835b78a40f51f396586be2
  Author: Andy Zhou <azhou at ovn.org>
  Date:   2016-08-31 (Wed, 31 Aug 2016)

  Changed paths:
    M ovsdb/replication.c

  Log Message:
  -----------
  ovsdb: Add request_ids

When starting, the replication logic may issue multiple requests at
a time, for example, one monitor request for each databases. The
request_ids keeps track of all outsanding request IDs that are used
for matching reply message with. It also provides the 'db' context
for the reply.

Future patches will make use of this facility.

Signed-off-by: Andy Zhou <azhou at ovn.org>
Acked-by: Ben Pfaff <blp at ovn.org>


  Commit: 6ab3dd961635646a762ce24fc9d38dfebe0bc0f4
      https://github.com/openvswitch/ovs/commit/6ab3dd961635646a762ce24fc9d38dfebe0bc0f4
  Author: Andy Zhou <azhou at ovn.org>
  Date:   2016-08-31 (Wed, 31 Aug 2016)

  Changed paths:
    M ovsdb/ovsdb-server.c
    M ovsdb/replication.c
    M ovsdb/replication.h

  Log Message:
  -----------
  ovsdb: (Re)hide struct db in ovsdb-server.c

It seems odd that the currently replication implementation moves the
struct db from ovsdb-server.c (file private) to replication.h (global).

This patch moves the 'struct db' defintion back into ovsdb-server.c,

Signed-off-by: Andy Zhou <azhou at ovn.org>


  Commit: 5dd81c22a62d81741c5516e3e1a6c61809fd609f
      https://github.com/openvswitch/ovs/commit/5dd81c22a62d81741c5516e3e1a6c61809fd609f
  Author: Andy Zhou <azhou at ovn.org>
  Date:   2016-08-31 (Wed, 31 Aug 2016)

  Changed paths:
    M tests/ovsdb-replication.at
    M tests/ovsdb-server.at

  Log Message:
  -----------
  test: Improve replication unit tests

Replication test currently uses many sleeps that slowes the test down
and may not be reliable. Remove those sleeps when possible.

OVSDB servers needs to be killed on test failure. Use on_exit() to
ensure cleanup happens, so they don't have to be handled for each
testing step.

Signed-off-by: Andy Zhou <azhou at ovn.org>
Acked-by: Ben Pfaff <blp at ovn.org>


  Commit: 23c16b51247304e12cccc91b83d2f8984607a5f6
      https://github.com/openvswitch/ovs/commit/23c16b51247304e12cccc91b83d2f8984607a5f6
  Author: Andy Zhou <azhou at ovn.org>
  Date:   2016-08-31 (Wed, 31 Aug 2016)

  Changed paths:
    M ovsdb/ovsdb-server.c
    M ovsdb/replication.c
    M ovsdb/replication.h

  Log Message:
  -----------
  ovsdb: Reimplement replication. Using a state machine.

Current replication uses blocking transactions, which are error prone
in practice, especially in handling RPC connection flapping to the
active server.

Signed-off-by: Andy Zhou <azhou at ovn.org>
Acked-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/7724ed8d6406...23c16b512473