[ovs-git] [openvswitch/ovs] d03603: netdev-dpdk: When no QoS set, set type to empty st...

GitHub noreply at github.com
Fri Aug 5 00:38:02 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: d03603c48527069c1bb81a0eb32165a317930e80
      https://github.com/openvswitch/ovs/commit/d03603c48527069c1bb81a0eb32165a317930e80
  Author: Maxime Coquelin <maxime.coquelin at redhat.com>
  Date:   2016-08-04 (Thu, 04 Aug 2016)

  Changed paths:
    M AUTHORS
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: When no QoS set, set type to empty string

This patch sets *typep to an empty string instead of letting
it uninitialized when no QoS configuration is set.

It fixes the following vswitchd crash when no QoS has been set
on vhost-user interface:

 $> ovs-appctl -t ovs-vswitchd qos/show vhost-user1

 #0  0x00007efcbadf18d7 in raise () from /lib64/libc.so.6
 #1  0x00007efcbadf353a in abort () from /lib64/libc.so.6
 #2  0x000000000068d5be in ovs_abort_valist at lib/util.c:335
 #3  0x0000000000693d90 in vlog_abort_valist at lib/vlog.c:1204
 #4  0x0000000000693e17 in vlog_abort at lib/vlog.c:1218
 #5  0x000000000068d3ae in ovs_assert_failure at lib/util.c:72
 #6  0x000000000060425c in ds_put_format_valist at lib/dynamic-string.c:168
 #7  0x00000000006042e7 in ds_put_format at lib/dynamic-string.c:142
 #8  0x00000000005a9e75 in qos_unixctl_show at vswitchd/bridge.c:3185
 #9  0x000000000068cda1 in process_command at lib/unixctl.c:347
 #11 unixctl_server_run at lib/unixctl.c:400
 #12 0x000000000040a3ff in main at vswitchd/ovs-vswitchd.c:113

Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
Acked-by: Ian Stokes <ian.stokes at intel.com>
Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>




More information about the git mailing list