[ovs-git] [openvswitch/ovs] da9cfc: Revert "pvector: Expose non-concurrent priority ve...

GitHub noreply at github.com
Wed Aug 10 22:04:51 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: da9cfca6e2d70c4c8e4bec7ff644a71da149c4b8
      https://github.com/openvswitch/ovs/commit/da9cfca6e2d70c4c8e4bec7ff644a71da149c4b8
  Author: Jarno Rajahalme <jarno at ovn.org>
  Date:   2016-08-10 (Wed, 10 Aug 2016)

  Changed paths:
    M lib/classifier.c
    M lib/classifier.h
    M lib/dpif-netdev.c
    M lib/pvector.c
    M lib/pvector.h
    M tests/test-classifier.c

  Log Message:
  -----------
  Revert "pvector: Expose non-concurrent priority vector."

This reverts commit 8bdfe1313894047d44349fa4cf4402970865950f.

I failed to see that lib/dpif-netdev.c actually needs the concurrency
provided by pvector prior to this change.  More specifically, when a
subtable is removed, concurrent lookups may skip over another subtable
swapped in to the place of the removed subtable in the vector.

Since this was the only use of the non-concurrent pvector, it is
cleaner to revert the whole patch.

Reported-by: Jan Scheurich <jan.scheurich at ericsson.com>
Signed-off-by: Jarno Rajahalme <jarno at ovn.org>
Acked-by: Daniele Di Proietto <diproiettod at vmware.com>




More information about the git mailing list