[ovs-git] [openvswitch/ovs] 26f858: ofproto-dpif-xlate: Fix VLOG_ERR_RL() call.

GitHub noreply at github.com
Fri Aug 12 01:03:09 UTC 2016

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 26f858a9174dc4c2283e5d5f0d798d9a0c478e55
  Author: Joe Stringer <joe at ovn.org>
  Date:   2016-08-11 (Thu, 11 Aug 2016)

  Changed paths:
    M ofproto/ofproto-dpif-xlate.c

  Log Message:
  ofproto-dpif-xlate: Fix VLOG_ERR_RL() call.

a716ef9a7a73 ("ofproto-dpif-xlate: Log flow in XLATE_REPORT_ERROR.")
inadvertantly broke build on clang due to improper passing of the ds
cstring into the VLOG() function:

error: format string is not a string literal
      (potentially insecure) [-Werror,-Wformat-security]
  XLATE_REPORT_ERROR(ctx, "over max translation depth %d", MAX_DEPTH);
note: expanded from macro
      VLOG_ERR_RL(&error_report_rl, ds_cstr(&ds));        \

Reported-by: Daniele Di Proietto <diproiettod at vmware.com>
Signed-off-by: Joe Stringer <joe at ovn.org>
Acked-by: Daniele Di Proietto <diproiettod at vmware.com>

More information about the git mailing list