[ovs-git] [openvswitch/ovs] 96a234: ovn-controller: Fix memory leak of nat_ip_keys sse...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 96a234ad8a96314cb083dc1816f0023e0940bc92
      https://github.com/openvswitch/ovs/commit/96a234ad8a96314cb083dc1816f0023e0940bc92
  Author: Ramu Ramamurthy <ramu.ramamurthy at us.ibm.com>
  Date:   2016-08-19 (Fri, 19 Aug 2016)

  Changed paths:
    M ovn/controller/pinctrl.c

  Log Message:
  -----------
  ovn-controller: Fix memory leak of nat_ip_keys sset in send_garp_run().

This commit fixes the following leak found by check-valgrind in the test:
"send gratuitous arp for nat ips in localnet"

sset gets allocated but not destroyed.

valgrind.14154-==14157== 1,892 bytes in 44 blocks are definitely lost in loss record 176 of 180
valgrind.14154-==14157==    at 0x4C29BFD: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
valgrind.14154-==14157==    by 0x48E1E7: xmalloc (util.c:112)
valgrind.14154-==14157==    by 0x487EDC: sset_add__ (sset.c:51)
valgrind.14154-==14157==    by 0x411A46: get_nat_addresses_and_keys (pinctrl.c:1231)
valgrind.14154-==14157==    by 0x411A46: send_garp_run (pinctrl.c:1260)
valgrind.14154-==14157==    by 0x411A46: pinctrl_run (pinctrl.c:787)
valgrind.14154:==14157==    by 0x407ABE: main (ovn-controller.c:451)

Signed-off-by: Ramu Ramamurthy <ramu.ramamurthy at us.ibm.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>