[ovs-git] [openvswitch/ovs] c18480: lib: Retire packet buffering feature.

GitHub noreply at github.com
Tue Aug 30 17:20:58 UTC 2016

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: c184807ced554c1dc7b69b3cd4f59cd85575fdf1
  Author: Jarno Rajahalme <jarno at ovn.org>
  Date:   2016-08-30 (Tue, 30 Aug 2016)

  Changed paths:
    M FAQ.md
    M include/openvswitch/ofp-util.h
    M lib/automake.mk
    M lib/ofp-util.c
    R lib/pktbuf.c
    R lib/pktbuf.h
    M ofproto/bundles.c
    M ofproto/connmgr.c
    M ofproto/connmgr.h
    M ofproto/fail-open.c
    M ofproto/ofproto-dpif.c
    M ofproto/ofproto-provider.h
    M ofproto/ofproto.c
    M tests/ofproto.at
    M tutorial/OVN-Tutorial.md
    M vswitchd/ovs-vswitchd.8.in

  Log Message:
  lib: Retire packet buffering feature.

OVS implementation of buffering packets that are sent to the
controller is not compliant with the OpenFlow specifications after
OpenFlow 1.0, which is possibly true since OpenFlow 1.0 is not really
specifying the packet buffering behavior.

OVS implementation executes the buffered packet against the actions of
the modified or added rule, whereas OpenFlow (since 1.1) specifies
that the packet should be matched against the flow table 0 and
processed accordingly.

Rather than fix this behavior, and potentially break OVS users, the
packet buffering feature is removed altogether.  After all, such
packet buffering is an optional OpenFlow feature, and as such any
possible users should continue to work without this feature.

This patch also makes OVS check the received 'buffer_id' values more
rigorously, and fixes some internal users accordingly.

Found by inspection.

Signed-off-by: Jarno Rajahalme <jarno at ovn.org>
Acked-by: Ben Pfaff <blp at ovn.org>

More information about the git mailing list