[ovs-git] [openvswitch/ovs] 466059: bridge: Honor 'mtu_request' when port is added.

GitHub noreply at github.com
Wed Aug 31 01:04:36 UTC 2016


  Branch: refs/heads/branch-2.6
  Home:   https://github.com/openvswitch/ovs
  Commit: 46605905116fce407f228fa8f6206372dd86dcd5
      https://github.com/openvswitch/ovs/commit/46605905116fce407f228fa8f6206372dd86dcd5
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2016-08-30 (Tue, 30 Aug 2016)

  Changed paths:
    M tests/ofproto-dpif.at
    M vswitchd/bridge.c

  Log Message:
  -----------
  bridge: Honor 'mtu_request' when port is added.

'mtu_request' was honored only when the port was reconfigured, not when
the port was added.

This commit fixes the problem and improves a testcase to detect the bug.

Found by inspection.

Fixes: 56abcf497b56("vswitchd: Introduce 'mtu_request' column in
Interface.")
Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Acked-by: Ben Pfaff <blp at ovn.org>


  Commit: f6043b3feca7a2979ccb9980ccbad381a66d6550
      https://github.com/openvswitch/ovs/commit/f6043b3feca7a2979ccb9980ccbad381a66d6550
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2016-08-30 (Tue, 30 Aug 2016)

  Changed paths:
    M ofproto/ofproto.c
    M tests/ofproto-dpif.at

  Log Message:
  -----------
  ofproto: Always set MTU for new internal ports.

We only change the MTU of new internal ports if it is bigger than the
bridge minimum.  But when the minimum MTU of the bridge is updated we
change the MTU of all internal ports no matter what.

The behavior is inconsistent, because now the internal ports MTU depends
on the order in which the ports were added.

This commit fixes the problem by _always_ setting the MTU of new
internal ports to the bridge minimum.  I'm not sure what was the logic
behind only adjusting the mtu if it was too big.

A testcase is improved to detect the problem.

VMware-BZ: #1718776
Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Acked-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/c051a1fd847f...f6043b3feca7


More information about the git mailing list