[ovs-git] [openvswitch/ovs] 922fed: vlog: Make the most common module reference more d...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 922fed065e65ad8388528976d631445f9e768f55
      https://github.com/openvswitch/ovs/commit/922fed065e65ad8388528976d631445f9e768f55
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-02-10 (Wed, 10 Feb 2016)

  Changed paths:
    M include/openvswitch/vlog.h
    M lib/bfd.c
    M lib/db-ctl-base.c
    M lib/dpif.c
    M lib/jsonrpc.c
    M lib/ofp-prop.h
    M lib/stream-ssl.c
    M lib/vconn-stream.c
    M lib/vlog.c
    M ovn/utilities/ovn-nbctl.c
    M ovn/utilities/ovn-sbctl.c
    M tests/test-reconnect.c
    M utilities/ovs-vsctl.c
    M vtep/vtep-ctl.c

  Log Message:
  -----------
  vlog: Make the most common module reference more direct.

Most vlog calls are for the log module owned by the translation unit being
compiled, but this module was referenced indirectly through a pointer
variable.  That seems silly, so this commit changes the code so that the
local vlog module is referred to directly, as &this_module.

We could get rid of the global variables for vlog modules entirely, but
I like getting linker errors when there's a duplicate module name.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Russell Bryant <russell at ovn.org>


  Commit: 063801288e2b1c98026d7faa81de9959eee678a3
      https://github.com/openvswitch/ovs/commit/063801288e2b1c98026d7faa81de9959eee678a3
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-02-10 (Wed, 10 Feb 2016)

  Changed paths:
    M NEWS
    M lib/vlog-unixctl.man
    M lib/vlog.c
    M python/ovs/vlog.py
    M tests/unixctl-py.at
    M tests/vlog.at
    M utilities/ovs-appctl.8.in

  Log Message:
  -----------
  vlog: Add vlog/close command.

Requested-by: P R Dinesh
Requested-at: https://github.com/openvswitch/ovs/pull/94
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Russell Bryant <russell at ovn.org>


  Commit: 867a2e3aae16024358768d4fac3fb0843db453b8
      https://github.com/openvswitch/ovs/commit/867a2e3aae16024358768d4fac3fb0843db453b8
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-02-10 (Wed, 10 Feb 2016)

  Changed paths:
    M lib/vlog.c

  Log Message:
  -----------
  vlog: Use log_file_mutex to more consistently protect vlog_modules.

This could be beneficial if we ever insert a new module at runtime
(currently we only insert them at startup) and it should have negligible
cost.

Suggested-by: Russell Bryant <russell at ovn.org>
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Russell Bryant <russell at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/3ca6cc76c3f3...867a2e3aae16