[ovs-git] [openvswitch/ovs] b39c20: netdev-dpdk: Do not add vhost-user ports with '/' ...

GitHub noreply at github.com
Wed Feb 24 21:52:31 UTC 2016


  Branch: refs/heads/branch-2.5
  Home:   https://github.com/openvswitch/ovs
  Commit: b39c209833d4f3c40e89c43cd83a86c6c669acbc
      https://github.com/openvswitch/ovs/commit/b39c209833d4f3c40e89c43cd83a86c6c669acbc
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2016-02-23 (Tue, 23 Feb 2016)

  Changed paths:
    M INSTALL.DPDK.md
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: Do not add vhost-user ports with '/' or '\' in name.

This check prevents an obvious way for a vhost-user socket to escape the
intended directory.

There might be other ways to escape the directory (none comes to mind at
the moment), but this is a problem that should be properly solved by
mandatory access control.

A similar check is done for a bridge name, since that name is used as
part of a socket as well.

Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Acked-by: Flavio Leitner <fbl at sysclose.org>


  Commit: 6d278b22a99c8bcfbc7106c40e9c95da6d608880
      https://github.com/openvswitch/ovs/commit/6d278b22a99c8bcfbc7106c40e9c95da6d608880
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2016-02-24 (Wed, 24 Feb 2016)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: vhost-user: Fix sending packets to queues not enabled by guest.

Currently virtio driver in guest operating system have to be configured
to use exactly same number of queues. If number of queues will be less,
some packets will get stuck in queues unused by guest and will not be
received.

Fix that by using new 'vring_state_changed' callback, which is
available for vhost-user since DPDK 2.2.
Implementation uses additional mapping from configured tx queues to
enabled by virtio driver. This requires mandatory locking of TX queues
in __netdev_dpdk_vhost_send(), but this locking was almost always anyway
because of calling set_multiq with n_txq = 'ovs_numa_get_n_cores() + 1'.

OVS_VHOST_MAX_QUEUE_NUM = 1024 chosen based on the fact that this is
the maximum number of queues supported by QEMU.

Fixes: 4573fbd38fa1 ("netdev-dpdk: Add vhost-user multiqueue support")
Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Acked-by: Flavio Leitner <fbl at sysclose.org>
Acked-by: Daniele Di Proietto <diproiettod at vmware.com>


  Commit: 5b173228c65b52427710cec7ee47b043a552fc6b
      https://github.com/openvswitch/ovs/commit/5b173228c65b52427710cec7ee47b043a552fc6b
  Author: Ian Stokes <ian.stokes at intel.com>
  Date:   2016-02-24 (Wed, 24 Feb 2016)

  Changed paths:
    M INSTALL.DPDK.md
    M NEWS

  Log Message:
  -----------
  INSTALL.DPDK: Add notes regarding vhost multiq configuration.

Linux kernel network devices in a guest should have the number of
multi-purpose channels configured when used with DPDK multiqueue on the host.
This commit adds an example of how this can be done. Also add QEMU 2.5
requirements for multiqueue with DPDK in NEWS.

Signed-off-by: Ian Stokes <ian.stokes at intel.com>
Acked-by: Flavio Leitner <fbl at sysclose.org>
Acked-by: Daniele Di Proietto <diproiettod at vmware.com>


Compare: https://github.com/openvswitch/ovs/compare/27723faa5708...5b173228c65b


More information about the git mailing list