[ovs-git] [openvswitch/ovs] 5e2291: ovsdb: Fix one off error in tracking monitor chang...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 5e22917729791c66ea9f5dd74b36858fa73b1b28
      https://github.com/openvswitch/ovs/commit/5e22917729791c66ea9f5dd74b36858fa73b1b28
  Author: Andy Zhou <azhou at ovn.org>
  Date:   2016-02-24 (Wed, 24 Feb 2016)

  Changed paths:
    M ovsdb/monitor.c

  Log Message:
  -----------
  ovsdb: Fix one off error in tracking monitor changes

dbmon's changes should be stored with the next transaction number,
rather than the current transaction number.  This bug causes the
changes of a transaction stored in a monitor to be unnoticed by
the jsonrpc connections that is responsible for flush the monitor
content.

However, the bug was not noticed until it was exposed by a later
optimization patch: "avoid unnecessary call to ovsdb_monitor_get_update()."
The lack of optimization means that the update is still generated
when 'unflushed' equals to n_transactions + 1, which should have
indicated the monitor has been flushed already.

Signed-off-by: Andy Zhou <azhou at ovn.org>
Acked-by: Liran Schour <lirans at il.ibm.com>
Acked-by: Ben Pfaff <blp at ovn.org>


  Commit: 765b5a0e09353e58614c14cb980c389b614ae7ec
      https://github.com/openvswitch/ovs/commit/765b5a0e09353e58614c14cb980c389b614ae7ec
  Author: Andy Zhou <azhou at ovn.org>
  Date:   2016-02-24 (Wed, 24 Feb 2016)

  Changed paths:
    M ovsdb/monitor.c

  Log Message:
  -----------
  ovsdb: rename variables in ovsdb_monitor_get_update()

'prev_txn' and 'next_txn" are more confusing than 'unflushed' and
'unflushed_next'. Rename them.

Signed-off-by: Andy Zhou <azhou at ovn.org>
Acked-by: Liran Schour <lirans at il.ibm.com>
Acked-by: Ben Pfaff <blp at ovn.org>


  Commit: 8cffdcd071ed47a503edb211bfaa15639d265ee0
      https://github.com/openvswitch/ovs/commit/8cffdcd071ed47a503edb211bfaa15639d265ee0
  Author: Andy Zhou <azhou at ovn.org>
  Date:   2016-02-24 (Wed, 24 Feb 2016)

  Changed paths:
    M ovsdb/jsonrpc-server.c

  Log Message:
  -----------
  ovsdb: avoid unnecessary call to ovsdb_monitor_get_update()

Optimizing ovsdb_jsonrpc_mintor_flush_all() by avoiding calling
ovsdb_monitor_get_update() on monitors that do not have any
unflushed updates.  This change saves CPU cycles on ovsdb-server's
main loop, but should not introduce any client visible changes.

Reported-by: Liran Schour <lirans at il.ibm.com>
Signed-off-by: Andy Zhou <azhou at ovn.org>
Acked-by: Liran Schour <lirans at il.ibm.com>
Acked-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/655306c825a8...8cffdcd071ed