[ovs-git] [openvswitch/ovs] 33fa5f: learning-switch: Use "if"s instead of "switch" to ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 33fa5fe5819b00b7e57b95405ccf9a2e8a4cd258
      https://github.com/openvswitch/ovs/commit/33fa5fe5819b00b7e57b95405ccf9a2e8a4cd258
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-01-19 (Tue, 19 Jan 2016)

  Changed paths:
    M lib/learning-switch.c

  Log Message:
  -----------
  learning-switch: Use "if"s instead of "switch" to reduce maintenance.

This code only cares about a very few kinds of OpenFlow messages, and it's
unlikely that it will care about new ones, so replace the "switch" by "if"
statements so that GCC won't complain about every new message.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Jarno Rajahalme <jarno at ovn.org>


  Commit: afe8a6c869d75d035b7550599234186b120a1afd
      https://github.com/openvswitch/ovs/commit/afe8a6c869d75d035b7550599234186b120a1afd
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-01-19 (Tue, 19 Jan 2016)

  Changed paths:
    M include/openflow/openflow-1.4.h
    M lib/ofp-msgs.h

  Log Message:
  -----------
  ofp-msgs: Fix definitions of OF1.4 OFPT_GET_ASYNC_REPLY and OFPT_SET_ASYNC.

The structures declared in ofp-msgs.h for messages definitions should not
include an OpenFlow header (its presence is implied), but the definition of
these messages did.  This commit fixes the definitions.

The visible bug was really minor here: messages of these kinds without any
TLVs would be rejected by the OpenFlow parser.  But OVS never sends these
messages without TLVs, so probably no one ever noticed this.  (Also, the
OVS support for OF1.4 is still incomplete and experimental.)

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Jarno Rajahalme <jarno at ovn.org>


  Commit: 77a9bb314916503e29f0fa7588ed4bfff7e8b5d8
      https://github.com/openvswitch/ovs/commit/77a9bb314916503e29f0fa7588ed4bfff7e8b5d8
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-01-19 (Tue, 19 Jan 2016)

  Changed paths:
    M lib/ofp-msgs.c

  Log Message:
  -----------
  ofp-msgs: Fix comments.

ofpbuf used to have members named 'frame' and 'l3' but now they're 'header'
and 'msg'.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Jarno Rajahalme <jarno at ovn.org>


  Commit: 0b9af7cb235e2d964c06b1c526b4912429d8135b
      https://github.com/openvswitch/ovs/commit/0b9af7cb235e2d964c06b1c526b4912429d8135b
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-01-19 (Tue, 19 Jan 2016)

  Changed paths:
    M lib/ofp-util.h

  Log Message:
  -----------
  ofp-util: Improve formatting of comment.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Jarno Rajahalme <jarno at ovn.org>


  Commit: 85586ad3a411044bf6aa882e5b6e8afd222a976e
      https://github.com/openvswitch/ovs/commit/85586ad3a411044bf6aa882e5b6e8afd222a976e
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-01-19 (Tue, 19 Jan 2016)

  Changed paths:
    M include/openflow/openflow-1.2.h

  Log Message:
  -----------
  openflow-1.2: Remove unused struct definition.

Experimenter stats are handled by code in ofp-msgs, and this struct isn't
good for anything.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Jarno Rajahalme <jarno at ovn.org>


  Commit: 64e3c4e551a8b10384cfa3fe927133a1d88d790b
      https://github.com/openvswitch/ovs/commit/64e3c4e551a8b10384cfa3fe927133a1d88d790b
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-01-19 (Tue, 19 Jan 2016)

  Changed paths:
    M ofproto/pinsched.c

  Log Message:
  -----------
  pinsched: Remove obsolete ofpbuf_trim().

This call to ofpbuf_trim() comes from a time when the packets passed to
pinsched came directly from a dpif.  For some time now that's no longer
true--now they are messages generated by ofputil_encode_packet_in(), which
generally are well sized and do not benefit from trimming.

This is not a bug fix--the code is equally correct either way, it's only
the rationale for trimming that's obsolete.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Jarno Rajahalme <jarno at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/63eded989e13...64e3c4e551a8