[ovs-git] [openvswitch/ovs] 5876b4: ofp-util: Fix OF1.4+ version of ofputil_decode_set...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 5876b4dbf6887a9c6c419c130a8ef9996ac52012
      https://github.com/openvswitch/ovs/commit/5876b4dbf6887a9c6c419c130a8ef9996ac52012
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-01-20 (Wed, 20 Jan 2016)

  Changed paths:
    M OPENFLOW-1.1+.md
    M lib/ofp-print.c
    M lib/ofp-util.c
    M lib/ofp-util.h
    M ofproto/ofproto.c

  Log Message:
  -----------
  ofp-util: Fix OF1.4+ version of ofputil_decode_set_async_config().

The OF1.0 through OF1.3 "set async config" set the whole configuration,
OF1.4+ only update parts of it piecemeal, but the decoding function always
set the whole configuration.  This commit fixes the problem by changing the
interface to require the caller to provide an initial state.  (It would
be possible to simply make it mutate existing state in-place, but that
interface seems a little more error-prone.)

Found by inspection.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Jarno Rajahalme <jarno at ovn.org>


  Commit: af7bc161f5ea9b6ae3e1405d6c619b734c2529a7
      https://github.com/openvswitch/ovs/commit/af7bc161f5ea9b6ae3e1405d6c619b734c2529a7
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-01-20 (Wed, 20 Jan 2016)

  Changed paths:
    M lib/ofp-msgs.h
    M lib/ofp-util.c
    M lib/ofp-util.h
    M ofproto/ofproto.c

  Log Message:
  -----------
  ofp-util: Add function to encode OFPT_SET_ASYNC messages.

This isn't used yet but it will be in future commits.

This also looks forward to supporting Open vSwitch extensions to OAM_*,
which will be coming up soon.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Jarno Rajahalme <jarno at ovn.org>


  Commit: 904e520200fbf39fd651bb22210b41079f397cc3
      https://github.com/openvswitch/ovs/commit/904e520200fbf39fd651bb22210b41079f397cc3
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-01-20 (Wed, 20 Jan 2016)

  Changed paths:
    M lib/ofp-print.c
    M tests/ofp-print.at
    M tests/ofproto-dpif.at
    M tests/ofproto.at

  Log Message:
  -----------
  ofp-print: Decode and print all async config messages the same way.

We have a single function to decode all of these messages, so there's no
reason to do it two different ways for printing.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Jarno Rajahalme <jarno at ovn.org>


  Commit: 43948fa5a64e17155ada614b87946021b109163e
      https://github.com/openvswitch/ovs/commit/43948fa5a64e17155ada614b87946021b109163e
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-01-20 (Wed, 20 Jan 2016)

  Changed paths:
    M include/openflow/openflow-1.3.h
    M lib/ofp-msgs.h
    M lib/ofp-util.c

  Log Message:
  -----------
  openflow: Get rid of struct ofp13_packet_in.

It's actually harder to parse OF1.2/OF1.3 "packet-in" messages when
ofp13_packet_in is involved than when the code just realizes that
ofp13_packet_in = ofp12_packet_in + cookie.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Jarno Rajahalme <jarno at ovn.org>


  Commit: 99520767ca72b422d83c1357d8f876a7ed1bf0d2
      https://github.com/openvswitch/ovs/commit/99520767ca72b422d83c1357d8f876a7ed1bf0d2
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-01-20 (Wed, 20 Jan 2016)

  Changed paths:
    M ofproto/connmgr.c
    M ofproto/ofproto-dpif-upcall.c
    M ofproto/ofproto-dpif-xlate.c
    M ofproto/ofproto-dpif-xlate.h
    M ofproto/pktbuf.c
    M ofproto/pktbuf.h

  Log Message:
  -----------
  fail-open: Drop some of the weirder special cases.

I don't have any real evidence that these special cases make a difference
in real-world cases.  The messages for the commits that add them are not
clear about the reasons for them.  I seem to recall that they were only
tested with the dummy controller inside OVS, which isn't very good evidence
for real controllers.  Finally, they cut across layers in nasty ways and
make it hard to better abstract packet-ins and packet buffering.

If these solve real problems then we can reconsider after some reports
come in.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Jarno Rajahalme <jarno at ovn.org>


  Commit: 730b985b03f79b5bd9c46edb8f1dc77a7db92547
      https://github.com/openvswitch/ovs/commit/730b985b03f79b5bd9c46edb8f1dc77a7db92547
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-01-20 (Wed, 20 Jan 2016)

  Changed paths:
    M lib/automake.mk
    A lib/pktbuf.c
    A lib/pktbuf.h
    M ofproto/automake.mk
    R ofproto/pktbuf.c
    R ofproto/pktbuf.h

  Log Message:
  -----------
  pktbuf: Move from 'ofproto' to 'lib'.

An upcoming commit will use this library from ofp-util instead of ofproto.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Jarno Rajahalme <jarno at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/8fd0bb602e49...730b985b03f7