[ovs-git] [openvswitch/ovs] 417509: ofproto-dpif-rid: Use separate pointers for action...

GitHub noreply at github.com
Thu Jan 21 01:03:19 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 417509faf2dff3be26f2ab4c9dd45809ec32e5dc
      https://github.com/openvswitch/ovs/commit/417509faf2dff3be26f2ab4c9dd45809ec32e5dc
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-01-20 (Wed, 20 Jan 2016)

  Changed paths:
    M ofproto/ofproto-dpif-rid.c
    M ofproto/ofproto-dpif-rid.h
    M ofproto/ofproto-dpif-xlate.c

  Log Message:
  -----------
  ofproto-dpif-rid: Use separate pointers for actions and action set.

During translation it makes some sense to concatenate these in a single
array, but in my opinion it's conceptually better to separate them for
the recirc_state; they are not naturally the same thing.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Jarno Rajahalme <jarno at ovn.org>


  Commit: 7e7e8dbb6749034d5229ed17ebdc5fe5a3ad98b0
      https://github.com/openvswitch/ovs/commit/7e7e8dbb6749034d5229ed17ebdc5fe5a3ad98b0
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-01-20 (Wed, 20 Jan 2016)

  Changed paths:
    M ofproto/ofproto-dpif-rid.h
    M ofproto/ofproto-dpif-xlate.c

  Log Message:
  -----------
  ofproto-dpif-rid: Don't carry actset_output explicitly in metadata.

Instead reconstruct it using the action set, since we already have the
logic to do that.

This seems a little nicer because we don't have to "trust" the metadata
as much.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Jarno Rajahalme <jarno at ovn.org>


  Commit: b597af0fb00dc6925c9ef3a466e9848e95b16280
      https://github.com/openvswitch/ovs/commit/b597af0fb00dc6925c9ef3a466e9848e95b16280
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-01-20 (Wed, 20 Jan 2016)

  Changed paths:
    M ofproto/ofproto-dpif-rid.c

  Log Message:
  -----------
  ofproto-dpif-rid: Fix names of recirc_metadata_{hash,equal}().

These functions actually hash or compare recirc_state structs, so they
should be named that way; recirc_metadata is only a small subset of
recirc_state.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Jarno Rajahalme <jarno at ovn.org>


  Commit: 290835f9648c9669fb17f3191906026affde8f2b
      https://github.com/openvswitch/ovs/commit/290835f9648c9669fb17f3191906026affde8f2b
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-01-20 (Wed, 20 Jan 2016)

  Changed paths:
    M ofproto/ofproto-dpif-rid.c
    M ofproto/ofproto-dpif-rid.h
    M ofproto/ofproto-dpif-xlate.c
    M ofproto/ofproto-dpif.c
    M ofproto/ofproto-dpif.h

  Log Message:
  -----------
  ofproto-dpif-rid: Use UUID, not pointer, to identify ofprotos for recirc.

An upcoming commit will make it possible to essentially serialize the
recirculation state into an OpenFlow message.  For that purpose, we can't
sensibly pass a "struct ofproto *", but a randomly generated UUID works
just as well.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Jarno Rajahalme <jarno at ovn.org>


  Commit: 9f6e20b70e1117037dda056bda39b02c769aa8cd
      https://github.com/openvswitch/ovs/commit/9f6e20b70e1117037dda056bda39b02c769aa8cd
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-01-20 (Wed, 20 Jan 2016)

  Changed paths:
    M lib/nx-match.c
    M lib/nx-match.h

  Log Message:
  -----------
  nx-match: Add functions for raw decoding and encoding of OXM.

The existing functions either assumed that we were working with NXM
(instead of OXM), or they added or parsed a header before OXM headers.
These aren't needed when OXM is encapsulated inside a property, as will be
the case in an upcoming commit.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Jarno Rajahalme <jarno at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/5c1b231450df...9f6e20b70e11


More information about the git mailing list