[ovs-git] [openvswitch/ovs] 576198: ovn-nbctl: Help catch lport-set-addresses mistakes...

[GitHub]

  Branch: refs/heads/branch-2.5
  Home:   https://github.com/openvswitch/ovs
  Commit: 5761980d53c025ab73839624ea25bce30a94e80f
      https://github.com/openvswitch/ovs/commit/5761980d53c025ab73839624ea25bce30a94e80f
  Author: Russell Bryant <russell at ovn.org>
  Date:   2016-01-21 (Thu, 21 Jan 2016)

  Changed paths:
    M ovn/ovn-nb.xml
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Help catch lport-set-addresses mistakes.

While debugging a broken OVN environment yesterday, the problem turned
out to be invalid entries in the logical port addresses column.  In
particular, the following command had been used:

  $ ovn-nbctl lport-set-addresses lp0 MAC IP

instead of:

  $ ovn-nbctl lport-set-addresses lp0 "MAC IP"

This is really easy to mess up, so add some simple validation to the
lport-set-addresses command.  If the beginning of an argument is ever
an IP address, it's wrong.

In passing, also add a note to the ovn-nb db documentation to note that
the order of "MAC IP" is required, as "IP MAC" is not valid.

Signed-off-by: Russell Bryant <russell at ovn.org>
Acked-by: Ben Pfaff <blp at ovn.org>


  Commit: ab8854a531a7fd141cbf5ec5a2e8694fd53fa62a
      https://github.com/openvswitch/ovs/commit/ab8854a531a7fd141cbf5ec5a2e8694fd53fa62a
  Author: Russell Bryant <russell at ovn.org>
  Date:   2016-01-21 (Thu, 21 Jan 2016)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Update show format for addresses.

This patch updates the formatting for the Logical_Port addresses column
in the show command output.  Previously, output would look like:

  addresses: 00:00:00:00:00:01 192.168.1.1 00:00:00:00:00:01 192.168.1.2

Now it looks like:

  addresses: ["00:00:00:00:00:01 192.168.1.1", "00:00:00:00:00:01 192.168.1.2"]

The grouping of addresses is important, so it should be reflected in the
output.

Signed-off-by: Russell Bryant <russell at ovn.org>
Acked-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/9fd52392dae1...ab8854a531a7