[ovs-git] [openvswitch/ovs] 312352: utilities/ovs-tcpdump.in: Fix port lookups

GitHub noreply at github.com
Sat Jul 2 04:30:33 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 312352673895035bfa286f8cf7c3627d580fdc2b
      https://github.com/openvswitch/ovs/commit/312352673895035bfa286f8cf7c3627d580fdc2b
  Author: Aaron Conole <aconole at bytheb.org>
  Date:   2016-07-01 (Fri, 01 Jul 2016)

  Changed paths:
    M utilities/ovs-tcpdump.in

  Log Message:
  -----------
  utilities/ovs-tcpdump.in: Fix port lookups

The original implementation of ovs-tcpdump conflated interfaces and
ports needlessly.  This commit changes ovs-tcpdump to only consider the
port name when looking up the corresponding bridge.

Reported-by: Jean-Tsung Hsiao <jhsiao at redhat.com>
Tested-by: Jean-Tsung Hsiao <jhsiao at redhat.com>
Signed-off-by: Aaron Conole <aconole at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 52654c4a1272f3f4e8e88f1c710d3e9e545014ef
      https://github.com/openvswitch/ovs/commit/52654c4a1272f3f4e8e88f1c710d3e9e545014ef
  Author: Aaron Conole <aconole at bytheb.org>
  Date:   2016-07-01 (Fri, 01 Jul 2016)

  Changed paths:
    M utilities/ovs-tcpdump.in

  Log Message:
  -----------
  utilities/ovs-tcpdump.in: Poll the process status

Some options (such as -c X), when passed to tcpdump will cause it to
halt.  When this occurs, ovs-tcpdump will not recognize that such
an event has happened, and will spew newlines across the screen
running forever.  To fix this, ovs-tcpdump can poll and then raise a
KeyboardInterrupt event.

Now, when the underlying dump-cmd (such as tcpdump, tshark, etc.)
actually signals exit, ovs-tcpdump follows the SIGINT path, telling the
database to clean up.  Exit is signalled by either returning, 'killing',
or closing the output descriptor.

Signed-off-by: Aaron Conole <aconole at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/f5d29e922c0e...52654c4a1272


More information about the git mailing list