[ovs-git] [openvswitch/ovs] 50c61d: ovn: Remove unreferenced patched datapaths.

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 50c61d46c49756ef7474951ee586fd7ae252484c
      https://github.com/openvswitch/ovs/commit/50c61d46c49756ef7474951ee586fd7ae252484c
  Author: Darrell Ball <dlu998 at gmail.com>
  Date:   2016-07-09 (Sat, 09 Jul 2016)

  Changed paths:
    M ovn/controller/ovn-controller.h
    M ovn/controller/patch.c

  Log Message:
  -----------
  ovn: Remove unreferenced patched datapaths.

Patched datapaths that are no longer referenced should be removed from
the patched_datapaths map; otherwise incorrect state references for a
patched datapath may be used and also datapaths that are absent will be
interpreted as present.

Signed-off-by: Darrell Ball <dlu998 at gmail.com>
Acked-by: Ryan Moats <rmoats at us.ibm.com>
Signed-off-by: Gurucharan Shetty <guru at ovn.org>


  Commit: 34114cf8165b6134a556d07ed22d03e9eac2fe4f
      https://github.com/openvswitch/ovs/commit/34114cf8165b6134a556d07ed22d03e9eac2fe4f
  Author: Gurucharan Shetty <guru at ovn.org>
  Date:   2016-07-09 (Sat, 09 Jul 2016)

  Changed paths:
    M ovn/controller/ovn-controller.c
    M ovn/controller/ovn-controller.h
    M ovn/controller/patch.c
    M ovn/controller/physical.c
    M ovn/lib/ovn-util.c
    M ovn/lib/ovn-util.h
    M tests/ovn.at

  Log Message:
  -----------
  ovn-controller: Change strategy for gateway conntrack zone allocation.

Commit 263064aeaa31e7 (Convert binding_run to incremental processing.)
changed the way patched_datapaths were handled. Previously we would
destroy the datastructure in every run and re-create it fresh. The new
way causes problems with the way conntrack zones are allocated as now
we can have stale port_binding entries causing segmentation faults.

With this commit, we simply don't depend on port_binding records in
conntrack zone allocation and instead store the UUID as a string in
the patch_datapath datastructure.

(The test enhanced with this commit would fail without the changes
in the commit. i.e. ovn-controller would crash. )

Signed-off-by: Gurucharan Shetty <guru at ovn.org>
Acked-by: Ryan Moats <rmoats at us.ibm.com>


Compare: https://github.com/openvswitch/ovs/compare/ea997e594516...34114cf8165b