[ovs-git] [openvswitch/ovs] fdb3c7: ovn-controller: Drop remove_local_datapath_by_bind...

GitHub noreply at github.com
Mon Jul 18 21:02:41 UTC 2016

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: fdb3c70c3ee54ce362a92c31adee3908251b39a0
  Author: Russell Bryant <russell at ovn.org>
  Date:   2016-07-18 (Mon, 18 Jul 2016)

  Changed paths:
    M ovn/controller/binding.c

  Log Message:
  ovn-controller: Drop remove_local_datapath_by_binding().

ovn-controller has an hmap called 'local_datapaths' which tracks
all OVN datapaths that have at least one port binding on the local
chassis.  This patch corrects the case where a port binding row is
deleted from the southbound DB while it's still bound to the chassis,
meaning it was deleted before the ovs interface was deleted.

The previous code tried to handle this case by calling
remove_local_datapath_by_binding().  The function appears to try
to look up local_datapath by the binding UUID.  If it finds it,
it will delete the local datapath entry.  On the surface, this
looks like a bug where it deletes a local datapath entry even
when there could be other ports still bound to the chassis.
The reality is that this function was always a no-op.  It was
doing a lookup using a different hash value than how local_datapath
entries are actually hashed. In practice, this wasn't a big problem
because local_datapaths are correctly cleaned in in the
process_full_binding case after an ovs interface is added or removed.

The new change ensures that we run the process_full_binding code
in this case right away, even if the interface is not deleted.

Fixes: 263064aeaa31 ("Convert binding_run to incremental processing.")
Signed-off-by: Russell Bryant <russell at ovn.org>
Acked-by: Ryan Moats <rmoats at us.ibm.com>

More information about the git mailing list