[ovs-git] [openvswitch/ovs] ca2d5f: tests: Define trim_zeros in only one place.

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: ca2d5f75ff5e4c919891e4f0a73db326625ea335
      https://github.com/openvswitch/ovs/commit/ca2d5f75ff5e4c919891e4f0a73db326625ea335
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-07-26 (Tue, 26 Jul 2016)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  tests: Define trim_zeros in only one place.

Defining trim_zeros in a common place allows us to skip defining it in
every test that needs it.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 5d1ce9088405757a619a0673ff4d87bc46208efd
      https://github.com/openvswitch/ovs/commit/5d1ce9088405757a619a0673ff4d87bc46208efd
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-07-26 (Tue, 26 Jul 2016)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  ovn: Make two end-to-end tests more reliable.

These tests change the northbound configuration and then immediately check
that the changes have taken effect on the hypervisors.  This can't work
reliably, so add a sleep to each one.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 21387dcc15c727598d8d0485faf5bae4704015c2
      https://github.com/openvswitch/ovs/commit/21387dcc15c727598d8d0485faf5bae4704015c2
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-07-26 (Tue, 26 Jul 2016)

  Changed paths:
    M lib/ovsdb-idl.c
    M lib/ovsdb-idl.h
    M ovn/utilities/ovn-nbctl.8.xml
    M ovn/utilities/ovn-nbctl.c
    M tests/ovn.at
    M tests/test-ovsdb.c
    M utilities/ovs-vsctl.c

  Log Message:
  -----------
  ovn-nbctl: Add "sync" command to wait for previous changes to take effect.

It's slow to add --wait to every ovn-nbctl command; only the last command
needs it.  But it's sometimes inconvenient to add it to the last command
if it's in a loop, etc.  This makes it possible to separately wait for
the OVN southbound or hypervisors to catch up to the northbound.

Also, modify the tests to replace "sleep" invocations that were waiting
for hypervisors to catch up by --wait=hv or by invocations of "ovn-nbctl
--wait=hv sync".

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 3eefe40f16f5f5804adfe1437e0f96aba9090445
      https://github.com/openvswitch/ovs/commit/3eefe40f16f5f5804adfe1437e0f96aba9090445
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-07-26 (Tue, 26 Jul 2016)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  tests: Remove most packet-forwarding related "sleep"s from OVN tests.

These arbitrary sleeps are often longer than necessary and can be too short
in corner cases.  This commit replaces them by a common macro that waits
only as long as necessary.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: ebdc69a4506b1ab807bb0b5d63e648e8cad41bcf
      https://github.com/openvswitch/ovs/commit/ebdc69a4506b1ab807bb0b5d63e648e8cad41bcf
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-07-26 (Tue, 26 Jul 2016)

  Changed paths:
    M lib/ovsdb-idl.c

  Log Message:
  -----------
  ovsdb-idl: Wake up ovsdb_idl_loop when a transaction commits.

There is a fair amount of code that defers modifying the database when a
transaction cannot be created (because there is already one outstanding).
This code tends to assume that the main loop will wake up again when it
becomes possible again to modify the database, but the actual ovsdb_id_loop
implementation only did this if the database had changed.  This is too
conservative a policy and may account for some failures I've seen in tests.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: fc618461b76afe0ba1e6866412a832f47ac520de
      https://github.com/openvswitch/ovs/commit/fc618461b76afe0ba1e6866412a832f47ac520de
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-07-27 (Wed, 27 Jul 2016)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Improve usage message.

The most important change here is to delete misspelled "the".

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <nusiddiq at redhat.com>


Compare: https://github.com/openvswitch/ovs/compare/fa183acc654f...fc618461b76a