[ovs-git] [openvswitch/ovs] efe179: netdev-*: Do not use dp_packet_pad() in recv() fun...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: efe179e041f97205d0442fd740e8ca7568534e2d
      https://github.com/openvswitch/ovs/commit/efe179e041f97205d0442fd740e8ca7568534e2d
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2016-07-29 (Fri, 29 Jul 2016)

  Changed paths:
    M lib/netdev-bsd.c
    M lib/netdev-dummy.c
    M lib/netdev-linux.c
    M tests/learn.at
    M tests/ofproto-dpif.at
    M tests/ofproto.at
    M tests/ovn.at
    M tests/pmd.at

  Log Message:
  -----------
  netdev-*: Do not use dp_packet_pad() in recv() functions.

All the netdevs used by dpif-netdev (except for netdev-dpdk) have a
dp_packet_pad() call in the receive function, probably because the
userspace datapath couldn't handle properly short packets.

This doesn't appear to be the case anymore.

This commit removes the call to have a more consistent behavior with the
kernel datapath.

All the testsuite changes in this commit adjust the expectations for
packet lengths in flow dumps and other stats.  There's only one fix in
ovn.at: one of the test_ip() functions generated an incomplete udp
packet, which was not a problem until now, because of the padding.

Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Acked-by: Ben Pfaff <blp at ovn.org>


  Commit: e4543cfe62efbc80db128a46d8019ac54e6720fd
      https://github.com/openvswitch/ovs/commit/e4543cfe62efbc80db128a46d8019ac54e6720fd
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2016-07-29 (Fri, 29 Jul 2016)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  tests: Remove trim_zeros() from ovn tests.

trim_zeros() is not necessary anymore, since now we don't pad packets in
the userspace datapath.

Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Acked-by: Ben Pfaff <blp at ovn.org>


  Commit: 4573c42eafb5008003afa80f08c10846f1afcbe9
      https://github.com/openvswitch/ovs/commit/4573c42eafb5008003afa80f08c10846f1afcbe9
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2016-07-29 (Fri, 29 Jul 2016)

  Changed paths:
    M tests/system-kmod-macros.at
    M tests/system-ovn.at
    M tests/system-traffic.at
    M tests/system-userspace-macros.at

  Log Message:
  -----------
  system-tests: Run conntrack tests with userspace.

The userspace connection tracker doesn't support ALGs, frag reassembly
or NAT yet, so skip those tests.

Also, connection tracking state input from a local port is not possible
in userspace.

Finally, the userspace datapath checks for the IPv4 header checksum, so
fix those in the hardcoded packets.

Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Acked-by: Joe Stringer <joe at ovn.org>
Acked-by: Flavio Leitner <fbl at sysclose.org>


  Commit: e5cf8cce275934549ee1b1ed41d60d5b6ce7918d
      https://github.com/openvswitch/ovs/commit/e5cf8cce275934549ee1b1ed41d60d5b6ce7918d
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2016-07-29 (Fri, 29 Jul 2016)

  Changed paths:
    M tests/system-traffic.at

  Log Message:
  -----------
  system-tests: Add ping through conntrack test.

Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Acked-by: Joe Stringer <joe at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/ac1432a46775...e5cf8cce2759