[ovs-git] [openvswitch/ovs] a134d7: system-tests: fix module removal during cleanup

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: a134d79dfb0efcc0095aaec03f3b001c01ba6057
      https://github.com/openvswitch/ovs/commit/a134d79dfb0efcc0095aaec03f3b001c01ba6057
  Author: Thadeu Lima de Souza Cascardo <cascardo at redhat.com>
  Date:   2016-06-01 (Wed, 01 Jun 2016)

  Changed paths:
    M tests/system-kmod-macros.at

  Log Message:
  -----------
  system-tests: fix module removal during cleanup

Currently, cleanup files for system tests will look like this:

modprobe -q -r vport_vxlan
modprobe -q -r vport_sttmodprobe
modprobe -q -r vport_lispmodprobe
modprobe -q -r vport_gremodprobe
modprobe -q -r vport_genevemodprobe
modprobe -r openvswitch

This is caused by a missing newline in m4_foreach EXPRESSION and the fact that
on_exit is a shell function. It was being expanded like this:

on_exit 'modprobe -q -r vport_genevemodprobe' -q vport_gre

Fixes: 53eb8cb83013 ("tests: Replace ON_EXIT m4 macro by on_exit() shell function.")
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo at redhat.com>
Signed-off-by: Joe Stringer <joe at ovn.org>