[ovs-git] [openvswitch/ovs] 93ce57: ovs-numa: Remove non-linux stubs.

GitHub noreply at github.com
Tue Jun 7 21:08:13 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 93ce57623f67547d4873889c77ec5250728b304f
      https://github.com/openvswitch/ovs/commit/93ce57623f67547d4873889c77ec5250728b304f
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2016-06-07 (Tue, 07 Jun 2016)

  Changed paths:
    M lib/automake.mk
    M lib/ovs-numa.c
    M lib/ovs-numa.h

  Log Message:
  -----------
  ovs-numa: Remove non-linux stubs.

Instead of having static inline stubs for non linux platform we can use
the implementations in ovs-numa.c.  With one small change to
ovs_numa_dump_cores_on_numa(), they will behave exactly like the
stubs for the non-linux case, because 'found_numa_and_core' will be
false and the socket and cpu hmaps will be empty.

There are a few places where conditional compilation is required: the
code that parses the linux specific sysfs entries and its dependencies.
It requires opendir() and readdir() and doesn't make sense outside of
linux anyway.

This change is required to have a cross-platform ovs-numa dummy
implementation for testing.

Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Acked-by: Ilya Maximets <i.maximets at samsung.com>


  Commit: 6930c7e01c3f4ee8f4a9360d293d065f35588bf0
      https://github.com/openvswitch/ovs/commit/6930c7e01c3f4ee8f4a9360d293d065f35588bf0
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2016-06-07 (Tue, 07 Jun 2016)

  Changed paths:
    M lib/dpif-netdev.c
    M lib/netdev-dpdk.c
    M lib/netdev-dpdk.h
    M lib/ovs-numa.c
    M lib/ovs-numa.h

  Log Message:
  -----------
  ovs-numa: Introduce function to set current thread affinity.

This commit moves the code that sets the pmd threads affinity from
netdev-dpdk to ovs-numa.  There's one small part left in netdev-dpdk, to
set the lcore_id.

Now dpif-netdev will call both modules (ovs-numa and netdev-dpdk) when
starting a pmd thread.

This change will allow having a dummy implementation of the set affinity
call, for testing purposes.

Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Acked-by: Ilya Maximets <i.maximets at samsung.com>


  Commit: f8cf65022b75eeb376921d11ee455a4af5387e91
      https://github.com/openvswitch/ovs/commit/f8cf65022b75eeb376921d11ee455a4af5387e91
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2016-06-07 (Tue, 07 Jun 2016)

  Changed paths:
    M lib/netdev-dummy.c

  Log Message:
  -----------
  netdev-dummy: Introduce sched_yield() in rxq_recv() for pmd devices.

Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Acked-by: Ilya Maximets <i.maximets at samsung.com>


  Commit: b4e28b7f981fb673d59320348e05983af3dfd7b7
      https://github.com/openvswitch/ovs/commit/b4e28b7f981fb673d59320348e05983af3dfd7b7
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2016-06-07 (Tue, 07 Jun 2016)

  Changed paths:
    M lib/ovs-numa.c
    M lib/ovs-numa.h
    M vswitchd/ovs-vswitchd.c

  Log Message:
  -----------
  vswitchd: Add --dummy-numa command line option.

This option is used to initialize the ovs_numa module with a fake
configuration and to avoid pthread_setaffinity_np() calls.  It will be
useful to test dpif-netdev with pmd threads.

Since it is only used for testing it is not documented in the man pages.

Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Acked-by: Ilya Maximets <i.maximets at samsung.com>


  Commit: f7cfe5c2445f94f90fb7dbff6403f2c6de9596dc
      https://github.com/openvswitch/ovs/commit/f7cfe5c2445f94f90fb7dbff6403f2c6de9596dc
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2016-06-07 (Tue, 07 Jun 2016)

  Changed paths:
    M tests/ofproto-macros.at

  Log Message:
  -----------
  tests: Allow extra cmd line args to OVS_VSWITCHD_START.

This will be used by a following commit, to add dummy-numa options.

Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Acked-by: Ilya Maximets <i.maximets at samsung.com>


  Commit: 71c1cd42d9f57da62ddcb727e4430aa62448a614
      https://github.com/openvswitch/ovs/commit/71c1cd42d9f57da62ddcb727e4430aa62448a614
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2016-06-07 (Tue, 07 Jun 2016)

  Changed paths:
    M tests/dpif-netdev.at

  Log Message:
  -----------
  dpif-netdev.at: Run tests with dummy-pmd.

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Acked-by: Daniele Di Proietto <diproiettod at vmware.com>


  Commit: e539ba875d11030b845b0ed7efc2cf9b5ff01524
      https://github.com/openvswitch/ovs/commit/e539ba875d11030b845b0ed7efc2cf9b5ff01524
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2016-06-07 (Tue, 07 Jun 2016)

  Changed paths:
    M tests/ofproto-dpif.at
    M tests/ofproto-macros.at

  Log Message:
  -----------
  ofproto-dpif.at: Run tests with dummy-pmd.

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Acked-by: Daniele Di Proietto <diproiettod at vmware.com>


  Commit: 589dd1d57413f7b9ff951a29803e6b2ee5b15d88
      https://github.com/openvswitch/ovs/commit/589dd1d57413f7b9ff951a29803e6b2ee5b15d88
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2016-06-07 (Tue, 07 Jun 2016)

  Changed paths:
    M tests/automake.mk
    A tests/pmd.at
    M tests/testsuite.at

  Log Message:
  -----------
  testsuite: Add PMD specific tests.

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>


Compare: https://github.com/openvswitch/ovs/compare/24cc3f0c6614...589dd1d57413


More information about the git mailing list