[ovs-git] [openvswitch/ovs] d1b97f: ipfix: Bug fix for not sending template packets on...

GitHub noreply at github.com
Tue Jun 14 15:28:28 UTC 2016

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: d1b97f99a7f350420439e44c0fa78e8da1757a63
  Author: Benli Ye <daniely at vmware.com>
  Date:   2016-06-14 (Tue, 14 Jun 2016)

  Changed paths:
    M ofproto/ofproto-dpif-ipfix.c

  Log Message:
  ipfix: Bug fix for not sending template packets on 32-bit OS

'last_template_set_time' in truct dpif_ipfix_exporter is declared
as time_t and time_t is long int type. If we initialize
'last_template_set_time' as TIME_MIN, whose value is -2147483648
on 32-bit OS and -2^63 on 64-bit OS. There will be a problem on
32-bit OS when comparing 'last_template_set_time' with a unisgned int
type variable, because type casting will happen and negative value
could be a large positive number. Fix this problem by simply initialize
'last_template_set_time' as 0.

Signed-off-by: Benli Ye <daniely at vmware.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: William Tu <u9012063 at gmail.com>

More information about the git mailing list