[ovs-git] [openvswitch/ovs] a1361a: tests: make ovn logical router test case more reli...
noreply at github.com
Tue Jun 21 18:06:09 UTC 2016
Author: Lance Richardson <lrichard at redhat.com>
Date: 2016-06-21 (Tue, 21 Jun 2016)
tests: make ovn logical router test case more reliable
The "ovn -- 1 HVs, 2 LSs, 1 lport/LS, 1 LR" test case creates a
configuration including a logical router, then:
1) Sends a packet that is expected to be forwarded by the
2) Disables the logical router.
3) Sends another packet, identical to the one sent in (1), that
should not be forwarded.
This test case fails intermittently, apparently because the disabling
of the logical router in (2) has not yet been propagated to the
forwarding plane at the time the second packet is sent. (When the
failure occurs, two packets are captured whereas only one is expected.)
Address this issue by adding a one second sleep between steps (2) and
(3). Adding a sleep does not actually fix anything, but it
does make this test case more likely to work correctly.
In one series of tests, this test case failed 11 times out of 20
without this fix and succeeded 20 times out of 20 attempts with
Fixes: 5412db307420 ("ovn: Add column enabled to table Logical_Router")
Signed-off-by: Lance Richardson <lrichard at redhat.com>
Signed-off-by: Russell Bryant <russell at ovn.org>
More information about the git