[ovs-git] [openvswitch/ovs] 3b18b0: ovsdb-server: Fix a reference count leak bug

GitHub noreply at github.com
Tue Mar 8 19:25:25 UTC 2016

  Branch: refs/heads/branch-2.4
  Home:   https://github.com/openvswitch/ovs
  Commit: 3b18b0d690fd8e9d6158ce241128277caf848f0d
  Author: andy zhou <azhou at ovn.org>
  Date:   2016-03-08 (Tue, 08 Mar 2016)

  Changed paths:
    M ovsdb/jsonrpc-server.c
    M ovsdb/monitor.c
    M ovsdb/monitor.h

  Log Message:
  ovsdb-server: Fix a reference count leak bug

When destroying an ovsdb_jsonrpc_monitor, the jsonrpc monitor still
holds a reference count to the monitors 'changes' indexed with
'unflushed' transaction id.  The bug is that the reference count was
not decremented as it should in the code path.

The bug caused 'changes' that have been flushed to all jsonrpc
clients to linger around unnecessarily, occupying increasingly
large amount of memory. See "Reported-at" URL for more details.

This bug is tricky to find since the memory is not leaked; they will
eventually be freed when monitors are destroyed.

Reported-by: Lei Huang <huang.f.lei at gmail.com>
Reported-at: http://openvswitch.org/pipermail/dev/2016-March/067274.html
Signed-off-by: Andy Zhou <azhou at ovn.org>
Tested-by: Han Zhou <zhouhan at gmail.com>
Acked-by: Han Zhou <zhouhan at gmail.com>
Acked-by: Liran Schour <lirans at il.ibm.com>

More information about the git mailing list