[ovs-git] [openvswitch/ovs] 2f22d6: bridge: Fix qos_unixctl_show bug.

GitHub noreply at github.com
Tue Mar 22 17:58:38 UTC 2016

  Branch: refs/heads/branch-2.3
  Home:   https://github.com/openvswitch/ovs
  Commit: 2f22d6a2c8e58c986ec41f6074959a6dc47c35b2
  Author: Ian Stokes <ian.stokes at intel.com>
  Date:   2016-03-22 (Tue, 22 Mar 2016)

  Changed paths:
    M vswitchd/bridge.c

  Log Message:
  bridge: Fix qos_unixctl_show bug.

netdev_get_qos returns a value to indicate if an error has occurred while
attempting to query the QoS configuration of an interface. If an error does
occur the pointer argument passed to it will be set to null before returning.
Currently the vswitch will segfault if this occurs as qos_unixctl_show will
attempt to access the pointer directly after it calls netdev_get_qos.

Avoid this by adding a check for the return value and flagging an appropriate
error message to appctl.

Signed-off-by: Ian Stokes <ian.stokes at intel.com>
[blp at ovn.org changed details of error report]
Signed-off-by: Ben Pfaff <blp at ovn.org>

More information about the git mailing list