[ovs-git] [openvswitch/ovs] 756237: tests: Fix *bsd failure in OVS_APP_EXIT_AND_WAIT.

GitHub noreply at github.com
Thu Mar 31 14:53:37 UTC 2016

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 7562379719a9cd42b79fcff3a6a288e5961cc561
  Author: Lance Richardson <lrichard at redhat.com>
  Date:   2016-03-31 (Thu, 31 Mar 2016)

  Changed paths:
    M tests/ovs-macros.at

  Log Message:
  tests: Fix *bsd failure in OVS_APP_EXIT_AND_WAIT.

When using the default user shell in FreeBSD and NetBSD and executing
a test in which the app name parameter to OVS_APP_EXIT_AND_WAIT
contains backticks (e.g. "`pwd`/unixctl"), TMPPID expands to:

    `cat "$OVS_RUNDIR"/"`pwd`"/unixctl.pid 2>/dev/null`

This results in an "unterminated quoted string" syntax error from
the shell.

Correct this by replacing backticks with $(...) in OVS_APP_EXIT_AND_WAIT.
Verified via "make check" under NetBSD 7 and Fedora 23.

Fixes: f9b11f2a09b4 ("tests: Make OVS_APP_EXIT_AND_WAIT() wait for process termination")
Reported-by: Aaron Conole <aconole at redhat.com>
Signed-off-by: Lance Richardson <lrichard at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

More information about the git mailing list