[ovs-git] [openvswitch/ovs] 37b4ea: classifier: Remove redundant index.

GitHub noreply at github.com
Wed May 4 20:07:24 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 37b4ea1250aadc9afcbc61a2905b55fd0e4a1421
      https://github.com/openvswitch/ovs/commit/37b4ea1250aadc9afcbc61a2905b55fd0e4a1421
  Author: Jarno Rajahalme <jarno at ovn.org>
  Date:   2016-05-04 (Wed, 04 May 2016)

  Changed paths:
    M lib/classifier.c

  Log Message:
  -----------
  classifier: Remove redundant index.

The test for figuring out if the last index had the same fields as the
actual rules map as broken, resulting into keeping an unnecessary
index around.

Signed-off-by: Jarno Rajahalme <jarno at ovn.org>
Acked-by: Ryan Moats <rmoats at us.ibm.com>
Acked-by: Ben Pfaff <blp at ovn.org>


  Commit: fd7a68dd76e558a060d082b0b492991a6d35e345
      https://github.com/openvswitch/ovs/commit/fd7a68dd76e558a060d082b0b492991a6d35e345
  Author: Jarno Rajahalme <jarno at ovn.org>
  Date:   2016-05-04 (Wed, 04 May 2016)

  Changed paths:
    M lib/classifier.c

  Log Message:
  -----------
  classifier: Remove logging.

The only vlog line was a left over from debugging.

Signed-off-by: Jarno Rajahalme <jarno at ovn.org>
Acked-by: Ryan Moats <rmoats at us.ibm.com>
Acked-by: Ben Pfaff <blp at ovn.org>


  Commit: 31ecf25fad50093c9dfd3396f9e3adef6e9e2eed
      https://github.com/openvswitch/ovs/commit/31ecf25fad50093c9dfd3396f9e3adef6e9e2eed
  Author: Jarno Rajahalme <jarno at ovn.org>
  Date:   2016-05-04 (Wed, 04 May 2016)

  Changed paths:
    M lib/classifier.c
    M tests/classifier.at
    M tests/ofproto-dpif.at

  Log Message:
  -----------
  classifier: Remove rare optimization case.

This optimization applied when a staged lookup index would narrow down
to a single rule, which happens sometimes is simple test cases, but
presumably less often in more populated flow tables.  The result of
this optimization allowed a bit more general megaflows, but the bit
patterns produced were sometimes cryptic.  Finally, a later fix to a
more important performance problem does not allow for this
optimization any more, so remove it now.

Signed-off-by: Jarno Rajahalme <jarno at ovn.org>
Acked-by: Ryan Moats <rmoats at us.ibm.com>
Acked-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/54529e94e96a...31ecf25fad50


More information about the git mailing list