[ovs-git] [openvswitch/ovs] 3fd9ec: datapath-windows: add nlMsgHdr to OvsPacketExecute

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 3fd9ec0b81f37454ba91e6a8ae3605ecd85a71c5
      https://github.com/openvswitch/ovs/commit/3fd9ec0b81f37454ba91e6a8ae3605ecd85a71c5
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2016-05-25 (Wed, 25 May 2016)

  Changed paths:
    M datapath-windows/ovsext/DpInternal.h
    M datapath-windows/ovsext/User.c

  Log Message:
  -----------
  datapath-windows: add nlMsgHdr to OvsPacketExecute

We'll need this for parsing nested attributes.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Acked-by: Sairam Venugopal <vsairam at vmware.com>
Signed-off-by: Joe Stringer <joe at ovn.org>


  Commit: 3729199262009ef886e9c6b17d5f73a792a54946
      https://github.com/openvswitch/ovs/commit/3729199262009ef886e9c6b17d5f73a792a54946
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2016-05-25 (Wed, 25 May 2016)

  Changed paths:
    M datapath-windows/ovsext/Flow.c
    M datapath-windows/ovsext/Flow.h

  Log Message:
  -----------
  datapath-windows: Make _MapTunAttrToFlowPut() global

Move this function out from file scope.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Acked-by: Sairam Venugopal <vsairam at vmware.com>
Signed-off-by: Joe Stringer <joe at ovn.org>


  Commit: 3871d4fb748e32d8d13c76e23f3775ccd3194ef4
      https://github.com/openvswitch/ovs/commit/3871d4fb748e32d8d13c76e23f3775ccd3194ef4
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2016-05-25 (Wed, 25 May 2016)

  Changed paths:
    M datapath-windows/ovsext/User.c

  Log Message:
  -----------
  datapath-windows: Use l2 port and tunkey during execute

While testing DFW and recirc code it was found that userspace
was calling into packet execute with the tunnel key and the
vport added as part of the execute structure. We were not passing
this along to the code that executes actions. The right thing is
to contruct the key based on all of the attributes sent down from
userspace.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Acked-by: Sairam Venugopal <vsairam at vmware.com>
Signed-off-by: Joe Stringer <joe at ovn.org>


  Commit: bfac27150b4dedd6bb143299ef9bb1a31e448e62
      https://github.com/openvswitch/ovs/commit/bfac27150b4dedd6bb143299ef9bb1a31e448e62
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2016-05-25 (Wed, 25 May 2016)

  Changed paths:
    M datapath-windows/ovsext/Actions.c

  Log Message:
  -----------
  datapath-windows: remove extract flow in OvsDoRecirc()

It is not necessary to do a flow extract in OvsDoRecirc().
In fact, doing it would overwrite the tunnel key within
'key'. So, let's remove the call.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Signed-off-by: Sairam Venugopal <vsairam at vmware.com>
Co-Authored-by: Sairam Venugopal <vsairam at vmware.com>
Acked-by: Sairam Venugopal <vsairam at vmware.com>
Acked-by: Paul-Daniel Boca <pboca at cloudbasesolutions.com>
Signed-off-by: Joe Stringer <joe at ovn.org>


  Commit: 57b99edd7eb351c76e3785effbf8463437202abf
      https://github.com/openvswitch/ovs/commit/57b99edd7eb351c76e3785effbf8463437202abf
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2016-05-25 (Wed, 25 May 2016)

  Changed paths:
    M datapath-windows/ovsext/Datapath.c

  Log Message:
  -----------
  datapath-windows: don't map output buffer in OVS_IOCTL_WRITE

The contract of OVS_IOCTL_WRITE is that write operations
will not need the output buffer. Only the input buffer
will be used in the IRP. So, better to not map the output
buffer at all.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Acked-by: Paul-Daniel Boca <pboca at cloudbasesolutions.com>
Signed-off-by: Joe Stringer <joe at ovn.org>


  Commit: 7e98ed23669f423daca1bc4731bbd467cee726e2
      https://github.com/openvswitch/ovs/commit/7e98ed23669f423daca1bc4731bbd467cee726e2
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2016-05-25 (Wed, 25 May 2016)

  Changed paths:
    M datapath-windows/ovsext/Datapath.c
    M datapath-windows/ovsext/Flow.c
    M datapath-windows/ovsext/Netlink/Netlink.c
    M datapath-windows/ovsext/Netlink/Netlink.h
    M datapath-windows/ovsext/User.c
    M datapath-windows/ovsext/Vport.c

  Log Message:
  -----------
  datapath-windows: o/p buffer must fit NL error message

OVS_IOCTL_WRITE and OVS_IOCTL_TRANSACT can generate a
netlink error that is represented by a OVS_MESSAGE_ERROR
struct. We want to make sure at the entry point of the
ioctl processing that the output buffer is big enough
to hold the error message. We were earlier checking
for struct OVS_MESSAGE which is smaller.

Since we are ensuring that output buffer can fit
OVS_MESSAGE_ERROR at the top of the ioctl function,
there's no need to check for that later.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Acked-by: Paul-Daniel Boca <pboca at cloudbasesolutions.com>
Signed-off-by: Joe Stringer <joe at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/9509913aa722...7e98ed23669f