[ovs-git] [openvswitch/ovs] 093aa7: ovn: Fix races in MAC_Binding deletion test.

GitHub noreply at github.com
Fri Oct 7 15:36:53 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 093aa761fac5703f091b8250585cf6f68343aa80
      https://github.com/openvswitch/ovs/commit/093aa761fac5703f091b8250585cf6f68343aa80
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-10-07 (Fri, 07 Oct 2016)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  ovn: Fix races in MAC_Binding deletion test.

The test assumed that ovn-northd could delete the MAC_Binding rows
instantly, but it may take a while.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Gurucharan Shetty <guru at ovn.org>


  Commit: 6d53e8a9841a4421c15fb10049f4c2bfb361363e
      https://github.com/openvswitch/ovs/commit/6d53e8a9841a4421c15fb10049f4c2bfb361363e
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-10-07 (Fri, 07 Oct 2016)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  ovn: Fix bugs in port security test.

A number of instances of "{i}" in this test should have been "${i}".

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Gurucharan Shetty <guru at ovn.org>


  Commit: 8bc2c143e808e99177a3fb30649366e22088b395
      https://github.com/openvswitch/ovs/commit/8bc2c143e808e99177a3fb30649366e22088b395
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-10-07 (Fri, 07 Oct 2016)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  ovn: Fix some races in IPAM connectivity test.

It can take a way for dynamic addresses to propagate through ovn-northd,
so wait for it to happen.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Gurucharan Shetty <guru at ovn.org>


  Commit: 3b9bdc6c7764d8d5049ad6981e73ed2f66ffa021
      https://github.com/openvswitch/ovs/commit/3b9bdc6c7764d8d5049ad6981e73ed2f66ffa021
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-10-07 (Fri, 07 Oct 2016)

  Changed paths:
    M tests/ovn-sbctl.at

  Log Message:
  -----------
  ovn: Wait for ovn-northd to catch up in "ovn-sbctl" test.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Gurucharan Shetty <guru at ovn.org>


  Commit: 8263474e623cd8e76105664e8308823b26f7afa9
      https://github.com/openvswitch/ovs/commit/8263474e623cd8e76105664e8308823b26f7afa9
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-10-07 (Fri, 07 Oct 2016)

  Changed paths:
    M tests/ovn-controller-vtep.at

  Log Message:
  -----------
  ovn: Fix some races in ovn-controller-vtep tests.

This fixes a few races for port bindings appearing and being bound to
a chassis.  The ones changed to use "ovn-sbctl wait-until" were previously
only waiting until a Port_Binding record appeared (created by ovn-northd),
but not until the Port_Binding record's 'chassis' column was set (by
ovn-controller).

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Gurucharan Shetty <guru at ovn.org>


  Commit: 1794d5f2dbd51a7f82c21c49956015a9eb9faa3f
      https://github.com/openvswitch/ovs/commit/1794d5f2dbd51a7f82c21c49956015a9eb9faa3f
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-10-07 (Fri, 07 Oct 2016)

  Changed paths:
    M tests/ovn.at

  Log Message:
  -----------
  ovn: Remove weird or unneeded keywords from tests.

AT_KEYWORDS are mostly there to make it easier to find the tests you're
looking for.  One might, for example, mark tests as "positive" or
"negative" so you can select the tests you want to run on that basis.
They're also useful for cases where Autotest just isn't good at splitting
words: for example, Autotest includes punctuation so that a test name
that has a word followed by a comma or colon won't be selected using a
keyword that lacks the comma or the colon.

But a lot of OVN tests had keywords that just didn't seem helpful in one
of these ways.  For example, it's hard to guess why running together
words into a longer word would help someone select a test, and it's not
helpful at all to repeat one of the words in the test name, since those
words are keywords by default anyway.

Therefore, this commit removes the keywords that don't seem helpful.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Gurucharan Shetty <guru at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/62f0430e903a...1794d5f2dbd5


More information about the git mailing list