[ovs-git] [openvswitch/ovs] 7b38ad: ovn-controller: Fix memory leak in recv_S_TLV_TABL...

[GitHub]

  Branch: refs/heads/branch-2.6
  Home:   https://github.com/openvswitch/ovs
  Commit: 7b38ad74f9844d835b48c95037c4a2ce461917c5
      https://github.com/openvswitch/ovs/commit/7b38ad74f9844d835b48c95037c4a2ce461917c5
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2016-09-01 (Thu, 01 Sep 2016)

  Changed paths:
    M ovn/controller/ofctrl.c

  Log Message:
  -----------
  ovn-controller: Fix memory leak in recv_S_TLV_TABLE_REQUESTED().

Nothing freed 'reply'.  This fixes the problem.

Most of this patch is moving coding around.  The essential change is that
breaking the code that works with 'reply' out into a separate function
makes it possible to catch all paths out of the function so that 'reply'
can be freed in one place.

Reported-by: Ryan Moats <rmoats at us.ibm.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Ryan Moats <rmoats at us.ibm.com>
Acked-by: Flavio Fernandes <flavio at flaviof.com>