[ovs-git] [openvswitch/ovs] 7478b5: Revert "ofproto: Always set MTU for new internal p...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 7478b5a2b73be87d3b42e0c2ed7b09b1efeff0fe
      https://github.com/openvswitch/ovs/commit/7478b5a2b73be87d3b42e0c2ed7b09b1efeff0fe
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2016-09-02 (Fri, 02 Sep 2016)

  Changed paths:
    M ofproto/ofproto.c
    M tests/ofproto-dpif.at

  Log Message:
  -----------
  Revert "ofproto: Always set MTU for new internal ports."

This reverts commit 47bf118665a3d0f3c153d1fe80e9af02ac9a4e9c.
While the commit tries to make it more consistent, it breaks some system
tests.  The assumptions made on the tests are probably made by many
users, so it's better to revert it.

Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Acked-by: Ben Pfaff <blp at ovn.org>


  Commit: 3a414a0a4f1901ba015ec80b917b9fb206f3c74f
      https://github.com/openvswitch/ovs/commit/3a414a0a4f1901ba015ec80b917b9fb206f3c74f
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2016-09-02 (Fri, 02 Sep 2016)

  Changed paths:
    M FAQ.md
    M NEWS
    M lib/netdev-provider.h
    M lib/netdev.c
    M lib/netdev.h
    M ofproto/ofproto.c
    M tests/ofproto-dpif.at
    M vswitchd/bridge.c
    M vswitchd/vswitch.xml

  Log Message:
  -----------
  ofproto: Honor mtu_request even for internal ports.

By default Open vSwitch tries to configure internal interfaces MTU to
match the bridge minimum, overriding any attempt by the user to
configure it through standard system tools, or the database.

While this works in many simple cases (there are probably many users
that rely on this) it may create problems for more advanced use cases
(like any overlay networks).

This commit allows the user to override the default behavior by
providing an explict MTU in the mtu_request column in the Interface
table.

This means that Open vSwitch will now treat differently database MTU
requests from standard system tools MTU requests (coming from `ip link`
or `ifconfig`), but this seems the best way to remain compatible with
old users while providing a more powerful interface.

Suggested-by: Darrell Ball <dlu998 at gmail.com>
Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Acked-by: Ben Pfaff <blp at ovn.org>
Tested-by: Joe Stringer <joe at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/c65a31e26224...3a414a0a4f19