[ovs-git] [openvswitch/ovs] 0367a7: ovn-controller: Fix group_id allocation.

GitHub noreply at github.com
Fri Sep 9 22:28:42 UTC 2016


  Branch: refs/heads/branch-2.6
  Home:   https://github.com/openvswitch/ovs
  Commit: 0367a759486876ae259df25254710250d55a20d2
      https://github.com/openvswitch/ovs/commit/0367a759486876ae259df25254710250d55a20d2
  Author: Gurucharan Shetty <guru at ovn.org>
  Date:   2016-09-09 (Fri, 09 Sep 2016)

  Changed paths:
    M include/ovn/actions.h
    M ovn/controller/ofctrl.c
    M ovn/lib/actions.c

  Log Message:
  -----------
  ovn-controller: Fix group_id allocation.

A bitmap in 'struct group_table' is used to track all the allocated
group_ids.  For every run of logical flows action parsing, we
add 'group_info' structure to a hmap called 'desired_groups'. The
group_id assigned to this group_info either comes from an already
installed 'existing groups' or a new reservation done in the bitmap.

In ofctrl_put(), if there is a backlog, we call ovn_group_table_clear().
This could unreserve a group_id that comes from an already existing group.
This could result in re-use of group_id in the future causing errors while
installing new groups.

This commit fixes the above scenario.

Signed-off-by: Gurucharan Shetty <guru at ovn.org>
Acked-by: Ben Pfaff <blp at ovn.org>




More information about the git mailing list