[ovs-git] [openvswitch/ovs] ad376c: ovsdb-monitor: Fix valgrind 'possible loss' warnin...

GitHub noreply at github.com
Mon Sep 12 18:05:24 UTC 2016


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: ad376c93032c5960392efc3192e2a0852bd16462
      https://github.com/openvswitch/ovs/commit/ad376c93032c5960392efc3192e2a0852bd16462
  Author: Joe Stringer <joe at ovn.org>
  Date:   2016-09-12 (Mon, 12 Sep 2016)

  Changed paths:
    M ovsdb/jsonrpc-server.c
    M ovsdb/monitor.c

  Log Message:
  -----------
  ovsdb-monitor: Fix valgrind 'possible loss' warnings.

By placing these nodes at the start of their respective structures,
several "possibly lost" warnings from valgrind are silenced.

Fixes: 60e0cd041958 ("ovsdb: Replication usability improvements")
Signed-off-by: Joe Stringer <joe at ovn.org>
Acked-by: Ben Pfaff <blp at ovn.org>


  Commit: c95e1d65160a9adece38e96515fc5a67a01464e2
      https://github.com/openvswitch/ovs/commit/c95e1d65160a9adece38e96515fc5a67a01464e2
  Author: Joe Stringer <joe at ovn.org>
  Date:   2016-09-12 (Mon, 12 Sep 2016)

  Changed paths:
    M ovsdb/replication.c

  Log Message:
  -----------
  ovsdb: Fix replication memory leak.

Valgrind reports:

==18725== 32 bytes in 1 blocks are definitely lost in loss record 339 of 497
==18725==    at 0x4C29BBE: malloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==18725==    by 0x450F1F: xmalloc (util.c:112)
==18725==    by 0x41748E: replication_add_local_db (replication.c:137)
==18725==    by 0x40803B: ovsdb_replication_init (ovsdb-server.c:146)
==18725==    by 0x407C9E: ovsdb_server_connect_active_ovsdb_server
(ovsdb-server.c:1165)
==18725==    by 0x450AB3: process_command (unixctl.c:313)
==18725==    by 0x4500DC: run_connection (unixctl.c:347)
==18725==    by 0x44FFB6: unixctl_server_run (unixctl.c:400)
==18725==    by 0x4081AC: main_loop (ovsdb-server.c:182)
==18725==    by 0x406432: main (ovsdb-server.c:429)

Fixes: 60e0cd041958 ("ovsdb: Replication usability improvements")
Signed-off-by: Joe Stringer <joe at ovn.org>
Acked-by: Flavio Fernandes <flavio at flaviof.com>
Acked-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/0720377c902e...c95e1d65160a


More information about the git mailing list