[ovs-git] [openvswitch/ovs] ceb0a8: datapath: Fix refcount leak on force commit.

GitHub noreply at github.com
Fri Apr 21 01:15:16 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: ceb0a8a92550cb7f8117e94d1c7ecda77970fc13
      https://github.com/openvswitch/ovs/commit/ceb0a8a92550cb7f8117e94d1c7ecda77970fc13
  Author: Jarno Rajahalme <jarno at ovn.org>
  Date:   2017-04-19 (Wed, 19 Apr 2017)

  Changed paths:
    M datapath/conntrack.c

  Log Message:
  -----------
  datapath: Fix refcount leak on force commit.

Upstream commit:

    commit b768b16de58d5e0b1d7c3f936825b25327ced20c
    Author: Jarno Rajahalme <jarno at ovn.org>
    Date:   Tue Mar 28 11:25:26 2017 -0700

    openvswitch: Fix refcount leak on force commit.

    The reference count held for skb needs to be released when the skb's
    nfct pointer is cleared regardless of if nf_ct_delete() is called or
    not.

    Failing to release the skb's reference cound led to deferred conntrack
    cleanup spinning forever within nf_conntrack_cleanup_net_list() when
    cleaning up a network namespace:

       kworker/u16:0-19025 [004] 45981067.173642: sched_switch: kworker/u16:0:19025 [120] R ==> rcu_preempt:7 [120]
       kworker/u16:0-19025 [004] 45981067.173651: kernel_stack: <stack trace>
    => ___preempt_schedule (ffffffffa001ed36)
    => _raw_spin_unlock_bh (ffffffffa0713290)
    => nf_ct_iterate_cleanup (ffffffffc00a4454)
    => nf_conntrack_cleanup_net_list (ffffffffc00a5e1e)
    => nf_conntrack_pernet_exit (ffffffffc00a63dd)
    => ops_exit_list.isra.1 (ffffffffa06075f3)
    => cleanup_net (ffffffffa0607df0)
    => process_one_work (ffffffffa0084c31)
    => worker_thread (ffffffffa008592b)
    => kthread (ffffffffa008bee2)
    => ret_from_fork (ffffffffa071b67c)

    Fixes: dd41d33f0b03 ("openvswitch: Add force commit.")
    Reported-by: Yang Song <yangsong at vmware.com>
    Signed-off-by: Jarno Rajahalme <jarno at ovn.org>
    Acked-by: Joe Stringer <joe at ovn.org>
    Signed-off-by: David S. Miller <davem at davemloft.net>

Signed-off-by: Jarno Rajahalme <jarno at ovn.org>
Acked-by: Joe Stringer <joe at ovn.org>




More information about the git mailing list