From noreply at github.com Tue Aug 1 00:12:38 2017 From: noreply at github.com (GitHub) Date: Mon, 31 Jul 2017 17:12:38 -0700 Subject: [ovs-git] [openvswitch/ovs] 686bea: odp-util: Fix generating various ct fields in odp_... Message-ID: <597fc776c4005_cde3f8656d8fc40999a2@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 686beac8d482f82164932eb5e50680821e2f2f46 https://github.com/openvswitch/ovs/commit/686beac8d482f82164932eb5e50680821e2f2f46 Author: Yi-Hung Wei Date: 2017-07-31 (Mon, 31 Jul 2017) Changed paths: M lib/odp-util.c Log Message: ----------- odp-util: Fix generating various ct fields in odp_key_to_dp_packet() Previously, odp_key_to_dp_packet() may fail to get ct_state, ct_zone, ct_mark, and ct_labels from ODP flow key. This patch fixes the issue. VMWare-BZ: #1920903 Fixes: 07659514c3c1 ("Add support for connection tracking.") Fixes: 8e53fe8cf7a1 ("Add connection tracking mark support.") Fixes: 9daf23484fb1 ("Add connection tracking label support.") Suggested-by: Joe Stringer Signed-off-by: Yi-Hung Wei Signed-off-by: Joe Stringer Commit: 7cc23d90af5e6ec6d117044f8a6d69eaa70d3438 https://github.com/openvswitch/ovs/commit/7cc23d90af5e6ec6d117044f8a6d69eaa70d3438 Author: Yi-Hung Wei Date: 2017-07-31 (Mon, 31 Jul 2017) Changed paths: M lib/odp-util.c Log Message: ----------- odp-util: Fix generating ct_orig_tuple in odp_key_to_dp_packet() Previously, odp_key_to_dp_packet() may fail to get ct_orig_tuple from ODP flow key. This patch fixes the issue. VMWare-BZ: #1920903 Fixes: daf4d3c18da4 ("odp: Support conntrack orig tuple key.") Suggested-by: Joe Stringer Signed-off-by: Yi-Hung Wei Signed-off-by: Joe Stringer Commit: 984c861b54dfb498b05291205baad3c6bede41af https://github.com/openvswitch/ovs/commit/984c861b54dfb498b05291205baad3c6bede41af Author: Yi-Hung Wei Date: 2017-07-31 (Mon, 31 Jul 2017) Changed paths: M lib/odp-util.c Log Message: ----------- odp-util: Remove unnecessary optimization in odp_key_to_dp_packet() The optimization logic in odp_key_to_dp_packet() used to be useful if the number of wanted key attributes are small. However, as the expected key attributes increase, and the optimization logic need to check all the netlink attributes if one of the wanted key attributes is missing, the benefit of the optimization logic is minimal. Therefore, this patch removes the optimization. Suggested-by: Joe Stringer Signed-off-by: Yi-Hung Wei Signed-off-by: Joe Stringer Commit: 08ef583dbc6146a0c98b4e18686ec95369ee6ca8 https://github.com/openvswitch/ovs/commit/08ef583dbc6146a0c98b4e18686ec95369ee6ca8 Author: Yi-Hung Wei Date: 2017-07-31 (Mon, 31 Jul 2017) Changed paths: M lib/odp-util.c Log Message: ----------- odp-util: Refactor odp_key_to_dp_packet() Change type from uint16_t to 'enum ovs_key_attr' so that the compiler will warn the unhandled cases. Suggested-by: Joe Stringer Signed-off-by: Yi-Hung Wei Signed-off-by: Joe Stringer Compare: https://github.com/openvswitch/ovs/compare/b17298ae49c0...08ef583dbc61 From noreply at github.com Tue Aug 1 00:12:56 2017 From: noreply at github.com (GitHub) Date: Mon, 31 Jul 2017 17:12:56 -0700 Subject: [ovs-git] [openvswitch/ovs] e00e94: odp-util: Fix generating various ct fields in odp_... Message-ID: <597fc788ac567_48aa3fc1c6301c3c477f2@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: e00e94ce51e4459bfeb49d926464bc9c3328d045 https://github.com/openvswitch/ovs/commit/e00e94ce51e4459bfeb49d926464bc9c3328d045 Author: Yi-Hung Wei Date: 2017-07-31 (Mon, 31 Jul 2017) Changed paths: M lib/odp-util.c Log Message: ----------- odp-util: Fix generating various ct fields in odp_key_to_dp_packet() Previously, odp_key_to_dp_packet() may fail to get ct_state, ct_zone, ct_mark, and ct_labels from ODP flow key. This patch fixes the issue. Backported from master commit 686beac8d482. VMWare-BZ: #1920903 Fixes: 07659514c3c1 ("Add support for connection tracking.") Fixes: 8e53fe8cf7a1 ("Add connection tracking mark support.") Fixes: 9daf23484fb1 ("Add connection tracking label support.") Suggested-by: Joe Stringer Signed-off-by: Yi-Hung Wei Signed-off-by: Joe Stringer From noreply at github.com Tue Aug 1 00:12:58 2017 From: noreply at github.com (GitHub) Date: Mon, 31 Jul 2017 17:12:58 -0700 Subject: [ovs-git] [openvswitch/ovs] 16c81f: odp-util: Fix generating various ct fields in odp_... Message-ID: <597fc78ad0628_222a23fe32d1b3c30407e6@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.6 Home: https://github.com/openvswitch/ovs Commit: 16c81f26213ba99dfe7cdd62fa4bc187af7c2584 https://github.com/openvswitch/ovs/commit/16c81f26213ba99dfe7cdd62fa4bc187af7c2584 Author: Yi-Hung Wei Date: 2017-07-31 (Mon, 31 Jul 2017) Changed paths: M lib/odp-util.c Log Message: ----------- odp-util: Fix generating various ct fields in odp_key_to_dp_packet() Previously, odp_key_to_dp_packet() may fail to get ct_state, ct_zone, ct_mark, and ct_labels from ODP flow key. This patch fixes the issue. Backported from master commit 686beac8d482. VMWare-BZ: #1920903 Fixes: 07659514c3c1 ("Add support for connection tracking.") Fixes: 8e53fe8cf7a1 ("Add connection tracking mark support.") Fixes: 9daf23484fb1 ("Add connection tracking label support.") Suggested-by: Joe Stringer Signed-off-by: Yi-Hung Wei Signed-off-by: Joe Stringer From noreply at github.com Tue Aug 1 00:13:01 2017 From: noreply at github.com (GitHub) Date: Mon, 31 Jul 2017 17:13:01 -0700 Subject: [ovs-git] [openvswitch/ovs] a858f9: odp-util: Fix generating various ct fields in odp_... Message-ID: <597fc78d8b28a_159e3fba19b3dc3436356@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.5 Home: https://github.com/openvswitch/ovs Commit: a858f99207140c468f7d4d30fc64b6b05e0b305a https://github.com/openvswitch/ovs/commit/a858f99207140c468f7d4d30fc64b6b05e0b305a Author: Yi-Hung Wei Date: 2017-07-31 (Mon, 31 Jul 2017) Changed paths: M lib/odp-util.c Log Message: ----------- odp-util: Fix generating various ct fields in odp_key_to_dp_packet() Previously, odp_key_to_dp_packet() may fail to get ct_state, ct_zone, ct_mark, and ct_labels from ODP flow key. This patch fixes the issue. Backported from master commit 686beac8d482. VMWare-BZ: #1920903 Fixes: 07659514c3c1 ("Add support for connection tracking.") Fixes: 8e53fe8cf7a1 ("Add connection tracking mark support.") Fixes: 9daf23484fb1 ("Add connection tracking label support.") Suggested-by: Joe Stringer Signed-off-by: Yi-Hung Wei Signed-off-by: Joe Stringer From noreply at github.com Tue Aug 1 16:43:11 2017 From: noreply at github.com (GitHub) Date: Tue, 01 Aug 2017 09:43:11 -0700 Subject: [ovs-git] [openvswitch/ovs] c94d81: rhel: Fix typo in README.RHEL.rst Message-ID: <5980af9f8eb87_120c3f94a9e05c40758f6@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: c94d81549bd4788924a77eb706f019251018c755 https://github.com/openvswitch/ovs/commit/c94d81549bd4788924a77eb706f019251018c755 Author: Timothy Redaelli Date: 2017-08-01 (Tue, 01 Aug 2017) Changed paths: M rhel/README.RHEL.rst Log Message: ----------- rhel: Fix typo in README.RHEL.rst Replace systemctk with systemctl Signed-off-by: Timothy Redaelli Signed-off-by: Russell Bryant From noreply at github.com Tue Aug 1 17:24:13 2017 From: noreply at github.com (GitHub) Date: Tue, 01 Aug 2017 10:24:13 -0700 Subject: [ovs-git] [openvswitch/ovs] 952646: ofpbuf: Fix parameter for const initializer. Message-ID: <5980b93d73173_cf03fab851bdc38119445@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 952646cbfdbf7d708e93446f617b2eb8c94900e0 https://github.com/openvswitch/ovs/commit/952646cbfdbf7d708e93446f617b2eb8c94900e0 Author: Joe Stringer Date: 2017-08-01 (Tue, 01 Aug 2017) Changed paths: M include/openvswitch/ofpbuf.h Log Message: ----------- ofpbuf: Fix parameter for const initializer. Clang 4.0 complains: In file included from include/openvswitch/cxxtest.cc:11:0: ../include/openvswitch/ofpbuf.h: In function ?ofpbuf ofpbuf_const_initializer(const void*, size_t)?: ../include/openvswitch/ofpbuf.h:107:5: warning: narrowing conversion of ?size? from ?size_t {aka long unsigned int}? to ?uint32_t {aka unsigned int}? inside { } [-Wnarrowing] }; ^ ../include/openvswitch/ofpbuf.h:107:5: warning: narrowing conversion of ?size? from ?size_t {aka long unsigned int}? to ?uint32_t {aka unsigned int}? inside { } [-Wnarrowing] This is because the ofpbuf struct's "size" parameter is a uint32_t, while ofpbuf_const_initializer() takes a size_t for the size. Fix this function to take a uint32_t instead. Signed-off-by: Joe Stringer Acked-by: Ben Pfaff From noreply at github.com Tue Aug 1 23:46:51 2017 From: noreply at github.com (GitHub) Date: Tue, 01 Aug 2017 16:46:51 -0700 Subject: [ovs-git] [openvswitch/ovs] 76e2d4: dpif-netlink-rtnl: Fix VXLAN port create for regul... Message-ID: <598112ebb4b58_b8b3ff76a5ebc3481639@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 76e2d4e70a0e813804edf08eba9675aad71c8221 https://github.com/openvswitch/ovs/commit/76e2d4e70a0e813804edf08eba9675aad71c8221 Author: Eric Garver Date: 2017-08-01 (Tue, 01 Aug 2017) Changed paths: M lib/dpif-netlink-rtnl.c Log Message: ----------- dpif-netlink-rtnl: Fix VXLAN port create for regular VXLAN When VXLAN-GPE was introduced we added IFLA_VXLAN_GPE to the policy parsing, but did not mark it as optional. The kernel only returns this netlink attribute if it's actually configured. This also adds a missing entry for IFLA_VXLAN_GBP. Apparently we have no system-traffic test coverage there. Fixes: c33c412fb139 ("dpif-netlink-rtnl: Support VXLAN-GPE") Fixes: 825e45e0109f ("dpif-netlink-rtnl: Support VXLAN creation") Reported-by: Joe Stringer Signed-off-by: Eric Garver Signed-off-by: Joe Stringer Commit: acf2e6c00ffc77c942a1780a088dd64a82428449 https://github.com/openvswitch/ovs/commit/acf2e6c00ffc77c942a1780a088dd64a82428449 Author: Roi Dayan Date: 2017-08-01 (Tue, 01 Aug 2017) Changed paths: M lib/dpif-netlink-rtnl.c Log Message: ----------- dpif-netlink-rtnl: Fix false errors on interfaces without tunnel config When we skip adding a port using rtnetlink and not because of an error we need to return EOPNOTSUPP to avoid logging an error message. Fixes: 2fd3d5eda508 ("dpif-netlink-rtnl: Support layer3 GRE") Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey Acked-by: Eric Garver Acked-by: Simon Horman Signed-off-by: Joe Stringer Commit: d52ef4ebe2391a1c1f6c6b71f727298694ff5372 https://github.com/openvswitch/ovs/commit/d52ef4ebe2391a1c1f6c6b71f727298694ff5372 Author: Roi Dayan Date: 2017-08-01 (Tue, 01 Aug 2017) Changed paths: M lib/dpif-netlink.c Log Message: ----------- dpif-netlink: Fix log level for error message Since it's an error but also will always occur in older kernels log the message with level warning instead of info. Signed-off-by: Roi Dayan Acked-by: Eric Garver Signed-off-by: Joe Stringer Compare: https://github.com/openvswitch/ovs/compare/952646cbfdbf...d52ef4ebe239 From noreply at github.com Wed Aug 2 14:45:04 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 07:45:04 -0700 Subject: [ovs-git] [openvswitch/ovs] c1f272: ovn: Fix the failing "2335: ovn -- ACL logging" te... Message-ID: <5981e5705609_7e1e3faad9b5fc346173c@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: c1f272f9cd49c950a4c0b9c41c26a766f16cafd4 https://github.com/openvswitch/ovs/commit/c1f272f9cd49c950a4c0b9c41c26a766f16cafd4 Author: Numan Siddique Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M tests/ovn.at Log Message: ----------- ovn: Fix the failing "2335: ovn -- ACL logging" test case The test case is failing mainly because of timing issue. Looking into the ovn-controller.log it is evident that the last packet injected just before the AT_CHECK, is still not processed by ovn-controller. Fixes: d383eed59589 ("ovn: Add support for ACL logging.") Suggested-by: Lance Richardson Signed-off-by: Numan Siddique Signed-off-by: Justin Pettit From noreply at github.com Wed Aug 2 17:54:26 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 10:54:26 -0700 Subject: [ovs-git] [openvswitch/ovs] 140dd6: dpif-netdev: Incremental addition/deletion of PMD ... Message-ID: <598211d23eef8_7e243fc622f4bc44643b@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 140dd699463a61923538dab70e3b3eeec6fb695d https://github.com/openvswitch/ovs/commit/140dd699463a61923538dab70e3b3eeec6fb695d Author: Ilya Maximets Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/dpif-netdev.c M tests/pmd.at Log Message: ----------- dpif-netdev: Incremental addition/deletion of PMD threads. Currently, change of 'pmd-cpu-mask' is very heavy operation. It requires destroying of all the PMD threads and creating them back. After that, all the threads will sleep until ports' redistribution finished. This patch adds ability to not stop the datapath while adjusting number/placement of PMD threads. All not affected threads will forward traffic without any additional latencies. id-pool created for static tx queue ids to keep them sequential in a flexible way. non-PMD thread will always have static_tx_qid = 0 as it was before. Signed-off-by: Ilya Maximets Tested-by: Mark Kavanagh Acked-by: Mark Kavanagh Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff Commit: e215018b0bc2f9f8aab5f7613ff013323a0018ab https://github.com/openvswitch/ovs/commit/e215018b0bc2f9f8aab5f7613ff013323a0018ab Author: Ilya Maximets Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/dpif-netdev.c Log Message: ----------- dpif-netdev: Don't uninit emc on reload. There are many reasons for reloading of pmd threads: * reconfiguration of one of the ports. * Adjusting of static_tx_qid. * Adding new tx/rx ports. In many cases EMC is still useful after reload and uninit will only lead to unnecessary upcalls/classifier lookups. Such behaviour slows down the datapath. Uninit itself slows down the reload path. All this factors leads to additional unexpected latencies/drops on events not directly connected to current PMD thread. Lets not uninitialize emc cache on reload path. 'emc_cache_slow_sweep()' and replacements should free all the old/unwanted entries. Signed-off-by: Ilya Maximets Acked-by: Cian Ferriter Tested-by: Cian Ferriter Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff Commit: c37813fdb030b4270d05ad61943754f67021a50d https://github.com/openvswitch/ovs/commit/c37813fdb030b4270d05ad61943754f67021a50d Author: Billy O'Mahony Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M Documentation/intro/install/dpdk.rst M lib/dpif-netdev.c Log Message: ----------- dpif-netdev: Assign ports to pmds on non-local numa node. Previously if there is no available (non-isolated) pmd on the numa node for a port then the port is not polled at all. This can result in a non-operational system until such time as nics are physically repositioned. It is preferable to operate with a pmd on the 'wrong' numa node albeit with lower performance. Local pmds are still chosen when available. Signed-off-by: Billy O'Mahony Signed-off-by: Ilya Maximets Co-authored-by: Ilya Maximets Tested-by: Ian Stokes Acked-by: Ian Stokes Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff Commit: 67fe6d635193761439f791e48652acfd60076cfb https://github.com/openvswitch/ovs/commit/67fe6d635193761439f791e48652acfd60076cfb Author: Mark Kavanagh Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/netdev-dpdk.c Log Message: ----------- netdev-dpdk: use rte_eth_dev_set_mtu. DPDK provides an API to set the MTU of compatible physical devices - rte_eth_dev_set_mtu(). Prior to DPDK v16.07 however, this API was not implemented in some DPDK PMDs (i40e, specifically). To allow the use of jumbo frames with affected NICs in OvS-DPDK, MTU configuration was achieved by setting the jumbo frame flag, and corresponding maximum permitted Rx frame size, in an rte_eth_conf structure for the NIC port, and subsequently invoking rte_eth_dev_configure() with that configuration. However, that method does not set the MTU field of the underlying DPDK structure (rte_eth_dev) for the corresponding physical device; consequently, rte_eth_dev_get_mtu() reports the incorrect MTU for an OvS-DPDK phy device with non-standard MTU. Resolve this issue by invoking rte_eth_dev_set_mtu() when setting up or modifying the MTU of a DPDK phy port. Fixes: 0072e93 ("netdev-dpdk: add support for jumbo frames") Reported-by: Aaron Conole Reported-by: Vipin Varghese Reviewed-by: Aaron Conole Acked-by: Sugesh Chandran Tested-by: Sugesh Chandran Signed-off-by: Mark Kavanagh Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff Commit: f3e7ec254738364101eed8f04b1d954cb510615c https://github.com/openvswitch/ovs/commit/f3e7ec254738364101eed8f04b1d954cb510615c Author: Michal Weglicki Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M .travis/linux-build.sh M Documentation/faq/releases.rst M Documentation/howto/dpdk.rst M Documentation/intro/install/dpdk.rst M Documentation/topics/dpdk/vhost-user.rst M NEWS M lib/netdev-dpdk.c M rhel/openvswitch-fedora.spec.in M tests/dpdk/ring_client.c Log Message: ----------- Update relevant artifacts to add support for DPDK 17.05.1. Upgrading to DPDK 17.05.1 stable release adds new significant features relevant to OVS, including, but not limited to: - tun/tap PMD, - VFIO hotplug support, - Generic flow API. Following changes are applied: - netdev-dpdk: Changes required by DPDK API modifications. - doc: Because of DPDK API changes, backward compatibility with previous DPDK releases will be broken, thus all relevant documentation entries are updated. - .travis: DPDK version change from 16.11.1 to 17.05.1. - rhel/openvswitch-fedora.spec.in: DPDK version change from 16.11 to 17.05.1 Signed-off-by: Michal Weglicki Acked-by: Kevin Traynor Acked-by: Mark Kavanagh Tested-by: Ian Stokes Acked-by: Aaron Conole Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff Commit: 0ee821c2e604628b3ef3ab09c45bdd941be7702e https://github.com/openvswitch/ovs/commit/0ee821c2e604628b3ef3ab09c45bdd941be7702e Author: Darrell Ball Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M Documentation/howto/dpdk.rst M lib/netdev-dpdk.c Log Message: ----------- dpdk: Fix device cleanup. Commit 5dcde09c80a8 was introduced to make detaching more automatic without using an additional command beyond ovs-vsctl del-port
. Sometimes, since commit 5dcde09c80a8, dpdk devices are not detached when del-port is issued; command example: sudo ovs-vsctl del-port br0 dpdk1 This can happen when vswitchd is (re)started with an existing database and devices are already bound to dpdk. A minimal recipe to reproduce the issue is: 1/ Starting with darrell at prmh-nsx-perf-server125:~$ sudo ovs-vsctl show 1c50d8ee-b17f-4fac-a595-03b0da8c8275 Bridge "br0" Port "br0" Interface "br0" type: internal Port "dpdk1" Interface "dpdk1" type: dpdk options: {dpdk-devargs="0000:04:00.1"} Port "dpdk0" Interface "dpdk0" type: dpdk options: {dpdk-devargs="0000:04:00.0"} darrell at prmh-nsx-perf-server125:~$ /usr/src/dpdk-16.11/tools/dpdk-devbind.py --status Network devices using DPDK-compatible driver ============================================ 0000:04:00.0 'Ethernet Controller 10-Gigabit X540-AT2' drv=uio_pci_generic unused=ixgbe,vfio-pci 0000:04:00.1 'Ethernet Controller 10-Gigabit X540-AT2' drv=uio_pci_generic unused=ixgbe,vfio-pci 2/ restart vswitchd 3/ run sudo ovs-vsctl del-port br0 dpdk1 and find the interface is NOT detached; there is no info log ?Device '0000:04:00.1' detached?. A more verbose discussion is here: https://mail.openvswitch.org/pipermail/ovs-dev/2017-June/333462.html along with another possible solution. Since we are nearing the end of a release, a safe approach is needed, at this time. One approach is to revert 5dcde09c80a8. This patch does not do that but reinstates the command ovs-appctl netdev-dpdk/detach to handle cases when del-port will not work. To detach the device, run the reinstated command ovs-appctl netdev-dpdk/detach 0000:04:00.1 Observe console output ?Device '0000:04:00.1' has been detached? Fixes: 5dcde09c80a8 ("netdev-dpdk: Fix device leak on port deletion.") CC: Ilya Maximets Acked-by: Aaron Conole Acked-by: Fischetti, Antonio Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff Commit: af697f26b51b67fb4b8db8358bb4c6268bcce0f4 https://github.com/openvswitch/ovs/commit/af697f26b51b67fb4b8db8358bb4c6268bcce0f4 Author: Daniele Di Proietto Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/packets.h Log Message: ----------- packets: Do not initialize ct_orig_tuple. Commit "odp: Support conntrack orig tuple key." introduced new fields in struct 'pkt_metadata'. pkt_metadata_init() is called for every packet in the userspace datapath. When testing a simple single flow case with DPDK, we observe a lower throughput after the above commit (it was 14.88 Mpps before, it is 13 Mpps after). This patch skips initializing ct_orig_tuple in pkt_metadata_init(). It should be enough to initialize ct_state, because nobody should look at ct_orig_tuple unless ct_state is != 0. It's discussed at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-May/332419.html Fixes: daf4d3c18da4("odp: Support conntrack orig tuple key.") Signed-off-by: Daniele Di Proietto Signed-off-by: Bhanuprakash Bodireddy Co-authored-by: Bhanuprakash Bodireddy Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff Commit: 7451af618e0dd55d072821caed95a86d43a54d30 https://github.com/openvswitch/ovs/commit/7451af618e0dd55d072821caed95a86d43a54d30 Author: Sugesh Chandran Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/dp-packet.h Log Message: ----------- dp-packet : Update DPDK rx checksum validation functions. DPDK ports use masks while reporting rx checksum flags. OVS should use these mask along with reported checksum flag while validating the good checksum. Added two new functions to validate bad checksum reported by DPDK NIC port. These two functions will be used in the following patch for enabling rx checksum offload in conntrack module. Signed-off-by: Sugesh Chandran Co-authored-by: Darrell Ball Signed-off-by: Darrell Ball Acked-by: Antonio Fishetti Signed-off-by: Ben Pfaff Commit: 324459a39d17559d1adcb42b9d141b0288a75127 https://github.com/openvswitch/ovs/commit/324459a39d17559d1adcb42b9d141b0288a75127 Author: Sugesh Chandran Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/conntrack.c Log Message: ----------- conntrack : Use Rx checksum offload feature on DPDK ports for conntrack. Avoiding checksum validation in conntrack module if it is already verified in DPDK physical NIC ports. Signed-off-by: Sugesh Chandran Co-authored-by: Darrell Ball Signed-off-by: Darrell Ball Acked-by: Antonio Fishetti Signed-off-by: Ben Pfaff Commit: ded30c74b1e57af84416cdf6c5babd66b1f48ee6 https://github.com/openvswitch/ovs/commit/ded30c74b1e57af84416cdf6c5babd66b1f48ee6 Author: Antonio Fischetti Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/conntrack.c M lib/conntrack.h M lib/ct-dpif.c M lib/ct-dpif.h M lib/dpctl.c M lib/dpctl.man M lib/dpif-netdev.c M lib/dpif-netlink.c M lib/dpif-provider.h M lib/netlink-conntrack.c M lib/netlink-conntrack.h M tests/test-netlink-conntrack.c M utilities/ovs-dpctl.c Log Message: ----------- dpctl: Add new 'ct-bkts' command. With the command: ovs-appctl dpctl/ct-bkts shows the number of connections per bucket. By using a threshold: ovs-appctl dpctl/ct-bkts gt=N for each bucket shows the number of connections when they are greater than N. Signed-off-by: Antonio Fischetti Signed-off-by: Bhanuprakash Bodireddy Co-authored-by: Bhanuprakash Bodireddy Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff Commit: ca62bb16aba7734d83d752b3e4710111bd1eadc0 https://github.com/openvswitch/ovs/commit/ca62bb16aba7734d83d752b3e4710111bd1eadc0 Author: Bhanuprakash Bodireddy Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/dpif-netdev.c Log Message: ----------- dpif-netdev: Reorder elements in dp_netdev_port structure. By reordering the elements in dp_netdev_port structure, pad bytes can be reduced there by saving a cache line. Marginal performance improvement is also observed with this change. Before: structure size: 136, holes: 7, sum padbytes:7, cachelines:3 After : structure size: 128, holes: 6, sum padbytes:0, cachelines:2 Signed-off-by: Bhanuprakash Bodireddy Reviewed-by: Greg Rose Tested-by: Greg Rose Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/c1f272f9cd49...ca62bb16aba7 From noreply at github.com Wed Aug 2 18:05:35 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 11:05:35 -0700 Subject: [ovs-git] [openvswitch/ovs] 46a54c: ovn-northd: Add native active-standby HA. Message-ID: <5982146ff1b1b_7f203f937c617c3c73664@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 46a54ce7114f2caf9367dbc142d37c813adf9db6 https://github.com/openvswitch/ovs/commit/46a54ce7114f2caf9367dbc142d37c813adf9db6 Author: Russell Bryant Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M NEWS M ovn/northd/ovn-northd.8.xml M ovn/northd/ovn-northd.c M tests/ofproto-macros.at Log Message: ----------- ovn-northd: Add native active-standby HA. Add native support for active-standby HA in ovn-northd by having each instance attempt to acquire an OVSDB lock. Only the instance of ovn-northd that currently holds the lock will make active changes to the OVN databases. Signed-off-by: Russell Bryant Acked-by: Han Zhou Tested-by: Numan Siddique Acked-by: Numan Siddique From noreply at github.com Wed Aug 2 18:18:26 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 11:18:26 -0700 Subject: [ovs-git] [openvswitch/ovs] f83989: OF support and translation of generic encap and de... Message-ID: <5982177264995_6f1c3fed89cddc44699c@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: f839892a206abd7adbc0845f772b9f3c58945af5 https://github.com/openvswitch/ovs/commit/f839892a206abd7adbc0845f772b9f3c58945af5 Author: Jan Scheurich Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M NEWS M include/openflow/openflow-common.h M include/openvswitch/automake.mk M include/openvswitch/ofp-actions.h A include/openvswitch/ofp-ed-props.h M include/openvswitch/ofp-errors.h M lib/automake.mk M lib/odp-util.c M lib/odp-util.h M lib/ofp-actions.c A lib/ofp-ed-props.c M lib/packets.h M ofproto/ofproto-dpif-xlate.c M utilities/ovs-ofctl.8.in Log Message: ----------- OF support and translation of generic encap and decap This commit adds support for the OpenFlow actions generic encap and decap (as specified in ONF EXT-382) to the OVS control plane. CLI syntax for encap action with properties: encap(
) encap(
(=,(,,),...)) For example: encap(ethernet) encap(nsh(md_type=1)) encap(nsh(md_type=2,tlv(0x1000,10,0x12345678),tlv(0x2000,20,0xfedcba9876543210))) CLI syntax for decap action: decap() decap(packet_type(ns=,type=)) For example: decap() decap(packet_type(ns=0,type=0xfffe)) decap(packet_type(ns=1,type=0x894f)) The first header supported for encap and decap is "ethernet" to convert packets between packet_type (1,Ethertype) and (0,0). This commit also implements a skeleton for the translation of generic encap and decap actions in ofproto-dpif and adds support to encap and decap an Ethernet header. In general translation of encap commits pending actions and then rewrites struct flow in accordance with the new packet type and header. In the case of encap(ethernet) it suffices to change the packet type from (1, Ethertype) to (0,0) and set the dl_type accordingly. A new pending_encap flag in xlate ctx is set to mark that an corresponding datapath encap action must be triggered at the next commit. In the case of encap(ethernet) ofproto generetas a push_eth action. The general case for translation of decap() is to emit a datapath action to decap the current outermost header and then recirculate the packet to reparse the inner headers. In the special case of an Ethernet packet, decap() just changes the packet type from (0,0) to (1, dl_type) without a need to recirculate. The emission of the pop_eth action for the datapath is postponed to the next commit. Hence encap(ethernet) and decap() on an Ethernet packet are OF octions that only incur a cost in the dataplane when a modifed packet is actually committed, e.g. because it is sent out. They can freely be used for normalizing the packet type in the OF pipeline without degrading performance. Signed-off-by: Jan Scheurich Signed-off-by: Yi Yang Signed-off-by: Zoltan Balogh Co-authored-by: Zoltan Balogh Signed-off-by: Ben Pfaff Commit: d03d0cf2b71b96d8ea46fbc9623f6e14df7f5115 https://github.com/openvswitch/ovs/commit/d03d0cf2b71b96d8ea46fbc9623f6e14df7f5115 Author: Zoltan Balogh Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M tests/packet-type-aware.at Log Message: ----------- tests: Extend PTAP unit tests with decap action - Checking decap() prerequisits. - Encap/decap VLAN tagged Ethernet frames. - Send L3 packet over patch port. - Output L2/L3 packet to ports with different packet_type properties. Signed-off-by: Zoltan Balogh Suggested-by: Jan Scheurich Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/46a54ce7114f...d03d0cf2b71b From noreply at github.com Wed Aug 2 18:33:58 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 11:33:58 -0700 Subject: [ovs-git] [openvswitch/ovs] fe09b6: datapath-windows: Use non-executable memory when a... Message-ID: <59821b164c8d4_7dd03fe14ae3dc388624a@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: fe09b60d4923eb97e2bc1a5ffa5961a46b95f01f https://github.com/openvswitch/ovs/commit/fe09b60d4923eb97e2bc1a5ffa5961a46b95f01f Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/Util.c Log Message: ----------- datapath-windows: Use non-executable memory when allocating memory Use non-executable memory when using ExAllocatePoolWithTagPriority. Found using WDK 10 static code analysis. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 043b1405b50a881953aff99affd2ee6d3448d3b7 https://github.com/openvswitch/ovs/commit/043b1405b50a881953aff99affd2ee6d3448d3b7 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/Switch.c Log Message: ----------- datapath-windows: Remove annotations in Switch.c There are no annotations defined for `OvsExtDetach` and `OvsExtRestart`. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 4f967565aed2ed4baf3f7f23c0f579e0b873cbfc https://github.com/openvswitch/ovs/commit/4f967565aed2ed4baf3f7f23c0f579e0b873cbfc Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/IpHelper.c Log Message: ----------- datapath-windows: interfaceName overflow in IpHelper Bump the size of interfaceName so an overflow cannot occur when using `ConvertInterfaceLuidToAlias`. Found using WDK 10 static code analysis. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: d82c1ff1dbd74151cd05ecd2f882ab13a471714b https://github.com/openvswitch/ovs/commit/d82c1ff1dbd74151cd05ecd2f882ab13a471714b Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/Stt.c Log Message: ----------- datapath-windows: Fix code alignment in Stt Found by inspection. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: b0586ec79b482eccf0efec4201313180999cf70f https://github.com/openvswitch/ovs/commit/b0586ec79b482eccf0efec4201313180999cf70f Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/Stt.c Log Message: ----------- datapath-windows: Add asserts to Stt Unfortunately the WDK 10 static code analysis can't see this one clearly. Add an ASSERT to silence the warning. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 1919e76d6b8ebce97c03291291e088c7a7e88fa2 https://github.com/openvswitch/ovs/commit/1919e76d6b8ebce97c03291291e088c7a7e88fa2 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/Datapath.c Log Message: ----------- datapath-windows: Suppress PAGED_CODE warnings Suppress static code analysis around PAGED_CODE(). The macro is useful only in checked builds. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 5a3cb5148f1ec663fb4252545eaafe5c47b245d0 https://github.com/openvswitch/ovs/commit/5a3cb5148f1ec663fb4252545eaafe5c47b245d0 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/BufferMgmt.c Log Message: ----------- datapath-windows: Fix possible NULL dereference in BufferMgmt The mdl can be NULL. Found using WDK 10 static code analysis. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 9264367cd5490b3503dba277e99b481777792396 https://github.com/openvswitch/ovs/commit/9264367cd5490b3503dba277e99b481777792396 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/Actions.c Log Message: ----------- datapath-windows: Add an assert in recirculation `ovsFwdCtx.switchContext` can't be null since it is passed from actions. Add an assert to keep the static analyzer happy. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 9f6573fe07dba5218ae1fa78c4d15b7f1620dac9 https://github.com/openvswitch/ovs/commit/9f6573fe07dba5218ae1fa78c4d15b7f1620dac9 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/Datapath.c M datapath-windows/ovsext/Datapath.h Log Message: ----------- datapath-windows: Add annotations for OvsAcquireCtrlLock Add annotations to the function `OvsAcquireCtrlLock`. We make it aware that it raises the dispatch level, where it saves the dispatch level and it acquires a lock. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 3cbbcb1ba61134030c994eb7f545e90736625f33 https://github.com/openvswitch/ovs/commit/3cbbcb1ba61134030c994eb7f545e90736625f33 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/Datapath.c M datapath-windows/ovsext/Datapath.h Log Message: ----------- datapath-windows: Add annotations for OvsReleaseCtrlLock Add function annotations for `OvsReleaseCtrlLock`. We make it aware that it requires a certain dispatch level, that it restores the dispatch level, that it requires a lock held and release a lock. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 9330795b9790240873afe61d2ddbf9f1e2dfb2d7 https://github.com/openvswitch/ovs/commit/9330795b9790240873afe61d2ddbf9f1e2dfb2d7 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/Tunnel.c Log Message: ----------- datapath-windows: Remove function declarations from Tunnel.c `OvsAcquireDatapathRead`, `OvsAcquireDatapathWrite`, `OvsReleaseDatapath` are defined and implemented in Switch.h which is already included. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 3e6d3fe13bdd81feed3a92ee828c611984a7d46b https://github.com/openvswitch/ovs/commit/3e6d3fe13bdd81feed3a92ee828c611984a7d46b Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/Switch.h Log Message: ----------- datapath-windows: Add function annotations for OvsAcquireDatapathRead The function should be aware that it raises the dispatch level, saves the dispatch level and acquires a lock. This patch adds annotation for that. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 41d18c494a7b12bf235841e51cda7ac51c05ee66 https://github.com/openvswitch/ovs/commit/41d18c494a7b12bf235841e51cda7ac51c05ee66 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/Switch.h Log Message: ----------- datapath-windows: Add function annotations for OvsAcquireDatapathWrite The function should be aware that it raises the dispatch level, saves the dispatch level and acquires a lock. This patch adds annotation for that. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 5635920bb4eaa94a4edae6547eb763de635b6d7e https://github.com/openvswitch/ovs/commit/5635920bb4eaa94a4edae6547eb763de635b6d7e Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/Switch.h Log Message: ----------- datapath-windows: Add function annotations for OvsReleaseDatapath The function should be aware that it requires a certain dispatch level, restores the dispatch level, requires lock held and releases a lock. This patch adds annotation for that. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 5f0d140d127da048469226a957eab9e904bc88b3 https://github.com/openvswitch/ovs/commit/5f0d140d127da048469226a957eab9e904bc88b3 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/Event.c Log Message: ----------- datapath-windows: Add function annotations for OvsCancelIrp The function should be aware that it is cancel routine. This patch adds annotation for that. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 8ba92ebee99dab07261811db22e9cf849e4c3d52 https://github.com/openvswitch/ovs/commit/8ba92ebee99dab07261811db22e9cf849e4c3d52 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/TunnelFilter.c Log Message: ----------- datapath-windows: Add function annotations for OvsTunnelFilterCancelIrp The function should be aware that it is cancel routine. This patch adds annotation for that. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 7fba23033f2190c0282d5832d3ec786b7595cbdf https://github.com/openvswitch/ovs/commit/7fba23033f2190c0282d5832d3ec786b7595cbdf Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/User.c Log Message: ----------- datapath-windows: Add function annotations for OvsCancelIrpDatapath The function should be aware that it is cancel routine. This patch adds annotation for that. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: f05dc2c26e8c98b48b8263e6e62879978b57cb8a https://github.com/openvswitch/ovs/commit/f05dc2c26e8c98b48b8263e6e62879978b57cb8a Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/Event.c Log Message: ----------- datapath-windows: Add function annotations for OvsAcquireEventQueueLock The function should be aware that it raises the dispatch level, saves the dispatch level and acquires a lock. This patch adds annotation for that. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 7dcfa473bfb663b5df18452459e9be3aade1894b https://github.com/openvswitch/ovs/commit/7dcfa473bfb663b5df18452459e9be3aade1894b Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/Event.c Log Message: ----------- datapath-windows: Add annotations for OvsReleaseEventQueueLock Add function annotations for ` OvsReleaseEventQueueLock`. We make it aware that it requires a certain dispatch level, that it restores the dispatch level, that it requires a lock held and releases a lock. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: cfc854f0bad5ee0181146545e4c64a045cf20a51 https://github.com/openvswitch/ovs/commit/cfc854f0bad5ee0181146545e4c64a045cf20a51 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/User.c Log Message: ----------- datapath-windows: Add annotations for OvsReleasePidHashLock Add function annotations for ` OvsReleasePidHashLock`. We make it aware that it requires a certain dispatch level, that it restores the dispatch level, that it requires a lock held and releases a lock. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: f0187396b0a77623a726590ff0a22a1db20d7ba4 https://github.com/openvswitch/ovs/commit/f0187396b0a77623a726590ff0a22a1db20d7ba4 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/User.c Log Message: ----------- datapath-windows: Add annotations for OvsAcquirePidHashLock Add annotations to the function ` OvsAcquirePidHashLock`. We make it aware that it raises the dispatch level, where it saves the dispatch level and it acquires a lock. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: c5a12e53f86fedfe389c6ba66666026589006594 https://github.com/openvswitch/ovs/commit/c5a12e53f86fedfe389c6ba66666026589006594 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/TunnelFilter.c Log Message: ----------- datapath-windows: Fix misspelling in comment. Found by inspection. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: b27b4e5f05a6f2e27bd5ef9b0078a5ccc6678b7c https://github.com/openvswitch/ovs/commit/b27b4e5f05a6f2e27bd5ef9b0078a5ccc6678b7c Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/Debug.h M datapath-windows/ovsext/Util.c M datapath-windows/ovsext/Util.h Log Message: ----------- datapath-windows: Use annotations instead for macros We can safely use function annotations to instead of defining out own macros. Nuke implementation of `OVS_VERIFY_IRQL_LE` and OVS_VERIFY_IRQL (unused). Add function annotations to the functions which were using OVS_VERIFY_IRQL_LE`. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 0d4374aa82dea2dc316c432c0cfee371456fcf9d https://github.com/openvswitch/ovs/commit/0d4374aa82dea2dc316c432c0cfee371456fcf9d Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/BufferMgmt.c Log Message: ----------- datapath-windows: Add assert in OvsPartialCopyNBL `srcNb` should never be NULL since it was copied over from another nbl. Add an assertion just in case and to keep static analysis happy. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 445995a8e270d6a7301fbc09b482d3e177172edb https://github.com/openvswitch/ovs/commit/445995a8e270d6a7301fbc09b482d3e177172edb Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/BufferMgmt.c Log Message: ----------- datapath-windows: Fix possible NULL deference in OvsFullCopyNBL Check if the first net buffer exists before trying to copy it. Found using WDK 10 static code analysis. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 20804d501994e7e5a1b7876fce40b473770c6101 https://github.com/openvswitch/ovs/commit/20804d501994e7e5a1b7876fce40b473770c6101 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/Jhash.c Log Message: ----------- datapath-windows: Suppress warning in jhash Suppress overflow warning to keep static code analysis happy. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: f0aeea81bd27f1d757df531890bbf0ad3bbbc111 https://github.com/openvswitch/ovs/commit/f0aeea81bd27f1d757df531890bbf0ad3bbbc111 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/IpHelper.c Log Message: ----------- datapath-windows: Add dummy parameter for NotifyRouteChange2 Add a dummy parameter when using `NotifyRouteChange2` to keep static static analysis happy. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 1c5875f7d9d7dd93aa319265fdeaf971c871b010 https://github.com/openvswitch/ovs/commit/1c5875f7d9d7dd93aa319265fdeaf971c871b010 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/IpHelper.c Log Message: ----------- datapath-windows: fix excessive stack usage in iphelper `OvsGetOrResolveIPNeigh` uses a stack over 1024 bytes. Switch one parameter to be a pointer. Found using WDK 8.1 static code analysis. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 3630a2f321226bce0306c6a8834812a0dd4dc88f https://github.com/openvswitch/ovs/commit/3630a2f321226bce0306c6a8834812a0dd4dc88f Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/IpHelper.c Log Message: ----------- datapath-windows: Check return status when using APIs Check the return status of `ConvertInterfaceLuidToAlias` and `RtlStringCbLengthW` and treat them accordingly. Also remove unneeded initialization for `interfaceName`. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 7ce89fa2d4a6021d9e9321d200bb886992053949 https://github.com/openvswitch/ovs/commit/7ce89fa2d4a6021d9e9321d200bb886992053949 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/NetProto.h Log Message: ----------- datapath-windows: Treat TCP_HDR_LEN static analysis warnings Using the shift operator in macros makes the static analyzer on WDK 8.1 confused. Switch to multiplication when trying to get the data offset of the TCP header. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 553966a7942c3c709fa75c277af8ddb2dd4ec602 https://github.com/openvswitch/ovs/commit/553966a7942c3c709fa75c277af8ddb2dd4ec602 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/Conntrack-related.c Log Message: ----------- datapath-windows: Add annotation for OvsCtRelatedEntryCleaner Make the function `OvsCtRelatedEntryCleaner` aware it is a kstart_routine. Also, the function is not compliant with the coding standard. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 17cf43bce5b36413ac642793678cde4e8ed67711 https://github.com/openvswitch/ovs/commit/17cf43bce5b36413ac642793678cde4e8ed67711 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/IpFragment.c Log Message: ----------- datapath-windows: Add annotation for OvsIpFragmentEntryCleaner Make the function `OvsIpFragmentEntryCleaner` aware it is a kstart_routine. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Commit: 1e30f5fa96d84b7c500784220753b247726bb362 https://github.com/openvswitch/ovs/commit/1e30f5fa96d84b7c500784220753b247726bb362 Author: Alin Serdean Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/Switch.c Log Message: ----------- datapath-windows: Fix shared variables which use Interlocked functions Instead of assigning a value directly to the variable use `InterlockedAdd` with 0. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Compare: https://github.com/openvswitch/ovs/compare/d03d0cf2b71b...1e30f5fa96d8 From noreply at github.com Wed Aug 2 19:28:44 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 12:28:44 -0700 Subject: [ovs-git] [openvswitch/ovs] 8ee458: vlog: reopen log file in monitor process Message-ID: <598227ece1f53_79733fca88503c2c1051aa@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 8ee4583645db89a7d3d2cd3137a649aedcd8358b https://github.com/openvswitch/ovs/commit/8ee4583645db89a7d3d2cd3137a649aedcd8358b Author: Huanle Han Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/daemon-unix.c Log Message: ----------- vlog: reopen log file in monitor process ovs daemon process will reopen file after every log rotate. However, it doesn't happen to monitor process. That is to say, fd of log file in monitor proces always point to oldest disk file, which is deleted after log rotate. Once daemon process restarts from a crash, it inherits parent's fds, including the deleted log file. This commit reopens log file in monitor process everytime it wakes up from waitpid. Signed-off-by: Huanle Han Signed-off-by: Ben Pfaff From noreply at github.com Wed Aug 2 19:36:33 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 12:36:33 -0700 Subject: [ovs-git] [openvswitch/ovs] 8b0c3c: lacp: enable bond slave immediately after lacp att... Message-ID: <598229c1ecdf4_79e73fcd70d2fc3032539@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 8b0c3c3813dd7149ab7f791ae7a13d67eabfdedf https://github.com/openvswitch/ovs/commit/8b0c3c3813dd7149ab7f791ae7a13d67eabfdedf Author: Huanle Han Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/lacp.c Log Message: ----------- lacp: enable bond slave immediately after lacp attach There is a long interval (5~20 seconds) between lacp slave attach and bond slave enable. During the interval, ovs drop all received packets from that slave because bond_check_admissibility() check fails. The root cause is that connectivity_seq is not changed after lacp update and lacp status is not populated into port->may_enable by port_run() immediately. Signed-off-by: Huanle Han Signed-off-by: Ben Pfaff From noreply at github.com Wed Aug 2 19:36:48 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 12:36:48 -0700 Subject: [ovs-git] [openvswitch/ovs] ce32d6: lacp: enable bond slave immediately after lacp att... Message-ID: <598229d025059_35d3ffb39983c3436738@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: ce32d6edc33fdda064cc766119e6de1cc6dfab91 https://github.com/openvswitch/ovs/commit/ce32d6edc33fdda064cc766119e6de1cc6dfab91 Author: Huanle Han Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/lacp.c Log Message: ----------- lacp: enable bond slave immediately after lacp attach There is a long interval (5~20 seconds) between lacp slave attach and bond slave enable. During the interval, ovs drop all received packets from that slave because bond_check_admissibility() check fails. The root cause is that connectivity_seq is not changed after lacp update and lacp status is not populated into port->may_enable by port_run() immediately. Signed-off-by: Huanle Han Signed-off-by: Ben Pfaff From noreply at github.com Wed Aug 2 19:36:53 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 12:36:53 -0700 Subject: [ovs-git] [openvswitch/ovs] 4e12bb: lacp: enable bond slave immediately after lacp att... Message-ID: <598229d5c814d_39d63f8e9016fc34101682@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.6 Home: https://github.com/openvswitch/ovs Commit: 4e12bb34e4f17a9539d0bfa0119a759bcd0aa8aa https://github.com/openvswitch/ovs/commit/4e12bb34e4f17a9539d0bfa0119a759bcd0aa8aa Author: Huanle Han Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/lacp.c Log Message: ----------- lacp: enable bond slave immediately after lacp attach There is a long interval (5~20 seconds) between lacp slave attach and bond slave enable. During the interval, ovs drop all received packets from that slave because bond_check_admissibility() check fails. The root cause is that connectivity_seq is not changed after lacp update and lacp status is not populated into port->may_enable by port_run() immediately. Signed-off-by: Huanle Han Signed-off-by: Ben Pfaff From noreply at github.com Wed Aug 2 19:36:58 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 12:36:58 -0700 Subject: [ovs-git] [openvswitch/ovs] a42abc: lacp: enable bond slave immediately after lacp att... Message-ID: <598229daeb786_745a3f9aa2227c30812ee@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.5 Home: https://github.com/openvswitch/ovs Commit: a42abcb4bc540564655030c47c85da4182f92272 https://github.com/openvswitch/ovs/commit/a42abcb4bc540564655030c47c85da4182f92272 Author: Huanle Han Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/lacp.c Log Message: ----------- lacp: enable bond slave immediately after lacp attach There is a long interval (5~20 seconds) between lacp slave attach and bond slave enable. During the interval, ovs drop all received packets from that slave because bond_check_admissibility() check fails. The root cause is that connectivity_seq is not changed after lacp update and lacp status is not populated into port->may_enable by port_run() immediately. Signed-off-by: Huanle Han Signed-off-by: Ben Pfaff From noreply at github.com Wed Aug 2 19:37:04 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 12:37:04 -0700 Subject: [ovs-git] [openvswitch/ovs] f2999d: lacp: enable bond slave immediately after lacp att... Message-ID: <598229e0d8708_70d53f827a205c388497e@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.4 Home: https://github.com/openvswitch/ovs Commit: f2999d50aba1156c4cc4b85bc54c86586e43a4cd https://github.com/openvswitch/ovs/commit/f2999d50aba1156c4cc4b85bc54c86586e43a4cd Author: Huanle Han Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/lacp.c Log Message: ----------- lacp: enable bond slave immediately after lacp attach There is a long interval (5~20 seconds) between lacp slave attach and bond slave enable. During the interval, ovs drop all received packets from that slave because bond_check_admissibility() check fails. The root cause is that connectivity_seq is not changed after lacp update and lacp status is not populated into port->may_enable by port_run() immediately. Signed-off-by: Huanle Han Signed-off-by: Ben Pfaff From noreply at github.com Wed Aug 2 20:38:14 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 13:38:14 -0700 Subject: [ovs-git] [openvswitch/ovs] f80485: ovn-controller: Monitor port bindings of parent po... Message-ID: <59823836d3679_1859c3f9d4c713c24107077@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: f80485a1f5a43e8d228fe81c1e9395a6bf5abb67 https://github.com/openvswitch/ovs/commit/f80485a1f5a43e8d228fe81c1e9395a6bf5abb67 Author: wangqianyu Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M ovn/controller/ovn-controller.c Log Message: ----------- ovn-controller: Monitor port bindings of parent ports. Neutron configure a trunk-sub port. The parent-port and sub-port located in different network. there is a vm attached to parent port. And no vm attached to the network of sub-port in the same chassis. In this situation, the ovn-controller can not get the configuration info of sub-port. The reason is that ovn-controller does not monitor the port-binding with parent. This patch fix this bug. Signed-off-by: wangqianyu Signed-off-by: Ben Pfaff From noreply at github.com Wed Aug 2 20:38:47 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 13:38:47 -0700 Subject: [ovs-git] [openvswitch/ovs] afaf4d: ovn-controller: Monitor port bindings of parent po... Message-ID: <59823857d37ed_6b9c3fe6a2323c28676cb@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: afaf4de07083863bccb1feaf01f37a59ca06a909 https://github.com/openvswitch/ovs/commit/afaf4de07083863bccb1feaf01f37a59ca06a909 Author: wangqianyu Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M ovn/controller/ovn-controller.c Log Message: ----------- ovn-controller: Monitor port bindings of parent ports. Neutron configure a trunk-sub port. The parent-port and sub-port located in different network. there is a vm attached to parent port. And no vm attached to the network of sub-port in the same chassis. In this situation, the ovn-controller can not get the configuration info of sub-port. The reason is that ovn-controller does not monitor the port-binding with parent. This patch fix this bug. Signed-off-by: wangqianyu Signed-off-by: Ben Pfaff From noreply at github.com Wed Aug 2 20:57:51 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 13:57:51 -0700 Subject: [ovs-git] [openvswitch/ovs] 8c2c22: netdev: Fix netdev_open() to track and recreate cl... Message-ID: <59823ccf8613f_18f543f8ebf5d1c306855b@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 8c2c225e481d6560faf73bb49c33f026bc58a664 https://github.com/openvswitch/ovs/commit/8c2c225e481d6560faf73bb49c33f026bc58a664 Author: Eelco Chaudron Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/netdev-provider.h M lib/netdev.c Log Message: ----------- netdev: Fix netdev_open() to track and recreate classless interfaces Due to commit 67ac844 an existing issue with OVS persisten ports surfaced. If we revert the commit we no longer get the error, and basic traffic will flow. However the wrong netdev class is used, hence the wrong callbacks get called. The main issue is with netdev_open() being called with type = NULL before the interface is actually configured in the system. This patch tracks these "auto" generated interfaces, and once netdev_open() gets called with a valid type, re-configures (re-create) it. Signed-off-by: Eelco Chaudron Signed-off-by: Ben Pfaff From noreply at github.com Wed Aug 2 21:06:18 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 14:06:18 -0700 Subject: [ovs-git] [openvswitch/ovs] f3eb76: hash: Add "fall through" annotations for 32-bit bu... Message-ID: <59823eca88750_6ea43f9e4c3c9c3434836@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: f3eb7691bfddda35dc65c781de54adf837e8f6b7 https://github.com/openvswitch/ovs/commit/f3eb7691bfddda35dc65c781de54adf837e8f6b7 Author: Ben Pfaff Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/hash.c Log Message: ----------- hash: Add "fall through" annotations for 32-bit builds as well. Commit 73c7216a5329 ("Fix some -Wimplicit-fallthrough warnings building with GCC 7") missed a few fall through annotations that only appear in 32-bit builds. This commit adds them. CC: Timothy Redaelli Signed-off-by: Ben Pfaff Acked-by: Andy Zhou From noreply at github.com Wed Aug 2 22:08:12 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 15:08:12 -0700 Subject: [ovs-git] [openvswitch/ovs] b24fa3: ofproto-dpif-xlate: Eliminate duplicate read of xc... Message-ID: <59824d4c8a8d0_7f9e3fbc2da1dc3075190@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: b24fa3f486d4061cb9facd181fd6234f281904df https://github.com/openvswitch/ovs/commit/b24fa3f486d4061cb9facd181fd6234f281904df Author: Ben Pfaff Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M ofproto/ofproto-dpif-xlate.c Log Message: ----------- ofproto-dpif-xlate: Eliminate duplicate read of xcfgp. This inner 'xcfg' shadowed the outer one and could have read a different value if 'xcfgp' was changing, so this is possibly a bug fix. Found by -Wshadow=local in GCC 7. Signed-off-by: Ben Pfaff Acked-by: Andy Zhou Commit: 71f21279f62c2cca39ff1522f4d25b5de74992e3 https://github.com/openvswitch/ovs/commit/71f21279f62c2cca39ff1522f4d25b5de74992e3 Author: Ben Pfaff Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/classifier.c M lib/daemon-unix.c M lib/db-ctl-base.c M lib/dpctl.c M lib/dpif-netdev.c M lib/hash.c M lib/learn.c M lib/lldp/lldpd.c M lib/netdev-dummy.c M lib/netdev-linux.c M lib/odp-util.c M lib/ofp-print.c M lib/ofp-util.c M lib/ovsdb-idl.c M lib/table.c M lib/unixctl.c M lib/vconn.c M lib/vlog.c M ofproto/ofproto-dpif-xlate.c M ofproto/ofproto-dpif.c M ovn/controller/ofctrl.c M ovn/controller/patch.c M ovn/controller/physical.c M ovn/lib/expr.c M ovn/northd/ovn-northd.c M ovn/utilities/ovn-trace.c M ovsdb/jsonrpc-server.c M ovsdb/replication.c M tests/test-bundle.c M tests/test-ccmap.c M tests/test-classifier.c M tests/test-cmap.c M tests/test-odp.c M tests/test-ovn.c M utilities/ovs-vsctl.c M vswitchd/bridge.c M vtep/vtep-ctl.c Log Message: ----------- Eliminate most shadowing for local variable names. Shadowing is when a variable with a given name in an inner scope hides a different variable with the same name in a surrounding scope. This is generally undesirable because it can confuse programmers. This commit eliminates most of it. Found with -Wshadow=local in GCC 7. The repo is not really ready to enable this option by default because of a few cases that are harder to fix, and harmless, such as nested use of CMAP_FOR_EACH. Signed-off-by: Ben Pfaff Acked-by: Andy Zhou Compare: https://github.com/openvswitch/ovs/compare/f3eb7691bfdd...71f21279f62c From noreply at github.com Wed Aug 2 22:08:29 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 15:08:29 -0700 Subject: [ovs-git] [openvswitch/ovs] 4aad8d: ofproto-dpif-xlate: Eliminate duplicate read of xc... Message-ID: <59824d5dd240c_41683fe6736d1c3c1007f8@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: 4aad8de9963d5df272a71c7d015c3acffd192722 https://github.com/openvswitch/ovs/commit/4aad8de9963d5df272a71c7d015c3acffd192722 Author: Ben Pfaff Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M ofproto/ofproto-dpif-xlate.c Log Message: ----------- ofproto-dpif-xlate: Eliminate duplicate read of xcfgp. This inner 'xcfg' shadowed the outer one and could have read a different value if 'xcfgp' was changing, so this is possibly a bug fix. Found by -Wshadow=local in GCC 7. Signed-off-by: Ben Pfaff Acked-by: Andy Zhou From noreply at github.com Wed Aug 2 22:18:03 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 15:18:03 -0700 Subject: [ovs-git] [openvswitch/ovs] 1bc241: ofproto-dpif-xlate: Always process IGMP packets in... Message-ID: <59824f9b2e003_77643fb6f522fc2c365d6@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 1bc241690f276c057e8d3590118f687a170bd46a https://github.com/openvswitch/ovs/commit/1bc241690f276c057e8d3590118f687a170bd46a Author: Ben Pfaff Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M ofproto/ofproto-dpif-xlate.c Log Message: ----------- ofproto-dpif-xlate: Always process IGMP packets in userspace. Open vSwitch needs to always process IGMP packets in the userspace slow path so that they can have their desired side effects. However, userspace was only applying SLOW_ACTION to IGMP packets in some cases, as opposed to all cases, which meant that sometimes IGMP packets were ignored. This fixes that particular problem. A problem remains: there is a mismatch between userspace support for IGMP matching and kernel (lack of) support for IGMP matching. This should probably be handled better. See the original report for more information. Reported-by: Huanle Han Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/335690.html Signed-off-by: Ben Pfaff From noreply at github.com Wed Aug 2 22:54:33 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 15:54:33 -0700 Subject: [ovs-git] [openvswitch/ovs] 507180: datapath-windows: Refactor OvsCreateNewNBLsFromMul... Message-ID: <598258293f06e_6ea43f9e4c3c9c34362d4@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 5071802a6c9090dcd13d39e4e06b550d478ef6fc https://github.com/openvswitch/ovs/commit/5071802a6c9090dcd13d39e4e06b550d478ef6fc Author: Shashank Ram Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M datapath-windows/ovsext/PacketIO.c Log Message: ----------- datapath-windows: Refactor OvsCreateNewNBLsFromMultipleNBs Previously, the function would take the curNbl and nextNbl as inputs, and modify the linked list, and merge the input linked list with the newly generated newNbl list. This is confusing for the caller, and the function has unnecessary logic for merging linked lists that instead the caller should take care of. This is because the OvsCreateNewNBLsFromMultipleNBs() is a generic API that can be used by other functions as well, and its natural for different callers to have different needs. This patch refactors the behavior of OvsCreateNewNBLsFromMultipleNBs to take in the curNbl and lastNbl, and it returns a linked list of NBLs and sets the HEAD and TAIL of the new list obtained from the curNbl. If the caller wants to chain a new linked list at the HEAD or TAIL, it can make use of the curNbl and lastNbl to do so. Signed-off-by: Shashank Ram Signed-off-by: Ben Pfaff Acked-by: Anand Kumar From noreply at github.com Wed Aug 2 23:04:16 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 16:04:16 -0700 Subject: [ovs-git] [openvswitch/ovs] 564230: ofproto-dpif-ipfix: add support for per-flow drop ... Message-ID: <59825a7052c80_72c03fcd83f5bc44304a5@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 564230b6c982fc5b6df06b139a938edce874a5f7 https://github.com/openvswitch/ovs/commit/564230b6c982fc5b6df06b139a938edce874a5f7 Author: Przemyslaw Szczerbik Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M ofproto/ofproto-dpif-ipfix.c M ofproto/ofproto-dpif-ipfix.h M ofproto/ofproto-dpif-upcall.c Log Message: ----------- ofproto-dpif-ipfix: add support for per-flow drop counters Patch based on RFC 5102, section 5.10. It implements per-flow drop counters: - droppedPacketDeltaCount - droppedPacketTotalCount - droppedOctetDeltaCount - droppedOctetTotalCount In order to determine if packet is going to be dropped, flow actions associated with packet are read. If at least one of the following conditions is met, packet is not marked as dropped. Packet has at least one: - OVS_ACTION_ATTR_OUTPUT action - OVS_ACTION_ATTR_CLONE action with nested OVS_ACTION_ATTR_OUTPUT action - OVS_ACTION_ATTR_SAMPLE action with nested OVS_ACTION_ATTR_OUTPUT action and sampling probability is set to 100% Signed-off-by: Przemyslaw Szczerbik Signed-off-by: Ben Pfaff From noreply at github.com Thu Aug 3 00:57:32 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 17:57:32 -0700 Subject: [ovs-git] [openvswitch/ovs] 29a18d: vlog: reopen log file in monitor process Message-ID: <598274fcdbaf_3dff3ff7c84ebc2c31741@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.6 Home: https://github.com/openvswitch/ovs Commit: 29a18daf3eaa5b388b9565ecd0cbd7c52067363a https://github.com/openvswitch/ovs/commit/29a18daf3eaa5b388b9565ecd0cbd7c52067363a Author: Huanle Han Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/daemon-unix.c Log Message: ----------- vlog: reopen log file in monitor process ovs daemon process will reopen file after every log rotate. However, it doesn't happen to monitor process. That is to say, fd of log file in monitor proces always point to oldest disk file, which is deleted after log rotate. Once daemon process restarts from a crash, it inherits parent's fds, including the deleted log file. This commit reopens log file in monitor process everytime it wakes up from waitpid. Signed-off-by: Huanle Han Signed-off-by: Ben Pfaff From noreply at github.com Thu Aug 3 00:57:35 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 17:57:35 -0700 Subject: [ovs-git] [openvswitch/ovs] 87e087: vlog: reopen log file in monitor process Message-ID: <598274ffd740c_78b43fa680e2bc2c63083@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.5 Home: https://github.com/openvswitch/ovs Commit: 87e087f0d98dc1368d9a17f962e51941695074a2 https://github.com/openvswitch/ovs/commit/87e087f0d98dc1368d9a17f962e51941695074a2 Author: Huanle Han Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/daemon-unix.c Log Message: ----------- vlog: reopen log file in monitor process ovs daemon process will reopen file after every log rotate. However, it doesn't happen to monitor process. That is to say, fd of log file in monitor proces always point to oldest disk file, which is deleted after log rotate. Once daemon process restarts from a crash, it inherits parent's fds, including the deleted log file. This commit reopens log file in monitor process everytime it wakes up from waitpid. Signed-off-by: Huanle Han Signed-off-by: Ben Pfaff From noreply at github.com Thu Aug 3 00:57:28 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 17:57:28 -0700 Subject: [ovs-git] [openvswitch/ovs] 4adc71: vlog: reopen log file in monitor process Message-ID: <598274f828231_3d4f3fd32c695c3c292ac@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: 4adc71a5316d4f30d2abce7cbb6ba8b95e77faf3 https://github.com/openvswitch/ovs/commit/4adc71a5316d4f30d2abce7cbb6ba8b95e77faf3 Author: Huanle Han Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/daemon-unix.c Log Message: ----------- vlog: reopen log file in monitor process ovs daemon process will reopen file after every log rotate. However, it doesn't happen to monitor process. That is to say, fd of log file in monitor proces always point to oldest disk file, which is deleted after log rotate. Once daemon process restarts from a crash, it inherits parent's fds, including the deleted log file. This commit reopens log file in monitor process everytime it wakes up from waitpid. Signed-off-by: Huanle Han Signed-off-by: Ben Pfaff From noreply at github.com Thu Aug 3 01:59:42 2017 From: noreply at github.com (GitHub) Date: Wed, 02 Aug 2017 18:59:42 -0700 Subject: [ovs-git] [openvswitch/ovs] a61a28: dp-packet: New function dp_packet_get_send_len(). Message-ID: <5982838e960fc_198a3ff76ebf9c30218e0@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: a61a2891197d5390ebc77f69cb15564ed1960662 https://github.com/openvswitch/ovs/commit/a61a2891197d5390ebc77f69cb15564ed1960662 Author: Ben Pfaff Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/dp-packet.h M lib/netdev-bsd.c M lib/netdev-dummy.c M lib/netdev-linux.c Log Message: ----------- dp-packet: New function dp_packet_get_send_len(). This function is useful in a few places for representing the packet's length minus the cutlen. Signed-off-by: Ben Pfaff Commit: d19cf8bb798ff52d69893d77032a0ec0e9325b75 https://github.com/openvswitch/ovs/commit/d19cf8bb798ff52d69893d77032a0ec0e9325b75 Author: Zhenyu Gao Date: 2017-08-02 (Wed, 02 Aug 2017) Changed paths: M lib/netdev-linux.c Log Message: ----------- netdev-linux: Replace sendmsg with sendmmsg in netdev_linux_send Sendmmsg can reduce cpu cycles in sending packets to kernel. Replace sendmsg with sendmmsg in function netdev_linux_send to send batch packets if sendmmsg is available. If kernel side doesn't support sendmmsg, will fallback to sendmsg. netserver |------------| | | | container | |----veth----| | | |------------| |---veth-| dpdk-ovs | netperf | | |--------------| |----dpdk----| | bare-metal | | |--------------| | | | | pnic-----------pnic Netperf was consumed to test the performance: 1)cmd:netperf -H remote-container -t UDP_STREAM -l 60 -- -m 1400 result: netserver received 2383.21Mb(sendmsg)/2551.64Mb(sendmmsg) 2)cmd:netperf -H remote-container -t UDP_STREAM -l 60 -- -m 60 result: netserver received 109.72Mb(sendmsg)/115.18Mb(sendmmsg) Sendmmsg show about 6% improvement in netperf UDP testing. Signed-off-by: Zhenyu Gao Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/564230b6c982...d19cf8bb798f From noreply at github.com Thu Aug 3 15:17:22 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 08:17:22 -0700 Subject: [ovs-git] [openvswitch/ovs] 94896b: rhel: Use systemd Restart option for ovn-controlle... Message-ID: <59833e8263c24_9533fca4b5a5c308585d@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 94896b2e8117e999155a026ccbde9df9800c2c39 https://github.com/openvswitch/ovs/commit/94896b2e8117e999155a026ccbde9df9800c2c39 Author: Mark Michelson Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M ovn/utilities/ovn-ctl M rhel/usr_lib_systemd_system_ovn-controller-vtep.service M rhel/usr_lib_systemd_system_ovn-controller.service Log Message: ----------- rhel: Use systemd Restart option for ovn-controllers. This change stops the use of OVS's monitor for the ovn-controller and ovn-controller-vtep systemd services. Instead, the services use the systemd Restart option to restart the services automatically if they fail. This patch changes the ovn-controller service Type from "oneshot" to "forking". The Restart option is incompatible with oneshot services. The patch does not change the ovn-controller-vtep service type from "simple", however. Signed-off-by: Mark Michelson Acked-by: Lance Richardson Signed-off-by: Russell Bryant From noreply at github.com Thu Aug 3 17:59:23 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 10:59:23 -0700 Subject: [ovs-git] [openvswitch/ovs] fbe061: ovs-router: Remove redundant headers. Message-ID: <5983647bd2c6d_d593fbb45b8dc3412995f@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: fbe061cbec75d3f22e84532f624aac2d537e6ba3 https://github.com/openvswitch/ovs/commit/fbe061cbec75d3f22e84532f624aac2d537e6ba3 Author: Tonghao Zhang Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M lib/ovs-router.c Log Message: ----------- ovs-router: Remove redundant headers. Signed-off-by: Tonghao Zhang Signed-off-by: Ben Pfaff From noreply at github.com Thu Aug 3 18:33:46 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 11:33:46 -0700 Subject: [ovs-git] [openvswitch/ovs] 73e713: util: Add PADDED_MEMBERS_CACHELINE_MARKER macro to... Message-ID: <59836c8a11185_2f6b3fa986a8bc30112735@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 73e713fc7b69984f75e5947397f9599eb4fb0f83 https://github.com/openvswitch/ovs/commit/73e713fc7b69984f75e5947397f9599eb4fb0f83 Author: Bhanuprakash Bodireddy Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M include/openvswitch/util.h M lib/util.h Log Message: ----------- util: Add PADDED_MEMBERS_CACHELINE_MARKER macro to mark cachelines. PADDED_MEMBERS_CACHELINE_MARKER macro introduces a way to mark cachelines. This macro expands to an anonymous union containing cacheline marker, members in nested anonymous structure, followed by array of bytes that is multiple of UNIT bytes. Signed-off-by: Bhanuprakash Bodireddy Signed-off-by: Ben Pfaff Commit: 99fc16c036f7e6b978a41cce7dc995660d140d96 https://github.com/openvswitch/ovs/commit/99fc16c036f7e6b978a41cce7dc995660d140d96 Author: Bhanuprakash Bodireddy Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M lib/packets.h Log Message: ----------- packets: Reorganize the pkt_metadata structure. pkt_metadata_init() is called for every packet in userspace datapath and initializes few members in pkt_metadata. Before this the members that needs to be initialized are prefetched using pkt_metadata_prefetch_init(). The above functions are critical to the userspace datapath performance and should be in sync. Any changes to the pkt_metadata should also include changes to metadata_init() and prefetch_init() if necessary. This commit slightly refactors the pkt_metadata structure and introduces cache line markers to catch any violations to the structure. Also only prefetch the cachelines having the members that needs to be zeroed out. Signed-off-by: Bhanuprakash Bodireddy Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/fbe061cbec75...99fc16c036f7 From noreply at github.com Thu Aug 3 19:32:49 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 12:32:49 -0700 Subject: [ovs-git] [openvswitch/ovs] 1a18a2: ovs-ctl: Remove a leftover restore_interfaces in r... Message-ID: <59837a6183317_31fa3f872bf05c3414413f@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 1a18a2e085e01acc1cab6420a19cb6cf0c36c923 https://github.com/openvswitch/ovs/commit/1a18a2e085e01acc1cab6420a19cb6cf0c36c923 Author: Timothy Redaelli Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M utilities/ovs-ctl.in Log Message: ----------- ovs-ctl: Remove a leftover restore_interfaces in restart Since commit c416eaf8c247 ("ovs-ctl: Remove code for upgrading from Open vSwitch 1.9 and earlier.") the kernel configuration of the specified network interfaces is not saved anymore for restart command so there is no need to try to restore it. CC: Ben Pfaff Fixes: c416eaf8c247 ("ovs-ctl: Remove code for upgrading from Open vSwitch 1.9 and earlier.") Signed-off-by: Timothy Redaelli Signed-off-by: Ben Pfaff From noreply at github.com Thu Aug 3 19:37:31 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 12:37:31 -0700 Subject: [ovs-git] [openvswitch/ovs] bb1706: tc: Refactor nl_msg_put_flower_options Message-ID: <59837b7b1ef2_6e343fcb21f45c2814737@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: bb17064412557087c18f947aa4a6d074571a79dc https://github.com/openvswitch/ovs/commit/bb17064412557087c18f947aa4a6d074571a79dc Author: Paul Blakey Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M lib/tc.c Log Message: ----------- tc: Refactor nl_msg_put_flower_options Refactor nl_msg_put_flower_options to be more readable. This commit doesn't change functionality. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Acked-by: Simon Horman Signed-off-by: Ben Pfaff Commit: 2b1d9fa9090965f31c83966d513d6e486481decb https://github.com/openvswitch/ovs/commit/2b1d9fa9090965f31c83966d513d6e486481decb Author: Paul Blakey Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M lib/netdev-tc-offloads.c M lib/tc.c M lib/tc.h Log Message: ----------- tc: Split IPs and transport layer ports unions in flower struct Split dst/src_port and ipv4/ipv6 union so we can distingush them easily for later features. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Signed-off-by: Ben Pfaff Commit: 83a87fae79e9c324b5e4d4b8e4ec104f4a86b060 https://github.com/openvswitch/ovs/commit/83a87fae79e9c324b5e4d4b8e4ec104f4a86b060 Author: Paul Blakey Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M lib/netdev-tc-offloads.c Log Message: ----------- netdev-tc-offloads: Parse ip related fields only if eth type is ip There is no need to parse ip related fields if eth type is not ip. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/1a18a2e085e0...83a87fae79e9 From noreply at github.com Thu Aug 3 19:39:19 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 12:39:19 -0700 Subject: [ovs-git] [openvswitch/ovs] 18e5d1: ofproto-dpif: A new command for changing dpif supp... Message-ID: <59837be764418_8efd3f9638533c3073517@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 18e5d1a81961786b42a986960059e319dd6a1c9a https://github.com/openvswitch/ovs/commit/18e5d1a81961786b42a986960059e319dd6a1c9a Author: Andy Zhou Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M ofproto/ofproto-dpif.c Log Message: ----------- ofproto-dpif: A new command for changing dpif support fields dpif support fields contain various datapath capabilities detected by ofproto at start up time. Usually those fields are read-only, not intended to be changed at runtime. However in practice, when writing tests or running experiments, it becomes necessary to set those fields to emulate different datapath feature combinations. Currently there are several separate commands that can be used defeature individual support fields. This patch generalize those implementations, provides a single command to change any support fields. Later patches will remove those individual defeature commands. The new command also allow the support fields to be changed multiple times. Currently defeature commands does not allow the support level to be restored. Signed-off-by: Andy Zhou Acked-by: Ben Pfaff Commit: 88186383f36ca4e3708c9737f43c5e8908cd58d8 https://github.com/openvswitch/ovs/commit/88186383f36ca4e3708c9737f43c5e8908cd58d8 Author: Andy Zhou Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M ofproto/bond.c M ofproto/ofproto-dpif-upcall.c M ofproto/ofproto-dpif-xlate.c M ofproto/ofproto-dpif-xlate.h M ofproto/ofproto-dpif.c M ofproto/ofproto-dpif.h Log Message: ----------- ofproto-dpif: Add boottime support field. When changing support fields, it may be unsafe to set support level beyond what datapath can support. This patch introduce the notion of boot time support and runtime support fields. Boot time support are set only once during ofproto start up phase, and not changed during runtime. The runtime support fields are the same as boot time support fields at the startup time, but can be changed via the 'ovs-appctl' command. However, each change will be checked against the corresponding boot time support field. Only feature reduction from the boot time support is allowed. Signed-off-by: Andy Zhou Acked-by: Ben Pfaff Commit: ce15b514a6de816845a46ee7bb74f37aad1a0582 https://github.com/openvswitch/ovs/commit/ce15b514a6de816845a46ee7bb74f37aad1a0582 Author: Andy Zhou Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M ofproto/ofproto-dpif-xlate.c M ofproto/ofproto-dpif-xlate.h M ofproto/ofproto-dpif.c M tests/ofproto-dpif.at Log Message: ----------- ofproto-dpif: Remove dpif/disable-dp-clone command. Use 'dpif/set-dp-features' command instead. Signed-off-by: Andy Zhou Acked-by: Ben Pfaff Commit: c7eca9658d4519cf88ddb6dea02efb745f7bdbcb https://github.com/openvswitch/ovs/commit/c7eca9658d4519cf88ddb6dea02efb745f7bdbcb Author: Andy Zhou Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M ofproto/ofproto-dpif.c M tests/system-traffic.at Log Message: ----------- ofproto-dpif: Remove dpif/disable-truncate command. Use 'dpif/set-dp-features' command instead. Signed-off-by: Andy Zhou Acked-by: Ben Pfaff Commit: 80dc5c8494d7c65a47c82c8bb9a5f7542a66e468 https://github.com/openvswitch/ovs/commit/80dc5c8494d7c65a47c82c8bb9a5f7542a66e468 Author: Andy Zhou Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M ofproto/ofproto-dpif.c M tests/ofproto-macros.at Log Message: ----------- ofproto-dpif: Remove ofprto/tnl-push-pop command. Use dpif/set-dp-features command instead. Signed-off-by: Andy Zhou Acked-by: Ben Pfaff Commit: 9c2a44dcdcecec56255b89d0175b843de3e69711 https://github.com/openvswitch/ovs/commit/9c2a44dcdcecec56255b89d0175b843de3e69711 Author: Andy Zhou Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M ofproto/ofproto-dpif-xlate.c M tests/ofproto-dpif.at Log Message: ----------- xlate: Refactor compose_clone() API Create a new function that hides the details of netlink encoding for the translated clone action. Signed-off-by: Andy Zhou Acked-by: Ben Pfaff Commit: eee693934aacf03ceaf15a931e3f377e6702f8b3 https://github.com/openvswitch/ovs/commit/eee693934aacf03ceaf15a931e3f377e6702f8b3 Author: Andy Zhou Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M ofproto/ofproto-dpif-xlate.c M tests/ofproto-dpif.at Log Message: ----------- xlate: Emit datapath clone only when necessary. Currently the open flow 'clone' action is always translated into datapath clone. While this is valid translation, the datapath 'clone' action is more expensive and has more restrictions than not using them. This patch optimizing the open flow 'clone' translation. Whenever the open flow actions within the 'clone' is reversible, i.e. any datapath actions that modifies a packet can be reversed by using another datapath action. Reversible actions can be translated without emitting datapath clone. This patch combines xlate_clone() and compose_clone() into a single compose_clone() API, since the layering boundary is not obvious. Signed-off-by: Andy Zhou Acked-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/83a87fae79e9...eee693934aac From noreply at github.com Thu Aug 3 19:52:03 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 12:52:03 -0700 Subject: [ovs-git] [openvswitch/ovs] 08fa02: odp-util: Support zero mask on ipv4 frag Message-ID: <59837ee37893e_338b3fb2f1d63c2c4798c@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 08fa0266b6632111407f00de9bc6e118522204d6 https://github.com/openvswitch/ovs/commit/08fa0266b6632111407f00de9bc6e118522204d6 Author: Paul Blakey Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M lib/odp-util.c Log Message: ----------- odp-util: Support zero mask on ipv4 frag Don't print frag parsing error if mask is zero, instead just don't print it. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Signed-off-by: Ben Pfaff From noreply at github.com Thu Aug 3 19:54:03 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 12:54:03 -0700 Subject: [ovs-git] [openvswitch/ovs] 8c1e74: tc: Correct convert ticks to msecs on parsing tc T... Message-ID: <59837f5b3800a_196c93fae1cce7c3c83513@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 8c1e74d1c8e3aeb74b676da45ff0b04021083c35 https://github.com/openvswitch/ovs/commit/8c1e74d1c8e3aeb74b676da45ff0b04021083c35 Author: Paul Blakey Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M lib/tc.c Log Message: ----------- tc: Correct convert ticks to msecs on parsing tc TM Use sysconf(_SC_CLK_TCK) to read run time "number of clock ticks per second" and use that to convert ticks to msecs. This is how iproute does the conversion when parsing tc filters. The system call is done only once. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Acked-by: Joe Stringer Signed-off-by: Ben Pfaff From noreply at github.com Thu Aug 3 20:15:52 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 13:15:52 -0700 Subject: [ovs-git] [openvswitch/ovs] 493e05: tnl-ports: Open tunnel type if device name has spe... Message-ID: <598384787047b_6cad3fd9d8da9c3c103497@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 493e0550a37cd0efac299ad5f643ee3e8eb354bf https://github.com/openvswitch/ovs/commit/493e0550a37cd0efac299ad5f643ee3e8eb354bf Author: Paul Blakey Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M lib/tnl-ports.c Log Message: ----------- tnl-ports: Open tunnel type if device name has special prefix There is a race between listening on route changes from route-table netlink which then calls ovs_router_insert() where it adds the involved netdev to the tnl-ports map (tnl_port_map_insert_ipdev()), and netdev_open from from normal opening of the port. tnl-ports open the netdev as type system (type == NULL) when it doesn't exists before it is opened normally, e.g from dumping the ports in dpctl. This solves 'ovs-dpctl show' EExists error on vxlan ports as both (dpctl/tnl-ports) will open the ports as vxlan type. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Signed-off-by: Ben Pfaff From noreply at github.com Thu Aug 3 20:21:20 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 13:21:20 -0700 Subject: [ovs-git] [openvswitch/ovs] 091337: ovs-ovctl: Fix "OpenFlow versions" in ovs-ofctl -V Message-ID: <598385c055d9_18cbf3fd09ccbdc2868343@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 091337a224f522978aba586507f646d74806958b https://github.com/openvswitch/ovs/commit/091337a224f522978aba586507f646d74806958b Author: Timothy Redaelli Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M lib/ofp-version-opt.h Log Message: ----------- ovs-ovctl: Fix "OpenFlow versions" in ovs-ofctl -V Fix the output of "ovs-ofctl -V" to show OpenFlow 1.4 as max supported versions since OpenFlow 1.4 was enabled by default in commit 8d3485791188 ("OpenFlow: Enable OpenFlow 1.4 by default.") CC: Ben Pfaff Signed-off-by: Timothy Redaelli Signed-off-by: Ben Pfaff From noreply at github.com Thu Aug 3 20:51:52 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 13:51:52 -0700 Subject: [ovs-git] [openvswitch/ovs] 2142be: ofproto-dpif-xlate: Add OFPACT_ENCAP, OFPACT_DECAP... Message-ID: <59838ce84b124_7b743f9a4ec99c3015313a@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 2142be1f91af9650d3e95e2ebfe1428c65c761b8 https://github.com/openvswitch/ovs/commit/2142be1f91af9650d3e95e2ebfe1428c65c761b8 Author: Ben Pfaff Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M ofproto/ofproto-dpif-xlate.c Log Message: ----------- ofproto-dpif-xlate: Add OFPACT_ENCAP, OFPACT_DECAP to reversible_actions(). Fixes a broken build when building with --enable-Werror. I guess that encap and decap are often reversible, but it's safe to consider them irreversible. Fixes: eee693934aac ("xlate: Emit datapath clone only when necessary.") Signed-off-by: Ben Pfaff Acked-by: Andy Zhou From noreply at github.com Thu Aug 3 20:57:02 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 13:57:02 -0700 Subject: [ovs-git] [openvswitch/ovs] 6cc9d7: ovs-ofctl: Avoid unnecessary flow replacement in "... Message-ID: <59838e1e6419f_3d4f3fd32c695c3c43237@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 6cc9d77c78f684c3f01a2ca66691b08bf9bec791 https://github.com/openvswitch/ovs/commit/6cc9d77c78f684c3f01a2ca66691b08bf9bec791 Author: Ben Pfaff Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M include/openvswitch/ofp-actions.h M lib/ofp-actions.c M utilities/ovs-ofctl.c Log Message: ----------- ovs-ofctl: Avoid unnecessary flow replacement in "replace-flows" command. The ovs-ofctl "diff-flows" and "replace-flows" command compare the flows in two flow tables. Until now, the "replace-flows" command has considered certain almost meaningless differences related to the version of OpenFlow used to add a flow as significant, which caused it to replace a flow by an identical-in-practice version, e.g. in the following, the "replace-flows" command prints a FLOW_MOD that adds the flow that was already added previously: $ cat > flows actions=resubmit(,1) $ ovs-vsctl add-br br0 $ ovs-ofctl del-flows br0 $ ovs-ofctl add-flows br0 flows $ ovs-ofctl -vvconn replace-flows br0 flows 2>&1 | grep FLOW_MOD Re-adding an existing flow has some effects, for example, it resets the flow's duration, so it's better to avoid it. This commit fixes the problem using the same trick previously used for a similar problem with the "diff-flows" command, which was fixed in commit 98f7f427bf8b ("ovs-ofctl: Avoid printing false differences on "ovs-ofctl diff-flows"."). Reported-by: Kevin Lin Signed-off-by: Ben Pfaff Acked-by: Andy Zhou From noreply at github.com Thu Aug 3 20:58:04 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 13:58:04 -0700 Subject: [ovs-git] [openvswitch/ovs] e9804f: bridge: Avoid read of uninitialized data configuri... Message-ID: <59838e5c4c7b1_14053f97b88b5c386576@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: e9804ffdf703d27b18ca3a4d81a4599ac2eacc04 https://github.com/openvswitch/ovs/commit/e9804ffdf703d27b18ca3a4d81a4599ac2eacc04 Author: Ben Pfaff Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M vswitchd/bridge.c Log Message: ----------- bridge: Avoid read of uninitialized data configuring Auto-Attach. Reported-by: "qintao (F)" Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2017-April/044309.html Signed-off-by: Ben Pfaff Acked-by: Andy Zhou From noreply at github.com Thu Aug 3 20:59:16 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 13:59:16 -0700 Subject: [ovs-git] [openvswitch/ovs] 702097: bridge: Avoid read of uninitialized data configuri... Message-ID: <59838ea458c53_3f1e3fe734103c3043280@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.6 Home: https://github.com/openvswitch/ovs Commit: 7020975768f69f404221d303cde7da7531479ef4 https://github.com/openvswitch/ovs/commit/7020975768f69f404221d303cde7da7531479ef4 Author: Ben Pfaff Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M vswitchd/bridge.c Log Message: ----------- bridge: Avoid read of uninitialized data configuring Auto-Attach. Reported-by: "qintao (F)" Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2017-April/044309.html Signed-off-by: Ben Pfaff Acked-by: Andy Zhou From noreply at github.com Thu Aug 3 20:59:21 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 13:59:21 -0700 Subject: [ovs-git] [openvswitch/ovs] 01122c: bridge: Avoid read of uninitialized data configuri... Message-ID: <59838ea97cd7c_78c03f7ef23bbc34112826@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.5 Home: https://github.com/openvswitch/ovs Commit: 01122c2ac158d9edb76d860a379b32b26f3687d1 https://github.com/openvswitch/ovs/commit/01122c2ac158d9edb76d860a379b32b26f3687d1 Author: Ben Pfaff Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M vswitchd/bridge.c Log Message: ----------- bridge: Avoid read of uninitialized data configuring Auto-Attach. Reported-by: "qintao (F)" Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2017-April/044309.html Signed-off-by: Ben Pfaff Acked-by: Andy Zhou From noreply at github.com Thu Aug 3 20:59:11 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 13:59:11 -0700 Subject: [ovs-git] [openvswitch/ovs] bba844: bridge: Avoid read of uninitialized data configuri... Message-ID: <59838e9f2b41a_7c763ff3276f3c2c157724@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: bba844a66a6b9593ad999e6b555a9e46128dce28 https://github.com/openvswitch/ovs/commit/bba844a66a6b9593ad999e6b555a9e46128dce28 Author: Ben Pfaff Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M vswitchd/bridge.c Log Message: ----------- bridge: Avoid read of uninitialized data configuring Auto-Attach. Reported-by: "qintao (F)" Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2017-April/044309.html Signed-off-by: Ben Pfaff Acked-by: Andy Zhou From noreply at github.com Thu Aug 3 20:59:26 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 13:59:26 -0700 Subject: [ovs-git] [openvswitch/ovs] 6b9b9d: bridge: Avoid read of uninitialized data configuri... Message-ID: <59838eae568b3_2ee3fa6e1d39c2c119863@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.4 Home: https://github.com/openvswitch/ovs Commit: 6b9b9da122c23fc3454d63414524c281bb7acd4e https://github.com/openvswitch/ovs/commit/6b9b9da122c23fc3454d63414524c281bb7acd4e Author: Ben Pfaff Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M vswitchd/bridge.c Log Message: ----------- bridge: Avoid read of uninitialized data configuring Auto-Attach. Reported-by: "qintao (F)" Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2017-April/044309.html Signed-off-by: Ben Pfaff Acked-by: Andy Zhou From noreply at github.com Thu Aug 3 21:38:15 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 14:38:15 -0700 Subject: [ovs-git] [openvswitch/ovs] 662975: datapath-windows: Fix conntrack lookups for revers... Message-ID: <598397c725dca_196f73f7e43c15c40117763@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 662975e43c3f65b52d32e12cdff3d9796c9f138b https://github.com/openvswitch/ovs/commit/662975e43c3f65b52d32e12cdff3d9796c9f138b Author: Sairam Venugopal Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M datapath-windows/ovsext/Conntrack.c Log Message: ----------- datapath-windows: Fix conntrack lookups for reversed keys The conntrack table needs to be queried for entries in either directions to determine if the packet is in forward direction or reply direction. The current behavior ends up reversing the incoming packet's 5-Tuple for every entry in the loop instead of doing it only once. Testing Done: - Verified that ICMP requests are no longer treated as replies in Conntrack. Co-authored-by: Sairam Venugopal Signed-off-by: Anand Kumar Signed-off-by: Ben Pfaff Acked-by: Shashank Ram Acked-by: Alin Gabriel Serdean From noreply at github.com Thu Aug 3 21:54:44 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 14:54:44 -0700 Subject: [ovs-git] [openvswitch/ovs] e90bc0: ovsdb-idl: compound indexes design document Message-ID: <59839ba480e9d_43c13fafcad7fc30993ca@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: e90bc056d11f51b8bc772d376d9017df1b17325d https://github.com/openvswitch/ovs/commit/e90bc056d11f51b8bc772d376d9017df1b17325d Author: Lance Richardson Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M Documentation/automake.mk A Documentation/topics/idl-compound-indexes.rst M Documentation/topics/index.rst Log Message: ----------- ovsdb-idl: compound indexes design document In the work made in our projects, it was found the need to have a faster access to the rows contained in tables in the replica, as well to have the possibility to loop over a subset of rows that meet some specified criteria. Those needs lead us to design and implement a functionality that satisfies those requirements, so an implementation of special indexes were done. In order to keep the OVSDB server implementation unmodified and avoid extra load of processing, the indexes are created as part of the IDL. The indexes are created as part of the initialization of the replica request and are maintained automatically when there are changes in the replica. This document explains the design rationale of the compound indexes feature. Signed-off-by: Javier Albornoz Signed-off-by: Esteban Rodriguez Betancourt Signed-off-by: Jorge Arturo Sauma Vargas Co-authored-by: Javier Albornoz Co-authored-by: Esteban Rodriguez Betancourt Co-authored-by: Jorge Arturo Sauma Vargas Co-aughored-by: Lance Richardson Signed-off-by: Lance Richardson Signed-off-by: Ben Pfaff Commit: 6c2705cda300c63019c93c0755b16308ae7d8540 https://github.com/openvswitch/ovs/commit/6c2705cda300c63019c93c0755b16308ae7d8540 Author: Lance Richardson Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M lib/automake.mk A lib/skiplist.c A lib/skiplist.h M tests/.gitignore M tests/automake.mk M tests/library.at A tests/test-skiplist.c Log Message: ----------- lib: skiplist implementation Skiplist implementation intended for use in the IDL compound indexes feature. Signed-off-by: Esteban Rodriguez Betancourt Co-authored-by: Lance Richardson Signed-off-by: Lance Richardson Signed-off-by: Ben Pfaff Commit: 93fe026466644b6f436d99e69a31d9884d5a3506 https://github.com/openvswitch/ovs/commit/93fe026466644b6f436d99e69a31d9884d5a3506 Author: Lance Richardson Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M lib/ovsdb-idl-provider.h M lib/ovsdb-idl.c M lib/ovsdb-idl.h Log Message: ----------- ovsdb-idl: idl compound indexes implementation This patch adds support for the creation of multicolumn indexes in the C IDL to enable for efficient search and retrieval of database rows by key. Signed-off-by: Esteban Rodriguez Betancourt Co-authored-by: Lance Richardson Signed-off-by: Lance Richardson Signed-off-by: Ben Pfaff Commit: 0a8606ee56422e40b93a02effea62a5a87543543 https://github.com/openvswitch/ovs/commit/0a8606ee56422e40b93a02effea62a5a87543543 Author: Lance Richardson Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M ovsdb/ovsdb-idlc.in M tests/ovsdb-idl.at M tests/test-ovsdb.c Log Message: ----------- ovsdb-idl: Autogenerated functions for compound indexes Generates and fills in the default comparators for columns with type int, real, string. Also creates the macros that allow iteration over the contents of the index, and perform queries. Signed-off-by: Arnoldo Lutz Guevara Signed-off-by: Esteban Rodriguez Betancourt Co-authored-by: Arnoldo Lutz Guevara Co-authored-by: Esteban Rodriguez Betancourt Signed-off-by: Lance Richardson Signed-off-by: Ben Pfaff Commit: 5be10ec1fee8efcc104f0d8d4318791779afd6e6 https://github.com/openvswitch/ovs/commit/5be10ec1fee8efcc104f0d8d4318791779afd6e6 Author: Lance Richardson Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M ovn/controller/lflow.c M ovn/controller/lflow.h M ovn/controller/lport.c M ovn/controller/lport.h M ovn/controller/ovn-controller.c Log Message: ----------- ovn-controller: use idl index for multicast group table Use IDL index for multicast group table lookups, avoiding the overhead of creating/destroying an index hmap for each iteration of the ovn-controller main loop. Signed-off-by: Lance Richardson Signed-off-by: Ben Pfaff Commit: f4557c0957916be9c7c639ae1a12368948d0fe63 https://github.com/openvswitch/ovs/commit/f4557c0957916be9c7c639ae1a12368948d0fe63 Author: Lance Richardson Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M ovn/controller/binding.c M ovn/controller/binding.h M ovn/controller/lflow.c M ovn/controller/lflow.h M ovn/controller/lport.c M ovn/controller/lport.h M ovn/controller/ovn-controller.c M ovn/controller/physical.c M ovn/controller/physical.h M ovn/controller/pinctrl.c M ovn/controller/pinctrl.h Log Message: ----------- ovn-controller: use idl indexes for logical port table Use IDL index for logical port table lookups, avoiding the overhead of creating/destroying an index hmap for each iteration of the ovn-controller main loop. Signed-off-by: Lance Richardson Signed-off-by: Ben Pfaff Commit: 34653b68091709f16014bf7e5b0f1df0ffd96af3 https://github.com/openvswitch/ovs/commit/34653b68091709f16014bf7e5b0f1df0ffd96af3 Author: Lance Richardson Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M ovn/controller/bfd.c M ovn/controller/binding.c M ovn/controller/binding.h M ovn/controller/lport.c M ovn/controller/lport.h M ovn/controller/ovn-controller.c M ovn/controller/ovn-controller.h M ovn/controller/pinctrl.c Log Message: ----------- ovn-controller: use idl indexes for logical datapath Use IDL index to iterate over all logical ports in a given logical datapath, avoiding the overhead of creating/destroying an indexing data structure in each iteration of the ovn-controller main loop. Signed-off-by: Lance Richardson Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/662975e43c3f...34653b680917 From noreply at github.com Thu Aug 3 21:56:18 2017 From: noreply at github.com (GitHub) Date: Thu, 03 Aug 2017 14:56:18 -0700 Subject: [ovs-git] [openvswitch/ovs] e7cd8c: AUTHORS: Add Jorge Arturo Sauma Vargas and fix a m... Message-ID: <59839c02b0855_7a133fa7ca389c3857438@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: e7cd8c3632a9f3b7390639303b038835ef2b71ed https://github.com/openvswitch/ovs/commit/e7cd8c3632a9f3b7390639303b038835ef2b71ed Author: Ben Pfaff Date: 2017-08-03 (Thu, 03 Aug 2017) Changed paths: M AUTHORS.rst Log Message: ----------- AUTHORS: Add Jorge Arturo Sauma Vargas and fix a misspelling. Signed-off-by: Ben Pfaff From noreply at github.com Fri Aug 4 18:05:25 2017 From: noreply at github.com (GitHub) Date: Fri, 04 Aug 2017 11:05:25 -0700 Subject: [ovs-git] [openvswitch/ovs] 0d31e5: tests: avoid non-posix options to wc Message-ID: <5984b76571219_a9a3fea4db93c2412292@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 0d31e5be04ee5e4ab389ff123ad4a58f755d793e https://github.com/openvswitch/ovs/commit/0d31e5be04ee5e4ab389ff123ad4a58f755d793e Author: Lance Richardson Date: 2017-08-04 (Fri, 04 Aug 2017) Changed paths: M tests/ovn.at Log Message: ----------- tests: avoid non-posix options to wc The '--lines' option for the wc command is a GNU extension and is not recognized by some implemenations. Use the POSIX 1003.1 '-l' option instead. Signed-off-by: Lance Richardson Signed-off-by: Russell Bryant From noreply at github.com Fri Aug 4 18:12:19 2017 From: noreply at github.com (GitHub) Date: Fri, 04 Aug 2017 11:12:19 -0700 Subject: [ovs-git] [openvswitch/ovs] 8a5a5e: tests: fix wrapped comment Message-ID: <5984b903dadc0_38083fe01315dc301389b7@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 8a5a5e3c3319a6728b8b7fe24d35b1825cf32771 https://github.com/openvswitch/ovs/commit/8a5a5e3c3319a6728b8b7fe24d35b1825cf32771 Author: Lance Richardson Date: 2017-08-04 (Fri, 04 Aug 2017) Changed paths: M tests/ovn.at Log Message: ----------- tests: fix wrapped comment Add missing '#' to comment line. Signed-off-by: Lance Richardson Signed-off-by: Russell Bryant From noreply at github.com Fri Aug 4 18:12:19 2017 From: noreply at github.com (GitHub) Date: Fri, 04 Aug 2017 11:12:19 -0700 Subject: [ovs-git] [openvswitch/ovs] 8a5a5e: tests: fix wrapped comment Message-ID: <5984b903dadc0_38083fe01315dc301389b7@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 8a5a5e3c3319a6728b8b7fe24d35b1825cf32771 https://github.com/openvswitch/ovs/commit/8a5a5e3c3319a6728b8b7fe24d35b1825cf32771 Author: Lance Richardson Date: 2017-08-04 (Fri, 04 Aug 2017) Changed paths: M tests/ovn.at Log Message: ----------- tests: fix wrapped comment Add missing '#' to comment line. Signed-off-by: Lance Richardson Signed-off-by: Russell Bryant From noreply at github.com Fri Aug 4 18:12:19 2017 From: noreply at github.com (GitHub) Date: Fri, 04 Aug 2017 11:12:19 -0700 Subject: [ovs-git] [openvswitch/ovs] 8a5a5e: tests: fix wrapped comment Message-ID: <5984b903dadc0_38083fe01315dc301389b7@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 8a5a5e3c3319a6728b8b7fe24d35b1825cf32771 https://github.com/openvswitch/ovs/commit/8a5a5e3c3319a6728b8b7fe24d35b1825cf32771 Author: Lance Richardson Date: 2017-08-04 (Fri, 04 Aug 2017) Changed paths: M tests/ovn.at Log Message: ----------- tests: fix wrapped comment Add missing '#' to comment line. Signed-off-by: Lance Richardson Signed-off-by: Russell Bryant From noreply at github.com Fri Aug 4 21:53:38 2017 From: noreply at github.com (GitHub) Date: Fri, 04 Aug 2017 14:53:38 -0700 Subject: [ovs-git] [openvswitch/ovs] 1d4b41: debian.rst: Clarify that "dpkg" needs manual help ... Message-ID: <5984ece214de0_78893fc001de3c34148081@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 1d4b414790ce0cc580085ee7e57f17c1c147e106 https://github.com/openvswitch/ovs/commit/1d4b414790ce0cc580085ee7e57f17c1c147e106 Author: Ben Pfaff Date: 2017-08-04 (Fri, 04 Aug 2017) Changed paths: M AUTHORS.rst M Documentation/intro/install/debian.rst Log Message: ----------- debian.rst: Clarify that "dpkg" needs manual help with dependencies. Reported-by: Mircea Ulinic Signed-off-by: Ben Pfaff Acked-by: Andy Zhou From noreply at github.com Fri Aug 4 21:54:11 2017 From: noreply at github.com (GitHub) Date: Fri, 04 Aug 2017 14:54:11 -0700 Subject: [ovs-git] [openvswitch/ovs] 970a7e: ovsdb-server: Document clarification for some bad ... Message-ID: <5984ed0387436_67643fcfda9f3c3073461@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 970a7e91ed7a027b551496cc1937452491e011ef https://github.com/openvswitch/ovs/commit/970a7e91ed7a027b551496cc1937452491e011ef Author: Ben Pfaff Date: 2017-08-04 (Fri, 04 Aug 2017) Changed paths: M AUTHORS.rst M ovsdb/ovsdb-server.1.in Log Message: ----------- ovsdb-server: Document clarification for some bad wording in RFC 7047. Reported-by: Harish Kanakaraju Signed-off-by: Ben Pfaff Acked-by: Andy Zhou From noreply at github.com Fri Aug 4 21:53:38 2017 From: noreply at github.com (GitHub) Date: Fri, 04 Aug 2017 14:53:38 -0700 Subject: [ovs-git] [openvswitch/ovs] 1d4b41: debian.rst: Clarify that "dpkg" needs manual help ... Message-ID: <5984ece214de0_78893fc001de3c34148081@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 1d4b414790ce0cc580085ee7e57f17c1c147e106 https://github.com/openvswitch/ovs/commit/1d4b414790ce0cc580085ee7e57f17c1c147e106 Author: Ben Pfaff Date: 2017-08-04 (Fri, 04 Aug 2017) Changed paths: M AUTHORS.rst M Documentation/intro/install/debian.rst Log Message: ----------- debian.rst: Clarify that "dpkg" needs manual help with dependencies. Reported-by: Mircea Ulinic Signed-off-by: Ben Pfaff Acked-by: Andy Zhou From noreply at github.com Fri Aug 4 21:58:12 2017 From: noreply at github.com (GitHub) Date: Fri, 04 Aug 2017 14:58:12 -0700 Subject: [ovs-git] [openvswitch/ovs] 17b6e3: Prepare for 2.8.0. Message-ID: <5984edf4d589a_62d03fb20aeedc24124267@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 17b6e3ce82ca27fc5c795817fe42ddcb9241acd5 https://github.com/openvswitch/ovs/commit/17b6e3ce82ca27fc5c795817fe42ddcb9241acd5 Author: Ben Pfaff Date: 2017-08-04 (Fri, 04 Aug 2017) Changed paths: M NEWS M configure.ac M debian/changelog Log Message: ----------- Prepare for 2.8.0. Signed-off-by: Ben Pfaff From noreply at github.com Fri Aug 4 22:05:08 2017 From: noreply at github.com (GitHub) Date: Fri, 04 Aug 2017 15:05:08 -0700 Subject: [ovs-git] [openvswitch/ovs] 17b6e3: Prepare for 2.8.0. Message-ID: <5984ef94a9b17_8efd3f9638533c301045b4@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 17b6e3ce82ca27fc5c795817fe42ddcb9241acd5 https://github.com/openvswitch/ovs/commit/17b6e3ce82ca27fc5c795817fe42ddcb9241acd5 Author: Ben Pfaff Date: 2017-08-04 (Fri, 04 Aug 2017) Changed paths: M NEWS M configure.ac M debian/changelog Log Message: ----------- Prepare for 2.8.0. Signed-off-by: Ben Pfaff Commit: e656b165460fb550c7b9ab0677b3d1f28d786908 https://github.com/openvswitch/ovs/commit/e656b165460fb550c7b9ab0677b3d1f28d786908 Author: Ben Pfaff Date: 2017-08-04 (Fri, 04 Aug 2017) Changed paths: M NEWS M configure.ac M debian/changelog Log Message: ----------- Prepare for post-2.8.0 (2.8.90). Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/970a7e91ed7a...e656b165460f From noreply at github.com Fri Aug 4 22:05:08 2017 From: noreply at github.com (GitHub) Date: Fri, 04 Aug 2017 15:05:08 -0700 Subject: [ovs-git] [openvswitch/ovs] 17b6e3: Prepare for 2.8.0. Message-ID: <5984ef94a9b17_8efd3f9638533c301045b4@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 17b6e3ce82ca27fc5c795817fe42ddcb9241acd5 https://github.com/openvswitch/ovs/commit/17b6e3ce82ca27fc5c795817fe42ddcb9241acd5 Author: Ben Pfaff Date: 2017-08-04 (Fri, 04 Aug 2017) Changed paths: M NEWS M configure.ac M debian/changelog Log Message: ----------- Prepare for 2.8.0. Signed-off-by: Ben Pfaff Commit: e656b165460fb550c7b9ab0677b3d1f28d786908 https://github.com/openvswitch/ovs/commit/e656b165460fb550c7b9ab0677b3d1f28d786908 Author: Ben Pfaff Date: 2017-08-04 (Fri, 04 Aug 2017) Changed paths: M NEWS M configure.ac M debian/changelog Log Message: ----------- Prepare for post-2.8.0 (2.8.90). Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/970a7e91ed7a...e656b165460f From noreply at github.com Mon Aug 7 13:53:43 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 06:53:43 -0700 Subject: [ovs-git] [openvswitch/ovs] a238db: netdev-tc-offloads: Fix parsing SCTP in dump flows Message-ID: <598870e77778_30c3f86544c9c341113a2@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: a238dbb568a0e3755ee16fb045def88f50491a2d https://github.com/openvswitch/ovs/commit/a238dbb568a0e3755ee16fb045def88f50491a2d Author: Roi Dayan Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M lib/netdev-tc-offloads.c Log Message: ----------- netdev-tc-offloads: Fix parsing SCTP in dump flows After splitting the unions of tcp/udp the sctp was forgotten when parsing flower back to match. Fixes: 2b1d9fa90909 ("tc: Split IPs and transport layer ports unions in flower struct") Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey Signed-off-by: Ben Pfaff Acked-by: Simon Horman From noreply at github.com Mon Aug 7 13:57:29 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 06:57:29 -0700 Subject: [ovs-git] [openvswitch/ovs] 9f8a86: netdev-tc-offloads: Fix parsing SCTP in dump flows Message-ID: <598871c9b985b_9a03fc57f0ffc388429a@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 9f8a86542387b02e5c067a7fd67aaae254fc52c3 https://github.com/openvswitch/ovs/commit/9f8a86542387b02e5c067a7fd67aaae254fc52c3 Author: Roi Dayan Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M lib/netdev-tc-offloads.c Log Message: ----------- netdev-tc-offloads: Fix parsing SCTP in dump flows After splitting the unions of tcp/udp the sctp was forgotten when parsing flower back to match. Fixes: 2b1d9fa90909 ("tc: Split IPs and transport layer ports unions in flower struct") Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey Signed-off-by: Ben Pfaff Acked-by: Simon Horman From noreply at github.com Mon Aug 7 14:00:14 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 07:00:14 -0700 Subject: [ovs-git] [openvswitch/ovs] 327d98: netdev-vport: Always implement get_ifindex for net... Message-ID: <5988726e7146c_7f9e3fbc2da1dc30114921@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 327d98eb197bf04da90e23c03d88093a6eeeb6f3 https://github.com/openvswitch/ovs/commit/327d98eb197bf04da90e23c03d88093a6eeeb6f3 Author: Paul Blakey Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M lib/netdev-vport.c Log Message: ----------- netdev-vport: Always implement get_ifindex for netdev-vport Always implement get_ifindex without checking if offload is enabled or not as this should not be related. From ovs-dpctl we cannot tell if offload is enabled or not as other_config is not being read. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Signed-off-by: Ben Pfaff From noreply at github.com Mon Aug 7 14:00:24 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 07:00:24 -0700 Subject: [ovs-git] [openvswitch/ovs] 7cd341: netdev-vport: Always implement get_ifindex for net... Message-ID: <598872781e32c_185a53fd00c5cbc348247c@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 7cd341e92208d07e868f00c54e9e71b5281eaeb1 https://github.com/openvswitch/ovs/commit/7cd341e92208d07e868f00c54e9e71b5281eaeb1 Author: Paul Blakey Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M lib/netdev-vport.c Log Message: ----------- netdev-vport: Always implement get_ifindex for netdev-vport Always implement get_ifindex without checking if offload is enabled or not as this should not be related. From ovs-dpctl we cannot tell if offload is enabled or not as other_config is not being read. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Signed-off-by: Ben Pfaff From noreply at github.com Mon Aug 7 16:12:09 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 09:12:09 -0700 Subject: [ovs-git] [openvswitch/ovs] b0d03a: ovs-bugtool: Collect OVS logs with "--ovs" option. Message-ID: <5988915987e54_1d093fbeb9e05c3880282@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: b0d03a150e1c0c18587bbb8ecdd4f8e269f5d89b https://github.com/openvswitch/ovs/commit/b0d03a150e1c0c18587bbb8ecdd4f8e269f5d89b Author: Gurucharan Shetty Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M utilities/bugtool/ovs-bugtool.in Log Message: ----------- ovs-bugtool: Collect OVS logs with "--ovs" option. ovs-bugtool collects a lot of data. This can be time consuming and can end up collecting a lot of redundant data. A option "--ovs" was added a while ago to only collect OVS relevent data. We missed adding the OVS logs to this filter. Signed-off-by: Gurucharan Shetty Reviewed-by: Greg Rose Tested-by: Greg Rose Acked-by: Ben Pfaff From noreply at github.com Mon Aug 7 16:13:19 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 09:13:19 -0700 Subject: [ovs-git] [openvswitch/ovs] 90cef1: ovs-bugtool: Run the 'dmesg' command without condi... Message-ID: <5988919f876ce_2fc33fe9949f1c2c1425c@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 90cef12cf0376be33029d8da0c66f8b0be4829fd https://github.com/openvswitch/ovs/commit/90cef12cf0376be33029d8da0c66f8b0be4829fd Author: Gurucharan Shetty Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M utilities/bugtool/ovs-bugtool.in Log Message: ----------- ovs-bugtool: Run the 'dmesg' command without condition. Currently we look for files with the name of "dmesg" in "/var/log". If it exists, we don't run the command "dmesg". This is unreliable as the file does not always contain the latest dmesg information. Since OVS kernel module emits information to dmesg, we need this information to debug bugs. So always run the "dmesg" command and collect its output. Signed-off-by: Gurucharan Shetty Reviewed-by: Greg Rose Tested-by: Greg Rose Acked-by: Ben Pfaff From noreply at github.com Mon Aug 7 17:05:12 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 10:05:12 -0700 Subject: [ovs-git] [openvswitch/ovs] a59ea7: Revert "netdev-vport: Always implement get_ifindex... Message-ID: <59889dc825ac8_130b3f95006edc3095619@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: a59ea79baa4cd05ca88f5952087ffda0470c7f5f https://github.com/openvswitch/ovs/commit/a59ea79baa4cd05ca88f5952087ffda0470c7f5f Author: Ben Pfaff Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M lib/netdev-vport.c Log Message: ----------- Revert "netdev-vport: Always implement get_ifindex for netdev-vport" This reverts commit 327d98eb197bf04da90e23c03d88093a6eeeb6f3, which several unit tests to fail due to new warning messages in the logs. Signed-off-by: Ben Pfaff From noreply at github.com Mon Aug 7 17:05:25 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 10:05:25 -0700 Subject: [ovs-git] [openvswitch/ovs] 258541: Revert "netdev-vport: Always implement get_ifindex... Message-ID: <59889dd518b28_6c323fe16971dc4086129@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 2585418e0fc537727786027cbea1ae6d85669a36 https://github.com/openvswitch/ovs/commit/2585418e0fc537727786027cbea1ae6d85669a36 Author: Ben Pfaff Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M lib/netdev-vport.c Log Message: ----------- Revert "netdev-vport: Always implement get_ifindex for netdev-vport" This reverts commit 327d98eb197bf04da90e23c03d88093a6eeeb6f3, which several unit tests to fail due to new warning messages in the logs. Signed-off-by: Ben Pfaff From noreply at github.com Mon Aug 7 18:07:06 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 11:07:06 -0700 Subject: [ovs-git] [openvswitch/ovs] e0dfd6: debian: Add note on interfaces in "auto" section. Message-ID: <5988ac4a7aa08_60bf3fc955b9bc44874ab@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: e0dfd67b456c8ea36cc2e2f23039a300dbbedfed https://github.com/openvswitch/ovs/commit/e0dfd67b456c8ea36cc2e2f23039a300dbbedfed Author: Gurucharan Shetty Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M debian/openvswitch-switch.README.Debian Log Message: ----------- debian: Add note on interfaces in "auto" section. We had a note about the issues with adding OVS interfaces in the "auto" section. This commit clarifies what an "auto" section is and also adds another note about how adding OVS bridges in the "auto" section can cause race conditions with systemd. Signed-off-by: Gurucharan Shetty Acked-by: Ben Pfaff From noreply at github.com Mon Aug 7 18:17:56 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 11:17:56 -0700 Subject: [ovs-git] [openvswitch/ovs] ab6f68: string: Implement strcasestr for Windows. Message-ID: <5988aed46d84b_5a163ff2cf3a1c34665d1@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: ab6f684e36c72e2551f47bb7dcce6835e7881542 https://github.com/openvswitch/ovs/commit/ab6f684e36c72e2551f47bb7dcce6835e7881542 Author: Darrell Ball Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M lib/string.c M lib/string.h.in Log Message: ----------- string: Implement strcasestr for Windows. strcasestr is not defined for Windows, so implement a version that could be used on Windows. This is needed for an upcoming patch. Signed-off-by: Darrell Ball Co-authored-by: Ben Pfaff Signed-off-by: Ben Pfaff Commit: 5ed7a0b402879e604d6986e8ca4bf08bb5307773 https://github.com/openvswitch/ovs/commit/5ed7a0b402879e604d6986e8ca4bf08bb5307773 Author: Darrell Ball Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M lib/conntrack.c Log Message: ----------- Userspace Datapath: Introduce conn_key_cmp(). A new function conn_key_cmp() is introduced and used to replace memcmp of conn_keys. Given that OVS runs on with many compilers and on many architectures, it seems prudent to avoid memcmp in case existing and future holes in conn_key are not handled by a given compiler for a given architecture. Signed-off-by: Darrell Ball Suggested-by: Ben Pfaff Signed-off-by: Ben Pfaff Commit: bd5e81a0e596dd012d11824cce69b7c80ae107c5 https://github.com/openvswitch/ovs/commit/bd5e81a0e596dd012d11824cce69b7c80ae107c5 Author: Darrell Ball Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M lib/conntrack-private.h M lib/conntrack.c M lib/conntrack.h Log Message: ----------- Userspace Datapath: Add ALG infra and FTP. ALG infra and FTP (both V4 and V6) support is added to the userspace datapath. Also, NAT support is included. Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff Commit: 7be77cb0d3378a71a18b0d1d0f3513da16f071c6 https://github.com/openvswitch/ovs/commit/7be77cb0d3378a71a18b0d1d0f3513da16f071c6 Author: Darrell Ball Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M include/sparse/netinet/in.h M lib/conntrack.c Log Message: ----------- Userspace Datapath: Add TFTP support. Both ipv4 and ipv6 are supported. Also, NAT support is included. Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff Commit: a80316339ed24d48cba7794af746dec5594ac4ef https://github.com/openvswitch/ovs/commit/a80316339ed24d48cba7794af746dec5594ac4ef Author: Darrell Ball Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M tests/system-userspace-macros.at Log Message: ----------- System tests: Enable ALGs for userspace. Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff Commit: 200a9af97d1cd089690f8fc7fac2e331ff55991e https://github.com/openvswitch/ovs/commit/200a9af97d1cd089690f8fc7fac2e331ff55991e Author: Darrell Ball Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M tests/system-traffic.at Log Message: ----------- System tests: Add 4 new ftp and tftp tests. In order to have full coverage of ALGs for the userspace datapath, it is necessary to add 4 new tests. Three of these will cover passive ftp, including basic V6 passive ftp, V4 passive ftp with NAT and sequence skew and V6 passive ftp with NAT. The last test will cover tftp with NAT. Before these additions, there was only one part of one test covering passive ftp without NAT and one basic tftp test without NAT. Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff Commit: 05f282c2e16126577de7704b16f9dd591b927904 https://github.com/openvswitch/ovs/commit/05f282c2e16126577de7704b16f9dd591b927904 Author: Darrell Ball Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M NEWS Log Message: ----------- NEWS: Announce userspace datapath ALG support. Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/e0dfd67b456c...05f282c2e161 From noreply at github.com Mon Aug 7 18:18:23 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 11:18:23 -0700 Subject: [ovs-git] [openvswitch/ovs] 1ba9f0: string: Implement strcasestr for Windows. Message-ID: <5988aeef175c7_317b3f97b1d6bc34625b1@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 1ba9f0e7bb7c25346ac3e64cdb296a33b4e6e809 https://github.com/openvswitch/ovs/commit/1ba9f0e7bb7c25346ac3e64cdb296a33b4e6e809 Author: Darrell Ball Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M lib/string.c M lib/string.h.in Log Message: ----------- string: Implement strcasestr for Windows. strcasestr is not defined for Windows, so implement a version that could be used on Windows. This is needed for an upcoming patch. Signed-off-by: Darrell Ball Co-authored-by: Ben Pfaff Signed-off-by: Ben Pfaff Commit: ed4495041733b139ad591908c004ce232d51692b https://github.com/openvswitch/ovs/commit/ed4495041733b139ad591908c004ce232d51692b Author: Darrell Ball Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M lib/conntrack.c Log Message: ----------- Userspace Datapath: Introduce conn_key_cmp(). A new function conn_key_cmp() is introduced and used to replace memcmp of conn_keys. Given that OVS runs on with many compilers and on many architectures, it seems prudent to avoid memcmp in case existing and future holes in conn_key are not handled by a given compiler for a given architecture. Signed-off-by: Darrell Ball Suggested-by: Ben Pfaff Signed-off-by: Ben Pfaff Commit: cd12dfc82f06045d346e8ae6f85fad5091b719d5 https://github.com/openvswitch/ovs/commit/cd12dfc82f06045d346e8ae6f85fad5091b719d5 Author: Darrell Ball Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M lib/conntrack-private.h M lib/conntrack.c M lib/conntrack.h Log Message: ----------- Userspace Datapath: Add ALG infra and FTP. ALG infra and FTP (both V4 and V6) support is added to the userspace datapath. Also, NAT support is included. Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff Commit: 8628c220f71824263d584e25fe7675b3fb27a797 https://github.com/openvswitch/ovs/commit/8628c220f71824263d584e25fe7675b3fb27a797 Author: Darrell Ball Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M include/sparse/netinet/in.h M lib/conntrack.c Log Message: ----------- Userspace Datapath: Add TFTP support. Both ipv4 and ipv6 are supported. Also, NAT support is included. Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff Commit: a08f97cc5b0d444037ad9cc3362ba3153ba3e9eb https://github.com/openvswitch/ovs/commit/a08f97cc5b0d444037ad9cc3362ba3153ba3e9eb Author: Darrell Ball Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M tests/system-userspace-macros.at Log Message: ----------- System tests: Enable ALGs for userspace. Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff Commit: 4448f0d0dac5acf03d3d32d8f18a0b575362e7f9 https://github.com/openvswitch/ovs/commit/4448f0d0dac5acf03d3d32d8f18a0b575362e7f9 Author: Darrell Ball Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M tests/system-traffic.at Log Message: ----------- System tests: Add 4 new ftp and tftp tests. In order to have full coverage of ALGs for the userspace datapath, it is necessary to add 4 new tests. Three of these will cover passive ftp, including basic V6 passive ftp, V4 passive ftp with NAT and sequence skew and V6 passive ftp with NAT. The last test will cover tftp with NAT. Before these additions, there was only one part of one test covering passive ftp without NAT and one basic tftp test without NAT. Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff Commit: f0291320d0ebcb90b6d23648278f4a83592a14b7 https://github.com/openvswitch/ovs/commit/f0291320d0ebcb90b6d23648278f4a83592a14b7 Author: Darrell Ball Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M NEWS Log Message: ----------- NEWS: Announce userspace datapath ALG support. Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/2585418e0fc5...f0291320d0eb From noreply at github.com Mon Aug 7 18:32:12 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 11:32:12 -0700 Subject: [ovs-git] [openvswitch/ovs] 3d2fbd: userspace: Add support for NSH MD1 match fields Message-ID: <5988b22cd51e_2b623fb943b9bc34110981@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 3d2fbd70bda514f7327970b859663f34f994290c https://github.com/openvswitch/ovs/commit/3d2fbd70bda514f7327970b859663f34f994290c Author: Jan Scheurich Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M build-aux/extract-odp-netlink-h M build-aux/extract-ofp-fields M datapath/linux/compat/include/linux/openvswitch.h M include/openvswitch/automake.mk M include/openvswitch/flow.h M include/openvswitch/match.h M include/openvswitch/meta-flow.h A include/openvswitch/nsh.h M include/openvswitch/packets.h M lib/flow.c M lib/flow.h M lib/match.c M lib/meta-flow.c M lib/meta-flow.xml M lib/nx-match.c M lib/odp-execute.c M lib/odp-util.c M lib/odp-util.h M lib/ofp-util.c M lib/packets.h M ofproto/ofproto-dpif-rid.h M ofproto/ofproto-dpif-sflow.c M ofproto/ofproto-dpif-xlate.c M tests/ofproto.at Log Message: ----------- userspace: Add support for NSH MD1 match fields This patch adds support for NSH packet header fields to the OVS control plane and the userspace datapath. Initially we support the fields of the NSH base header as defined in https://www.ietf.org/id/draft-ietf-sfc-nsh-13.txt and the fixed context headers specified for metadata format MD1. The variable length MD2 format is parsed but the TLV context headers are not yet available for matching. The NSH fields are modelled as experimenter fields with the dedicated experimenter class 0x005ad650 proposed for NSH in ONF. The following fields are defined: NXOXM code ofctl name Size Comment ===================================================================== NXOXM_NSH_FLAGS nsh_flags 8 Bits 2-9 of 1st NSH word (0x005ad650,1) NXOXM_NSH_MDTYPE nsh_mdtype 8 Bits 16-23 (0x005ad650,2) NXOXM_NSH_NEXTPROTO nsh_np 8 Bits 24-31 (0x005ad650,3) NXOXM_NSH_SPI nsh_spi 24 Bits 0-23 of 2nd NSH word (0x005ad650,4) NXOXM_NSH_SI nsh_si 8 Bits 24-31 (0x005ad650,5) NXOXM_NSH_C1 nsh_c1 32 Maskable, nsh_mdtype==1 (0x005ad650,6) NXOXM_NSH_C2 nsh_c2 32 Maskable, nsh_mdtype==1 (0x005ad650,7) NXOXM_NSH_C3 nsh_c3 32 Maskable, nsh_mdtype==1 (0x005ad650,8) NXOXM_NSH_C4 nsh_c4 32 Maskable, nsh_mdtype==1 (0x005ad650,9) Co-authored-by: Johnson Li Signed-off-by: Yi Yang Signed-off-by: Jan Scheurich Signed-off-by: Ben Pfaff Commit: e398127135006a26b5c067a5be6dc0c3b9bd4a98 https://github.com/openvswitch/ovs/commit/e398127135006a26b5c067a5be6dc0c3b9bd4a98 Author: Jan Scheurich Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M lib/match.c M tests/automake.mk M tests/classifier.at A tests/nsh.at M tests/ofproto-dpif.at M tests/testsuite.at M tests/tunnel.at Log Message: ----------- Adding nsh.at for NSH unit tests First basic NSH test case implemented and working. Unconditionally show matched packet_type in megaflows, even when matching on eth. Signed-off-by: Jan Scheurich Signed-off-by: Ben Pfaff Commit: 478b14731cf32b20517fc02db9e13e9e36764469 https://github.com/openvswitch/ovs/commit/478b14731cf32b20517fc02db9e13e9e36764469 Author: Jan Scheurich Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M lib/netdev-native-tnl.c Log Message: ----------- userspace: add NSH support to vxlan-gpe tunnels Signed-off-by: Yi Yang Signed-off-by: Jan Scheurich Signed-off-by: Ben Pfaff Commit: 1fc11c5948cf83b47588ec1eaa4eef437c2df373 https://github.com/openvswitch/ovs/commit/1fc11c5948cf83b47588ec1eaa4eef437c2df373 Author: Jan Scheurich Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M datapath/linux/compat/include/linux/openvswitch.h M include/openvswitch/ofp-ed-props.h M lib/dpif-netdev.c M lib/dpif.c M lib/odp-execute.c M lib/odp-util.c M lib/odp-util.h M lib/ofp-actions.c M lib/ofp-ed-props.c M lib/packets.c M lib/packets.h M ofproto/ofproto-dpif-ipfix.c M ofproto/ofproto-dpif-sflow.c M ofproto/ofproto-dpif-xlate.c Log Message: ----------- Generic encap and decap support for NSH This commit adds translation and netdev datapath support for generic encap and decap actions for the NSH MD1 header. The generic encap and decap actions are mapped to specific encap_nsh and decap_nsh actions in the datapath. The translation follows that general scheme that decap() of an NSH packet triggers recirculation after decapsulation, while encap(nsh) just modifies struct flow and sets the ctx->pending_encap flag to generate the encap_nsh action at the next commit to be able to include subsequent set_field actions for NSH headers. Support for the flexible MD2 format using TLV properties is foreseen in encap(nsh), but not yet fully implemented. The CLI syntax for encap of NSH is encap(nsh(md_type=1)) encap(nsh(md_type=2[,tlv(,,),...])) Signed-off-by: Jan Scheurich Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff Commit: cc6902feda897110414c87166a1ed6454a0f28a8 https://github.com/openvswitch/ovs/commit/cc6902feda897110414c87166a1ed6454a0f28a8 Author: Jan Scheurich Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M tests/nsh.at Log Message: ----------- NSH unit test cases using encap and decap actions With the support of generic encap and decap actions for Ethernet and NSH it is now possible to build test cases that mimic realistic OVS configurations and OF pipelines for Service Function Chaining. Packets are being encapsulated in NSH, forwarded based on NSH headers, sent over Ethernet links and VXLAN-GPE tunnels, and decapsulated at the end of a service chain. Signed-off-by: Jan Scheurich Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/05f282c2e161...cc6902feda89 From noreply at github.com Mon Aug 7 18:32:28 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 11:32:28 -0700 Subject: [ovs-git] [openvswitch/ovs] aaa43e: userspace: Add support for NSH MD1 match fields Message-ID: <5988b23ca9b3f_185a43f8d7c6abc301348d4@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: aaa43ed5af1ad9086716a984493a4f90629d6bed https://github.com/openvswitch/ovs/commit/aaa43ed5af1ad9086716a984493a4f90629d6bed Author: Jan Scheurich Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M build-aux/extract-odp-netlink-h M build-aux/extract-ofp-fields M datapath/linux/compat/include/linux/openvswitch.h M include/openvswitch/automake.mk M include/openvswitch/flow.h M include/openvswitch/match.h M include/openvswitch/meta-flow.h A include/openvswitch/nsh.h M include/openvswitch/packets.h M lib/flow.c M lib/flow.h M lib/match.c M lib/meta-flow.c M lib/meta-flow.xml M lib/nx-match.c M lib/odp-execute.c M lib/odp-util.c M lib/odp-util.h M lib/ofp-util.c M lib/packets.h M ofproto/ofproto-dpif-rid.h M ofproto/ofproto-dpif-sflow.c M ofproto/ofproto-dpif-xlate.c M tests/ofproto.at Log Message: ----------- userspace: Add support for NSH MD1 match fields This patch adds support for NSH packet header fields to the OVS control plane and the userspace datapath. Initially we support the fields of the NSH base header as defined in https://www.ietf.org/id/draft-ietf-sfc-nsh-13.txt and the fixed context headers specified for metadata format MD1. The variable length MD2 format is parsed but the TLV context headers are not yet available for matching. The NSH fields are modelled as experimenter fields with the dedicated experimenter class 0x005ad650 proposed for NSH in ONF. The following fields are defined: NXOXM code ofctl name Size Comment ===================================================================== NXOXM_NSH_FLAGS nsh_flags 8 Bits 2-9 of 1st NSH word (0x005ad650,1) NXOXM_NSH_MDTYPE nsh_mdtype 8 Bits 16-23 (0x005ad650,2) NXOXM_NSH_NEXTPROTO nsh_np 8 Bits 24-31 (0x005ad650,3) NXOXM_NSH_SPI nsh_spi 24 Bits 0-23 of 2nd NSH word (0x005ad650,4) NXOXM_NSH_SI nsh_si 8 Bits 24-31 (0x005ad650,5) NXOXM_NSH_C1 nsh_c1 32 Maskable, nsh_mdtype==1 (0x005ad650,6) NXOXM_NSH_C2 nsh_c2 32 Maskable, nsh_mdtype==1 (0x005ad650,7) NXOXM_NSH_C3 nsh_c3 32 Maskable, nsh_mdtype==1 (0x005ad650,8) NXOXM_NSH_C4 nsh_c4 32 Maskable, nsh_mdtype==1 (0x005ad650,9) Co-authored-by: Johnson Li Signed-off-by: Yi Yang Signed-off-by: Jan Scheurich Signed-off-by: Ben Pfaff Commit: 150d65be2b7e61972c59ff6a709c374459d0fd68 https://github.com/openvswitch/ovs/commit/150d65be2b7e61972c59ff6a709c374459d0fd68 Author: Jan Scheurich Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M lib/match.c M tests/automake.mk M tests/classifier.at A tests/nsh.at M tests/ofproto-dpif.at M tests/testsuite.at M tests/tunnel.at Log Message: ----------- Adding nsh.at for NSH unit tests First basic NSH test case implemented and working. Unconditionally show matched packet_type in megaflows, even when matching on eth. Signed-off-by: Jan Scheurich Signed-off-by: Ben Pfaff Commit: dd5f473678a284d5080ab18fc7f8aa32cac87907 https://github.com/openvswitch/ovs/commit/dd5f473678a284d5080ab18fc7f8aa32cac87907 Author: Jan Scheurich Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M lib/netdev-native-tnl.c Log Message: ----------- userspace: add NSH support to vxlan-gpe tunnels Signed-off-by: Yi Yang Signed-off-by: Jan Scheurich Signed-off-by: Ben Pfaff Commit: 077b3628327d47f613e7b0bbb831646349d1760a https://github.com/openvswitch/ovs/commit/077b3628327d47f613e7b0bbb831646349d1760a Author: Jan Scheurich Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M datapath/linux/compat/include/linux/openvswitch.h M include/openvswitch/ofp-ed-props.h M lib/dpif-netdev.c M lib/dpif.c M lib/odp-execute.c M lib/odp-util.c M lib/odp-util.h M lib/ofp-actions.c M lib/ofp-ed-props.c M lib/packets.c M lib/packets.h M ofproto/ofproto-dpif-ipfix.c M ofproto/ofproto-dpif-sflow.c M ofproto/ofproto-dpif-xlate.c Log Message: ----------- Generic encap and decap support for NSH This commit adds translation and netdev datapath support for generic encap and decap actions for the NSH MD1 header. The generic encap and decap actions are mapped to specific encap_nsh and decap_nsh actions in the datapath. The translation follows that general scheme that decap() of an NSH packet triggers recirculation after decapsulation, while encap(nsh) just modifies struct flow and sets the ctx->pending_encap flag to generate the encap_nsh action at the next commit to be able to include subsequent set_field actions for NSH headers. Support for the flexible MD2 format using TLV properties is foreseen in encap(nsh), but not yet fully implemented. The CLI syntax for encap of NSH is encap(nsh(md_type=1)) encap(nsh(md_type=2[,tlv(,,),...])) Signed-off-by: Jan Scheurich Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff Commit: 66f26c3590ec525213e52d382e6d5fcf905ff44d https://github.com/openvswitch/ovs/commit/66f26c3590ec525213e52d382e6d5fcf905ff44d Author: Jan Scheurich Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M tests/nsh.at Log Message: ----------- NSH unit test cases using encap and decap actions With the support of generic encap and decap actions for Ethernet and NSH it is now possible to build test cases that mimic realistic OVS configurations and OF pipelines for Service Function Chaining. Packets are being encapsulated in NSH, forwarded based on NSH headers, sent over Ethernet links and VXLAN-GPE tunnels, and decapsulated at the end of a service chain. Signed-off-by: Jan Scheurich Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/f0291320d0eb...66f26c3590ec From noreply at github.com Mon Aug 7 18:41:07 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 11:41:07 -0700 Subject: [ovs-git] [openvswitch/ovs] cf62c3: AUTHORS: Add Wang Zhike. Message-ID: <5988b4432b77d_317b3f97b1d6bc346295f@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: cf62c335821aab25cc1458569c582a3a0cf6a4ce https://github.com/openvswitch/ovs/commit/cf62c335821aab25cc1458569c582a3a0cf6a4ce Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M AUTHORS.rst Log Message: ----------- AUTHORS: Add Wang Zhike. Signed-off-by: Joe Stringer Acked-by: Ben Pfaff Commit: 55f854b9d51edcbccf4ae1655855dddd1d9ec1fe https://github.com/openvswitch/ovs/commit/55f854b9d51edcbccf4ae1655855dddd1d9ec1fe Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M ofproto/ofproto-dpif-upcall.c Log Message: ----------- ofproto-dpif-upcall: Fix action attr iteration. This calls is operating on messages generated by the datapath. If a datapath implementation sends improperly formatted netlink attributes, then it's possible for a revalidator thread to end up trapped in an infinite loop iterating across the actions attributes. Rather than using the UNSAFE variation of this iterator, use the regular version. Fixes: e672ff9b4d22 ("ofproto-dpif: Restore metadata and registers on recirculation.") Signed-off-by: Joe Stringer Acked-by: Ben Pfaff Commit: f2d3fef3d90253dda3e03822df2e921ec853192d https://github.com/openvswitch/ovs/commit/f2d3fef3d90253dda3e03822df2e921ec853192d Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M ofproto/ofproto-dpif-upcall.c Log Message: ----------- ofproto-dpif-upcall: Fix key attr iteration. This call is operating on messages generated by the datapath. If a datapath implementation sends improperly formatted netlink attributes, then it's possible for a revalidator thread to end up trapped in an infinite loop iterating across these attributes. Rather than using the UNSAFE variation of this iterator, use the regular version. Fixes: 994fcc5a15d3 ("upcall: Check for recirc_id in ukey_create_from_dpif_flow()") Signed-off-by: Joe Stringer Reviewed-by: Greg Rose Acked-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/cc6902feda89...f2d3fef3d902 From noreply at github.com Mon Aug 7 18:42:01 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 11:42:01 -0700 Subject: [ovs-git] [openvswitch/ovs] f848fa: AUTHORS: Add Wang Zhike. Message-ID: <5988b4799c46a_43543fc5e6d4bc3c14566d@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: f848faa4361d290817b6102f6a43aa19f2cd9ff5 https://github.com/openvswitch/ovs/commit/f848faa4361d290817b6102f6a43aa19f2cd9ff5 Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M AUTHORS.rst Log Message: ----------- AUTHORS: Add Wang Zhike. Signed-off-by: Joe Stringer Acked-by: Ben Pfaff Commit: 5d30c7a20959732cf8d7deeb3c63d1805f9334e4 https://github.com/openvswitch/ovs/commit/5d30c7a20959732cf8d7deeb3c63d1805f9334e4 Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M ofproto/ofproto-dpif-upcall.c Log Message: ----------- ofproto-dpif-upcall: Fix action attr iteration. This calls is operating on messages generated by the datapath. If a datapath implementation sends improperly formatted netlink attributes, then it's possible for a revalidator thread to end up trapped in an infinite loop iterating across the actions attributes. Rather than using the UNSAFE variation of this iterator, use the regular version. >From master commit 55f854b9d51edcbccf4ae1655855dddd1d9ec1fe. Fixes: e672ff9b4d22 ("ofproto-dpif: Restore metadata and registers on recirculation.") Signed-off-by: Joe Stringer Acked-by: Ben Pfaff Commit: c4571d8b4bc81642fdda80bb072f85d2686fd978 https://github.com/openvswitch/ovs/commit/c4571d8b4bc81642fdda80bb072f85d2686fd978 Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M ofproto/ofproto-dpif-upcall.c Log Message: ----------- ofproto-dpif-upcall: Fix key attr iteration. This call is operating on messages generated by the datapath. If a datapath implementation sends improperly formatted netlink attributes, then it's possible for a revalidator thread to end up trapped in an infinite loop iterating across these attributes. Rather than using the UNSAFE variation of this iterator, use the regular version. >From master commit f2d3fef3d90253dda3e03822df2e921ec853192d. Fixes: 994fcc5a15d3 ("upcall: Check for recirc_id in ukey_create_from_dpif_flow()") Signed-off-by: Joe Stringer Reviewed-by: Greg Rose Acked-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/66f26c3590ec...c4571d8b4bc8 From noreply at github.com Mon Aug 7 18:42:34 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 11:42:34 -0700 Subject: [ovs-git] [openvswitch/ovs] 8e4e55: ofproto-dpif-upcall: Fix action attr iteration. Message-ID: <5988b49a9cbb0_18a193fc0371c9c38175991@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: 8e4e55f17e07c45143338c543239c556c2214df1 https://github.com/openvswitch/ovs/commit/8e4e55f17e07c45143338c543239c556c2214df1 Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M ofproto/ofproto-dpif-upcall.c Log Message: ----------- ofproto-dpif-upcall: Fix action attr iteration. This calls is operating on messages generated by the datapath. If a datapath implementation sends improperly formatted netlink attributes, then it's possible for a revalidator thread to end up trapped in an infinite loop iterating across the actions attributes. Rather than using the UNSAFE variation of this iterator, use the regular version. >From master commit 55f854b9d51edcbccf4ae1655855dddd1d9ec1fe. Fixes: e672ff9b4d22 ("ofproto-dpif: Restore metadata and registers on recirculation.") Signed-off-by: Joe Stringer Acked-by: Ben Pfaff Commit: 634e1d0f3a5b9b40b665fca1bcf6e63a07bda2d2 https://github.com/openvswitch/ovs/commit/634e1d0f3a5b9b40b665fca1bcf6e63a07bda2d2 Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M ofproto/ofproto-dpif-upcall.c Log Message: ----------- ofproto-dpif-upcall: Fix key attr iteration. This call is operating on messages generated by the datapath. If a datapath implementation sends improperly formatted netlink attributes, then it's possible for a revalidator thread to end up trapped in an infinite loop iterating across these attributes. Rather than using the UNSAFE variation of this iterator, use the regular version. >From master commit f2d3fef3d90253dda3e03822df2e921ec853192d. Fixes: 994fcc5a15d3 ("upcall: Check for recirc_id in ukey_create_from_dpif_flow()") Signed-off-by: Joe Stringer Reviewed-by: Greg Rose Acked-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/bba844a66a6b...634e1d0f3a5b From noreply at github.com Mon Aug 7 18:42:49 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 11:42:49 -0700 Subject: [ovs-git] [openvswitch/ovs] 4c2e44: ofproto-dpif-upcall: Fix action attr iteration. Message-ID: <5988b4a94a59b_16463ff7927d7c281389e8@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.6 Home: https://github.com/openvswitch/ovs Commit: 4c2e44febd64397e834f031bf17531de12b68187 https://github.com/openvswitch/ovs/commit/4c2e44febd64397e834f031bf17531de12b68187 Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M ofproto/ofproto-dpif-upcall.c Log Message: ----------- ofproto-dpif-upcall: Fix action attr iteration. This calls is operating on messages generated by the datapath. If a datapath implementation sends improperly formatted netlink attributes, then it's possible for a revalidator thread to end up trapped in an infinite loop iterating across the actions attributes. Rather than using the UNSAFE variation of this iterator, use the regular version. >From master commit 55f854b9d51edcbccf4ae1655855dddd1d9ec1fe. Fixes: e672ff9b4d22 ("ofproto-dpif: Restore metadata and registers on recirculation.") Signed-off-by: Joe Stringer Acked-by: Ben Pfaff Commit: 8db18b115e89f7d71c937714def94e5b50a005e0 https://github.com/openvswitch/ovs/commit/8db18b115e89f7d71c937714def94e5b50a005e0 Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M ofproto/ofproto-dpif-upcall.c Log Message: ----------- ofproto-dpif-upcall: Fix key attr iteration. This call is operating on messages generated by the datapath. If a datapath implementation sends improperly formatted netlink attributes, then it's possible for a revalidator thread to end up trapped in an infinite loop iterating across these attributes. Rather than using the UNSAFE variation of this iterator, use the regular version. >From master commit f2d3fef3d90253dda3e03822df2e921ec853192d. Fixes: 994fcc5a15d3 ("upcall: Check for recirc_id in ukey_create_from_dpif_flow()") Signed-off-by: Joe Stringer Reviewed-by: Greg Rose Acked-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/7020975768f6...8db18b115e89 From noreply at github.com Mon Aug 7 18:42:24 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 11:42:24 -0700 Subject: [ovs-git] [openvswitch/ovs] 96195c: acinclude: Also support pkg-config for configuring... Message-ID: <5988b4907a627_39993fc4e9acbc3054414@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 96195c09cd2db4262f240a6a8ca7f7c9ef52b416 https://github.com/openvswitch/ovs/commit/96195c09cd2db4262f240a6a8ca7f7c9ef52b416 Author: Christian Ehrhardt Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M Documentation/intro/install/dpdk.rst M acinclude.m4 M configure.ac Log Message: ----------- acinclude: Also support pkg-config for configuring dpdk. If available use dpdk pkg-config info of libdpdk to set the right include paths. That for example, allows packagers to provide non default include paths in a common way (pkg-config). Signed-off-by: Christian Ehrhardt Suggested-by: Luca Boccassi Acked-by: Luca Boccassi Signed-off-by: Ben Pfaff From noreply at github.com Mon Aug 7 18:43:17 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 11:43:17 -0700 Subject: [ovs-git] [openvswitch/ovs] 023992: ofproto-dpif-upcall: Fix action attr iteration. Message-ID: <5988b4c57e70_4aac3fcab9e37c2c1036f1@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.5 Home: https://github.com/openvswitch/ovs Commit: 023992251a743af73a6b15460181531dad8119ff https://github.com/openvswitch/ovs/commit/023992251a743af73a6b15460181531dad8119ff Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M ofproto/ofproto-dpif-upcall.c Log Message: ----------- ofproto-dpif-upcall: Fix action attr iteration. This calls is operating on messages generated by the datapath. If a datapath implementation sends improperly formatted netlink attributes, then it's possible for a revalidator thread to end up trapped in an infinite loop iterating across the actions attributes. Rather than using the UNSAFE variation of this iterator, use the regular version. >From master commit 55f854b9d51edcbccf4ae1655855dddd1d9ec1fe. Fixes: e672ff9b4d22 ("ofproto-dpif: Restore metadata and registers on recirculation.") Signed-off-by: Joe Stringer Acked-by: Ben Pfaff Commit: 6f3f122bd73301a7396b2e29e4ed16a8955c1bab https://github.com/openvswitch/ovs/commit/6f3f122bd73301a7396b2e29e4ed16a8955c1bab Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M ofproto/ofproto-dpif-upcall.c Log Message: ----------- ofproto-dpif-upcall: Fix key attr iteration. This call is operating on messages generated by the datapath. If a datapath implementation sends improperly formatted netlink attributes, then it's possible for a revalidator thread to end up trapped in an infinite loop iterating across these attributes. Rather than using the UNSAFE variation of this iterator, use the regular version. >From master commit f2d3fef3d90253dda3e03822df2e921ec853192d. Fixes: 994fcc5a15d3 ("upcall: Check for recirc_id in ukey_create_from_dpif_flow()") Signed-off-by: Joe Stringer Reviewed-by: Greg Rose Acked-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/01122c2ac158...6f3f122bd733 From noreply at github.com Mon Aug 7 18:43:17 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 11:43:17 -0700 Subject: [ovs-git] [openvswitch/ovs] 023992: ofproto-dpif-upcall: Fix action attr iteration. Message-ID: <5988b4c57e70_4aac3fcab9e37c2c1036f1@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.5 Home: https://github.com/openvswitch/ovs Commit: 023992251a743af73a6b15460181531dad8119ff https://github.com/openvswitch/ovs/commit/023992251a743af73a6b15460181531dad8119ff Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M ofproto/ofproto-dpif-upcall.c Log Message: ----------- ofproto-dpif-upcall: Fix action attr iteration. This calls is operating on messages generated by the datapath. If a datapath implementation sends improperly formatted netlink attributes, then it's possible for a revalidator thread to end up trapped in an infinite loop iterating across the actions attributes. Rather than using the UNSAFE variation of this iterator, use the regular version. >From master commit 55f854b9d51edcbccf4ae1655855dddd1d9ec1fe. Fixes: e672ff9b4d22 ("ofproto-dpif: Restore metadata and registers on recirculation.") Signed-off-by: Joe Stringer Acked-by: Ben Pfaff Commit: 6f3f122bd73301a7396b2e29e4ed16a8955c1bab https://github.com/openvswitch/ovs/commit/6f3f122bd73301a7396b2e29e4ed16a8955c1bab Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M ofproto/ofproto-dpif-upcall.c Log Message: ----------- ofproto-dpif-upcall: Fix key attr iteration. This call is operating on messages generated by the datapath. If a datapath implementation sends improperly formatted netlink attributes, then it's possible for a revalidator thread to end up trapped in an infinite loop iterating across these attributes. Rather than using the UNSAFE variation of this iterator, use the regular version. >From master commit f2d3fef3d90253dda3e03822df2e921ec853192d. Fixes: 994fcc5a15d3 ("upcall: Check for recirc_id in ukey_create_from_dpif_flow()") Signed-off-by: Joe Stringer Reviewed-by: Greg Rose Acked-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/01122c2ac158...6f3f122bd733 From noreply at github.com Mon Aug 7 18:43:17 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 11:43:17 -0700 Subject: [ovs-git] [openvswitch/ovs] 023992: ofproto-dpif-upcall: Fix action attr iteration. Message-ID: <5988b4c57e70_4aac3fcab9e37c2c1036f1@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.5 Home: https://github.com/openvswitch/ovs Commit: 023992251a743af73a6b15460181531dad8119ff https://github.com/openvswitch/ovs/commit/023992251a743af73a6b15460181531dad8119ff Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M ofproto/ofproto-dpif-upcall.c Log Message: ----------- ofproto-dpif-upcall: Fix action attr iteration. This calls is operating on messages generated by the datapath. If a datapath implementation sends improperly formatted netlink attributes, then it's possible for a revalidator thread to end up trapped in an infinite loop iterating across the actions attributes. Rather than using the UNSAFE variation of this iterator, use the regular version. >From master commit 55f854b9d51edcbccf4ae1655855dddd1d9ec1fe. Fixes: e672ff9b4d22 ("ofproto-dpif: Restore metadata and registers on recirculation.") Signed-off-by: Joe Stringer Acked-by: Ben Pfaff Commit: 6f3f122bd73301a7396b2e29e4ed16a8955c1bab https://github.com/openvswitch/ovs/commit/6f3f122bd73301a7396b2e29e4ed16a8955c1bab Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M ofproto/ofproto-dpif-upcall.c Log Message: ----------- ofproto-dpif-upcall: Fix key attr iteration. This call is operating on messages generated by the datapath. If a datapath implementation sends improperly formatted netlink attributes, then it's possible for a revalidator thread to end up trapped in an infinite loop iterating across these attributes. Rather than using the UNSAFE variation of this iterator, use the regular version. >From master commit f2d3fef3d90253dda3e03822df2e921ec853192d. Fixes: 994fcc5a15d3 ("upcall: Check for recirc_id in ukey_create_from_dpif_flow()") Signed-off-by: Joe Stringer Reviewed-by: Greg Rose Acked-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/01122c2ac158...6f3f122bd733 From noreply at github.com Mon Aug 7 22:52:30 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 15:52:30 -0700 Subject: [ovs-git] [openvswitch/ovs] f505c0: Add NSH support information in NEWS Message-ID: <5988ef2e1111c_6a9d3f88e4793c3467016@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: f505c08f97905f41c291ddc40002178a7f92f7fb https://github.com/openvswitch/ovs/commit/f505c08f97905f41c291ddc40002178a7f92f7fb Author: Yi Yang Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M NEWS Log Message: ----------- Add NSH support information in NEWS Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff From noreply at github.com Mon Aug 7 22:52:39 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 15:52:39 -0700 Subject: [ovs-git] [openvswitch/ovs] b48f44: Add NSH support information in NEWS Message-ID: <5988ef3737aea_798c3fb2f41c3c341721f2@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: b48f44ff75948f1c4d688f5f524d76c14756b280 https://github.com/openvswitch/ovs/commit/b48f44ff75948f1c4d688f5f524d76c14756b280 Author: Yi Yang Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M NEWS Log Message: ----------- Add NSH support information in NEWS Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff From noreply at github.com Mon Aug 7 23:01:21 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 16:01:21 -0700 Subject: [ovs-git] [openvswitch/ovs] 599d46: MAINTAINERS: Add Alin Serdean. Message-ID: <5988f1411de98_122f3fe43f543c342124ec@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 599d460c9a9f06acf3887938f1e38dce603b91d7 https://github.com/openvswitch/ovs/commit/599d460c9a9f06acf3887938f1e38dce603b91d7 Author: Ben Pfaff Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M MAINTAINERS.rst Log Message: ----------- MAINTAINERS: Add Alin Serdean. Alin was elected by the Open vSwitch committers on Friday. Welcome to the team, Alin! CC: Alin Serdean Signed-off-by: Ben Pfaff From noreply at github.com Mon Aug 7 23:01:35 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 16:01:35 -0700 Subject: [ovs-git] [openvswitch/ovs] 0626d0: MAINTAINERS: Add Alin Serdean. Message-ID: <5988f14f2eee1_43433fcbec97fc3c924ef@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 0626d0eb43af330b8620767da01c115898a69f51 https://github.com/openvswitch/ovs/commit/0626d0eb43af330b8620767da01c115898a69f51 Author: Ben Pfaff Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M MAINTAINERS.rst Log Message: ----------- MAINTAINERS: Add Alin Serdean. Alin was elected by the Open vSwitch committers on Friday. Welcome to the team, Alin! CC: Alin Serdean Signed-off-by: Ben Pfaff From noreply at github.com Tue Aug 8 00:07:13 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 17:07:13 -0700 Subject: [ovs-git] [openvswitch/ovs] 8fc625: system-traffic: Fix TFTP NAT skip check. Message-ID: <598900b1d68d6_18b473fd35dc1bc341427f7@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 8fc6257baaedd0a2b271e59973b4ed2972633e0b https://github.com/openvswitch/ovs/commit/8fc6257baaedd0a2b271e59973b4ed2972633e0b Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M tests/system-traffic.at Log Message: ----------- system-traffic: Fix TFTP NAT skip check. This test checked whether FTP support was available rather than TFTP. It should check for TFTP, fix it. Fixes: 200a9af97d1c ("System tests: Add 4 new ftp and tftp tests.") Signed-off-by: Joe Stringer Acked-by: Andy Zhou Commit: 6b1babacc3ca0488e07596bf822fe356c9bab646 https://github.com/openvswitch/ovs/commit/6b1babacc3ca0488e07596bf822fe356c9bab646 Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M tests/system-kmod-macros.at Log Message: ----------- system-kmod-macros: Load TFTP module. Just like the FTP module needs to be loaded to ensure that the FTP tests work, the TFTP module needs to be loaded to ensure that the TFTP tests work. This patch does so. Fixes: 200a9af97d1c ("System tests: Add 4 new ftp and tftp tests.") Signed-off-by: Joe Stringer Acked-by: Andy Zhou Compare: https://github.com/openvswitch/ovs/compare/599d460c9a9f...6b1babacc3ca From noreply at github.com Tue Aug 8 00:35:46 2017 From: noreply at github.com (GitHub) Date: Mon, 07 Aug 2017 17:35:46 -0700 Subject: [ovs-git] [openvswitch/ovs] 2d5b4b: system-traffic: Fix TFTP NAT skip check. Message-ID: <59890762a49d9_94a3ff09a625c30834b6@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 2d5b4b1d7604ef1ec3bcb6bb7577680fd86f7fec https://github.com/openvswitch/ovs/commit/2d5b4b1d7604ef1ec3bcb6bb7577680fd86f7fec Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M tests/system-traffic.at Log Message: ----------- system-traffic: Fix TFTP NAT skip check. This test checked whether FTP support was available rather than TFTP. It should check for TFTP, fix it. >From master commit 8fc6257baaedd0a2b271e59973b4ed2972633e0b. Fixes: 200a9af97d1c ("System tests: Add 4 new ftp and tftp tests.") Signed-off-by: Joe Stringer Acked-by: Andy Zhou Commit: 5734dbfca8cb78f2e84c48bbb5d4c78e69439640 https://github.com/openvswitch/ovs/commit/5734dbfca8cb78f2e84c48bbb5d4c78e69439640 Author: Joe Stringer Date: 2017-08-07 (Mon, 07 Aug 2017) Changed paths: M tests/system-kmod-macros.at Log Message: ----------- system-kmod-macros: Load TFTP module. Just like the FTP module needs to be loaded to ensure that the FTP tests work, the TFTP module needs to be loaded to ensure that the TFTP tests work. This patch does so. >From master commit 6b1babacc3ca0488e07596bf822fe356c9bab646. Fixes: 200a9af97d1c ("System tests: Add 4 new ftp and tftp tests.") Signed-off-by: Joe Stringer Acked-by: Andy Zhou Compare: https://github.com/openvswitch/ovs/compare/0626d0eb43af...5734dbfca8cb From noreply at github.com Tue Aug 8 17:42:08 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 10:42:08 -0700 Subject: [ovs-git] [openvswitch/ovs] 92d535: redhat: allow arbitrary user:group Message-ID: <5989f7f052511_4963fc759f3fc2c8493a@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 92d53574d5039e1173347754090cf64ccf2af57c https://github.com/openvswitch/ovs/commit/92d53574d5039e1173347754090cf64ccf2af57c Author: aaron conole Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M rhel/automake.mk A rhel/etc_openvswitch_default.conf M rhel/openvswitch-fedora.spec.in M rhel/usr_lib_systemd_system_ovs-vswitchd.service M rhel/usr_lib_systemd_system_ovsdb-server.service M rhel/usr_share_openvswitch_scripts_systemd_sysconfig.template Log Message: ----------- redhat: allow arbitrary user:group Under rpm based distributions, the only user:group that the rhel daemons run as is 'root:root'. This is fine as a default, but as part of a security procedure, users may want to run as an alternate uid/gid. This commit adds an OVS_USER_ID environment variable for systemd, which defaults to root:root, but can be overridden by changing the /etc/sysconfig/openvswitch environment file. Acked-by: Markos Chandras Signed-off-by: Aaron Conole Signed-off-by: Russell Bryant Commit: ac416a3ab2d200284b4eeba0544056694850e65d https://github.com/openvswitch/ovs/commit/ac416a3ab2d200284b4eeba0544056694850e65d Author: aaron conole Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M rhel/openvswitch-fedora.spec.in M rhel/usr_lib_systemd_system_ovsdb-server.service Log Message: ----------- redhat: dynamically allocate and reference ovs user After this commit, the fedora RPM will create the openvswitch user, from the non-static pool, for use as an Open vSwitch daemon user. This only happens on install - not upgrade. This will be the default user:group combination for the openvswitch daemons. To do this in a way that doesn't impact existing installations, the /etc/openvswitch directory will be created during the installation, rather than being provided as part of the rpm. Acked-by: Markos Chandras Signed-off-by: Aaron Conole Signed-off-by: Russell Bryant Commit: 3828b456124b85093b414984daacbc8fae39dfca https://github.com/openvswitch/ovs/commit/3828b456124b85093b414984daacbc8fae39dfca Author: aaron conole Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M Makefile.am A build-aux/dpdkstrip.pl Log Message: ----------- dpdkstrip: add a preprocessor tool for stripping dpdk blocks Normally, in C code, pre-processing macros can be used to enable/disable specific functionality based on switches passed to configure. This works for DPDK using the --with-dpdk flag, which sets the DPDK_NETDEV define to the appropriate value. However, not all files are processed with the C pre-processor. For those files which are not, this commit adds a new pre-processor tool for .in files to either include or exclude those stanzas as appropriate. Signed-off-by: Aaron Conole Signed-off-by: Russell Bryant Commit: 491a9d3b6b2298f741d01d4398f80f388f1588a7 https://github.com/openvswitch/ovs/commit/491a9d3b6b2298f741d01d4398f80f388f1588a7 Author: aaron conole Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M rhel/.gitignore M rhel/automake.mk M rhel/openvswitch-fedora.spec.in R rhel/usr_lib_systemd_system_ovs-vswitchd.service A rhel/usr_lib_systemd_system_ovs-vswitchd.service.in Log Message: ----------- redhat: dynamic service file for vswitchd This commit changes the service file from static configuration to an autogenerated file, produced during the build. This will be relevant in a future commit. Signed-off-by: Aaron Conole Signed-off-by: Russell Bryant Commit: e3e738a3d0580a9a7178adfc9300a193b8df4ae5 https://github.com/openvswitch/ovs/commit/e3e738a3d0580a9a7178adfc9300a193b8df4ae5 Author: aaron conole Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M Documentation/intro/install/dpdk.rst M NEWS M rhel/README.RHEL.rst M rhel/openvswitch-fedora.spec.in M rhel/usr_lib_systemd_system_ovs-vswitchd.service.in Log Message: ----------- redhat: allow dpdk to also run as non-root user After this commit, users may start a dpdk-enabled ovs setup as a non-root user. This is accomplished by exporting the $HOME directory, which dpdk uses to fill in it's semi-persistent RTE configuration. This change may be a bit controversial since it modifies /dev/hugepages as part of starting the ovs-vswitchd to set a hugetlbfs group ownership. This is used to enable writing to /dev/hugepages so that the dpdk_init will successfully complete. There is an alternate way of accomplishing this - namely to initialize DPDK before dropping privileges. However, this would mean that if DPDK ever grows an uninit / reinit function, non-root ovs likely could never use it. This does not change OvS+DPDK's SELinux requirements. It still must be disabled. Signed-off-by: Aaron Conole Signed-off-by: Russell Bryant Compare: https://github.com/openvswitch/ovs/compare/6b1babacc3ca...e3e738a3d058 From noreply at github.com Tue Aug 8 17:45:15 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 10:45:15 -0700 Subject: [ovs-git] [openvswitch/ovs] 7f8d03: redhat: allow arbitrary user:group Message-ID: <5989f8ab463d1_a9a3fea4db93c241619e9@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 7f8d031836b0f39ec96f4d4cd5e09ae5227d5f89 https://github.com/openvswitch/ovs/commit/7f8d031836b0f39ec96f4d4cd5e09ae5227d5f89 Author: aaron conole Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M rhel/automake.mk A rhel/etc_openvswitch_default.conf M rhel/openvswitch-fedora.spec.in M rhel/usr_lib_systemd_system_ovs-vswitchd.service M rhel/usr_lib_systemd_system_ovsdb-server.service M rhel/usr_share_openvswitch_scripts_systemd_sysconfig.template Log Message: ----------- redhat: allow arbitrary user:group Under rpm based distributions, the only user:group that the rhel daemons run as is 'root:root'. This is fine as a default, but as part of a security procedure, users may want to run as an alternate uid/gid. This commit adds an OVS_USER_ID environment variable for systemd, which defaults to root:root, but can be overridden by changing the /etc/sysconfig/openvswitch environment file. Acked-by: Markos Chandras Signed-off-by: Aaron Conole Signed-off-by: Russell Bryant Commit: 5f17ca81a4cb5848d4f07a6758162b82c3fecc28 https://github.com/openvswitch/ovs/commit/5f17ca81a4cb5848d4f07a6758162b82c3fecc28 Author: aaron conole Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M rhel/openvswitch-fedora.spec.in M rhel/usr_lib_systemd_system_ovsdb-server.service Log Message: ----------- redhat: dynamically allocate and reference ovs user After this commit, the fedora RPM will create the openvswitch user, from the non-static pool, for use as an Open vSwitch daemon user. This only happens on install - not upgrade. This will be the default user:group combination for the openvswitch daemons. To do this in a way that doesn't impact existing installations, the /etc/openvswitch directory will be created during the installation, rather than being provided as part of the rpm. Acked-by: Markos Chandras Signed-off-by: Aaron Conole Signed-off-by: Russell Bryant Commit: 9bf077b5c398cabc92312845f6a78b390821ecbd https://github.com/openvswitch/ovs/commit/9bf077b5c398cabc92312845f6a78b390821ecbd Author: aaron conole Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M Makefile.am A build-aux/dpdkstrip.pl Log Message: ----------- dpdkstrip: add a preprocessor tool for stripping dpdk blocks Normally, in C code, pre-processing macros can be used to enable/disable specific functionality based on switches passed to configure. This works for DPDK using the --with-dpdk flag, which sets the DPDK_NETDEV define to the appropriate value. However, not all files are processed with the C pre-processor. For those files which are not, this commit adds a new pre-processor tool for .in files to either include or exclude those stanzas as appropriate. Signed-off-by: Aaron Conole Signed-off-by: Russell Bryant Commit: f98ba9fc5ae9fc16409afccf9a097837d69c17a8 https://github.com/openvswitch/ovs/commit/f98ba9fc5ae9fc16409afccf9a097837d69c17a8 Author: aaron conole Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M rhel/.gitignore M rhel/automake.mk M rhel/openvswitch-fedora.spec.in R rhel/usr_lib_systemd_system_ovs-vswitchd.service A rhel/usr_lib_systemd_system_ovs-vswitchd.service.in Log Message: ----------- redhat: dynamic service file for vswitchd This commit changes the service file from static configuration to an autogenerated file, produced during the build. This will be relevant in a future commit. Signed-off-by: Aaron Conole Signed-off-by: Russell Bryant Commit: b7ff4a4a917f06709220a138dfc0b6aeae6e6d5f https://github.com/openvswitch/ovs/commit/b7ff4a4a917f06709220a138dfc0b6aeae6e6d5f Author: aaron conole Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M Documentation/intro/install/dpdk.rst M NEWS M rhel/README.RHEL.rst M rhel/openvswitch-fedora.spec.in M rhel/usr_lib_systemd_system_ovs-vswitchd.service.in Log Message: ----------- redhat: allow dpdk to also run as non-root user After this commit, users may start a dpdk-enabled ovs setup as a non-root user. This is accomplished by exporting the $HOME directory, which dpdk uses to fill in it's semi-persistent RTE configuration. This change may be a bit controversial since it modifies /dev/hugepages as part of starting the ovs-vswitchd to set a hugetlbfs group ownership. This is used to enable writing to /dev/hugepages so that the dpdk_init will successfully complete. There is an alternate way of accomplishing this - namely to initialize DPDK before dropping privileges. However, this would mean that if DPDK ever grows an uninit / reinit function, non-root ovs likely could never use it. This does not change OvS+DPDK's SELinux requirements. It still must be disabled. Signed-off-by: Aaron Conole Signed-off-by: Russell Bryant Compare: https://github.com/openvswitch/ovs/compare/5734dbfca8cb...b7ff4a4a917f From noreply at github.com Tue Aug 8 18:31:13 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 11:31:13 -0700 Subject: [ovs-git] [openvswitch/ovs] ca40df: acinclude: Also support pkg-config for configuring... Message-ID: <598a0371e778b_69a53fc23973bc30139523@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: ca40df5144f3055db0d9d73830f0506875de1336 https://github.com/openvswitch/ovs/commit/ca40df5144f3055db0d9d73830f0506875de1336 Author: Christian Ehrhardt Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M Documentation/intro/install/dpdk.rst M acinclude.m4 M configure.ac Log Message: ----------- acinclude: Also support pkg-config for configuring dpdk. If available use dpdk pkg-config info of libdpdk to set the right include paths. That for example, allows packagers to provide non default include paths in a common way (pkg-config). Signed-off-by: Christian Ehrhardt Suggested-by: Luca Boccassi Acked-by: Luca Boccassi Signed-off-by: Ben Pfaff From noreply at github.com Tue Aug 8 18:31:13 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 11:31:13 -0700 Subject: [ovs-git] [openvswitch/ovs] ca40df: acinclude: Also support pkg-config for configuring... Message-ID: <598a0371e778b_69a53fc23973bc30139523@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: ca40df5144f3055db0d9d73830f0506875de1336 https://github.com/openvswitch/ovs/commit/ca40df5144f3055db0d9d73830f0506875de1336 Author: Christian Ehrhardt Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M Documentation/intro/install/dpdk.rst M acinclude.m4 M configure.ac Log Message: ----------- acinclude: Also support pkg-config for configuring dpdk. If available use dpdk pkg-config info of libdpdk to set the right include paths. That for example, allows packagers to provide non default include paths in a common way (pkg-config). Signed-off-by: Christian Ehrhardt Suggested-by: Luca Boccassi Acked-by: Luca Boccassi Signed-off-by: Ben Pfaff From noreply at github.com Tue Aug 8 18:31:13 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 11:31:13 -0700 Subject: [ovs-git] [openvswitch/ovs] ca40df: acinclude: Also support pkg-config for configuring... Message-ID: <598a0371e778b_69a53fc23973bc30139523@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: ca40df5144f3055db0d9d73830f0506875de1336 https://github.com/openvswitch/ovs/commit/ca40df5144f3055db0d9d73830f0506875de1336 Author: Christian Ehrhardt Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M Documentation/intro/install/dpdk.rst M acinclude.m4 M configure.ac Log Message: ----------- acinclude: Also support pkg-config for configuring dpdk. If available use dpdk pkg-config info of libdpdk to set the right include paths. That for example, allows packagers to provide non default include paths in a common way (pkg-config). Signed-off-by: Christian Ehrhardt Suggested-by: Luca Boccassi Acked-by: Luca Boccassi Signed-off-by: Ben Pfaff From noreply at github.com Tue Aug 8 18:31:13 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 11:31:13 -0700 Subject: [ovs-git] [openvswitch/ovs] ca40df: acinclude: Also support pkg-config for configuring... Message-ID: <598a0371e778b_69a53fc23973bc30139523@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: ca40df5144f3055db0d9d73830f0506875de1336 https://github.com/openvswitch/ovs/commit/ca40df5144f3055db0d9d73830f0506875de1336 Author: Christian Ehrhardt Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M Documentation/intro/install/dpdk.rst M acinclude.m4 M configure.ac Log Message: ----------- acinclude: Also support pkg-config for configuring dpdk. If available use dpdk pkg-config info of libdpdk to set the right include paths. That for example, allows packagers to provide non default include paths in a common way (pkg-config). Signed-off-by: Christian Ehrhardt Suggested-by: Luca Boccassi Acked-by: Luca Boccassi Signed-off-by: Ben Pfaff From noreply at github.com Tue Aug 8 19:25:24 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 12:25:24 -0700 Subject: [ovs-git] [openvswitch/ovs] a6e647: tnl-ports: Fix loss of tunneling upon removal of a... Message-ID: <598a1024a9b57_18a743fdb4e025c3816131f@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: a6e64715d4188832a2fd5fcf06c44fe4c0a160b7 https://github.com/openvswitch/ovs/commit/a6e64715d4188832a2fd5fcf06c44fe4c0a160b7 Author: zhaozhanxu Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M lib/tnl-ports.c Log Message: ----------- tnl-ports: Fix loss of tunneling upon removal of a single tunnel port. When OVS had multiple tunnel ports of a single kind, and any one of them was removed, the remaining ports could no longer receive traffic. This fixes the problem. Signed-off-by: zhaozhanxu Signed-off-by: Ben Pfaff From noreply at github.com Tue Aug 8 19:25:40 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 12:25:40 -0700 Subject: [ovs-git] [openvswitch/ovs] 33118c: tnl-ports: Fix loss of tunneling upon removal of a... Message-ID: <598a1034be2e4_6b9c3fe6a2323c2817241e@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.6 Home: https://github.com/openvswitch/ovs Commit: 33118cfa4c4af6a0659cdef85bc6e33eabf15ccf https://github.com/openvswitch/ovs/commit/33118cfa4c4af6a0659cdef85bc6e33eabf15ccf Author: zhaozhanxu Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M lib/tnl-ports.c Log Message: ----------- tnl-ports: Fix loss of tunneling upon removal of a single tunnel port. When OVS had multiple tunnel ports of a single kind, and any one of them was removed, the remaining ports could no longer receive traffic. This fixes the problem. Signed-off-by: zhaozhanxu Signed-off-by: Ben Pfaff From noreply at github.com Tue Aug 8 20:10:08 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 13:10:08 -0700 Subject: [ovs-git] [openvswitch/ovs] 804bdf: ovs-vsctl-bashcomp: Make compatible with busybox "... Message-ID: <598a1aa06cbf1_44cd3ff319cb5c2c1430c5@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 804bdf738e1302e802d794089bd5c5c8260a0e1a https://github.com/openvswitch/ovs/commit/804bdf738e1302e802d794089bd5c5c8260a0e1a Author: Ben Pfaff Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M utilities/ovs-vsctl-bashcomp.bash Log Message: ----------- ovs-vsctl-bashcomp: Make compatible with busybox "awk". It seems that awk in busybox doesn't think that an empty string is part of a larger string, but that GNU awk does. This commit adds an extra test to make _ovs_vsctl_check_startswith_string work either way. This allows the following tests to pass with busybox awk: vsctl bashcomp unit tests 7: vsctl-bashcomp - basic verification ok 8: vsctl-bashcomp - argument completion ok Reported-by: Stuart Cardall Signed-off-by: Ben Pfaff Acked-by: Lance Richardson Commit: 8c04a5843b6a137f47c42adad7d0457721af156a https://github.com/openvswitch/ovs/commit/8c04a5843b6a137f47c42adad7d0457721af156a Author: Bhanuprakash Bodireddy Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M vswitchd/vswitch.ovsschema Log Message: ----------- ovsschema: Fix line lengths. According to coding style the line lengths should be <=79. Fix the schema file and update the checksum and version number to reflect the change. Signed-off-by: Bhanuprakash Bodireddy Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/e3e738a3d058...8c04a5843b6a From noreply at github.com Tue Aug 8 20:10:08 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 13:10:08 -0700 Subject: [ovs-git] [openvswitch/ovs] 804bdf: ovs-vsctl-bashcomp: Make compatible with busybox "... Message-ID: <598a1aa06cbf1_44cd3ff319cb5c2c1430c5@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 804bdf738e1302e802d794089bd5c5c8260a0e1a https://github.com/openvswitch/ovs/commit/804bdf738e1302e802d794089bd5c5c8260a0e1a Author: Ben Pfaff Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M utilities/ovs-vsctl-bashcomp.bash Log Message: ----------- ovs-vsctl-bashcomp: Make compatible with busybox "awk". It seems that awk in busybox doesn't think that an empty string is part of a larger string, but that GNU awk does. This commit adds an extra test to make _ovs_vsctl_check_startswith_string work either way. This allows the following tests to pass with busybox awk: vsctl bashcomp unit tests 7: vsctl-bashcomp - basic verification ok 8: vsctl-bashcomp - argument completion ok Reported-by: Stuart Cardall Signed-off-by: Ben Pfaff Acked-by: Lance Richardson Commit: 8c04a5843b6a137f47c42adad7d0457721af156a https://github.com/openvswitch/ovs/commit/8c04a5843b6a137f47c42adad7d0457721af156a Author: Bhanuprakash Bodireddy Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M vswitchd/vswitch.ovsschema Log Message: ----------- ovsschema: Fix line lengths. According to coding style the line lengths should be <=79. Fix the schema file and update the checksum and version number to reflect the change. Signed-off-by: Bhanuprakash Bodireddy Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/e3e738a3d058...8c04a5843b6a From noreply at github.com Tue Aug 8 20:10:08 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 13:10:08 -0700 Subject: [ovs-git] [openvswitch/ovs] 804bdf: ovs-vsctl-bashcomp: Make compatible with busybox "... Message-ID: <598a1aa06cbf1_44cd3ff319cb5c2c1430c5@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 804bdf738e1302e802d794089bd5c5c8260a0e1a https://github.com/openvswitch/ovs/commit/804bdf738e1302e802d794089bd5c5c8260a0e1a Author: Ben Pfaff Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M utilities/ovs-vsctl-bashcomp.bash Log Message: ----------- ovs-vsctl-bashcomp: Make compatible with busybox "awk". It seems that awk in busybox doesn't think that an empty string is part of a larger string, but that GNU awk does. This commit adds an extra test to make _ovs_vsctl_check_startswith_string work either way. This allows the following tests to pass with busybox awk: vsctl bashcomp unit tests 7: vsctl-bashcomp - basic verification ok 8: vsctl-bashcomp - argument completion ok Reported-by: Stuart Cardall Signed-off-by: Ben Pfaff Acked-by: Lance Richardson Commit: 8c04a5843b6a137f47c42adad7d0457721af156a https://github.com/openvswitch/ovs/commit/8c04a5843b6a137f47c42adad7d0457721af156a Author: Bhanuprakash Bodireddy Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M vswitchd/vswitch.ovsschema Log Message: ----------- ovsschema: Fix line lengths. According to coding style the line lengths should be <=79. Fix the schema file and update the checksum and version number to reflect the change. Signed-off-by: Bhanuprakash Bodireddy Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/e3e738a3d058...8c04a5843b6a From noreply at github.com Tue Aug 8 20:10:08 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 13:10:08 -0700 Subject: [ovs-git] [openvswitch/ovs] 804bdf: ovs-vsctl-bashcomp: Make compatible with busybox "... Message-ID: <598a1aa06cbf1_44cd3ff319cb5c2c1430c5@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 804bdf738e1302e802d794089bd5c5c8260a0e1a https://github.com/openvswitch/ovs/commit/804bdf738e1302e802d794089bd5c5c8260a0e1a Author: Ben Pfaff Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M utilities/ovs-vsctl-bashcomp.bash Log Message: ----------- ovs-vsctl-bashcomp: Make compatible with busybox "awk". It seems that awk in busybox doesn't think that an empty string is part of a larger string, but that GNU awk does. This commit adds an extra test to make _ovs_vsctl_check_startswith_string work either way. This allows the following tests to pass with busybox awk: vsctl bashcomp unit tests 7: vsctl-bashcomp - basic verification ok 8: vsctl-bashcomp - argument completion ok Reported-by: Stuart Cardall Signed-off-by: Ben Pfaff Acked-by: Lance Richardson Commit: 8c04a5843b6a137f47c42adad7d0457721af156a https://github.com/openvswitch/ovs/commit/8c04a5843b6a137f47c42adad7d0457721af156a Author: Bhanuprakash Bodireddy Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M vswitchd/vswitch.ovsschema Log Message: ----------- ovsschema: Fix line lengths. According to coding style the line lengths should be <=79. Fix the schema file and update the checksum and version number to reflect the change. Signed-off-by: Bhanuprakash Bodireddy Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/e3e738a3d058...8c04a5843b6a From noreply at github.com Tue Aug 8 20:10:08 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 13:10:08 -0700 Subject: [ovs-git] [openvswitch/ovs] 804bdf: ovs-vsctl-bashcomp: Make compatible with busybox "... Message-ID: <598a1aa06cbf1_44cd3ff319cb5c2c1430c5@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 804bdf738e1302e802d794089bd5c5c8260a0e1a https://github.com/openvswitch/ovs/commit/804bdf738e1302e802d794089bd5c5c8260a0e1a Author: Ben Pfaff Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M utilities/ovs-vsctl-bashcomp.bash Log Message: ----------- ovs-vsctl-bashcomp: Make compatible with busybox "awk". It seems that awk in busybox doesn't think that an empty string is part of a larger string, but that GNU awk does. This commit adds an extra test to make _ovs_vsctl_check_startswith_string work either way. This allows the following tests to pass with busybox awk: vsctl bashcomp unit tests 7: vsctl-bashcomp - basic verification ok 8: vsctl-bashcomp - argument completion ok Reported-by: Stuart Cardall Signed-off-by: Ben Pfaff Acked-by: Lance Richardson Commit: 8c04a5843b6a137f47c42adad7d0457721af156a https://github.com/openvswitch/ovs/commit/8c04a5843b6a137f47c42adad7d0457721af156a Author: Bhanuprakash Bodireddy Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M vswitchd/vswitch.ovsschema Log Message: ----------- ovsschema: Fix line lengths. According to coding style the line lengths should be <=79. Fix the schema file and update the checksum and version number to reflect the change. Signed-off-by: Bhanuprakash Bodireddy Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/e3e738a3d058...8c04a5843b6a From noreply at github.com Tue Aug 8 20:10:08 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 13:10:08 -0700 Subject: [ovs-git] [openvswitch/ovs] 804bdf: ovs-vsctl-bashcomp: Make compatible with busybox "... Message-ID: <598a1aa06cbf1_44cd3ff319cb5c2c1430c5@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 804bdf738e1302e802d794089bd5c5c8260a0e1a https://github.com/openvswitch/ovs/commit/804bdf738e1302e802d794089bd5c5c8260a0e1a Author: Ben Pfaff Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M utilities/ovs-vsctl-bashcomp.bash Log Message: ----------- ovs-vsctl-bashcomp: Make compatible with busybox "awk". It seems that awk in busybox doesn't think that an empty string is part of a larger string, but that GNU awk does. This commit adds an extra test to make _ovs_vsctl_check_startswith_string work either way. This allows the following tests to pass with busybox awk: vsctl bashcomp unit tests 7: vsctl-bashcomp - basic verification ok 8: vsctl-bashcomp - argument completion ok Reported-by: Stuart Cardall Signed-off-by: Ben Pfaff Acked-by: Lance Richardson Commit: 8c04a5843b6a137f47c42adad7d0457721af156a https://github.com/openvswitch/ovs/commit/8c04a5843b6a137f47c42adad7d0457721af156a Author: Bhanuprakash Bodireddy Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M vswitchd/vswitch.ovsschema Log Message: ----------- ovsschema: Fix line lengths. According to coding style the line lengths should be <=79. Fix the schema file and update the checksum and version number to reflect the change. Signed-off-by: Bhanuprakash Bodireddy Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/e3e738a3d058...8c04a5843b6a From noreply at github.com Tue Aug 8 23:04:10 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 16:04:10 -0700 Subject: [ovs-git] [openvswitch/ovs] 5dc451: m4: Add pkg.m4 from pkg-config. Message-ID: <598a436a4c1cf_4db63fcc406efc343435d3@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 5dc451b65fa567716b930da88ef440023df082fb https://github.com/openvswitch/ovs/commit/5dc451b65fa567716b930da88ef440023df082fb Author: Ben Pfaff Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M m4/automake.mk A m4/pkg.m4 Log Message: ----------- m4: Add pkg.m4 from pkg-config. This way, users do not have to install the m4 file from pkg-config, which was not previously a requirement. Without this change, "configure" fails when pkg.m4 is not available via aclocal: ./configure: line 26189: `??????? PKG_CHECK_MODULES(DPDK, libdpdk,' Reported-by: Alin Serdean Signed-off-by: Ben Pfaff Acked-by: Alin Gabriel Serdean From noreply at github.com Tue Aug 8 23:04:28 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 16:04:28 -0700 Subject: [ovs-git] [openvswitch/ovs] 35066b: m4: Add pkg.m4 from pkg-config. Message-ID: <598a437c314f1_18fb83fc559667c3c118426@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 35066b4da636c429c7582d8974f6004f33e9d0d8 https://github.com/openvswitch/ovs/commit/35066b4da636c429c7582d8974f6004f33e9d0d8 Author: Ben Pfaff Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M m4/automake.mk A m4/pkg.m4 Log Message: ----------- m4: Add pkg.m4 from pkg-config. This way, users do not have to install the m4 file from pkg-config, which was not previously a requirement. Without this change, "configure" fails when pkg.m4 is not available via aclocal: ./configure: line 26189: `??????? PKG_CHECK_MODULES(DPDK, libdpdk,' Reported-by: Alin Serdean Signed-off-by: Ben Pfaff Acked-by: Alin Gabriel Serdean From noreply at github.com Tue Aug 8 23:14:20 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 16:14:20 -0700 Subject: [ovs-git] [openvswitch/ovs] ebd5a9: nsh: Avoid zero-length array. Message-ID: <598a45cc2827_632b3fcb8d371c3c12392c@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: ebd5a960cd53b1d7f1f468a522dbe4d515859118 https://github.com/openvswitch/ovs/commit/ebd5a960cd53b1d7f1f468a522dbe4d515859118 Author: Ben Pfaff Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M include/openvswitch/nsh.h M lib/packets.c Log Message: ----------- nsh: Avoid zero-length array. MSVC allows [] but not [0] for arrays in struct definitions, and does not allow nested [] inside a union. Reported-by: Alin Serdean Signed-off-by: Ben Pfaff Acked-by: Alin Gabriel Serdean From noreply at github.com Tue Aug 8 23:14:29 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 16:14:29 -0700 Subject: [ovs-git] [openvswitch/ovs] 12212c: nsh: Avoid zero-length array. Message-ID: <598a45d5b865b_70b3faf2a987c2c11319a@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 12212c222bf343f18d4f6655a6e1cd0bc9c86b96 https://github.com/openvswitch/ovs/commit/12212c222bf343f18d4f6655a6e1cd0bc9c86b96 Author: Ben Pfaff Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M include/openvswitch/nsh.h M lib/packets.c Log Message: ----------- nsh: Avoid zero-length array. MSVC allows [] but not [0] for arrays in struct definitions, and does not allow nested [] inside a union. Reported-by: Alin Serdean Signed-off-by: Ben Pfaff Acked-by: Alin Gabriel Serdean From noreply at github.com Tue Aug 8 23:21:40 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 16:21:40 -0700 Subject: [ovs-git] [openvswitch/ovs] 08ba5f: include: Add struct declaration to ofp-print.h. Message-ID: <598a4784dac07_4dd83f9dcaafbc2869832@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 08ba5f57f1a3305a4eab820c0d70ac7efd127b65 https://github.com/openvswitch/ovs/commit/08ba5f57f1a3305a4eab820c0d70ac7efd127b65 Author: Joe Stringer Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M include/openvswitch/ofp-print.h Log Message: ----------- include: Add struct declaration to ofp-print.h. If a libopenvswitch user includes ofp-print.h before ofp-util.h (which is standard alphabetical order), and turns on -Werror, then they would hit this compilation error in the include: error: 'struct ofputil_port_map' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] void ofp_print(FILE *, const void *, size_t *, const struct ofputil_port_map *, Fixes: 50f96b10e1c8 ("Support accepting and displaying port names in OVS tools.") Signed-off-by: Joe Stringer Acked-by: Ben Pfaff From noreply at github.com Tue Aug 8 23:22:18 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 16:22:18 -0700 Subject: [ovs-git] [openvswitch/ovs] 9d82b1: include: Add struct declaration to ofp-print.h. Message-ID: <598a47aa17fe9_afb3fddafd49c30610ec@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 9d82b1cc1afb558a0d21ab0bdd36ffe58f054a00 https://github.com/openvswitch/ovs/commit/9d82b1cc1afb558a0d21ab0bdd36ffe58f054a00 Author: Joe Stringer Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M include/openvswitch/ofp-print.h Log Message: ----------- include: Add struct declaration to ofp-print.h. If a libopenvswitch user includes ofp-print.h before ofp-util.h (which is standard alphabetical order), and turns on -Werror, then they would hit this compilation error in the include: error: 'struct ofputil_port_map' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] void ofp_print(FILE *, const void *, size_t *, const struct ofputil_port_map *, >From master commit 08ba5f57f1a3305a4eab820c0d70ac7efd127b65. Fixes: 50f96b10e1c8 ("Support accepting and displaying port names in OVS tools.") Signed-off-by: Joe Stringer Acked-by: Ben Pfaff From noreply at github.com Tue Aug 8 23:28:06 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 16:28:06 -0700 Subject: [ovs-git] [openvswitch/ovs] 0c24b0: ofp-print: #include its own header first. Message-ID: <598a4906bc86_7d993fafde69fc30145881@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 0c24b0ba1554e02e4776f2676435791333c50766 https://github.com/openvswitch/ovs/commit/0c24b0ba1554e02e4776f2676435791333c50766 Author: Ben Pfaff Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M lib/ofp-print.c Log Message: ----------- ofp-print: #include its own header first. The OVS coding style document says that a .c file should include the corresponding .h file first, to ensure that the .h file includes all of its dependencies, but this file didn't do that. Signed-off-by: Ben Pfaff Acked-by: Joe Stringer From noreply at github.com Tue Aug 8 23:45:59 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 16:45:59 -0700 Subject: [ovs-git] [openvswitch/ovs] 0ac010: netdev: check for NULL fields in netdev_get_addrs Message-ID: <598a4d3784706_7e133fdb7863fc34210d1@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 0ac01021a971e564acb8dc43e0872e6e0a2ee326 https://github.com/openvswitch/ovs/commit/0ac01021a971e564acb8dc43e0872e6e0a2ee326 Author: Daniel Alvarez Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M lib/netdev.c Log Message: ----------- netdev: check for NULL fields in netdev_get_addrs When the interfaces list is retrieved through getiffaddrs(), there might be elements with iface_name set to NULL. This patch checks ifa_name to be not NULL before comparing it to the actual device name in the loop that calculates how many interfaces exist with that same name. Also, this patch checks that ifa_netmask is not NULL for coherence with the existing code so that it doesn't allocate more memory than needed if this field is NULL. Note, that these checks are already being done later in the function so it should be done in both places. Signed-off-by: Daniel Alvarez Signed-off-by: Ben Pfaff Acked-by: Lance Richardson From noreply at github.com Tue Aug 8 23:46:16 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 16:46:16 -0700 Subject: [ovs-git] [openvswitch/ovs] 6c2d51: netdev: check for NULL fields in netdev_get_addrs Message-ID: <598a4d48e5798_632b3fcb8d371c3c12455a@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 6c2d5127daa3a3da3f00e6f2e9cb285b322b5794 https://github.com/openvswitch/ovs/commit/6c2d5127daa3a3da3f00e6f2e9cb285b322b5794 Author: Daniel Alvarez Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M lib/netdev.c Log Message: ----------- netdev: check for NULL fields in netdev_get_addrs When the interfaces list is retrieved through getiffaddrs(), there might be elements with iface_name set to NULL. This patch checks ifa_name to be not NULL before comparing it to the actual device name in the loop that calculates how many interfaces exist with that same name. Also, this patch checks that ifa_netmask is not NULL for coherence with the existing code so that it doesn't allocate more memory than needed if this field is NULL. Note, that these checks are already being done later in the function so it should be done in both places. Signed-off-by: Daniel Alvarez Signed-off-by: Ben Pfaff Acked-by: Lance Richardson From noreply at github.com Tue Aug 8 23:46:21 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 16:46:21 -0700 Subject: [ovs-git] [openvswitch/ovs] e7192a: netdev: check for NULL fields in netdev_get_addrs Message-ID: <598a4d4d9c497_50073fd8319b7c449637@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: e7192aac330564caf71be80be42af57937197138 https://github.com/openvswitch/ovs/commit/e7192aac330564caf71be80be42af57937197138 Author: Daniel Alvarez Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M lib/netdev.c Log Message: ----------- netdev: check for NULL fields in netdev_get_addrs When the interfaces list is retrieved through getiffaddrs(), there might be elements with iface_name set to NULL. This patch checks ifa_name to be not NULL before comparing it to the actual device name in the loop that calculates how many interfaces exist with that same name. Also, this patch checks that ifa_netmask is not NULL for coherence with the existing code so that it doesn't allocate more memory than needed if this field is NULL. Note, that these checks are already being done later in the function so it should be done in both places. Signed-off-by: Daniel Alvarez Signed-off-by: Ben Pfaff Acked-by: Lance Richardson From noreply at github.com Tue Aug 8 23:46:26 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 16:46:26 -0700 Subject: [ovs-git] [openvswitch/ovs] 31840b: netdev: check for NULL fields in netdev_get_addrs Message-ID: <598a4d527f37a_2e233fe9f89edc44410ae@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.6 Home: https://github.com/openvswitch/ovs Commit: 31840b2482c4535cbf06f18740f77de42255e48d https://github.com/openvswitch/ovs/commit/31840b2482c4535cbf06f18740f77de42255e48d Author: Daniel Alvarez Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M lib/netdev.c Log Message: ----------- netdev: check for NULL fields in netdev_get_addrs When the interfaces list is retrieved through getiffaddrs(), there might be elements with iface_name set to NULL. This patch checks ifa_name to be not NULL before comparing it to the actual device name in the loop that calculates how many interfaces exist with that same name. Also, this patch checks that ifa_netmask is not NULL for coherence with the existing code so that it doesn't allocate more memory than needed if this field is NULL. Note, that these checks are already being done later in the function so it should be done in both places. Signed-off-by: Daniel Alvarez Signed-off-by: Ben Pfaff Acked-by: Lance Richardson From noreply at github.com Tue Aug 8 23:54:18 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 16:54:18 -0700 Subject: [ovs-git] [openvswitch/ovs] 360990: netdev-dummy: Close pcap files when dummy device i... Message-ID: <598a4f2aa7689_2f073fa51cf29c241093a8@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 360990eb1d1aa13c7a623d9746ad301896aaabd5 https://github.com/openvswitch/ovs/commit/360990eb1d1aa13c7a623d9746ad301896aaabd5 Author: Ben Pfaff Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M lib/netdev-dummy.c Log Message: ----------- netdev-dummy: Close pcap files when dummy device is closed. Fixes a fd leak. Reported-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Alin Gabriel Serdean From noreply at github.com Tue Aug 8 23:54:35 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 16:54:35 -0700 Subject: [ovs-git] [openvswitch/ovs] 7aa47a: netdev-dummy: Close pcap files when dummy device i... Message-ID: <598a4f3b4385f_22983fee70f8fc3411049b@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 7aa47a19dce0ad8bd16a490ee4651fa77ad26843 https://github.com/openvswitch/ovs/commit/7aa47a19dce0ad8bd16a490ee4651fa77ad26843 Author: Ben Pfaff Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M lib/netdev-dummy.c Log Message: ----------- netdev-dummy: Close pcap files when dummy device is closed. Fixes a fd leak. Reported-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Alin Gabriel Serdean From noreply at github.com Tue Aug 8 23:54:39 2017 From: noreply at github.com (GitHub) Date: Tue, 08 Aug 2017 16:54:39 -0700 Subject: [ovs-git] [openvswitch/ovs] fc42cc: netdev-dummy: Close pcap files when dummy device i... Message-ID: <598a4f3fc0465_2b673ff911861c2c797f1@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: fc42cceacac508ac8a154f64247769872dc56a65 https://github.com/openvswitch/ovs/commit/fc42cceacac508ac8a154f64247769872dc56a65 Author: Ben Pfaff Date: 2017-08-08 (Tue, 08 Aug 2017) Changed paths: M lib/netdev-dummy.c Log Message: ----------- netdev-dummy: Close pcap files when dummy device is closed. Fixes a fd leak. Reported-by: Alin Gabriel Serdean Signed-off-by: Ben Pfaff Acked-by: Alin Gabriel Serdean From noreply at github.com Wed Aug 9 16:58:48 2017 From: noreply at github.com (GitHub) Date: Wed, 09 Aug 2017 09:58:48 -0700 Subject: [ovs-git] [openvswitch/ovs] 5e5254: travis: Fix DPDK builds in new environment. Message-ID: <598b3f48c97db_40fd3fd2ee063c4494969@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 5e52540f225cb25c155e41a9b1797402491cccdc https://github.com/openvswitch/ovs/commit/5e52540f225cb25c155e41a9b1797402491cccdc Author: Darrell Ball Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M .travis/linux-build.sh Log Message: ----------- travis: Fix DPDK builds in new environment. The following error is seen: 17.05.1/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c:29: /home/travis/build/darball/ovs/linux-3.16.46/arch/x86/include/asm/ dma-mapping.h:32:35: error: inlining failed in call to ?get_dma_ops?: call is unlikely and code size would grow [-Werror=inline] -Wno-error=inline is used to address the issues with the new environment. Suggested-by: Ben Pfaff Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff From noreply at github.com Wed Aug 9 16:58:58 2017 From: noreply at github.com (GitHub) Date: Wed, 09 Aug 2017 09:58:58 -0700 Subject: [ovs-git] [openvswitch/ovs] 78f75b: travis: Fix DPDK builds in new environment. Message-ID: <598b3f52e18d0_51383fb05abebc3010393@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 78f75b6d761d5243a0374a8d6fef4ebee345761d https://github.com/openvswitch/ovs/commit/78f75b6d761d5243a0374a8d6fef4ebee345761d Author: Darrell Ball Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M .travis/linux-build.sh Log Message: ----------- travis: Fix DPDK builds in new environment. The following error is seen: 17.05.1/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c:29: /home/travis/build/darball/ovs/linux-3.16.46/arch/x86/include/asm/ dma-mapping.h:32:35: error: inlining failed in call to ?get_dma_ops?: call is unlikely and code size would grow [-Werror=inline] -Wno-error=inline is used to address the issues with the new environment. Suggested-by: Ben Pfaff Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff From noreply at github.com Wed Aug 9 18:10:57 2017 From: noreply at github.com (GitHub) Date: Wed, 09 Aug 2017 11:10:57 -0700 Subject: [ovs-git] [openvswitch/ovs] cfc196: dp-packet: Use OVS_UNUSED to mark possibly unused ... Message-ID: <598b503170c2a_1d4cd3fdba4dd7c2c1007a2@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: cfc19646877af6c97bf24f9fe0afd0d3fc8245a5 https://github.com/openvswitch/ovs/commit/cfc19646877af6c97bf24f9fe0afd0d3fc8245a5 Author: Ben Pfaff Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M lib/dp-packet.h Log Message: ----------- dp-packet: Use OVS_UNUSED to mark possibly unused parameters. This is the way usually used in OVS. Signed-off-by: Ben Pfaff Acked-by: Darrell Ball From noreply at github.com Wed Aug 9 18:36:47 2017 From: noreply at github.com (GitHub) Date: Wed, 09 Aug 2017 11:36:47 -0700 Subject: [ovs-git] [openvswitch/ovs] 21b159: ovs-vsctl-bashcomp: Make compatible with busybox "... Message-ID: <598b563fbebc1_19cc3fc4a73a9c3c501cd@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 21b159802961e05104dee652817761d8c449fc48 https://github.com/openvswitch/ovs/commit/21b159802961e05104dee652817761d8c449fc48 Author: Ben Pfaff Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M utilities/ovs-vsctl-bashcomp.bash Log Message: ----------- ovs-vsctl-bashcomp: Make compatible with busybox "awk". It seems that awk in busybox doesn't think that an empty string is part of a larger string, but that GNU awk does. This commit adds an extra test to make _ovs_vsctl_check_startswith_string work either way. This allows the following tests to pass with busybox awk: vsctl bashcomp unit tests 7: vsctl-bashcomp - basic verification ok 8: vsctl-bashcomp - argument completion ok Reported-by: Stuart Cardall Signed-off-by: Ben Pfaff Acked-by: Lance Richardson From noreply at github.com Wed Aug 9 19:55:38 2017 From: noreply at github.com (GitHub) Date: Wed, 09 Aug 2017 12:55:38 -0700 Subject: [ovs-git] [openvswitch/ovs] 580e11: netdev-linux: Reduce log level for ENODEV errors g... Message-ID: <598b68baa89db_48d23f9d4ae8fc34780d9@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 580e1152d4c02d96312157084a437e4daedbc780 https://github.com/openvswitch/ovs/commit/580e1152d4c02d96312157084a437e4daedbc780 Author: Roi Dayan Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M lib/netdev-linux.c Log Message: ----------- netdev-linux: Reduce log level for ENODEV errors getting ifindex These are normal and unavoidable, because the vifs disappear from the kernel before they are removed them from the OVS database. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey Signed-off-by: Ben Pfaff Commit: 5e530e26bf3635ce9856e2259bdf3249bf9a25f3 https://github.com/openvswitch/ovs/commit/5e530e26bf3635ce9856e2259bdf3249bf9a25f3 Author: Paul Blakey Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M lib/netdev-vport.c Log Message: ----------- netdev-vport: Always implement get_ifindex for netdev-vport Always implement get_ifindex without checking if offload is enabled or not as this should not be related. From ovs-dpctl we cannot tell if offload is enabled or not as other_config is not being read. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/cfc19646877a...5e530e26bf36 From noreply at github.com Wed Aug 9 19:55:53 2017 From: noreply at github.com (GitHub) Date: Wed, 09 Aug 2017 12:55:53 -0700 Subject: [ovs-git] [openvswitch/ovs] 759bba: netdev-linux: Reduce log level for ENODEV errors g... Message-ID: <598b68c94dca1_73663fd70393dc348008a@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 759bbad1249ad256029a843fb79b1b5b4036b959 https://github.com/openvswitch/ovs/commit/759bbad1249ad256029a843fb79b1b5b4036b959 Author: Roi Dayan Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M lib/netdev-linux.c Log Message: ----------- netdev-linux: Reduce log level for ENODEV errors getting ifindex These are normal and unavoidable, because the vifs disappear from the kernel before they are removed them from the OVS database. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey Signed-off-by: Ben Pfaff Commit: 9567f0772e8507e5bbbd945b61fdbb6e8ea375bb https://github.com/openvswitch/ovs/commit/9567f0772e8507e5bbbd945b61fdbb6e8ea375bb Author: Paul Blakey Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M lib/netdev-vport.c Log Message: ----------- netdev-vport: Always implement get_ifindex for netdev-vport Always implement get_ifindex without checking if offload is enabled or not as this should not be related. From ovs-dpctl we cannot tell if offload is enabled or not as other_config is not being read. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Signed-off-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/21b159802961...9567f0772e85 From noreply at github.com Wed Aug 9 20:00:11 2017 From: noreply at github.com (GitHub) Date: Wed, 09 Aug 2017 13:00:11 -0700 Subject: [ovs-git] [openvswitch/ovs] 87da4e: Remove duplicate description about Experimenter cl... Message-ID: <598b69cb42154_73663fd70393dc3480250@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 87da4e2f6b9a4a91ba906e0ec6964690a5be1afa https://github.com/openvswitch/ovs/commit/87da4e2f6b9a4a91ba906e0ec6964690a5be1afa Author: Yi Yang Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M lib/meta-flow.xml Log Message: ----------- Remove duplicate description about Experimenter classes commit 3d2fbd70bda514f7327970b859663f34f994290c brought duplicate description about Experimenter classes ONFOXM_ET and NXOXM_NSH in lib/meta-flow.xml, branch-2.8 has the same issue. Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff From noreply at github.com Wed Aug 9 20:00:22 2017 From: noreply at github.com (GitHub) Date: Wed, 09 Aug 2017 13:00:22 -0700 Subject: [ovs-git] [openvswitch/ovs] 05982b: Remove duplicate description about Experimenter cl... Message-ID: <598b69d64e36b_4dfb3fc38cd4fc301354a@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 05982b1cb0ad47fa6cfa637b7b6fea3e5c16b403 https://github.com/openvswitch/ovs/commit/05982b1cb0ad47fa6cfa637b7b6fea3e5c16b403 Author: Yi Yang Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M lib/meta-flow.xml Log Message: ----------- Remove duplicate description about Experimenter classes commit 3d2fbd70bda514f7327970b859663f34f994290c brought duplicate description about Experimenter classes ONFOXM_ET and NXOXM_NSH in lib/meta-flow.xml, branch-2.8 has the same issue. Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff From noreply at github.com Wed Aug 9 20:07:04 2017 From: noreply at github.com (GitHub) Date: Wed, 09 Aug 2017 13:07:04 -0700 Subject: [ovs-git] [openvswitch/ovs] f88ee3: ofproto-dpif-ipfix: Use common OVS functions for g... Message-ID: <598b6b68d5625_405d3fda29dbdc2c965ad@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: f88ee3a599461f390bce7d0b00c182d7a1f5cb6e https://github.com/openvswitch/ovs/commit/f88ee3a599461f390bce7d0b00c182d7a1f5cb6e Author: Ben Pfaff Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M ofproto/ofproto-dpif-ipfix.c Log Message: ----------- ofproto-dpif-ipfix: Use common OVS functions for getting current time. OVS has common infrastructure functions for getting the current time, but this code was not using them. It is not clear why, so this commit changes it to use them. Signed-off-by: Ben Pfaff Acked-by: Andy Zhou From noreply at github.com Wed Aug 9 20:08:51 2017 From: noreply at github.com (GitHub) Date: Wed, 09 Aug 2017 13:08:51 -0700 Subject: [ovs-git] [openvswitch/ovs] e7164d: python: make python idl unicode-tolerant Message-ID: <598b6bd31e6c0_1c5883f817bfbbc384833c@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: e7164d96bcbcf79044a93f6e7acc68f05d8e3945 https://github.com/openvswitch/ovs/commit/e7164d96bcbcf79044a93f6e7acc68f05d8e3945 Author: Lance Richardson Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M python/ovs/json.py M python/ovs/jsonrpc.py M python/ovs/stream.py M tests/ovsdb-idl.at M tests/test-ovsdb.py Log Message: ----------- python: make python idl unicode-tolerant Ensure that JSON is utf-8 encoded and that bytes sent/received on the stream sockets are in utf-8 form. Add a test case to verify that unicode data can be sent/received successfully using Python IDL module. Co-authored-by: Terry Wilson Signed-off-by: Terry Wilson Signed-off-by: Lance Richardson Signed-off-by: Russell Bryant From noreply at github.com Wed Aug 9 20:09:18 2017 From: noreply at github.com (GitHub) Date: Wed, 09 Aug 2017 13:09:18 -0700 Subject: [ovs-git] [openvswitch/ovs] 6da17b: python: make python idl unicode-tolerant Message-ID: <598b6bee5fd08_1d4733fc4ff5cfc34334a9@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 6da17b7e27d3e550012a2052b249878694fd1092 https://github.com/openvswitch/ovs/commit/6da17b7e27d3e550012a2052b249878694fd1092 Author: Lance Richardson Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M python/ovs/json.py M python/ovs/jsonrpc.py M python/ovs/stream.py M tests/ovsdb-idl.at M tests/test-ovsdb.py Log Message: ----------- python: make python idl unicode-tolerant Ensure that JSON is utf-8 encoded and that bytes sent/received on the stream sockets are in utf-8 form. Add a test case to verify that unicode data can be sent/received successfully using Python IDL module. Co-authored-by: Terry Wilson Signed-off-by: Terry Wilson Signed-off-by: Lance Richardson Signed-off-by: Russell Bryant From noreply at github.com Wed Aug 9 20:11:04 2017 From: noreply at github.com (GitHub) Date: Wed, 09 Aug 2017 13:11:04 -0700 Subject: [ovs-git] [openvswitch/ovs] 91a322: python: make python idl unicode-tolerant Message-ID: <598b6c58930be_4b273fea5d337c2875c8@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: 91a322a3ac91c4e47afd6f9a92eedeeb1a61d205 https://github.com/openvswitch/ovs/commit/91a322a3ac91c4e47afd6f9a92eedeeb1a61d205 Author: Lance Richardson Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M python/ovs/json.py M python/ovs/jsonrpc.py M python/ovs/stream.py M tests/ovsdb-idl.at M tests/test-ovsdb.py Log Message: ----------- python: make python idl unicode-tolerant Ensure that JSON is utf-8 encoded and that bytes sent/received on the stream sockets are in utf-8 form. Add a test case to verify that unicode data can be sent/received successfully using Python IDL module. Co-authored-by: Terry Wilson Signed-off-by: Terry Wilson Signed-off-by: Lance Richardson Signed-off-by: Russell Bryant From noreply at github.com Wed Aug 9 20:47:37 2017 From: noreply at github.com (GitHub) Date: Wed, 09 Aug 2017 13:47:37 -0700 Subject: [ovs-git] [openvswitch/ovs] 79e717: travis: Explicitly disable LLVM for sparse build. Message-ID: <598b74e9c43d2_e0f3f99299a5c34445b@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: 79e717836cdb17a7e66cc3af30e26a155944218e https://github.com/openvswitch/ovs/commit/79e717836cdb17a7e66cc3af30e26a155944218e Author: Ben Pfaff Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M .travis/linux-prepare.sh Log Message: ----------- travis: Explicitly disable LLVM for sparse build. Newer travis environments claim to have LLVM support (llvm-config exists and works) but in reality don't, which prevents sparse from building and later parts of the build from succeeding. Signed-off-by: Ben Pfaff Acked-by: Justin Pettit From noreply at github.com Wed Aug 9 20:47:42 2017 From: noreply at github.com (GitHub) Date: Wed, 09 Aug 2017 13:47:42 -0700 Subject: [ovs-git] [openvswitch/ovs] 68c8eb: travis: Explicitly disable LLVM for sparse build. Message-ID: <598b74ee71da0_73603fbc46f9bc34199bf@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.6 Home: https://github.com/openvswitch/ovs Commit: 68c8eb7b2a6cdb32566d7a5fa32afbddd6124138 https://github.com/openvswitch/ovs/commit/68c8eb7b2a6cdb32566d7a5fa32afbddd6124138 Author: Ben Pfaff Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M .travis/linux-prepare.sh Log Message: ----------- travis: Explicitly disable LLVM for sparse build. Newer travis environments claim to have LLVM support (llvm-config exists and works) but in reality don't, which prevents sparse from building and later parts of the build from succeeding. Signed-off-by: Ben Pfaff Acked-by: Justin Pettit From noreply at github.com Wed Aug 9 22:57:31 2017 From: noreply at github.com (GitHub) Date: Wed, 09 Aug 2017 15:57:31 -0700 Subject: [ovs-git] [openvswitch/ovs] 6595cb: dpif: Clean up netdev_ports map on dpif_close(). Message-ID: <598b935b57160_77e43f92d1101c30255ad@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 6595cb95a4a9734a61711cb227a6d86d00b0e649 https://github.com/openvswitch/ovs/commit/6595cb95a4a9734a61711cb227a6d86d00b0e649 Author: Joe Stringer Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M lib/dpif.c Log Message: ----------- dpif: Clean up netdev_ports map on dpif_close(). Commit 32b77c316d9982("dpif: Save added ports in a port map.") introduced tracking of all dpif ports by taking a reference on each available netdev when the dpif is opened, but it failed to clear out and release references to these netdevs when the dpif is closed. One of the problems introduced by this was that upon clean exit of ovs-vswitchd via "ovs-appctl exit --cleanup", the "ovs-netdev" device was not deleted. This which could cause problems in subsequent start up. Commit 5119e258da92 ("dpif: Fix cleanup of userspace datapath.") fixed this particular problem by not adding such devices to the netdev_ports map, but the referencing/unreferencing upon dpif_open()/dpif_close() is still not balanced. Balance the referencing of netdevs by clearing these during dpif_close(). Fixes: 32b77c316d9982("dpif: Save added ports in a port map.") Signed-off-by: Joe Stringer Acked-by: Andy Zhou From noreply at github.com Wed Aug 9 23:57:13 2017 From: noreply at github.com (GitHub) Date: Wed, 09 Aug 2017 16:57:13 -0700 Subject: [ovs-git] [openvswitch/ovs] df3a6d: netdev-dummy: Fix minor style variation. Message-ID: <598ba159497fd_498d3ffb22375c3c351e8@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: df3a6d503e0f892c8c5ddcb7c9454bfab6079444 https://github.com/openvswitch/ovs/commit/df3a6d503e0f892c8c5ddcb7c9454bfab6079444 Author: Joe Stringer Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M lib/netdev-dummy.c Log Message: ----------- netdev-dummy: Fix minor style variation. Signed-off-by: Joe Stringer Acked-by: Ben Pfaff Commit: 09a21284b6bc1b304302bcf4ac48eac24e097df5 https://github.com/openvswitch/ovs/commit/09a21284b6bc1b304302bcf4ac48eac24e097df5 Author: Joe Stringer Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M ofproto/ofproto-dpif-ipfix.c Log Message: ----------- ofproto-dpif-ipfix: Fix minor style variation. Signed-off-by: Joe Stringer Acked-by: Ben Pfaff Commit: 13ad61c46e8a8f6b620818d30bfd855537ffe9e7 https://github.com/openvswitch/ovs/commit/13ad61c46e8a8f6b620818d30bfd855537ffe9e7 Author: Joe Stringer Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M ovn/northd/ovn-northd.c Log Message: ----------- ovn-northd: Fix minor style variation. Signed-off-by: Joe Stringer Acked-by: Ben Pfaff Commit: 0d7b16daea50e16e51ace3ba5b7f6617d5954183 https://github.com/openvswitch/ovs/commit/0d7b16daea50e16e51ace3ba5b7f6617d5954183 Author: Joe Stringer Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M utilities/checkpatch.py Log Message: ----------- checkpatch: Check for infix operator whitespace. The 'Expressions' section of the coding style specifies that one space should be on either side of infix binary and ternary operators. This adds a check to checkpatch.py for most of these. The regex won't match if there are speech marks on the line, because the style should not apply to the contents of strings. This check is left at warning level because there isn't a good way to determine whether a line is within a multiline comment or string, so it will occasionally flag such lines which contain hyphenated words. Signed-off-by: Joe Stringer Acked-by: Ben Pfaff Commit: bcd93351fc2439924da2faea49e279dcd75df266 https://github.com/openvswitch/ovs/commit/bcd93351fc2439924da2faea49e279dcd75df266 Author: Joe Stringer Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M utilities/checkpatch.py Log Message: ----------- checkpatch: Fix matching on C filenames. Most of the prerequisite checks so far matched on filenames that ended in some character followed by 'c' or 'h', rather than a filename that ends in '.c' or '.h'. Fix this. Signed-off-by: Joe Stringer Acked-by: Ben Pfaff Commit: 12f62e9df6d58f45320eb4f4f54f5ab8b0cdd8e2 https://github.com/openvswitch/ovs/commit/12f62e9df6d58f45320eb4f4f54f5ab8b0cdd8e2 Author: Joe Stringer Date: 2017-08-09 (Wed, 09 Aug 2017) Changed paths: M utilities/checkpatch.py Log Message: ----------- checkpatch: Check for trailing operators. The style guide states that lines should not end with '?' or ':'. Check for this and report an error. Signed-off-by: Joe Stringer Acked-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/6595cb95a4a9...12f62e9df6d5 From noreply at github.com Thu Aug 10 18:18:33 2017 From: noreply at github.com (GitHub) Date: Thu, 10 Aug 2017 11:18:33 -0700 Subject: [ovs-git] [openvswitch/ovs] ea5dbd: redhat: add vfio udev rules Message-ID: <598ca37914a41_4a793fb98a0c5c281013da@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: ea5dbd792d7b3cd12339517f7aa042161970a477 https://github.com/openvswitch/ovs/commit/ea5dbd792d7b3cd12339517f7aa042161970a477 Author: aaron conole Date: 2017-08-10 (Thu, 10 Aug 2017) Changed paths: M rhel/automake.mk M rhel/openvswitch-fedora.spec.in A rhel/usr_lib_udev_rules.d_91-vfio.rules Log Message: ----------- redhat: add vfio udev rules This commit builds on the non-root ovs work and adds a udev rule which will automatically set the group permissions of vfio devices. Fixes: e3e738a3d058 ("redhat: allow dpdk to also run as non-root user") Signed-off-by: Aaron Conole Signed-off-by: Russell Bryant From noreply at github.com Thu Aug 10 18:18:53 2017 From: noreply at github.com (GitHub) Date: Thu, 10 Aug 2017 11:18:53 -0700 Subject: [ovs-git] [openvswitch/ovs] 7b6ba9: redhat: add vfio udev rules Message-ID: <598ca38de9527_3d4c3fcc8534bc3c1026d1@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 7b6ba92b1d38dd2114324448aae3b78b5a546c73 https://github.com/openvswitch/ovs/commit/7b6ba92b1d38dd2114324448aae3b78b5a546c73 Author: aaron conole Date: 2017-08-10 (Thu, 10 Aug 2017) Changed paths: M rhel/automake.mk M rhel/openvswitch-fedora.spec.in A rhel/usr_lib_udev_rules.d_91-vfio.rules Log Message: ----------- redhat: add vfio udev rules This commit builds on the non-root ovs work and adds a udev rule which will automatically set the group permissions of vfio devices. Fixes: e3e738a3d058 ("redhat: allow dpdk to also run as non-root user") Signed-off-by: Aaron Conole Signed-off-by: Russell Bryant From noreply at github.com Thu Aug 10 20:41:48 2017 From: noreply at github.com (GitHub) Date: Thu, 10 Aug 2017 13:41:48 -0700 Subject: [ovs-git] [openvswitch/ovs] f8121b: dp-packet: Reset DPDK hwol flags on init. Message-ID: <598cc50cec259_49ec3ff1a1853c34399eb@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: f8121b3912f882c5f970cbcbbfde746cccce9aac https://github.com/openvswitch/ovs/commit/f8121b3912f882c5f970cbcbbfde746cccce9aac Author: Darrell Ball Date: 2017-08-10 (Thu, 10 Aug 2017) Changed paths: M lib/dp-packet.c M lib/dp-packet.h M lib/netdev-dpdk.c Log Message: ----------- dp-packet: Reset DPDK hwol flags on init. Reset the DPDK hwol flags in dp_packet_init_. The new hwol bad checksum flag is uninitialized for non-dpdk ports and this is noticed as test failures using netdev-dummy ports, when built with the --with-dpdk flag set. Hence, in this case, packets may be falsely marked as having a bad checksum. The existing APIs are simplified at the same time by making them specific to either DPDK or otherwise; they also now manage a single field. Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2017-August/045081.html Fixes: 7451af618e0d ("dp-packet : Update DPDK rx checksum validation functions.") CC: Sugesh Chandran Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff From noreply at github.com Thu Aug 10 20:41:59 2017 From: noreply at github.com (GitHub) Date: Thu, 10 Aug 2017 13:41:59 -0700 Subject: [ovs-git] [openvswitch/ovs] 3d0c4b: dp-packet: Reset DPDK hwol flags on init. Message-ID: <598cc5172b08d_ef53feaabbb9c2c72916@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 3d0c4b1b2ec36f64d321db18441a69aaede7dfc0 https://github.com/openvswitch/ovs/commit/3d0c4b1b2ec36f64d321db18441a69aaede7dfc0 Author: Darrell Ball Date: 2017-08-10 (Thu, 10 Aug 2017) Changed paths: M lib/dp-packet.c M lib/dp-packet.h M lib/netdev-dpdk.c Log Message: ----------- dp-packet: Reset DPDK hwol flags on init. Reset the DPDK hwol flags in dp_packet_init_. The new hwol bad checksum flag is uninitialized for non-dpdk ports and this is noticed as test failures using netdev-dummy ports, when built with the --with-dpdk flag set. Hence, in this case, packets may be falsely marked as having a bad checksum. The existing APIs are simplified at the same time by making them specific to either DPDK or otherwise; they also now manage a single field. Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2017-August/045081.html Fixes: 7451af618e0d ("dp-packet : Update DPDK rx checksum validation functions.") CC: Sugesh Chandran Signed-off-by: Darrell Ball Signed-off-by: Ben Pfaff From noreply at github.com Thu Aug 10 20:44:47 2017 From: noreply at github.com (GitHub) Date: Thu, 10 Aug 2017 13:44:47 -0700 Subject: [ovs-git] [openvswitch/ovs] fc56f5: netdev-dpdk: include dpdk PCI header directly Message-ID: <598cc5bf3a041_1d1bd3f81096b7c3098873@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: fc56f5e0f5fa2e185430a2c90df06d06b677bbd5 https://github.com/openvswitch/ovs/commit/fc56f5e0f5fa2e185430a2c90df06d06b677bbd5 Author: Aaron Conole Date: 2017-08-10 (Thu, 10 Aug 2017) Changed paths: M lib/netdev-dpdk.c Log Message: ----------- netdev-dpdk: include dpdk PCI header directly As part of a devargs rework in DPDK, the PCI header file was removed, and needs to be directly included. This isn't required to build with 17.05 or earlier, but will be required should a future update happen. Signed-off-by: Aaron Conole Signed-off-by: Ben Pfaff Tested-By: Timothy Redaelli Acked-by: Ciara Loftus From noreply at github.com Thu Aug 10 20:45:01 2017 From: noreply at github.com (GitHub) Date: Thu, 10 Aug 2017 13:45:01 -0700 Subject: [ovs-git] [openvswitch/ovs] 3631ed: netdev-dpdk: include dpdk PCI header directly Message-ID: <598cc5cde1ba2_7a213f81a0437c3479448@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 3631ed2d996ee8ec6a57a668f0233598bb7fe7d7 https://github.com/openvswitch/ovs/commit/3631ed2d996ee8ec6a57a668f0233598bb7fe7d7 Author: Aaron Conole Date: 2017-08-10 (Thu, 10 Aug 2017) Changed paths: M lib/netdev-dpdk.c Log Message: ----------- netdev-dpdk: include dpdk PCI header directly As part of a devargs rework in DPDK, the PCI header file was removed, and needs to be directly included. This isn't required to build with 17.05 or earlier, but will be required should a future update happen. Signed-off-by: Aaron Conole Signed-off-by: Ben Pfaff Tested-By: Timothy Redaelli Acked-by: Ciara Loftus From noreply at github.com Thu Aug 10 20:47:03 2017 From: noreply at github.com (GitHub) Date: Thu, 10 Aug 2017 13:47:03 -0700 Subject: [ovs-git] [openvswitch/ovs] 290488: travis: parallel builds and tests Message-ID: <598cc6474604f_4c433ff89103fc402501d@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 2904883c27a5804c8377363c2706e6842c6bf3c7 https://github.com/openvswitch/ovs/commit/2904883c27a5804c8377363c2706e6842c6bf3c7 Author: Lance Richardson Date: 2017-08-10 (Thu, 10 Aug 2017) Changed paths: M .travis/linux-build.sh Log Message: ----------- travis: parallel builds and tests Some recent travis builds have failed due to having exceeded the per-job time limit of 50 minutes. This change enables parallel builds and parallel test execution in order to reduce overall execution time, and will hopefully allow this class of build failures to be avoided. Since the travis build environment is provisioned with two CPUs, use -j2 for builds and -j4 for tests. Testing in a cloned repository shows slightly more than a 50% reduction in overall test time. Signed-off-by: Lance Richardson Signed-off-by: Ben Pfaff From noreply at github.com Thu Aug 10 21:09:00 2017 From: noreply at github.com (GitHub) Date: Thu, 10 Aug 2017 14:09:00 -0700 Subject: [ovs-git] [openvswitch/ovs] 0b31b6: sandbox: Add ports to br-int in ovn-setup. Message-ID: <598ccb6c79f93_1cc683ffa4dcb5c3c3252e@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 0b31b69fea1b86dee71e292342ec607ff5821e31 https://github.com/openvswitch/ovs/commit/0b31b69fea1b86dee71e292342ec607ff5821e31 Author: Russell Bryant Date: 2017-08-10 (Thu, 10 Aug 2017) Changed paths: M tutorial/ovn-setup.sh Log Message: ----------- sandbox: Add ports to br-int in ovn-setup. ovs-sandbox comes with a script to quickly set up a simple OVN configuration, ovn-setup.sh. This script set up config in the OVN northbound database, but didn't create the corresponding ports on br-int. Add that to save another step in provisioning this simple environment. Add "ovn-sbctl show" output as well, to follow the existing "ovn-nbctl show" output. Signed-off-by: Russell Bryant Acked-by: Ben Pfaff From noreply at github.com Fri Aug 11 15:56:19 2017 From: noreply at github.com (GitHub) Date: Fri, 11 Aug 2017 08:56:19 -0700 Subject: [ovs-git] [openvswitch/ovs] f3bba0: travis: parallel builds and tests Message-ID: <598dd3a32c893_2fec3f993e5adc3443715@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: f3bba028fe4a4669ca7deb5e01063ca4a488a4bd https://github.com/openvswitch/ovs/commit/f3bba028fe4a4669ca7deb5e01063ca4a488a4bd Author: Lance Richardson Date: 2017-08-11 (Fri, 11 Aug 2017) Changed paths: M .travis/linux-build.sh Log Message: ----------- travis: parallel builds and tests Some recent travis builds have failed due to having exceeded the per-job time limit of 50 minutes. This change enables parallel builds and parallel test execution in order to reduce overall execution time, and will hopefully allow this class of build failures to be avoided. Since the travis build environment is provisioned with two CPUs, use -j2 for builds and -j4 for tests. Testing in a cloned repository shows slightly more than a 50% reduction in overall test time. Signed-off-by: Lance Richardson Signed-off-by: Ben Pfaff From noreply at github.com Fri Aug 11 16:47:15 2017 From: noreply at github.com (GitHub) Date: Fri, 11 Aug 2017 09:47:15 -0700 Subject: [ovs-git] [openvswitch/ovs] c8d0f3: netdev: Free ifidx mapping in netdev_ports_remove(... Message-ID: <598ddf9386a3d_4bb93fb8accd9c2852399@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: c8d0f32a6045af69aefd72c35b2eb92dd972288f https://github.com/openvswitch/ovs/commit/c8d0f32a6045af69aefd72c35b2eb92dd972288f Author: Joe Stringer Date: 2017-08-11 (Fri, 11 Aug 2017) Changed paths: M lib/netdev.c Log Message: ----------- netdev: Free ifidx mapping in netdev_ports_remove(). Previously, netdev_ports_insert() would allocate and insert an ifindex->odp_port mapping, but netdev_ports_remove() would never remove the mapping or free the mapping structure. This patch fixes these up. Fixes: 32b77c316d9982("dpif: Save added ports in a port map.") Reported-by: Andy Zhou Signed-off-by: Joe Stringer Acked-by: Andy Zhou From noreply at github.com Fri Aug 11 17:02:03 2017 From: noreply at github.com (GitHub) Date: Fri, 11 Aug 2017 10:02:03 -0700 Subject: [ovs-git] [openvswitch/ovs] bed324: netdev: Free ifidx mapping in netdev_ports_remove(... Message-ID: <598de30befd17_142b93fc9c9929c309134@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: bed324c813587fa40aa767a01912a7d6e2794b4a https://github.com/openvswitch/ovs/commit/bed324c813587fa40aa767a01912a7d6e2794b4a Author: Joe Stringer Date: 2017-08-11 (Fri, 11 Aug 2017) Changed paths: M lib/netdev.c Log Message: ----------- netdev: Free ifidx mapping in netdev_ports_remove(). Previously, netdev_ports_insert() would allocate and insert an ifindex->odp_port mapping, but netdev_ports_remove() would never remove the mapping or free the mapping structure. This patch fixes these up. >From master commit c8d0f32a6045af69aefd72c35b2eb92dd972288f. Fixes: 32b77c316d9982("dpif: Save added ports in a port map.") Reported-by: Andy Zhou Signed-off-by: Joe Stringer Acked-by: Andy Zhou From noreply at github.com Fri Aug 11 18:44:32 2017 From: noreply at github.com (GitHub) Date: Fri, 11 Aug 2017 11:44:32 -0700 Subject: [ovs-git] [openvswitch/ovs] 2517aa: compat: Update tc compatibility header Message-ID: <598dfb10938ba_48123fc60adf7c347282e@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 2517aa5a6a38c4e00e8a0774b8ecdde30cb0fcdb https://github.com/openvswitch/ovs/commit/2517aa5a6a38c4e00e8a0774b8ecdde30cb0fcdb Author: Paul Blakey Date: 2017-08-11 (Fri, 11 Aug 2017) Changed paths: M acinclude.m4 M include/linux/pkt_cls.h Log Message: ----------- compat: Update tc compatibility header Update to include up to flower ttl matching. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Acked-by: Simon Horman Signed-off-by: Joe Stringer Commit: 0b4b5203d12e8a97e594129bd0c72978eead5fe6 https://github.com/openvswitch/ovs/commit/0b4b5203d12e8a97e594129bd0c72978eead5fe6 Author: Paul Blakey Date: 2017-08-11 (Fri, 11 Aug 2017) Changed paths: M lib/tc.c M lib/tc.h Log Message: ----------- tc: Add ip layer ttl matching Add matching on ip layer ttl, to be used later. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Acked-by: Simon Horman Signed-off-by: Joe Stringer Commit: c489ad67e416a34c5e60ddc962612820197b423b https://github.com/openvswitch/ovs/commit/c489ad67e416a34c5e60ddc962612820197b423b Author: Paul Blakey Date: 2017-08-11 (Fri, 11 Aug 2017) Changed paths: M include/openvswitch/match.h M lib/match.c Log Message: ----------- match: Add helper function to set nw_ttl with mask Add help function match_set_nw_ttl_masked() Will be used later to set ttl value. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Acked-by: Simon Horman Signed-off-by: Joe Stringer Commit: ab7ecf266b0ae9a9770657cc59359004e300b63d https://github.com/openvswitch/ovs/commit/ab7ecf266b0ae9a9770657cc59359004e300b63d Author: Paul Blakey Date: 2017-08-11 (Fri, 11 Aug 2017) Changed paths: M lib/netdev-tc-offloads.c Log Message: ----------- netdev-tc-offloads: Add nw_ttl matching using flower Add matching (put/dump) on ip layer ttl. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Acked-by: Simon Horman Signed-off-by: Joe Stringer Commit: 7cb324123387deca85af45bd9c1649257b40c7ea https://github.com/openvswitch/ovs/commit/7cb324123387deca85af45bd9c1649257b40c7ea Author: Paul Blakey Date: 2017-08-11 (Fri, 11 Aug 2017) Changed paths: M lib/odp-util.c Log Message: ----------- odp-util: Put tcp_flags value to netlink if value is 0 If tcp_flags value is 0 it isn't put to netlink, even if mask isn't zero. Fix that so we can have matching on value 0. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Acked-by: Simon Horman Signed-off-by: Joe Stringer Commit: cd0810438bcd4b8f5edaeaa9adefc366b3f12891 https://github.com/openvswitch/ovs/commit/cd0810438bcd4b8f5edaeaa9adefc366b3f12891 Author: Paul Blakey Date: 2017-08-11 (Fri, 11 Aug 2017) Changed paths: M lib/tc.c M lib/tc.h Log Message: ----------- tc: Add matching on tcp flags To be used later for offloading rules matching on tcp_flags. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Acked-by: Simon Horman Signed-off-by: Joe Stringer Commit: f2698407437636c8c53c5e03e5709682a3809dbd https://github.com/openvswitch/ovs/commit/f2698407437636c8c53c5e03e5709682a3809dbd Author: Paul Blakey Date: 2017-08-11 (Fri, 11 Aug 2017) Changed paths: M lib/netdev-tc-offloads.c Log Message: ----------- netdev-tc-offloads: Offload match on tcp_flags Add support to offload rules matching on tcp_flags. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Acked-by: Simon Horman Signed-off-by: Joe Stringer Compare: https://github.com/openvswitch/ovs/compare/c8d0f32a6045...f26984074376 From noreply at github.com Tue Aug 15 21:57:21 2017 From: noreply at github.com (GitHub) Date: Tue, 15 Aug 2017 14:57:21 -0700 Subject: [ovs-git] [openvswitch/ovs] 3eb142: ovsdb-idl: Avoid class declaration. Message-ID: <59936e4149759_70493f85bb8fdc2c164be@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 3eb142335321b16c255e8fc8ba57d13ea74dd20c https://github.com/openvswitch/ovs/commit/3eb142335321b16c255e8fc8ba57d13ea74dd20c Author: Joe Stringer Date: 2017-08-15 (Tue, 15 Aug 2017) Changed paths: M lib/db-ctl-base.c M lib/ovsdb-idl-provider.h M lib/ovsdb-idl.c M ovsdb/ovsdb-idlc.in Log Message: ----------- ovsdb-idl: Avoid class declaration. In C++, 'class' is a keyword. If this is used as the name for a field, then C++ compilers can get confused about the context and fail to compile references to such fields. Rename the field to 'class_' to avoid this issue. Signed-off-by: Joe Stringer Acked-by: Ben Pfaff Commit: c6e5d064a4f37a66ca6220ee9dd2bfa48035c103 https://github.com/openvswitch/ovs/commit/c6e5d064a4f37a66ca6220ee9dd2bfa48035c103 Author: Joe Stringer Date: 2017-08-15 (Tue, 15 Aug 2017) Changed paths: M lib/ovsdb-idl-provider.h M lib/ovsdb-idl.c M ovsdb/ovsdb-idlc.in Log Message: ----------- ovsdb-idl: Avoid mutable type specifier. In C++, 'mutable' is a keyword. If this is used as the name for a field, then C++ compilers can get confused about the context and fail to compile references to such fields. Rename the field to 'is_mutable' to avoid this issue. Signed-off-by: Joe Stringer Acked-by: Ben Pfaff Commit: fa50ab0bfbbb63e37813c33613b8c61536314253 https://github.com/openvswitch/ovs/commit/fa50ab0bfbbb63e37813c33613b8c61536314253 Author: Joe Stringer Date: 2017-08-15 (Tue, 15 Aug 2017) Changed paths: M lib/ovsdb-data.h M lib/ovsdb-idl-provider.h M lib/ovsdb-idl.c Log Message: ----------- ovsdb-idl: Avoid new expression. In C++, 'new' is a keyword. If this is used as the name for a field, then C++ compilers can get confused about the context and fail to compile references to such fields. Rename the field to 'new_datum' to avoid this issue. Signed-off-by: Joe Stringer Acked-by: Ben Pfaff Commit: 4e0b4acca2ab294a07836684d0726187b3cf7174 https://github.com/openvswitch/ovs/commit/4e0b4acca2ab294a07836684d0726187b3cf7174 Author: Joe Stringer Date: 2017-08-15 (Tue, 15 Aug 2017) Changed paths: M lib/ovsdb-data.h M lib/ovsdb-idl-provider.h M lib/ovsdb-idl.c Log Message: ----------- ovsdb-idl: Rename 'old' to 'old_datum'. Now that the 'new' datum is named 'new_datum', be more consistent by renaming 'old' to 'old_datum' to match. Signed-off-by: Joe Stringer Acked-by: Ben Pfaff Compare: https://github.com/openvswitch/ovs/compare/f26984074376...4e0b4acca2ab From noreply at github.com Tue Aug 15 23:48:28 2017 From: noreply at github.com (GitHub) Date: Tue, 15 Aug 2017 16:48:28 -0700 Subject: [ovs-git] [openvswitch/ovs] 46ccfa: tests: Put maximum timeout on netcat calls. Message-ID: <5993884c14be9_798f3fadf1a6bc2c775a@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 46ccfadd90998ebd46b68906191743010008c1a9 https://github.com/openvswitch/ovs/commit/46ccfadd90998ebd46b68906191743010008c1a9 Author: Joe Stringer Date: 2017-08-15 (Tue, 15 Aug 2017) Changed paths: M tests/atlocal.in Log Message: ----------- tests: Put maximum timeout on netcat calls. This was causing test script execution to hang forever on Ubuntu Zesty. Make sure it times out within 5 seconds, so at least it will fail out properly. Signed-off-by: Joe Stringer Acked-by: Flavio Leitner Commit: 0bedb3d6a8efea4397d7c10efc4aeb3aa6910bcf https://github.com/openvswitch/ovs/commit/0bedb3d6a8efea4397d7c10efc4aeb3aa6910bcf Author: Joe Stringer Date: 2017-08-15 (Tue, 15 Aug 2017) Changed paths: M tests/atlocal.in Log Message: ----------- tests: Comment which netcat version the opts are for. Signed-off-by: Joe Stringer Acked-by: Flavio Leitner Compare: https://github.com/openvswitch/ovs/compare/4e0b4acca2ab...0bedb3d6a8ef From noreply at github.com Wed Aug 16 22:18:12 2017 From: noreply at github.com (GitHub) Date: Wed, 16 Aug 2017 15:18:12 -0700 Subject: [ovs-git] [openvswitch/ovs] 0164f1: netdev-tc-offloads: Add prefix to identify source ... Message-ID: <5994c4a45f16d_65733fc76393dc3488090@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 0164f10cf7f5d5ab8820541b724a614233be0f53 https://github.com/openvswitch/ovs/commit/0164f10cf7f5d5ab8820541b724a614233be0f53 Author: Roi Dayan Date: 2017-08-16 (Wed, 16 Aug 2017) Changed paths: M lib/netdev-tc-offloads.c Log Message: ----------- netdev-tc-offloads: Add prefix to identify source of log msg There is an identical log msg from multiple api calls. Add a prefix to identify the source function of the log msg. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey Signed-off-by: Joe Stringer From noreply at github.com Thu Aug 17 19:48:27 2017 From: noreply at github.com (GitHub) Date: Thu, 17 Aug 2017 12:48:27 -0700 Subject: [ovs-git] [openvswitch/ovs] a19304: datapath-windows: Update Orig Tuple to use ICMP Ty... Message-ID: <5995f30b3e560_76583fc99a911c2c57021@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: a1930487b0c5846885f86fa29fd99f30a00bb5ae https://github.com/openvswitch/ovs/commit/a1930487b0c5846885f86fa29fd99f30a00bb5ae Author: Anand Kumar Date: 2017-08-17 (Thu, 17 Aug 2017) Changed paths: M datapath-windows/ovsext/Conntrack.c M datapath-windows/ovsext/Conntrack.h Log Message: ----------- datapath-windows: Update Orig Tuple to use ICMP Type and Code - Also add some padding for the ct_endpoint's union, so that each member of ct_endpoint's union are of same size. Co-authored-by: Sairam Venugopal Acked-by: Alin Gabriel Serdean Acked-by: Shashank Ram Signed-off-by: Anand Kumar Signed-off-by: Alin Gabriel Serdean Commit: 9fbb4a8a1031879e9c6d4d66ff24a2b034069084 https://github.com/openvswitch/ovs/commit/9fbb4a8a1031879e9c6d4d66ff24a2b034069084 Author: Anand Kumar Date: 2017-08-17 (Thu, 17 Aug 2017) Changed paths: M datapath-windows/ovsext/Conntrack-nat.c Log Message: ----------- datapath-windows: Do not modify port field for ICMP during SNAT/DNAT During SNAT/DNAT, we should not be updating the port field of ct_endpoint struct, as ICMP packets do not have port information. Since port and icmp_id are overlapped in ct_endpoint struct, icmp_id gets changed. As a result, NAT look up fails to find a matching entry. This patch addresses this issue by not modifying icmp_id field during SNAT/DNAT only for ICMP traffic The current NAT module doesn't take the ICMP type/code into account during the lookups. Fix this to make it similar with the other conntrack module. Acked-by: Shashank Ram Acked-by: Alin Gabriel Serdean Signed-off-by: Anand Kumar Signed-off-by: Alin Gabriel Serdean Compare: https://github.com/openvswitch/ovs/compare/0164f10cf7f5...9fbb4a8a1031 From noreply at github.com Thu Aug 17 19:59:48 2017 From: noreply at github.com (GitHub) Date: Thu, 17 Aug 2017 12:59:48 -0700 Subject: [ovs-git] [openvswitch/ovs] 98f539: datapath-windows: Do not modify port field for ICM... Message-ID: <5995f5b46d886_79a93fdb6c7a7c2c1309f@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 98f5393922979644448e1644acee8dcdf053fe10 https://github.com/openvswitch/ovs/commit/98f5393922979644448e1644acee8dcdf053fe10 Author: Anand Kumar Date: 2017-08-17 (Thu, 17 Aug 2017) Changed paths: M datapath-windows/ovsext/Conntrack-nat.c Log Message: ----------- datapath-windows: Do not modify port field for ICMP during SNAT/DNAT During SNAT/DNAT, we should not be updating the port field of ct_endpoint struct, as ICMP packets do not have port information. Since port and icmp_id are overlapped in ct_endpoint struct, icmp_id gets changed. As a result, NAT look up fails to find a matching entry. This patch addresses this issue by not modifying icmp_id field during SNAT/DNAT only for ICMP traffic The current NAT module doesn't take the ICMP type/code into account during the lookups. Fix this to make it similar with the other conntrack module. Acked-by: Alin Gabriel Serdean Acked-by: Shashank Ram Signed-off-by: Anand Kumar Signed-off-by: Alin Gabriel Serdean Commit: ea299ffb5faa3dc95e8ae7d1e85b38b6e6dd4e03 https://github.com/openvswitch/ovs/commit/ea299ffb5faa3dc95e8ae7d1e85b38b6e6dd4e03 Author: Anand Kumar Date: 2017-08-17 (Thu, 17 Aug 2017) Changed paths: M datapath-windows/ovsext/Conntrack.c M datapath-windows/ovsext/Conntrack.h Log Message: ----------- datapath-windows: Update Orig Tuple to use ICMP Type and Code - Also add some padding for the ct_endpoint's union, so that each member of ct_endpoint's union are of same size. Co-authored-by: Sairam Venugopal Signed-off-by: Anand Kumar Acked-by: Shashank Ram Acked-by: Alin Gabriel Serdean Signed-off-by: Alin Gabriel Serdean Compare: https://github.com/openvswitch/ovs/compare/bed324c81358...ea299ffb5faa From noreply at github.com Fri Aug 18 15:08:21 2017 From: noreply at github.com (GitHub) Date: Fri, 18 Aug 2017 08:08:21 -0700 Subject: [ovs-git] [openvswitch/ovs] cf1425: gitignore: Ignore cxx-check Message-ID: <599702e59ef5a_156c3fbacded1c2497453@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: cf14254d2b8767813c08f753c99c4c571e4c9aaa https://github.com/openvswitch/ovs/commit/cf14254d2b8767813c08f753c99c4c571e4c9aaa Author: Xiao Liang Date: 2017-08-18 (Fri, 18 Aug 2017) Changed paths: M .gitignore Log Message: ----------- gitignore: Ignore cxx-check Add cxx-check to .gitignore Signed-off-by: Xiao Liang Signed-off-by: Ben Pfaff From noreply at github.com Fri Aug 18 15:08:38 2017 From: noreply at github.com (GitHub) Date: Fri, 18 Aug 2017 08:08:38 -0700 Subject: [ovs-git] [openvswitch/ovs] 0f9e37: gitignore: Ignore cxx-check Message-ID: <599702f62ae50_76583fc99a911c2c64482@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 0f9e3705944958898f05d84d0882c7efdf2619db https://github.com/openvswitch/ovs/commit/0f9e3705944958898f05d84d0882c7efdf2619db Author: Xiao Liang Date: 2017-08-18 (Fri, 18 Aug 2017) Changed paths: M .gitignore Log Message: ----------- gitignore: Ignore cxx-check Add cxx-check to .gitignore Signed-off-by: Xiao Liang Signed-off-by: Ben Pfaff From noreply at github.com Fri Aug 18 20:13:41 2017 From: noreply at github.com (GitHub) Date: Fri, 18 Aug 2017 13:13:41 -0700 Subject: [ovs-git] [openvswitch/ovs] 225407: python: fix python3 encode/decode on Windows Message-ID: <59974a75f0d03_6f173ff0f0811c28105159@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 2254074e3067fd306c37ac80347ef75075b40a89 https://github.com/openvswitch/ovs/commit/2254074e3067fd306c37ac80347ef75075b40a89 Author: Alin Balutoiu Date: 2017-08-18 (Fri, 18 Aug 2017) Changed paths: M python/ovs/stream.py M python/ovs/winutils.py Log Message: ----------- python: fix python3 encode/decode on Windows Fix double encoding/decoding on data, caused by 'get_decoded_buffer' and 'get_encoded_buffer'. The functions 'get_decoded_buffer' and 'get_encoded_buffer' from winutils have been removed. They are no longer necessary since the buffers received/returned are already in the right form. The necessary encoding has been moved before any sending function (this also includes named pipes send on Windows). Co-authored-by: Alin Serdean Signed-off-by: Alin Balutoiu Signed-off-by: Alin Serdean Acked-by: Lance Richardson Signed-off-by: Russell Bryant Commit: 42253e5e5c86ba7fb4d57952f3bcc19451ccc0b3 https://github.com/openvswitch/ovs/commit/42253e5e5c86ba7fb4d57952f3bcc19451ccc0b3 Author: Alin Balutoiu Date: 2017-08-18 (Fri, 18 Aug 2017) Changed paths: M tests/test-ovsdb.py Log Message: ----------- python: Force file system encoding on cmdline args On Windows, the default file system encoding is 'mbcs' resulting in a bad conversion. To make it cross-platform tolerant use 'sys.getfilesystemencoding()' instead of 'utf-8'. Co-authored-by: Alin Serdean Signed-off-by: Alin Balutoiu Signed-off-by: Alin Serdean Acked-by: Lance Richardson Signed-off-by: Russell Bryant Compare: https://github.com/openvswitch/ovs/compare/cf14254d2b87...42253e5e5c86 From noreply at github.com Fri Aug 18 20:14:22 2017 From: noreply at github.com (GitHub) Date: Fri, 18 Aug 2017 13:14:22 -0700 Subject: [ovs-git] [openvswitch/ovs] a35807: python: fix python3 encode/decode on Windows Message-ID: <59974a9eb9843_e9f3fde48553c304535f@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: a358079fb1ebe1c4117c3eab6bfd432c273ad718 https://github.com/openvswitch/ovs/commit/a358079fb1ebe1c4117c3eab6bfd432c273ad718 Author: Alin Balutoiu Date: 2017-08-18 (Fri, 18 Aug 2017) Changed paths: M python/ovs/stream.py M python/ovs/winutils.py Log Message: ----------- python: fix python3 encode/decode on Windows Fix double encoding/decoding on data, caused by 'get_decoded_buffer' and 'get_encoded_buffer'. The functions 'get_decoded_buffer' and 'get_encoded_buffer' from winutils have been removed. They are no longer necessary since the buffers received/returned are already in the right form. The necessary encoding has been moved before any sending function (this also includes named pipes send on Windows). Co-authored-by: Alin Serdean Signed-off-by: Alin Balutoiu Signed-off-by: Alin Serdean Acked-by: Lance Richardson Signed-off-by: Russell Bryant Commit: dc82e5e8c72309de0ec40d7acf10b641bba82c56 https://github.com/openvswitch/ovs/commit/dc82e5e8c72309de0ec40d7acf10b641bba82c56 Author: Alin Balutoiu Date: 2017-08-18 (Fri, 18 Aug 2017) Changed paths: M tests/test-ovsdb.py Log Message: ----------- python: Force file system encoding on cmdline args On Windows, the default file system encoding is 'mbcs' resulting in a bad conversion. To make it cross-platform tolerant use 'sys.getfilesystemencoding()' instead of 'utf-8'. Co-authored-by: Alin Serdean Signed-off-by: Alin Balutoiu Signed-off-by: Alin Serdean Acked-by: Lance Richardson Signed-off-by: Russell Bryant Compare: https://github.com/openvswitch/ovs/compare/0f9e37059449...dc82e5e8c723 From noreply at github.com Fri Aug 18 20:16:28 2017 From: noreply at github.com (GitHub) Date: Fri, 18 Aug 2017 13:16:28 -0700 Subject: [ovs-git] [openvswitch/ovs] e2c706: python: fix python3 encode/decode on Windows Message-ID: <59974b1c3b464_65f3fb384e21c341300bc@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: e2c7064ca79617ae21f4621f1c9f1c78daaff84b https://github.com/openvswitch/ovs/commit/e2c7064ca79617ae21f4621f1c9f1c78daaff84b Author: Alin Balutoiu Date: 2017-08-18 (Fri, 18 Aug 2017) Changed paths: M python/ovs/stream.py M python/ovs/winutils.py Log Message: ----------- python: fix python3 encode/decode on Windows Fix double encoding/decoding on data, caused by 'get_decoded_buffer' and 'get_encoded_buffer'. The functions 'get_decoded_buffer' and 'get_encoded_buffer' from winutils have been removed. They are no longer necessary since the buffers received/returned are already in the right form. The necessary encoding has been moved before any sending function (this also includes named pipes send on Windows). Co-authored-by: Alin Serdean Signed-off-by: Alin Balutoiu Signed-off-by: Alin Serdean Acked-by: Lance Richardson Signed-off-by: Russell Bryant Commit: 294db1739a3be6da34e79dbf55c2c720fd56ca60 https://github.com/openvswitch/ovs/commit/294db1739a3be6da34e79dbf55c2c720fd56ca60 Author: Alin Balutoiu Date: 2017-08-18 (Fri, 18 Aug 2017) Changed paths: M tests/test-ovsdb.py Log Message: ----------- python: Force file system encoding on cmdline args On Windows, the default file system encoding is 'mbcs' resulting in a bad conversion. To make it cross-platform tolerant use 'sys.getfilesystemencoding()' instead of 'utf-8'. Co-authored-by: Alin Serdean Signed-off-by: Alin Balutoiu Signed-off-by: Alin Serdean Acked-by: Lance Richardson Signed-off-by: Russell Bryant Compare: https://github.com/openvswitch/ovs/compare/79e717836cdb...294db1739a3b From noreply at github.com Fri Aug 18 21:11:05 2017 From: noreply at github.com (GitHub) Date: Fri, 18 Aug 2017 14:11:05 -0700 Subject: [ovs-git] [openvswitch/ovs] 71d90b: dpif: Fix cleanup of netdev_ports map Message-ID: <599757e9e3640_6b093f8f5075bc2c122057@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 71d90be10d255542f058cce6d5bf324631f0059f https://github.com/openvswitch/ovs/commit/71d90be10d255542f058cce6d5bf324631f0059f Author: Roi Dayan Date: 2017-08-18 (Fri, 18 Aug 2017) Changed paths: M lib/dpif.c Log Message: ----------- dpif: Fix cleanup of netdev_ports map Executing dpctl commands from userspace also calls to dpif_open()/dpif_close() but not really creating another dpif but using a clone. As for netdev_ports map is global we avoid adding duplicate entries but also need to make sure we are not removing needed entries. With this commit we make sure only the last dpif close should clean the netdev_ports map. Fixes: 6595cb95a4a9 ("dpif: Clean up netdev_ports map on dpif_close().") Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey Signed-off-by: Joe Stringer Commit: 2e1fca6c7e4f7898b560bca0b64afdad4c240c6f https://github.com/openvswitch/ovs/commit/2e1fca6c7e4f7898b560bca0b64afdad4c240c6f Author: Roi Dayan Date: 2017-08-18 (Fri, 18 Aug 2017) Changed paths: M tests/system-offloads-traffic.at Log Message: ----------- system-offloads-traffic: Add sanity check Doing dump-flows also altering the netdev ports list. So doing it pre the actual test is adding a check to make sure we don't break the that list. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey Signed-off-by: Joe Stringer Compare: https://github.com/openvswitch/ovs/compare/42253e5e5c86...2e1fca6c7e4f From noreply at github.com Mon Aug 21 15:54:53 2017 From: noreply at github.com (GitHub) Date: Mon, 21 Aug 2017 08:54:53 -0700 Subject: [ovs-git] [openvswitch/ovs] 63d91a: ovn: support requested-chassis option for logical ... Message-ID: <599b024d9282c_49aa3fc450e25c4461769@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 63d91afa92ef602fb2abcae1281910966d88d2b7 https://github.com/openvswitch/ovs/commit/63d91afa92ef602fb2abcae1281910966d88d2b7 Author: Lance Richardson Date: 2017-08-21 (Mon, 21 Aug 2017) Changed paths: M ovn/controller/binding.c M ovn/ovn-nb.xml M ovn/ovn-sb.xml M tests/ovn.at Log Message: ----------- ovn: support requested-chassis option for logical switch ports This patch adds support for a "requested-chassis" option for logical switch ports. If set, the only chassis that will claim this port is the chassis identfied by this option; if already bound by another chassis, it will be released. The primary benefit of this enhancement is allowing a CMS to prevent "thrashing" in the southbound database during live migration by keeping the original chassis from attempting to re-bind a port that is in the process of migrating. This would also allow (with some additional work) RBAC to be applied to the Port_Binding table for additional security. Signed-off-by: Lance Richardson Signed-off-by: Russell Bryant From noreply at github.com Mon Aug 21 15:56:20 2017 From: noreply at github.com (GitHub) Date: Mon, 21 Aug 2017 08:56:20 -0700 Subject: [ovs-git] [openvswitch/ovs] f37dc2: ovn: support requested-chassis option for logical ... Message-ID: <599b02a42beed_1a283f985317fc34102549@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: f37dc273243cdc32e74e20a0b97f15c0acebc11e https://github.com/openvswitch/ovs/commit/f37dc273243cdc32e74e20a0b97f15c0acebc11e Author: Lance Richardson Date: 2017-08-21 (Mon, 21 Aug 2017) Changed paths: M ovn/controller/binding.c M ovn/ovn-nb.xml M ovn/ovn-sb.xml M tests/ovn.at Log Message: ----------- ovn: support requested-chassis option for logical switch ports This patch adds support for a "requested-chassis" option for logical switch ports. If set, the only chassis that will claim this port is the chassis identfied by this option; if already bound by another chassis, it will be released. The primary benefit of this enhancement is allowing a CMS to prevent "thrashing" in the southbound database during live migration by keeping the original chassis from attempting to re-bind a port that is in the process of migrating. This would also allow (with some additional work) RBAC to be applied to the Port_Binding table for additional security. Signed-off-by: Lance Richardson Signed-off-by: Russell Bryant From noreply at github.com Mon Aug 21 18:44:34 2017 From: noreply at github.com (GitHub) Date: Mon, 21 Aug 2017 11:44:34 -0700 Subject: [ovs-git] [openvswitch/ovs] 3f9e24: checkpatch: Enforce bracing around conditionals. Message-ID: <599b2a121f8d0_3d043feac922dc30173820@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 3f9e248f6ea57b1b32c35f6e1803c4cadd557220 https://github.com/openvswitch/ovs/commit/3f9e248f6ea57b1b32c35f6e1803c4cadd557220 Author: Joe Stringer Date: 2017-08-21 (Mon, 21 Aug 2017) Changed paths: M utilities/checkpatch.py Log Message: ----------- checkpatch: Enforce bracing around conditionals. The coding style states that BSD-style brace placement should be used, and even single statements should be enclosed. Add checks to checkpatch for this, particularly for 'else' statements. Signed-off-by: Joe Stringer Acked-by: Aaron Conole From noreply at github.com Mon Aug 21 19:49:44 2017 From: noreply at github.com (GitHub) Date: Mon, 21 Aug 2017 12:49:44 -0700 Subject: [ovs-git] [openvswitch/ovs] f6fabc: ofproto-dpif: Mark packets as "untracked" after ca... Message-ID: <599b395849170_394a3fd399c59c3c60952@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: f6fabcc62458d656046c9852ee80fcff3e516e6e https://github.com/openvswitch/ovs/commit/f6fabcc62458d656046c9852ee80fcff3e516e6e Author: Justin Pettit Date: 2017-08-21 (Mon, 21 Aug 2017) Changed paths: M NEWS M lib/ofp-actions.c M ofproto/ofproto-dpif-xlate.c M tests/ofproto-dpif.at M tests/system-traffic.at M utilities/ovs-ofctl.8.in Log Message: ----------- ofproto-dpif: Mark packets as "untracked" after call to ct(). Packet and Connection state is only available to the processing path that follows the "recirc_table" argument of the ct() action. The previous behavior made these states available until the end of the pipeline. This commit changes the behavior so that the Packet and Connection state are cleared for the current processing path whenever ct() is called (in addition to reaching the end of the pipeline.) A future commit will remove the behavior that a "send to controller" action causes all packets for that flow to be handled via the slow-path. The current behavior of connection tracking state makes that difficult due to datapath actions containing multiple OpenFlow rules that may contain different connection tracking states. This change will make that future commit possible. Signed-off-by: Justin Pettit Acked-by: Joe Stringer From noreply at github.com Mon Aug 21 19:55:55 2017 From: noreply at github.com (GitHub) Date: Mon, 21 Aug 2017 12:55:55 -0700 Subject: [ovs-git] [openvswitch/ovs] 8473cf: ofproto-dpif: Mark packets as "untracked" after ca... Message-ID: <599b3acb6ce02_7b53fbd6b199c2890421@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 8473cf69d25c4682cc6f6857b86b490a8c27cbd4 https://github.com/openvswitch/ovs/commit/8473cf69d25c4682cc6f6857b86b490a8c27cbd4 Author: Justin Pettit Date: 2017-08-21 (Mon, 21 Aug 2017) Changed paths: M NEWS M lib/ofp-actions.c M ofproto/ofproto-dpif-xlate.c M tests/ofproto-dpif.at M tests/system-traffic.at M utilities/ovs-ofctl.8.in Log Message: ----------- ofproto-dpif: Mark packets as "untracked" after call to ct(). Packet and Connection state is only available to the processing path that follows the "recirc_table" argument of the ct() action. The previous behavior made these states available until the end of the pipeline. This commit changes the behavior so that the Packet and Connection state are cleared for the current processing path whenever ct() is called (in addition to reaching the end of the pipeline.) A future commit will remove the behavior that a "send to controller" action causes all packets for that flow to be handled via the slow-path. The current behavior of connection tracking state makes that difficult due to datapath actions containing multiple OpenFlow rules that may contain different connection tracking states. This change will make that future commit possible. Signed-off-by: Justin Pettit Acked-by: Joe Stringer From noreply at github.com Wed Aug 23 15:19:20 2017 From: noreply at github.com (GitHub) Date: Wed, 23 Aug 2017 08:19:20 -0700 Subject: [ovs-git] [openvswitch/ovs] e27210: windows, python: Fix event type returned from poll... Message-ID: <599d9cf8293aa_465c3fdfa0fa9c30407c7@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: e272107e5a52f38bbf6c93acef2d892a6bc13b1f https://github.com/openvswitch/ovs/commit/e272107e5a52f38bbf6c93acef2d892a6bc13b1f Author: Alin Balutoiu Date: 2017-08-23 (Wed, 23 Aug 2017) Changed paths: M python/ovs/poller.py Log Message: ----------- windows, python: Fix event type returned from poller The function poll from poller should return a list of tuples containing the events and their types. On Windows the event type is not returned at the moment. Instead of returning zero all the time, we check to see the type of event and we set it accordingly before returning the list. This is used only for debugging purposes inside the function "__log_wakeup" later on. Signed-off-by: Alin Balutoiu Acked-by: Russell Bryant Acked-by: Alin Gabriel Serdean Signed-off-by: Alin Gabriel Serdean From noreply at github.com Wed Aug 23 15:20:10 2017 From: noreply at github.com (GitHub) Date: Wed, 23 Aug 2017 08:20:10 -0700 Subject: [ovs-git] [openvswitch/ovs] e2e31d: windows, python: Fix event type returned from poll... Message-ID: <599d9d2adcc52_1e82e3fb7b5411c2838549@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: e2e31d17f88d14fdabb720cf895bc2b705c8ed9a https://github.com/openvswitch/ovs/commit/e2e31d17f88d14fdabb720cf895bc2b705c8ed9a Author: Alin Balutoiu Date: 2017-08-23 (Wed, 23 Aug 2017) Changed paths: M python/ovs/poller.py Log Message: ----------- windows, python: Fix event type returned from poller The function poll from poller should return a list of tuples containing the events and their types. On Windows the event type is not returned at the moment. Instead of returning zero all the time, we check to see the type of event and we set it accordingly before returning the list. This is used only for debugging purposes inside the function "__log_wakeup" later on. Signed-off-by: Alin Balutoiu Acked-by: Russell Bryant Acked-by: Alin Gabriel Serdean Signed-off-by: Alin Gabriel Serdean From noreply at github.com Wed Aug 23 15:20:52 2017 From: noreply at github.com (GitHub) Date: Wed, 23 Aug 2017 08:20:52 -0700 Subject: [ovs-git] [openvswitch/ovs] 659de1: windows, python: Fix event type returned from poll... Message-ID: <599d9d54d31c1_51b83f96b0ebdc386215d@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: 659de19c7e90ffbaca9caf1cfb27b85ffd3ccd43 https://github.com/openvswitch/ovs/commit/659de19c7e90ffbaca9caf1cfb27b85ffd3ccd43 Author: Alin Balutoiu Date: 2017-08-23 (Wed, 23 Aug 2017) Changed paths: M python/ovs/poller.py Log Message: ----------- windows, python: Fix event type returned from poller The function poll from poller should return a list of tuples containing the events and their types. On Windows the event type is not returned at the moment. Instead of returning zero all the time, we check to see the type of event and we set it accordingly before returning the list. This is used only for debugging purposes inside the function "__log_wakeup" later on. Signed-off-by: Alin Balutoiu Acked-by: Russell Bryant Acked-by: Alin Gabriel Serdean Signed-off-by: Alin Gabriel Serdean From noreply at github.com Wed Aug 23 15:40:27 2017 From: noreply at github.com (GitHub) Date: Wed, 23 Aug 2017 08:40:27 -0700 Subject: [ovs-git] [openvswitch/ovs] ba953e: windows, python: Remove code duplication in send/r... Message-ID: <599da1ebe1a83_abb3f824404dc28119684@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: ba953e1e83d54d000b65aa6ac95821466849626c https://github.com/openvswitch/ovs/commit/ba953e1e83d54d000b65aa6ac95821466849626c Author: Alin Balutoiu Date: 2017-08-23 (Wed, 23 Aug 2017) Changed paths: M python/ovs/stream.py Log Message: ----------- windows, python: Remove code duplication in send/recv functions Move the return value at the end of the function regardless of the pending/non-pending operation. Signed-off-by: Alin Balutoiu Acked-by: Russell Bryant Acked-by: Alin Gabriel Serdean Signed-off-by: Alin Gabriel Serdean From noreply at github.com Wed Aug 23 15:42:50 2017 From: noreply at github.com (GitHub) Date: Wed, 23 Aug 2017 08:42:50 -0700 Subject: [ovs-git] [openvswitch/ovs] 37d69b: windows, python: Remove code duplication in send/r... Message-ID: <599da27aab8db_502e3f88c5051c3881916@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 37d69bd5d8f39f85152eaedb5dbc9c6c6beec9ea https://github.com/openvswitch/ovs/commit/37d69bd5d8f39f85152eaedb5dbc9c6c6beec9ea Author: Alin Balutoiu Date: 2017-08-23 (Wed, 23 Aug 2017) Changed paths: M python/ovs/stream.py Log Message: ----------- windows, python: Remove code duplication in send/recv functions Move the return value at the end of the function regardless of the pending/non-pending operation. Signed-off-by: Alin Balutoiu Acked-by: Russell Bryant Acked-by: Alin Gabriel Serdean Signed-off-by: Alin Gabriel Serdean From noreply at github.com Wed Aug 23 15:43:40 2017 From: noreply at github.com (GitHub) Date: Wed, 23 Aug 2017 08:43:40 -0700 Subject: [ovs-git] [openvswitch/ovs] 0c9e58: windows, python: Remove code duplication in send/r... Message-ID: <599da2ac5df43_ee13fed4b9c7c3c3622f@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: 0c9e58211106932e37f322fb29fce48f794e2ee4 https://github.com/openvswitch/ovs/commit/0c9e58211106932e37f322fb29fce48f794e2ee4 Author: Alin Balutoiu Date: 2017-08-23 (Wed, 23 Aug 2017) Changed paths: M python/ovs/stream.py Log Message: ----------- windows, python: Remove code duplication in send/recv functions Move the return value at the end of the function regardless of the pending/non-pending operation. Signed-off-by: Alin Balutoiu Acked-by: Russell Bryant Acked-by: Alin Gabriel Serdean Signed-off-by: Alin Gabriel Serdean From noreply at github.com Wed Aug 23 19:37:47 2017 From: noreply at github.com (GitHub) Date: Wed, 23 Aug 2017 12:37:47 -0700 Subject: [ovs-git] [openvswitch/ovs] bf4077: datapath-windows: Move OvsCreateNewNBLsFromMultipl... Message-ID: <599dd98b6c7d6_392b3fc61c2b1c2894268@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: bf4077e2cb571584cebcb1b506a34b5f31dc7be0 https://github.com/openvswitch/ovs/commit/bf4077e2cb571584cebcb1b506a34b5f31dc7be0 Author: Shashank Ram Date: 2017-08-23 (Wed, 23 Aug 2017) Changed paths: M datapath-windows/ovsext/BufferMgmt.c M datapath-windows/ovsext/BufferMgmt.h M datapath-windows/ovsext/PacketIO.c Log Message: ----------- datapath-windows: Move OvsCreateNewNBLsFromMultipleNBs to BuggerMgmt Moves function OvsCreateNewNBLsFromMultipleNBs() to BufferMgmt.c to facilitate consumption from outside PacketIO.c. Signed-off-by: Shashank Ram Acked-by: Anand Kumar Acked-by: Alin Gabriel Serdean Signed-off-by: Alin Gabriel Serdean From noreply at github.com Wed Aug 23 19:47:31 2017 From: noreply at github.com (GitHub) Date: Wed, 23 Aug 2017 12:47:31 -0700 Subject: [ovs-git] [openvswitch/ovs] 85924c: datapath-windows: Move OvsCreateNewNBLsFromMultipl... Message-ID: <599ddbd3a6576_75dc3fc7fc635c281882e@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 85924cd7731011b748f888169677e9b0ef82e93f https://github.com/openvswitch/ovs/commit/85924cd7731011b748f888169677e9b0ef82e93f Author: Shashank Ram Date: 2017-08-23 (Wed, 23 Aug 2017) Changed paths: M datapath-windows/ovsext/BufferMgmt.c M datapath-windows/ovsext/BufferMgmt.h M datapath-windows/ovsext/PacketIO.c Log Message: ----------- datapath-windows: Move OvsCreateNewNBLsFromMultipleNBs to BuggerMgmt Moves function OvsCreateNewNBLsFromMultipleNBs() to BufferMgmt.c to facilitate consumption from outside PacketIO.c. Signed-off-by: Shashank Ram Acked-by: Anand Kumar Acked-by: Alin Gabriel Serdean Signed-off-by: Alin Gabriel Serdean From noreply at github.com Wed Aug 23 23:27:03 2017 From: noreply at github.com (GitHub) Date: Wed, 23 Aug 2017 16:27:03 -0700 Subject: [ovs-git] [openvswitch/ovs] b7ab73: datapath: compat: Fix build on RHEL 7.4 Message-ID: <599e0f4773338_2a173fe5c27b5c2c98fd@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: b7ab73163cc88919b8e2a2164add198a09f81017 https://github.com/openvswitch/ovs/commit/b7ab73163cc88919b8e2a2164add198a09f81017 Author: Yi-Hung Wei Date: 2017-08-23 (Wed, 23 Aug 2017) Changed paths: M acinclude.m4 M datapath/linux/compat/include/linux/netdevice.h Log Message: ----------- datapath: compat: Fix build on RHEL 7.4 RHEL 7.4 introduces netdev_master_upper_dev_link_rh() that breaks the backport of OVS kernel module on RHEL 7.4. This patch fixes that issue. Signed-off-by: Yi-Hung Wei Signed-off-by: Joe Stringer Commit: 40e28d1323fdbc4dcaf71cc1ac96af921646e40d https://github.com/openvswitch/ovs/commit/40e28d1323fdbc4dcaf71cc1ac96af921646e40d Author: Yi-Hung Wei Date: 2017-08-23 (Wed, 23 Aug 2017) Changed paths: M tests/atlocal.in Log Message: ----------- atlocal: Document find_l7_lib() When a system traffic is skipped due to 'HAVE_FTP = no' or 'HAVE_TFTP = no', it takes some effort to figure out it is due to missing the required python library. Add some comments around the find_l7_lib(), so that user can figure that out by $ git grep HAVE_FTP. Signed-off-by: Yi-Hung Wei Signed-off-by: Joe Stringer Compare: https://github.com/openvswitch/ovs/compare/bf4077e2cb57...40e28d1323fd From noreply at github.com Wed Aug 23 23:28:03 2017 From: noreply at github.com (GitHub) Date: Wed, 23 Aug 2017 16:28:03 -0700 Subject: [ovs-git] [openvswitch/ovs] 1abeaa: datapath: compat: Fix build on RHEL 7.4 Message-ID: <599e0f8326922_3d123fab8ecdfc345963b@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 1abeaa587961fa11a9de08dfe5dcd96778d6a6ff https://github.com/openvswitch/ovs/commit/1abeaa587961fa11a9de08dfe5dcd96778d6a6ff Author: Yi-Hung Wei Date: 2017-08-23 (Wed, 23 Aug 2017) Changed paths: M acinclude.m4 M datapath/linux/compat/include/linux/netdevice.h Log Message: ----------- datapath: compat: Fix build on RHEL 7.4 RHEL 7.4 introduces netdev_master_upper_dev_link_rh() that breaks the backport of OVS kernel module on RHEL 7.4. This patch fixes that issue. >From master commit b7ab73163cc88919b8e2a2164add198a09f81017. Signed-off-by: Yi-Hung Wei Signed-off-by: Joe Stringer From noreply at github.com Thu Aug 24 19:06:11 2017 From: noreply at github.com (GitHub) Date: Thu, 24 Aug 2017 12:06:11 -0700 Subject: [ovs-git] [openvswitch/ovs] 75f9e0: ovn: Fix BFD error config on gateway Message-ID: <599f23a35550e_1fdc3f8d50bafc3065049@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 75f9e007e7f7eb91461e238f882d1c539c56bb8d https://github.com/openvswitch/ovs/commit/75f9e007e7f7eb91461e238f882d1c539c56bb8d Author: Gao Zhenyu Date: 2017-08-24 (Thu, 24 Aug 2017) Changed paths: M ovn/controller/bfd.c M tests/ovn.at Log Message: ----------- ovn: Fix BFD error config on gateway The bfd_calculate_chassis function calculates gateway's peer datapaths to figure out which tunnel's BFD should be enabled to from the current chassis. Existing algorithm only calculats peer datapaths at one hop, but multiple logical switches and E/W routers could be in the path, making several hops which were not considered on the calculation. It may disable BFD on some gw's tunnel ports. Then a port on a remote ovs cannot send packet out because it believes all remote gateways are down. This patch will go through whole graph and visit all datapath's port which has connection with gateways. Signed-off-by: Zhenyu Gao Acked-by: Venkata Anil Kommaddi Tested-by: Venkata Anil Kommaddi Signed-off-by: Russell Bryant From noreply at github.com Thu Aug 24 19:12:36 2017 From: noreply at github.com (GitHub) Date: Thu, 24 Aug 2017 12:12:36 -0700 Subject: [ovs-git] [openvswitch/ovs] c67117: ovn: Fix BFD error config on gateway Message-ID: <599f252433f3_86a3fdd479c1c38517a8@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: c6711707d05c74284535d7d3cc8488678cffbd2b https://github.com/openvswitch/ovs/commit/c6711707d05c74284535d7d3cc8488678cffbd2b Author: Gao Zhenyu Date: 2017-08-24 (Thu, 24 Aug 2017) Changed paths: M ovn/controller/bfd.c M tests/ovn.at Log Message: ----------- ovn: Fix BFD error config on gateway The bfd_calculate_chassis function calculates gateway's peer datapaths to figure out which tunnel's BFD should be enabled to from the current chassis. Existing algorithm only calculats peer datapaths at one hop, but multiple logical switches and E/W routers could be in the path, making several hops which were not considered on the calculation. It may disable BFD on some gw's tunnel ports. Then a port on a remote ovs cannot send packet out because it believes all remote gateways are down. This patch will go through whole graph and visit all datapath's port which has connection with gateways. Signed-off-by: Zhenyu Gao Acked-by: Venkata Anil Kommaddi Tested-by: Venkata Anil Kommaddi Signed-off-by: Russell Bryant From noreply at github.com Tue Aug 29 15:41:59 2017 From: noreply at github.com (GitHub) Date: Tue, 29 Aug 2017 08:41:59 -0700 Subject: [ovs-git] [openvswitch/ovs] 2fdbcc: nsh: fix an implicit bug in nsh_hdr_len Message-ID: <59a58b4745e2e_705e3fa266403c2c4048a@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 2fdbcc68f6829f2e06875d706a9ab5cdf3c3af3d https://github.com/openvswitch/ovs/commit/2fdbcc68f6829f2e06875d706a9ab5cdf3c3af3d Author: Yi Yang Date: 2017-08-29 (Tue, 29 Aug 2017) Changed paths: M include/openvswitch/nsh.h Log Message: ----------- nsh: fix an implicit bug in nsh_hdr_len Operator '*' will be executed prior to operator '>>', but we expect operator '>>' is executed prior to '*', this patch fixed the issue. Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff From noreply at github.com Tue Aug 29 15:41:48 2017 From: noreply at github.com (GitHub) Date: Tue, 29 Aug 2017 08:41:48 -0700 Subject: [ovs-git] [openvswitch/ovs] bce693: nsh: fix an implicit bug in nsh_hdr_len Message-ID: <59a58b3c5ef2_10de3f8b6088fc2c1033dd@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: bce693e72a4488866dd333a09f94e768dcd8ebaf https://github.com/openvswitch/ovs/commit/bce693e72a4488866dd333a09f94e768dcd8ebaf Author: Yi Yang Date: 2017-08-29 (Tue, 29 Aug 2017) Changed paths: M include/openvswitch/nsh.h Log Message: ----------- nsh: fix an implicit bug in nsh_hdr_len Operator '*' will be executed prior to operator '>>', but we expect operator '>>' is executed prior to '*', this patch fixed the issue. Signed-off-by: Yi Yang Signed-off-by: Ben Pfaff From noreply at github.com Tue Aug 29 20:14:15 2017 From: noreply at github.com (GitHub) Date: Tue, 29 Aug 2017 13:14:15 -0700 Subject: [ovs-git] [openvswitch/ovs] 441cb3: docs/dpdk: Consolidate pmd-cpu-mask references. Message-ID: <59a5cb17692f3_21fb3f9ca8143c44141e9@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 441cb3ebc040e568c91a23cb1cc0c9647c934b81 https://github.com/openvswitch/ovs/commit/441cb3ebc040e568c91a23cb1cc0c9647c934b81 Author: Darrell Ball Date: 2017-08-24 (Thu, 24 Aug 2017) Changed paths: M Documentation/intro/install/dpdk.rst Log Message: ----------- docs/dpdk: Consolidate pmd-cpu-mask references. The DPDK introductory documentation has various references to pmd-cpu-mask, including a section devoted to it. These parts of the documentation seemed to have been written at different times and look like they were individually ported from other sources. They all include an example command which gets repeated several times. Here, we consolidate those referenes to make the documentation easier to maintain. At the same time, create linkages to the pmd-cpu-mask section from other sections to provide some level of coherence. Reviewed-by: Greg rose Acked-by: Kevin Traynor Signed-off-by: Darrell Ball Commit: 11d4c7a84326cfb6fac9eb2ca57a12d056b40b01 https://github.com/openvswitch/ovs/commit/11d4c7a84326cfb6fac9eb2ca57a12d056b40b01 Author: Darrell Ball Date: 2017-08-24 (Thu, 24 Aug 2017) Changed paths: M lib/dp-packet.c M lib/dp-packet.h M lib/netdev-dpdk.c Log Message: ----------- dp-packet: Refactor DPDK packet initialization. DPDK uses dp-packet pools and manages the mbuf portion of each packet. When a pool is created, partial initialization is also done on the OVS portion (i.e. non-mbuf). Since packet memory is reused, this is not very useful for transient fields and is also misleading. Furthermore, some of these transient fields are properly initialized for DPDK packets entering OVS anyways, which is the only reasonable way to do this. Another field, cutlen, is initialized in this manner in the pool and intended to be reset when cutlen is applied on sending the packet out. However, if cutlen context is set but the packet is not sent out for some reason, then the packet header would be corrupted in the memory pool. It is better to just reset the cutlen in the packets when received. I did not detect a degradation in performance, however, I would be willing to have some degradation, since this is a proper way to handle this. In addition to initializing cutlen in received packets, the other OVS transient fields are removed from the DPDK pool initialization. Acked-by: Sugesh Chandran Signed-off-by: Darrell Ball Commit: 94053e66e3997dcf25dc1c1d0da0db6d57735388 https://github.com/openvswitch/ovs/commit/94053e66e3997dcf25dc1c1d0da0db6d57735388 Author: Fischetti, Antonio Date: 2017-08-24 (Thu, 24 Aug 2017) Changed paths: M lib/conntrack.c M lib/conntrack.h M lib/dpif-netdev.c M tests/test-conntrack.c Log Message: ----------- conntrack: pass current time to conntrack_execute. Current time is passed to conntrack_execute so it doesn't have to recompute it again. Signed-off-by: Antonio Fischetti Acked by: Sugesh Chandran Signed-off-by: Darrell Ball Commit: 84b705766012914ba7fc9083de11e3fec1d02f18 https://github.com/openvswitch/ovs/commit/84b705766012914ba7fc9083de11e3fec1d02f18 Author: Fischetti, Antonio Date: 2017-08-25 (Fri, 25 Aug 2017) Changed paths: M lib/dp-packet.c M lib/dp-packet.h Log Message: ----------- dp-packet: Use memcpy on dp_packet elements. memcpy replaces the several single copies inside dp_packet_clone_with_headroom(). Signed-off-by: Antonio Fischetti Signed-off-by: Darrell Ball Commit: 922b28d435c48cf7f29db885ba1d6b31b705c5ac https://github.com/openvswitch/ovs/commit/922b28d435c48cf7f29db885ba1d6b31b705c5ac Author: Kevin Traynor Date: 2017-08-25 (Fri, 25 Aug 2017) Changed paths: M lib/dpif-netdev.c Log Message: ----------- dpif-netdev: Change polled_queue to use dp_netdev_rxq. Soon we will want to store processing cycle counts in the dp_netdev_rxq, so use that as a basis for the polled_queue that pmd_thread_main uses. Signed-off-by: Kevin Traynor Signed-off-by: Darrell Ball Commit: c59e759f332cf0975de6b33fe58803e479d2b16f https://github.com/openvswitch/ovs/commit/c59e759f332cf0975de6b33fe58803e479d2b16f Author: Kevin Traynor Date: 2017-08-25 (Fri, 25 Aug 2017) Changed paths: M lib/dpif-netdev.c Log Message: ----------- dpif-netdev: Add rxq processing cycle counters. Add counters to dp_netdev_rxq which will later be used for storing the processing cycles of an rxq. Processing cycles will be stored in reference to a defined time interval. We will store the cycles of the current in progress interval, a number of completed intervals and the sum of the completed intervals. cycles_count_intermediate was used to count cycles for a pmd. With some small additions we can also use it to count the cycles used for processing an rxq. Signed-off-by: Kevin Traynor Signed-off-by: Darrell Ball Commit: 4809891b2e017dda95bb9cbacd470d0065fc7ce4 https://github.com/openvswitch/ovs/commit/4809891b2e017dda95bb9cbacd470d0065fc7ce4 Author: Kevin Traynor Date: 2017-08-25 (Fri, 25 Aug 2017) Changed paths: M lib/dpif-netdev.c Log Message: ----------- dpif-netdev: Count the rxq processing cycles for an rxq. Count the cycles used for processing an rxq during the pmd rxq interval. As this is an in flight counter and pmds run independently, also store the total cycles used during the last full interval. Signed-off-by: Kevin Traynor Signed-off-by: Darrell Ball Commit: 655856ef39b98dd854a2a764b1b2e88a020e3099 https://github.com/openvswitch/ovs/commit/655856ef39b98dd854a2a764b1b2e88a020e3099 Author: Kevin Traynor Date: 2017-08-25 (Fri, 25 Aug 2017) Changed paths: M Documentation/howto/dpdk.rst M lib/dpif-netdev.c Log Message: ----------- dpif-netdev: Change rxq_scheduling to use rxq processing cycles. Previously rxqs were assigned to pmds by round robin in port/queue order. Now that we have the processing cycles used for existing rxqs, use that information to try and produced a better balanced distribution of rxqs across pmds. i.e. given multiple pmds, the rxqs which have consumed the largest amount of processing cycles will be placed on different pmds. The rxqs are sorted by their processing cycles and assigned (in sorted order) round robin across pmds. Signed-off-by: Kevin Traynor Signed-off-by: Darrell Ball Commit: 79da1e411ba5f7ed0f667b470d075ad83e7fc593 https://github.com/openvswitch/ovs/commit/79da1e411ba5f7ed0f667b470d075ad83e7fc593 Author: Kevin Traynor Date: 2017-08-25 (Fri, 25 Aug 2017) Changed paths: M Documentation/howto/dpdk.rst M lib/dpif-netdev.c M tests/pmd.at Log Message: ----------- dpif-netdev: Change pmd selection order. Up to his point rxqs are sorted by processing cycles they consumed and assigned to pmds in a round robin manner. Ian pointed out that on wrap around the most loaded pmd will be the next one to be assigned an additional rxq and that it would be better to reverse the pmd order when wraparound occurs. In other words, change from assigning by rr to assigning in a forward and reverse cycle through pmds. Also, now that the algorithm has finalized, document an example. Suggested-by: Ian Stokes Signed-off-by: Kevin Traynor Signed-off-by: Darrell Ball Commit: cd995c739a330dbcaee6433c08ecaad62791a56b https://github.com/openvswitch/ovs/commit/cd995c739a330dbcaee6433c08ecaad62791a56b Author: Kevin Traynor Date: 2017-08-25 (Fri, 25 Aug 2017) Changed paths: M Documentation/howto/dpdk.rst M lib/dpif-netdev.c M vswitchd/ovs-vswitchd.8.in Log Message: ----------- dpif-netdev: Add ovs-appctl dpif-netdev/pmd-rxq-rebalance. Rxqs consumed processing cycles are used to improve the balance of how rxqs are assigned to pmds. Currently some reconfiguration is needed to perform a reassignment. Add an ovs-appctl command to perform a new assignment in order to balance based on the latest rxq processing cycle information. Note: Jan requested this for testing purposes. Suggested-by: Jan Scheurich Signed-off-by: Kevin Traynor Signed-off-by: Darrell Ball Commit: d8c5a93bd1f763938ac7fe0fef61151d29f97e1b https://github.com/openvswitch/ovs/commit/d8c5a93bd1f763938ac7fe0fef61151d29f97e1b Author: Lily Huang Date: 2017-08-25 (Fri, 25 Aug 2017) Changed paths: M AUTHORS.rst M lib/conntrack.c Log Message: ----------- conntrack: Fix ct-clean thread crash bug. Conn should be removed from the connection expiry list when the connection tracker experiences NAT resource exhaustion and the connection needing NAT mapping cannot get it. If this is not done, the connection tracker can crash during cleanup of expired connections by the clean thread. This crash will be triggered when a established flow do ct(nat) again, like "ip,actions=ct(table=1) table=1,in_port=1,ip,actions=ct(commit,nat(dst=5.5.5.5)),2 table=1,in_port=2,ip,ct_state=+est,actions=1 table=1,in_port=1,ip,ct_state=+est,actions=2" Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.") Signed-off-by: Lili Huang Signed-off-by: Darrell Ball Commit: 602c86681c93af6aa5ff5d9d40f7bf99d1020da1 https://github.com/openvswitch/ovs/commit/602c86681c93af6aa5ff5d9d40f7bf99d1020da1 Author: Lance Richardson Date: 2017-08-25 (Fri, 25 Aug 2017) Changed paths: M lib/netdev-dpdk.c Log Message: ----------- netdev-dpdk: use 64-bit arithmetic when converting rates. Force 64-bit arithmetic to be used when converting uint32_t rate and burst parameters from kilobits per second to bytes per second, avoiding incorrect behavior for rates exceeding UINT_MAX bits per second. Reported-by: "???" Fixes: 9509913aa722 ("netdev-dpdk.c: Add ingress-policing functionality.") Signed-off-by: Lance Richardson Acked-By: Mark Michelson Acked-by: Kevin Traynor Signed-off-by: Darrell Ball Commit: 50986e7842d8bc5ecfbb1e0423cc449f166c76fb https://github.com/openvswitch/ovs/commit/50986e7842d8bc5ecfbb1e0423cc449f166c76fb Author: wangzhike Date: 2017-08-25 (Fri, 25 Aug 2017) Changed paths: M lib/netdev-dpdk.c Log Message: ----------- netdev-dpdk: vhost get stats fix. In netdev_dpdk_vhost_get_stats, '+=' was used in a few places where '=' was expected. Signed-off-by: wangzhike Signed-off-by: Darrell Ball Commit: e8b91cf3676939f9cb3f746c063b5f1e77c97d1c https://github.com/openvswitch/ovs/commit/e8b91cf3676939f9cb3f746c063b5f1e77c97d1c Author: Ben Pfaff Date: 2017-08-29 (Tue, 29 Aug 2017) Changed paths: M AUTHORS.rst M Documentation/howto/dpdk.rst M Documentation/intro/install/dpdk.rst M lib/conntrack.c M lib/conntrack.h M lib/dp-packet.c M lib/dp-packet.h M lib/dpif-netdev.c M lib/netdev-dpdk.c M tests/pmd.at M tests/test-conntrack.c M vswitchd/ovs-vswitchd.8.in Log Message: ----------- Merge branch 'dpdk_merge' of https://github.com/darball/ovs. Compare: https://github.com/openvswitch/ovs/compare/bce693e72a44...e8b91cf36769 From noreply at github.com Tue Aug 29 21:16:08 2017 From: noreply at github.com (GitHub) Date: Tue, 29 Aug 2017 14:16:08 -0700 Subject: [ovs-git] [openvswitch/ovs] 6c7fe3: conntrack: Fix ct-clean thread crash bug. Message-ID: <59a5d9985f8ff_1f44f3f87b6b05c343271e@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 6c7fe347a4e483995e81a8435dc2dd5e2f7caf17 https://github.com/openvswitch/ovs/commit/6c7fe347a4e483995e81a8435dc2dd5e2f7caf17 Author: Lily Huang Date: 2017-08-29 (Tue, 29 Aug 2017) Changed paths: M AUTHORS.rst M lib/conntrack.c Log Message: ----------- conntrack: Fix ct-clean thread crash bug. Conn should be removed from the connection expiry list when the connection tracker experiences NAT resource exhaustion and the connection needing NAT mapping cannot get it. If this is not done, the connection tracker can crash during cleanup of expired connections by the clean thread. This crash will be triggered when a established flow do ct(nat) again, like "ip,actions=ct(table=1) table=1,in_port=1,ip,actions=ct(commit,nat(dst=5.5.5.5)),2 table=1,in_port=2,ip,ct_state=+est,actions=1 table=1,in_port=1,ip,ct_state=+est,actions=2" Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.") Signed-off-by: Lili Huang Signed-off-by: Darrell Ball From noreply at github.com Tue Aug 29 21:16:28 2017 From: noreply at github.com (GitHub) Date: Tue, 29 Aug 2017 14:16:28 -0700 Subject: [ovs-git] [openvswitch/ovs] aaeda9: netdev-dpdk: vhost get stats fix. Message-ID: <59a5d9ac85769_4aa93fa682671c2868297@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: aaeda900dfd183c797331adb7cc1686461fefca0 https://github.com/openvswitch/ovs/commit/aaeda900dfd183c797331adb7cc1686461fefca0 Author: wangzhike Date: 2017-08-29 (Tue, 29 Aug 2017) Changed paths: M lib/netdev-dpdk.c Log Message: ----------- netdev-dpdk: vhost get stats fix. In netdev_dpdk_vhost_get_stats, '+=' was used in a few places where '=' was expected. Signed-off-by: wangzhike Signed-off-by: Darrell Ball From noreply at github.com Tue Aug 29 21:16:34 2017 From: noreply at github.com (GitHub) Date: Tue, 29 Aug 2017 14:16:34 -0700 Subject: [ovs-git] [openvswitch/ovs] 965a8a: netdev-dpdk: vhost get stats fix. Message-ID: <59a5d9b24846d_28813fbc7dccdc3c337b9@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: 965a8a6040f603f8a96696ffde6c007979c65b2e https://github.com/openvswitch/ovs/commit/965a8a6040f603f8a96696ffde6c007979c65b2e Author: wangzhike Date: 2017-08-29 (Tue, 29 Aug 2017) Changed paths: M lib/netdev-dpdk.c Log Message: ----------- netdev-dpdk: vhost get stats fix. In netdev_dpdk_vhost_get_stats, '+=' was used in a few places where '=' was expected. Signed-off-by: wangzhike Signed-off-by: Darrell Ball From noreply at github.com Tue Aug 29 21:16:40 2017 From: noreply at github.com (GitHub) Date: Tue, 29 Aug 2017 14:16:40 -0700 Subject: [ovs-git] [openvswitch/ovs] a7dc20: netdev-dpdk: vhost get stats fix. Message-ID: <59a5d9b828d52_1eb393fe3ad111c3464077@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.6 Home: https://github.com/openvswitch/ovs Commit: a7dc20a0dc58d2f6803c306df2f61773d00caddf https://github.com/openvswitch/ovs/commit/a7dc20a0dc58d2f6803c306df2f61773d00caddf Author: wangzhike Date: 2017-08-29 (Tue, 29 Aug 2017) Changed paths: M lib/netdev-dpdk.c Log Message: ----------- netdev-dpdk: vhost get stats fix. In netdev_dpdk_vhost_get_stats, '+=' was used in a few places where '=' was expected. Signed-off-by: wangzhike Signed-off-by: Darrell Ball From noreply at github.com Tue Aug 29 21:16:57 2017 From: noreply at github.com (GitHub) Date: Tue, 29 Aug 2017 14:16:57 -0700 Subject: [ovs-git] [openvswitch/ovs] dd4e19: netdev-dpdk: use 64-bit arithmetic when converting... Message-ID: <59a5d9c923279_5b163fea24dbfc3861847@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: dd4e19283a9b2382abe119274db8676c9bb9aff3 https://github.com/openvswitch/ovs/commit/dd4e19283a9b2382abe119274db8676c9bb9aff3 Author: Lance Richardson Date: 2017-08-29 (Tue, 29 Aug 2017) Changed paths: M lib/netdev-dpdk.c Log Message: ----------- netdev-dpdk: use 64-bit arithmetic when converting rates. Force 64-bit arithmetic to be used when converting uint32_t rate and burst parameters from kilobits per second to bytes per second, avoiding incorrect behavior for rates exceeding UINT_MAX bits per second. Reported-by: "???" Fixes: 9509913aa722 ("netdev-dpdk.c: Add ingress-policing functionality.") Signed-off-by: Lance Richardson Acked-By: Mark Michelson Acked-by: Kevin Traynor Signed-off-by: Darrell Ball From noreply at github.com Tue Aug 29 21:17:02 2017 From: noreply at github.com (GitHub) Date: Tue, 29 Aug 2017 14:17:02 -0700 Subject: [ovs-git] [openvswitch/ovs] 5820af: netdev-dpdk: use 64-bit arithmetic when converting... Message-ID: <59a5d9ce866ea_1ab83fbf3348fc246959b@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: 5820afeb103eafe6dd7095e878b28680db5b7095 https://github.com/openvswitch/ovs/commit/5820afeb103eafe6dd7095e878b28680db5b7095 Author: Lance Richardson Date: 2017-08-29 (Tue, 29 Aug 2017) Changed paths: M lib/netdev-dpdk.c Log Message: ----------- netdev-dpdk: use 64-bit arithmetic when converting rates. Force 64-bit arithmetic to be used when converting uint32_t rate and burst parameters from kilobits per second to bytes per second, avoiding incorrect behavior for rates exceeding UINT_MAX bits per second. Reported-by: "???" Fixes: 9509913aa722 ("netdev-dpdk.c: Add ingress-policing functionality.") Signed-off-by: Lance Richardson Acked-By: Mark Michelson Acked-by: Kevin Traynor Signed-off-by: Darrell Ball From noreply at github.com Tue Aug 29 21:17:07 2017 From: noreply at github.com (GitHub) Date: Tue, 29 Aug 2017 14:17:07 -0700 Subject: [ovs-git] [openvswitch/ovs] ffe3e2: netdev-dpdk: use 64-bit arithmetic when converting... Message-ID: <59a5d9d3e1b4e_283a3fa4b5e27c34263f2@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.6 Home: https://github.com/openvswitch/ovs Commit: ffe3e283af938afaa09a8b603b16b13e037ced0f https://github.com/openvswitch/ovs/commit/ffe3e283af938afaa09a8b603b16b13e037ced0f Author: Lance Richardson Date: 2017-08-29 (Tue, 29 Aug 2017) Changed paths: M lib/netdev-dpdk.c Log Message: ----------- netdev-dpdk: use 64-bit arithmetic when converting rates. Force 64-bit arithmetic to be used when converting uint32_t rate and burst parameters from kilobits per second to bytes per second, avoiding incorrect behavior for rates exceeding UINT_MAX bits per second. Reported-by: "???" Fixes: 9509913aa722 ("netdev-dpdk.c: Add ingress-policing functionality.") Signed-off-by: Lance Richardson Acked-By: Mark Michelson Acked-by: Kevin Traynor Signed-off-by: Darrell Ball From noreply at github.com Wed Aug 30 14:54:07 2017 From: noreply at github.com (GitHub) Date: Wed, 30 Aug 2017 07:54:07 -0700 Subject: [ovs-git] [openvswitch/ovs] 2639f6: travis: parallel builds and tests Message-ID: <59a6d18f8bb50_20363fc093f33c2833747@hookshot-fe6-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.6 Home: https://github.com/openvswitch/ovs Commit: 2639f6b42b825196464d337bcb14e5da9173fb43 https://github.com/openvswitch/ovs/commit/2639f6b42b825196464d337bcb14e5da9173fb43 Author: Lance Richardson Date: 2017-08-30 (Wed, 30 Aug 2017) Changed paths: M .travis/linux-build.sh Log Message: ----------- travis: parallel builds and tests Some recent travis builds have failed due to having exceeded the per-job time limit of 50 minutes. This change enables parallel builds and parallel test execution in order to reduce overall execution time, and will hopefully allow this class of build failures to be avoided. Since the travis build environment is provisioned with two CPUs, use -j2 for builds and -j4 for tests. Testing in a cloned repository shows slightly more than a 50% reduction in overall test time. Signed-off-by: Lance Richardson Signed-off-by: Ben Pfaff From noreply at github.com Wed Aug 30 14:54:01 2017 From: noreply at github.com (GitHub) Date: Wed, 30 Aug 2017 07:54:01 -0700 Subject: [ovs-git] [openvswitch/ovs] 5e7b9b: travis: parallel builds and tests Message-ID: <59a6d1895ad5b_1e5993f9a0d1fdc2c66841@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: 5e7b9b05c80b96ec61b4c1a1ccfa2cf3c6066b76 https://github.com/openvswitch/ovs/commit/5e7b9b05c80b96ec61b4c1a1ccfa2cf3c6066b76 Author: Lance Richardson Date: 2017-08-30 (Wed, 30 Aug 2017) Changed paths: M .travis/linux-build.sh Log Message: ----------- travis: parallel builds and tests Some recent travis builds have failed due to having exceeded the per-job time limit of 50 minutes. This change enables parallel builds and parallel test execution in order to reduce overall execution time, and will hopefully allow this class of build failures to be avoided. Since the travis build environment is provisioned with two CPUs, use -j2 for builds and -j4 for tests. Testing in a cloned repository shows slightly more than a 50% reduction in overall test time. Signed-off-by: Lance Richardson Signed-off-by: Ben Pfaff From noreply at github.com Wed Aug 30 22:59:08 2017 From: noreply at github.com (GitHub) Date: Wed, 30 Aug 2017 15:59:08 -0700 Subject: [ovs-git] [openvswitch/ovs] 892ca4: Revert "ofproto-dpif-xlate: Fixes for propagating ... Message-ID: <59a7433c99ce1_22a673ff7d9f0bc2868525@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: 892ca41e5763bd36ccceb73703983275fe51ad27 https://github.com/openvswitch/ovs/commit/892ca41e5763bd36ccceb73703983275fe51ad27 Author: Justin Pettit Date: 2017-08-30 (Wed, 30 Aug 2017) Changed paths: M ofproto/ofproto-dpif-xlate.c M tests/ofproto-dpif.at Log Message: ----------- Revert "ofproto-dpif-xlate: Fixes for propagating state of conntrack." This reverts commit 8294d78ab124ec6f4b51c621e9baf7f29b287bb9. This patch was mistakenly backported to branch-2.7. The change breaks the OpenFlow API, which is not appropriate for a maintenance release. Signed-off-by: Justin Pettit Reported-by: Russell Bryant Acked-by: Russell Bryant From noreply at github.com Wed Aug 30 23:03:58 2017 From: noreply at github.com (GitHub) Date: Wed, 30 Aug 2017 16:03:58 -0700 Subject: [ovs-git] [openvswitch/ovs] 1a4e70: redhat: fix upgrades where group doesn't exist Message-ID: <59a7445eb57cd_2321e3fedb3f27c3c1047db@hookshot-fe-6dbb0c4.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 1a4e7075e5c6352d15ecda7f80d5e1ad153192d1 https://github.com/openvswitch/ovs/commit/1a4e7075e5c6352d15ecda7f80d5e1ad153192d1 Author: Aaron Conole Date: 2017-08-30 (Wed, 30 Aug 2017) Changed paths: M rhel/usr_lib_systemd_system_ovs-vswitchd.service.in Log Message: ----------- redhat: fix upgrades where group doesn't exist The upgrade from older Open vSwitch versions on RHEL will try, as much as possible, to preserve the system. This means no new users or groups are created. As an effect, it's possible for the chown to fail, because the hugetlbfs group may not exist. While it did on my systems, it was not there on others. This change allows the ExecStartPre commands to fail. In the case that the user doesn't use DPDK, it won't matter anyway. Fixes: e3e738a3d058 ('redhat: allow dpdk to also run as non-root user') Signed-off-by: Aaron Conole Reported-by: Jean-Tsung Hsiao Tested-by: Jean-Tsung Hsiao Acked-by: Flavio Leitner Signed-off-by: Russell Bryant From noreply at github.com Wed Aug 30 23:04:20 2017 From: noreply at github.com (GitHub) Date: Wed, 30 Aug 2017 16:04:20 -0700 Subject: [ovs-git] [openvswitch/ovs] ea81f1: redhat: fix upgrades where group doesn't exist Message-ID: <59a74474d7e8c_13c73fce35fbfc3c3129a@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: ea81f1d522cb752d1656bbe1d2933466ebbc53a7 https://github.com/openvswitch/ovs/commit/ea81f1d522cb752d1656bbe1d2933466ebbc53a7 Author: Aaron Conole Date: 2017-08-30 (Wed, 30 Aug 2017) Changed paths: M rhel/usr_lib_systemd_system_ovs-vswitchd.service.in Log Message: ----------- redhat: fix upgrades where group doesn't exist The upgrade from older Open vSwitch versions on RHEL will try, as much as possible, to preserve the system. This means no new users or groups are created. As an effect, it's possible for the chown to fail, because the hugetlbfs group may not exist. While it did on my systems, it was not there on others. This change allows the ExecStartPre commands to fail. In the case that the user doesn't use DPDK, it won't matter anyway. Fixes: e3e738a3d058 ('redhat: allow dpdk to also run as non-root user') Signed-off-by: Aaron Conole Reported-by: Jean-Tsung Hsiao Tested-by: Jean-Tsung Hsiao Acked-by: Flavio Leitner Signed-off-by: Russell Bryant From noreply at github.com Thu Aug 31 14:54:39 2017 From: noreply at github.com (GitHub) Date: Thu, 31 Aug 2017 07:54:39 -0700 Subject: [ovs-git] [openvswitch/ovs] 5707b8: monitor: Fix bad caching of conditional monitor_co... Message-ID: <59a8232ff7ba_14cb3fc4e1ad1c2895212@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 5707b87db75c0d46cca47b9946c031600b95ded1 https://github.com/openvswitch/ovs/commit/5707b87db75c0d46cca47b9946c031600b95ded1 Author: Ben Pfaff Date: 2017-08-31 (Thu, 31 Aug 2017) Changed paths: M ovsdb/monitor.c Log Message: ----------- monitor: Fix bad caching of conditional monitor_cond requests. The current implementation of ovsdb-server caches only non-conditional monitors, that is, monitors for every table row, not those that monitor only rows that match some condition. To figure out which monitors are conditional, the code track the number of tables that have conditions that are uniformly true (cond->n_true_cnd) and compares that against the number of tables in the condition (shash_count(&cond->tables)). If they are the same, then every table has (effectively) no condition, and so cond->conditional is set to false. However, the implementation was buggy. The function that adds a new table condition, ovsdb_monitor_table_condition_create(), only updated cond->conditional if the table condition being added was true. This is wrong; only adding a non-true condition can actually change cond->conditional. This commit fixes the problem by always recalculating cond->conditional. The most visible side effect of cond->conditional being true when it should be false, as caused by this bug, was that conditional monitors were being mixed with unconditional monitors for the purpose of caching. This meant that, if a client requested a conditional monitor that was the same as an unconditional one, except for the condition, then the client would receive the cached data previously sent for the unconditional one. This commit fixes the problem. Signed-off-by: Ben Pfaff Acked-by: Andy Zhou Acked-by: Liran Schour Commit: e4ef68817a8224404486a026df98495b6e0a86cd https://github.com/openvswitch/ovs/commit/e4ef68817a8224404486a026df98495b6e0a86cd Author: Ben Pfaff Date: 2017-08-31 (Thu, 31 Aug 2017) Changed paths: M ovsdb/monitor.c Log Message: ----------- monitor: Simplify calculation of cond->conditional. This removes n_true_cnd from struct ovsdb_monitor_session_condition. It was an "optimization" that is not part of any inner loop, but make the code harder to reason about. Signed-off-by: Ben Pfaff Acked-by: Andy Zhou Acked-by: Liran Schour Compare: https://github.com/openvswitch/ovs/compare/1a4e7075e5c6...e4ef68817a82 From noreply at github.com Thu Aug 31 14:55:01 2017 From: noreply at github.com (GitHub) Date: Thu, 31 Aug 2017 07:55:01 -0700 Subject: [ovs-git] [openvswitch/ovs] 5d1a10: monitor: Fix bad caching of conditional monitor_co... Message-ID: <59a8234524d73_17823ffdecdd5c3c97265@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.7 Home: https://github.com/openvswitch/ovs Commit: 5d1a10d7d6e6ada9d56d7e513cf93397243fbf36 https://github.com/openvswitch/ovs/commit/5d1a10d7d6e6ada9d56d7e513cf93397243fbf36 Author: Ben Pfaff Date: 2017-08-31 (Thu, 31 Aug 2017) Changed paths: M ovsdb/monitor.c Log Message: ----------- monitor: Fix bad caching of conditional monitor_cond requests. The current implementation of ovsdb-server caches only non-conditional monitors, that is, monitors for every table row, not those that monitor only rows that match some condition. To figure out which monitors are conditional, the code track the number of tables that have conditions that are uniformly true (cond->n_true_cnd) and compares that against the number of tables in the condition (shash_count(&cond->tables)). If they are the same, then every table has (effectively) no condition, and so cond->conditional is set to false. However, the implementation was buggy. The function that adds a new table condition, ovsdb_monitor_table_condition_create(), only updated cond->conditional if the table condition being added was true. This is wrong; only adding a non-true condition can actually change cond->conditional. This commit fixes the problem by always recalculating cond->conditional. The most visible side effect of cond->conditional being true when it should be false, as caused by this bug, was that conditional monitors were being mixed with unconditional monitors for the purpose of caching. This meant that, if a client requested a conditional monitor that was the same as an unconditional one, except for the condition, then the client would receive the cached data previously sent for the unconditional one. This commit fixes the problem. Signed-off-by: Ben Pfaff Acked-by: Andy Zhou Acked-by: Liran Schour From noreply at github.com Thu Aug 31 14:55:12 2017 From: noreply at github.com (GitHub) Date: Thu, 31 Aug 2017 07:55:12 -0700 Subject: [ovs-git] [openvswitch/ovs] 4f1506: monitor: Fix bad caching of conditional monitor_co... Message-ID: <59a823508779a_17783fa69cf3dc34574ba@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.6 Home: https://github.com/openvswitch/ovs Commit: 4f1506c25090612b651d055eced63bcd3bc87a34 https://github.com/openvswitch/ovs/commit/4f1506c25090612b651d055eced63bcd3bc87a34 Author: Ben Pfaff Date: 2017-08-31 (Thu, 31 Aug 2017) Changed paths: M ovsdb/monitor.c Log Message: ----------- monitor: Fix bad caching of conditional monitor_cond requests. The current implementation of ovsdb-server caches only non-conditional monitors, that is, monitors for every table row, not those that monitor only rows that match some condition. To figure out which monitors are conditional, the code track the number of tables that have conditions that are uniformly true (cond->n_true_cnd) and compares that against the number of tables in the condition (shash_count(&cond->tables)). If they are the same, then every table has (effectively) no condition, and so cond->conditional is set to false. However, the implementation was buggy. The function that adds a new table condition, ovsdb_monitor_table_condition_create(), only updated cond->conditional if the table condition being added was true. This is wrong; only adding a non-true condition can actually change cond->conditional. This commit fixes the problem by always recalculating cond->conditional. The most visible side effect of cond->conditional being true when it should be false, as caused by this bug, was that conditional monitors were being mixed with unconditional monitors for the purpose of caching. This meant that, if a client requested a conditional monitor that was the same as an unconditional one, except for the condition, then the client would receive the cached data previously sent for the unconditional one. This commit fixes the problem. Signed-off-by: Ben Pfaff Acked-by: Andy Zhou Acked-by: Liran Schour From noreply at github.com Thu Aug 31 14:54:54 2017 From: noreply at github.com (GitHub) Date: Thu, 31 Aug 2017 07:54:54 -0700 Subject: [ovs-git] [openvswitch/ovs] de3216: monitor: Fix bad caching of conditional monitor_co... Message-ID: <59a8233e3a8bf_10793f9cd81efc30957fb@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: de321681b5a96181a338cdd6bfc7a30f237ca542 https://github.com/openvswitch/ovs/commit/de321681b5a96181a338cdd6bfc7a30f237ca542 Author: Ben Pfaff Date: 2017-08-31 (Thu, 31 Aug 2017) Changed paths: M ovsdb/monitor.c Log Message: ----------- monitor: Fix bad caching of conditional monitor_cond requests. The current implementation of ovsdb-server caches only non-conditional monitors, that is, monitors for every table row, not those that monitor only rows that match some condition. To figure out which monitors are conditional, the code track the number of tables that have conditions that are uniformly true (cond->n_true_cnd) and compares that against the number of tables in the condition (shash_count(&cond->tables)). If they are the same, then every table has (effectively) no condition, and so cond->conditional is set to false. However, the implementation was buggy. The function that adds a new table condition, ovsdb_monitor_table_condition_create(), only updated cond->conditional if the table condition being added was true. This is wrong; only adding a non-true condition can actually change cond->conditional. This commit fixes the problem by always recalculating cond->conditional. The most visible side effect of cond->conditional being true when it should be false, as caused by this bug, was that conditional monitors were being mixed with unconditional monitors for the purpose of caching. This meant that, if a client requested a conditional monitor that was the same as an unconditional one, except for the condition, then the client would receive the cached data previously sent for the unconditional one. This commit fixes the problem. Signed-off-by: Ben Pfaff Acked-by: Andy Zhou Acked-by: Liran Schour From noreply at github.com Thu Aug 31 16:19:39 2017 From: noreply at github.com (GitHub) Date: Thu, 31 Aug 2017 09:19:39 -0700 Subject: [ovs-git] [openvswitch/ovs] 5df341: NEWS: Mark NSH support as experimental in 2.8. Message-ID: <59a8371b41714_14c43faa6623bc34725b5@hookshot-fe3-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 5df341420b4f4a0c6e76f583ca9be79d1c703a48 https://github.com/openvswitch/ovs/commit/5df341420b4f4a0c6e76f583ca9be79d1c703a48 Author: Ben Pfaff Date: 2017-08-31 (Thu, 31 Aug 2017) Changed paths: M NEWS Log Message: ----------- NEWS: Mark NSH support as experimental in 2.8. This feature landed late in 2.8 and the NSH wire protocol itself is not completely stable. Acked-by: Jiri Benc Acked-by: Flavio Leitner Signed-off-by: Ben Pfaff From noreply at github.com Thu Aug 31 16:19:21 2017 From: noreply at github.com (GitHub) Date: Thu, 31 Aug 2017 09:19:21 -0700 Subject: [ovs-git] [openvswitch/ovs] ab27bf: NEWS: Mark NSH support as experimental in 2.8. Message-ID: <59a8370924bbc_363e3f9b32fa7c44804fe@hookshot-fe2-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: ab27bfa6dc2926ff46b9d2bac40b6807a700738c https://github.com/openvswitch/ovs/commit/ab27bfa6dc2926ff46b9d2bac40b6807a700738c Author: Ben Pfaff Date: 2017-08-31 (Thu, 31 Aug 2017) Changed paths: M NEWS Log Message: ----------- NEWS: Mark NSH support as experimental in 2.8. This feature landed late in 2.8 and the NSH wire protocol itself is not completely stable. Acked-by: Jiri Benc Acked-by: Flavio Leitner Signed-off-by: Ben Pfaff From noreply at github.com Thu Aug 31 22:38:17 2017 From: noreply at github.com (GitHub) Date: Thu, 31 Aug 2017 15:38:17 -0700 Subject: [ovs-git] [openvswitch/ovs] 928f81: Revert "ofproto-dpif: Mark packets as "untracked" ... Message-ID: <59a88fd9cf5a_1b503ff610c51c28903bd@hookshot-fe1-cp1-prd.iad.github.net.mail> Branch: refs/heads/branch-2.8 Home: https://github.com/openvswitch/ovs Commit: 928f814d520afca1be6da03a50d434a4e3cd0872 https://github.com/openvswitch/ovs/commit/928f814d520afca1be6da03a50d434a4e3cd0872 Author: Justin Pettit Date: 2017-08-31 (Thu, 31 Aug 2017) Changed paths: M NEWS M lib/ofp-actions.c M ofproto/ofproto-dpif-xlate.c M tests/ofproto-dpif.at M tests/system-traffic.at M utilities/ovs-ofctl.8.in Log Message: ----------- Revert "ofproto-dpif: Mark packets as "untracked" after call to ct()." This reverts commit 8473cf69d25c4682cc6f6857b86b490a8c27cbd4. This commit introduced a change in the conntrack API. This affected some existing applications, so we will delay introducing the change until the next major release. Signed-off-by: Justin Pettit Requested-by: Flavio Leitner Acked-by: Russell Bryant Commit: 348f05afa4705025b173a803551cc72843227b43 https://github.com/openvswitch/ovs/commit/348f05afa4705025b173a803551cc72843227b43 Author: Justin Pettit Date: 2017-08-31 (Thu, 31 Aug 2017) Changed paths: M NEWS Log Message: ----------- NEWS: Mention ct() API change that will arrive in the next major release. Signed-off-by: Justin Pettit Acked-by: Russell Bryant Compare: https://github.com/openvswitch/ovs/compare/5df341420b4f...348f05afa470 From noreply at github.com Thu Aug 31 23:59:29 2017 From: noreply at github.com (GitHub) Date: Thu, 31 Aug 2017 16:59:29 -0700 Subject: [ovs-git] [openvswitch/ovs] 7bc1aa: rhel: make the selinux policy intermediate Message-ID: <59a8a2e193ef2_211d3fce97851c4081080@hookshot-fe5-cp1-prd.iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/openvswitch/ovs Commit: 7bc1aae71e8908d775d988f82f683533f253e6f4 https://github.com/openvswitch/ovs/commit/7bc1aae71e8908d775d988f82f683533f253e6f4 Author: Aaron Conole Date: 2017-08-31 (Thu, 31 Aug 2017) Changed paths: M rhel/openvswitch-fedora.spec.in M selinux/automake.mk R selinux/openvswitch-custom.te A selinux/openvswitch-custom.te.in Log Message: ----------- rhel: make the selinux policy intermediate This will be used by an upcoming commit to have @begin_ and @end_ dpdk blocks to keep dpdk specific policy decisions only active when dpdk is used. Acked-by: Flavio Leitner Acked-by: Ansis Atteka Signed-off-by: Aaron Conole Tested-by: Jean Hsiao Commit: 8e6681eaa612c70c2afdb4b5a68c18e9cd3940a8 https://github.com/openvswitch/ovs/commit/8e6681eaa612c70c2afdb4b5a68c18e9cd3940a8 Author: Aaron Conole Date: 2017-08-31 (Thu, 31 Aug 2017) Changed paths: M Makefile.am Log Message: ----------- makefile: hook up dpdkstrip preprocessor When building the openvswitch-custom.te file, it is important to have the ability to filter out dpdk blocks depending on whether the system has been configured with dpdk or not. This allows using all the standard .in file blocks, as well as the dpdkstrip blocks, when constructing the selinux policy file. Additionally, this means any .in files which might want to change based on configuration to exclude blocks based on dpdk can do so. Acked-by: Flavio Leitner Acked-by: Ansis Atteka Signed-off-by: Aaron Conole Tested-by: Jean Hsiao Commit: 84d2723305064e25402cb89a16bf7ad1aa2cda70 https://github.com/openvswitch/ovs/commit/84d2723305064e25402cb89a16bf7ad1aa2cda70 Author: Aaron Conole Date: 2017-08-31 (Thu, 31 Aug 2017) Changed paths: M selinux/openvswitch-custom.te.in Log Message: ----------- selinux: update policy to reflect non-root and dpdk support The selinux policy that exists in the repository did not specify access to all of the resources needed for Open vSwitch to properly function with an enforcing selinux policy. This update allows Open vSwitch to operate with selinux set to Enforcing mode, even while running as a non-root user. Acked-by: Flavio Leitner Acked-by: Ansis Atteka Signed-off-by: Aaron Conole Tested-by: Jean Hsiao Compare: https://github.com/openvswitch/ovs/compare/ab27bfa6dc29...84d272330506