[ovs-git] [openvswitch/ovs] b24fa3: ofproto-dpif-xlate: Eliminate duplicate read of xc...

GitHub noreply at github.com
Wed Aug 2 22:08:12 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: b24fa3f486d4061cb9facd181fd6234f281904df
      https://github.com/openvswitch/ovs/commit/b24fa3f486d4061cb9facd181fd6234f281904df
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-08-02 (Wed, 02 Aug 2017)

  Changed paths:
    M ofproto/ofproto-dpif-xlate.c

  Log Message:
  -----------
  ofproto-dpif-xlate: Eliminate duplicate read of xcfgp.

This inner 'xcfg' shadowed the outer one and could have read a different
value if 'xcfgp' was changing, so this is possibly a bug fix.

Found by -Wshadow=local in GCC 7.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Andy Zhou <azhou at ovn.org>


  Commit: 71f21279f62c2cca39ff1522f4d25b5de74992e3
      https://github.com/openvswitch/ovs/commit/71f21279f62c2cca39ff1522f4d25b5de74992e3
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-08-02 (Wed, 02 Aug 2017)

  Changed paths:
    M lib/classifier.c
    M lib/daemon-unix.c
    M lib/db-ctl-base.c
    M lib/dpctl.c
    M lib/dpif-netdev.c
    M lib/hash.c
    M lib/learn.c
    M lib/lldp/lldpd.c
    M lib/netdev-dummy.c
    M lib/netdev-linux.c
    M lib/odp-util.c
    M lib/ofp-print.c
    M lib/ofp-util.c
    M lib/ovsdb-idl.c
    M lib/table.c
    M lib/unixctl.c
    M lib/vconn.c
    M lib/vlog.c
    M ofproto/ofproto-dpif-xlate.c
    M ofproto/ofproto-dpif.c
    M ovn/controller/ofctrl.c
    M ovn/controller/patch.c
    M ovn/controller/physical.c
    M ovn/lib/expr.c
    M ovn/northd/ovn-northd.c
    M ovn/utilities/ovn-trace.c
    M ovsdb/jsonrpc-server.c
    M ovsdb/replication.c
    M tests/test-bundle.c
    M tests/test-ccmap.c
    M tests/test-classifier.c
    M tests/test-cmap.c
    M tests/test-odp.c
    M tests/test-ovn.c
    M utilities/ovs-vsctl.c
    M vswitchd/bridge.c
    M vtep/vtep-ctl.c

  Log Message:
  -----------
  Eliminate most shadowing for local variable names.

Shadowing is when a variable with a given name in an inner scope hides a
different variable with the same name in a surrounding scope.  This is
generally undesirable because it can confuse programmers.  This commit
eliminates most of it.

Found with -Wshadow=local in GCC 7.  The repo is not really ready to enable
this option by default because of a few cases that are harder to fix, and
harmless, such as nested use of CMAP_FOR_EACH.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Andy Zhou <azhou at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/f3eb7691bfdd...71f21279f62c


More information about the git mailing list