[ovs-git] [openvswitch/ovs] 507180: datapath-windows: Refactor OvsCreateNewNBLsFromMul...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 5071802a6c9090dcd13d39e4e06b550d478ef6fc
      https://github.com/openvswitch/ovs/commit/5071802a6c9090dcd13d39e4e06b550d478ef6fc
  Author: Shashank Ram <rams at vmware.com>
  Date:   2017-08-02 (Wed, 02 Aug 2017)

  Changed paths:
    M datapath-windows/ovsext/PacketIO.c

  Log Message:
  -----------
  datapath-windows: Refactor OvsCreateNewNBLsFromMultipleNBs

Previously, the function would take the curNbl and nextNbl
as inputs, and modify the linked list, and merge the input
linked list with the newly generated newNbl list.

This is confusing for the caller, and the function has
unnecessary logic for merging linked lists that instead
the caller should take care of. This is because the
OvsCreateNewNBLsFromMultipleNBs() is a generic API
that can be used by other functions as well, and its
natural for different callers to have different needs.

This patch refactors the behavior of OvsCreateNewNBLsFromMultipleNBs
to take in the curNbl and lastNbl, and it returns
a linked list of NBLs and sets the HEAD and TAIL of the
new list obtained from the curNbl. If the caller wants
to chain a new linked list at the HEAD or TAIL, it
can make use of the curNbl and lastNbl to do so.

Signed-off-by: Shashank Ram <rams at vmware.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Anand Kumar <kumaranand at vmware.com>