[ovs-git] [openvswitch/ovs] 023992: ofproto-dpif-upcall: Fix action attr iteration.

GitHub noreply at github.com
Mon Aug 7 18:43:17 UTC 2017


  Branch: refs/heads/branch-2.5
  Home:   https://github.com/openvswitch/ovs
  Commit: 023992251a743af73a6b15460181531dad8119ff
      https://github.com/openvswitch/ovs/commit/023992251a743af73a6b15460181531dad8119ff
  Author: Joe Stringer <joe at ovn.org>
  Date:   2017-08-07 (Mon, 07 Aug 2017)

  Changed paths:
    M ofproto/ofproto-dpif-upcall.c

  Log Message:
  -----------
  ofproto-dpif-upcall: Fix action attr iteration.

This calls is operating on messages generated by the datapath. If a
datapath implementation sends improperly formatted netlink attributes,
then it's possible for a revalidator thread to end up trapped in an
infinite loop iterating across the actions attributes. Rather than using
the UNSAFE variation of this iterator, use the regular version.

>From master commit 55f854b9d51edcbccf4ae1655855dddd1d9ec1fe.

Fixes: e672ff9b4d22 ("ofproto-dpif: Restore metadata and registers on recirculation.")
Signed-off-by: Joe Stringer <joe at ovn.org>
Acked-by: Ben Pfaff <blp at ovn.org>


  Commit: 6f3f122bd73301a7396b2e29e4ed16a8955c1bab
      https://github.com/openvswitch/ovs/commit/6f3f122bd73301a7396b2e29e4ed16a8955c1bab
  Author: Joe Stringer <joe at ovn.org>
  Date:   2017-08-07 (Mon, 07 Aug 2017)

  Changed paths:
    M ofproto/ofproto-dpif-upcall.c

  Log Message:
  -----------
  ofproto-dpif-upcall: Fix key attr iteration.

This call is operating on messages generated by the datapath. If a
datapath implementation sends improperly formatted netlink attributes,
then it's possible for a revalidator thread to end up trapped in an
infinite loop iterating across these attributes. Rather than using the
UNSAFE variation of this iterator, use the regular version.

>From master commit f2d3fef3d90253dda3e03822df2e921ec853192d.

Fixes: 994fcc5a15d3 ("upcall: Check for recirc_id in ukey_create_from_dpif_flow()")
Signed-off-by: Joe Stringer <joe at ovn.org>
Reviewed-by: Greg Rose <gvrose8192 at gmail.com>
Acked-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/01122c2ac158...6f3f122bd733


More information about the git mailing list