[ovs-git] [openvswitch/ovs] a19304: datapath-windows: Update Orig Tuple to use ICMP Ty...
GitHub
noreply at github.com
Thu Aug 17 19:48:27 UTC 2017
Branch: refs/heads/master
Home: https://github.com/openvswitch/ovs
Commit: a1930487b0c5846885f86fa29fd99f30a00bb5ae
https://github.com/openvswitch/ovs/commit/a1930487b0c5846885f86fa29fd99f30a00bb5ae
Author: Anand Kumar <kumaranand at vmware.com>
Date: 2017-08-17 (Thu, 17 Aug 2017)
Changed paths:
M datapath-windows/ovsext/Conntrack.c
M datapath-windows/ovsext/Conntrack.h
Log Message:
-----------
datapath-windows: Update Orig Tuple to use ICMP Type and Code
- Also add some padding for the ct_endpoint's union, so that each member
of ct_endpoint's union are of same size.
Co-authored-by: Sairam Venugopal <vsairam at vmware.com>
Acked-by: Alin Gabriel Serdean <aserdean at ovn.org>
Acked-by: Shashank Ram <rams at vmware.com>
Signed-off-by: Anand Kumar <kumaranand at vmware.com>
Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>
Commit: 9fbb4a8a1031879e9c6d4d66ff24a2b034069084
https://github.com/openvswitch/ovs/commit/9fbb4a8a1031879e9c6d4d66ff24a2b034069084
Author: Anand Kumar <kumaranand at vmware.com>
Date: 2017-08-17 (Thu, 17 Aug 2017)
Changed paths:
M datapath-windows/ovsext/Conntrack-nat.c
Log Message:
-----------
datapath-windows: Do not modify port field for ICMP during SNAT/DNAT
During SNAT/DNAT, we should not be updating the port field of ct_endpoint
struct, as ICMP packets do not have port information. Since port and
icmp_id are overlapped in ct_endpoint struct, icmp_id gets changed.
As a result, NAT look up fails to find a matching entry.
This patch addresses this issue by not modifying icmp_id field during
SNAT/DNAT only for ICMP traffic
The current NAT module doesn't take the ICMP type/code into account
during the lookups. Fix this to make it similar with the other conntrack
module.
Acked-by: Shashank Ram <rams at vmware.com>
Acked-by: Alin Gabriel Serdean <aserdean at ovn.org>
Signed-off-by: Anand Kumar <kumaranand at vmware.com>
Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>
Compare: https://github.com/openvswitch/ovs/compare/0164f10cf7f5...9fbb4a8a1031
More information about the git
mailing list