[ovs-git] [openvswitch/ovs] 6c7fe3: conntrack: Fix ct-clean thread crash bug.

[GitHub]

  Branch: refs/heads/branch-2.8
  Home:   https://github.com/openvswitch/ovs
  Commit: 6c7fe347a4e483995e81a8435dc2dd5e2f7caf17
      https://github.com/openvswitch/ovs/commit/6c7fe347a4e483995e81a8435dc2dd5e2f7caf17
  Author: Lily Huang <huanglili.huang at huawei.com>
  Date:   2017-08-29 (Tue, 29 Aug 2017)

  Changed paths:
    M AUTHORS.rst
    M lib/conntrack.c

  Log Message:
  -----------
  conntrack: Fix ct-clean thread crash bug.

Conn should be removed from the connection expiry list when
the connection tracker experiences NAT resource exhaustion
and the connection needing NAT mapping cannot get it.
If this is not done, the connection tracker can crash during
cleanup of expired connections by the clean thread.

This crash will be triggered when a established flow do ct(nat)
again, like
"ip,actions=ct(table=1)
 table=1,in_port=1,ip,actions=ct(commit,nat(dst=5.5.5.5)),2
 table=1,in_port=2,ip,ct_state=+est,actions=1
 table=1,in_port=1,ip,ct_state=+est,actions=2"

Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.")
Signed-off-by: Lili Huang <huanglili.huang at huawei.com>
Signed-off-by: Darrell Ball <dlu998 at gmail.com>