[ovs-git] [openvswitch/ovs] 0cc542: tests: Use $(MKDIR_P) to avoid races.

GitHub noreply at github.com
Wed Dec 6 18:23:49 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 0cc54252c94bafd195d95694050354deb8fab3de
      https://github.com/openvswitch/ovs/commit/0cc54252c94bafd195d95694050354deb8fab3de
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-12-06 (Wed, 06 Dec 2017)

  Changed paths:
    M tests/automake.mk

  Log Message:
  -----------
  tests: Use $(MKDIR_P) to avoid races.

"test -d x || mkdir x" has a race when invoked in parallel: it is possible
for two processes to both see that 'x' does not exist and both try to
create it, and if that happens then one of them will fail.  This avoids
the problem.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Reviewed-by: Greg Rose <gvrose8192 at gmail.com>


  Commit: 07754b23ee5027508d64804d445e617b017cc2d1
      https://github.com/openvswitch/ovs/commit/07754b23ee5027508d64804d445e617b017cc2d1
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-12-06 (Wed, 06 Dec 2017)

  Changed paths:
    M tests/automake.mk

  Log Message:
  -----------
  tests: Use $(MKDIR_P) instead of mkdir -p.

It is more portable.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Reviewed-by: Greg Rose <gvrose8192 at gmail.com>


Compare: https://github.com/openvswitch/ovs/compare/081afa70fd77...07754b23ee50


More information about the git mailing list