[ovs-git] [openvswitch/ovs] 2484d6: tests: Use $(MKDIR_P) to avoid races.

GitHub noreply at github.com
Wed Dec 6 18:25:40 UTC 2017


  Branch: refs/heads/branch-2.8
  Home:   https://github.com/openvswitch/ovs
  Commit: 2484d63ee0b197a90a341b1a1884840dd56ee317
      https://github.com/openvswitch/ovs/commit/2484d63ee0b197a90a341b1a1884840dd56ee317
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-12-06 (Wed, 06 Dec 2017)

  Changed paths:
    M tests/automake.mk

  Log Message:
  -----------
  tests: Use $(MKDIR_P) to avoid races.

"test -d x || mkdir x" has a race when invoked in parallel: it is possible
for two processes to both see that 'x' does not exist and both try to
create it, and if that happens then one of them will fail.  This avoids
the problem.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Reviewed-by: Greg Rose <gvrose8192 at gmail.com>


  Commit: 9a278b9ed5ae69481b18d4d37fb2a545bf8bef4a
      https://github.com/openvswitch/ovs/commit/9a278b9ed5ae69481b18d4d37fb2a545bf8bef4a
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-12-06 (Wed, 06 Dec 2017)

  Changed paths:
    M tests/automake.mk

  Log Message:
  -----------
  tests: Use $(MKDIR_P) instead of mkdir -p.

It is more portable.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Reviewed-by: Greg Rose <gvrose8192 at gmail.com>


Compare: https://github.com/openvswitch/ovs/compare/a07b7dafcf08...9a278b9ed5ae


More information about the git mailing list