[ovs-git] [openvswitch/ovs] d3aed7: tests: Use $(MKDIR_P) to avoid races.

GitHub noreply at github.com
Wed Dec 6 18:25:48 UTC 2017


  Branch: refs/heads/branch-2.7
  Home:   https://github.com/openvswitch/ovs
  Commit: d3aed7210f9bc8ce3c398a341e82cd252a5e6ad8
      https://github.com/openvswitch/ovs/commit/d3aed7210f9bc8ce3c398a341e82cd252a5e6ad8
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-12-06 (Wed, 06 Dec 2017)

  Changed paths:
    M tests/automake.mk

  Log Message:
  -----------
  tests: Use $(MKDIR_P) to avoid races.

"test -d x || mkdir x" has a race when invoked in parallel: it is possible
for two processes to both see that 'x' does not exist and both try to
create it, and if that happens then one of them will fail.  This avoids
the problem.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Reviewed-by: Greg Rose <gvrose8192 at gmail.com>


  Commit: fb76004bb33ee840b293317488bf037008e778d0
      https://github.com/openvswitch/ovs/commit/fb76004bb33ee840b293317488bf037008e778d0
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-12-06 (Wed, 06 Dec 2017)

  Changed paths:
    M tests/automake.mk

  Log Message:
  -----------
  tests: Use $(MKDIR_P) instead of mkdir -p.

It is more portable.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Reviewed-by: Greg Rose <gvrose8192 at gmail.com>


Compare: https://github.com/openvswitch/ovs/compare/e7b9b17cd096...fb76004bb33e


More information about the git mailing list