[ovs-git] [openvswitch/ovs] 88fcbb: tests: Use $(MKDIR_P) to avoid races.

GitHub noreply at github.com
Wed Dec 6 18:25:50 UTC 2017


  Branch: refs/heads/branch-2.6
  Home:   https://github.com/openvswitch/ovs
  Commit: 88fcbbbfd82d6c1a105b6d4ede612431e3f8812d
      https://github.com/openvswitch/ovs/commit/88fcbbbfd82d6c1a105b6d4ede612431e3f8812d
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-12-06 (Wed, 06 Dec 2017)

  Changed paths:
    M tests/automake.mk

  Log Message:
  -----------
  tests: Use $(MKDIR_P) to avoid races.

"test -d x || mkdir x" has a race when invoked in parallel: it is possible
for two processes to both see that 'x' does not exist and both try to
create it, and if that happens then one of them will fail.  This avoids
the problem.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Reviewed-by: Greg Rose <gvrose8192 at gmail.com>


  Commit: c89bd190ea163f0ce6938587ed8f803f03740409
      https://github.com/openvswitch/ovs/commit/c89bd190ea163f0ce6938587ed8f803f03740409
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-12-06 (Wed, 06 Dec 2017)

  Changed paths:
    M tests/automake.mk

  Log Message:
  -----------
  tests: Use $(MKDIR_P) instead of mkdir -p.

It is more portable.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Reviewed-by: Greg Rose <gvrose8192 at gmail.com>


Compare: https://github.com/openvswitch/ovs/compare/b9038a3676e2...c89bd190ea16


More information about the git mailing list