[ovs-git] [openvswitch/ovs] 14347f: stream-unix: Give accepted sockets distinct names ...

GitHub noreply at github.com
Fri Dec 8 22:25:18 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 14347f3e8276e555eeffb03e9e07564f1634f0db
      https://github.com/openvswitch/ovs/commit/14347f3e8276e555eeffb03e9e07564f1634f0db
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-12-08 (Fri, 08 Dec 2017)

  Changed paths:
    M lib/stream-unix.c
    M tests/ofproto-macros.at
    M tests/ofproto.at

  Log Message:
  -----------
  stream-unix: Give accepted sockets distinct names for log messages.

At least on Linux, when process A connects to process B over a Unix
domain socket, unless process A bound its socket to a name before
it made the connection, process B gets an empty peer name.  Until
now, OVS has just reported the name of the connection as "unix".
This is not meaningful, of course.  I do not know of a good general
solution to this problem, but this commit attempts a step in the
right direction by at least giving each connection of this kind a
number: "unix#1", "unix#2", and so on.  That way, in log messages
one can at least see which messages are related to a particular
connection.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>




More information about the git mailing list