[ovs-git] [openvswitch/ovs] 538372: Windows: Fixing Windows C++ compilation issues wit...

GitHub noreply at github.com
Tue Dec 19 22:28:15 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 538372329b4caef36c8706cb90107a557cfce2ae
      https://github.com/openvswitch/ovs/commit/538372329b4caef36c8706cb90107a557cfce2ae
  Author: Shireesh Singh <shireeshcse07 at gmail.com>
  Date:   2017-12-19 (Tue, 19 Dec 2017)

  Changed paths:
    M include/openvswitch/util.h

  Log Message:
  -----------
  Windows: Fixing Windows C++ compilation issues with unnamed structure

MSVC does not allow to redefine unnamed structure in union.
Thus, this fix defines the struct outside of the anonymous union
in order to calculate the padded size.

Signed-off-by: Shireesh Kumar Singh <shireeshkum at vmware.com>
Co-authored-by:Sairam Venugopal <vsairam at vmware.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 8bfc3c105de4c190190d762fa04948ee20e92e58
      https://github.com/openvswitch/ovs/commit/8bfc3c105de4c190190d762fa04948ee20e92e58
  Author: Shireesh Singh <shireeshcse07 at gmail.com>
  Date:   2017-12-19 (Tue, 19 Dec 2017)

  Changed paths:
    M lib/netlink.h
    M lib/ovs-thread.h
    M lib/packets.h
    M lib/socket-util.h

  Log Message:
  -----------
  lib: Adding explicit typecasts to fix C++ compilation issues

C++ does not allow implicit conversion from void pointer to a specific
pointer type. This change adds explicit typecasts to appropriate types
wherever needed.

Signed-off-by: Shireesh Kumar Singh <shireeshkum at vmware.com>
Signed-off-by: Sairam Venugopal <vsairam at vmware.com>
Co-authored-by:  Sairam Venugopal <vsairam at vmware.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: b35bd845d7679123d8f0dd5b7e9eb8307148a8fe
      https://github.com/openvswitch/ovs/commit/b35bd845d7679123d8f0dd5b7e9eb8307148a8fe
  Author: Shireesh Singh <shireeshcse07 at gmail.com>
  Date:   2017-12-19 (Tue, 19 Dec 2017)

  Changed paths:
    M lib/ovs-atomic-msvc.h

  Log Message:
  -----------
  Windows: Changing explicit typecasts to fix C++ compilation issues

C++ compiler cannot find matching function calls due to
unsupported implicit conversions. This change adds appropriate
explicit typecasts to match the existing function prototypes.

Signed-off-by: Shireesh Kumar Singh <shireeshkum at vmware.com>
Signed-off-by: Sairam Venugopal <vsairam at vmware.com>
Co-authored-by: Sairam Venugopal <vsairam at vmware.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: c0f84d8f07da769ac85299124c8770bb13de6098
      https://github.com/openvswitch/ovs/commit/c0f84d8f07da769ac85299124c8770bb13de6098
  Author: Shireesh Singh <shireeshcse07 at gmail.com>
  Date:   2017-12-19 (Tue, 19 Dec 2017)

  Changed paths:
    M lib/unaligned.h

  Log Message:
  -----------
  unaligned.h: Fixed C++ compilation issue due to designated initializers

This change fixes compilation issues related to designated
initializers, which are not supported by C++ compiler.

Signed-off-by: Shireesh Kumar Singh <shireeshkum at vmware.com>
Signed-off-by: Sairam Venugopal <vsairam at vmware.com>
Co-authored-by: Sairam Venugopal <vsairam at vmware.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/99b09c637b02...c0f84d8f07da


More information about the git mailing list