[ovs-git] [openvswitch/ovs] 40f583: netdev-tc-offloads: Use customary types for buffer...

GitHub noreply at github.com
Fri Dec 22 19:21:18 UTC 2017


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 40f583684f75afe8676dd44a6671acb7a9ab1e34
      https://github.com/openvswitch/ovs/commit/40f583684f75afe8676dd44a6671acb7a9ab1e34
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M lib/netdev-tc-offloads.c

  Log Message:
  -----------
  netdev-tc-offloads: Use customary types for buffer.

This function uses local array set_buff[] to store Netlink attributes.
It declares set_buff as an array of character pointers, which is a strange
type for a buffer of non-character-pointer objects.  In OVS it is
customary to use an ofpbuf with a stub of uint64_t objecs (to ensure
proper alignment, otherwise uint8_t would be more usual).  This commit
changes to that more usual form.

Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: c34a5515e2cb1a5e51c77de8fd6596e7035c93ff
      https://github.com/openvswitch/ovs/commit/c34a5515e2cb1a5e51c77de8fd6596e7035c93ff
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M lib/odp-util.c

  Log Message:
  -----------
  odp-util: Use flexible sized buffer to hold Geneve options.

The 'mask' buffer in parse_odp_action() is supposed to always be big
enough:
  /* 'mask' is big enough to hold any key. */

Geneve options can be really big and the comment was wrong.  In addition,
the user might supply more options than can really fit in any case, so
we might as well just use a stub.

Found by libfuzzer.

Reported-by: Bhargava Shastry <bshastry at sec.t-labs.tu-berlin.de>
Signed-off-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/404682c60a53...c34a5515e2cb


More information about the git mailing list