[ovs-git] [openvswitch/ovs] b2befd: sparse: Add guards to prevent FreeBSD-incompatible...

GitHub noreply at github.com
Fri Dec 22 20:58:31 UTC 2017

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: b2befd5bb2db811ac0273bc52be158d3476a5ff7
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2017-12-22 (Fri, 22 Dec 2017)

  Changed paths:
    M configure.ac
    M include/openvswitch/packets.h
    M include/sparse/arpa/inet.h
    M include/sparse/automake.mk
    M include/sparse/netinet/in.h
    A include/sparse/sys/types.h
    M lib/bfd.c
    M lib/bundle.c
    M lib/bundle.h
    M lib/byte-order.h
    M lib/classifier.c
    M lib/csum.c
    M lib/dpctl.c
    M lib/dpif-netdev.c
    M lib/learning-switch.c
    M lib/lldp/lldpd-structs.h
    M lib/lldp/lldpd.c
    M lib/lldp/lldpd.h
    M lib/multipath.c
    M lib/netdev-linux.c
    M lib/netdev-native-tnl.c
    M lib/netdev-vport.c
    M lib/netdev.c
    M lib/netlink.h
    M lib/odp-execute.c
    M lib/odp-util.c
    M lib/ofp-actions.c
    M lib/ofp-ed-props.c
    M lib/ofp-parse.c
    M lib/ovs-lldp.c
    M lib/ovs-router.c
    M lib/ovs-router.h
    M lib/packets.c
    M lib/route-table.c
    M lib/rstp-state-machines.c
    M lib/rstp.c
    M lib/sflow_api.h
    M lib/smap.h
    M lib/socket-util.c
    M lib/stream.c
    M lib/tc.h
    M lib/util.h
    M lib/vconn.c
    M ofproto/in-band.c
    M ofproto/in-band.h
    M ofproto/netflow.c
    M ofproto/ofproto-dpif-xlate-cache.c
    M ofproto/ofproto-dpif-xlate-cache.h
    M ofproto/ofproto-dpif-xlate.c
    M ovn/lib/ovn-l7.h
    M tests/test-csum.c
    M tests/test-sflow.c
    M utilities/ovs-dpctl.c

  Log Message:
  sparse: Add guards to prevent FreeBSD-incompatible #include order.

FreeBSD insists that <sys/types.h> be included before <netinet/in.h> and
that <netinet/in.h> be included before <arpa/inet.h>.  This adds guards to
the "sparse" headers to yield a warning if this order is violated.  This
commit also adjusts the order of many #includes to suit this requirement.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>

More information about the git mailing list