[ovs-git] [openvswitch/ovs] 49dd11: ofproto/bond: Validate active-slave mac.

GitHub noreply at github.com
Wed Feb 15 20:52:53 UTC 2017


  Branch: refs/heads/branch-2.5
  Home:   https://github.com/openvswitch/ovs
  Commit: 49dd114138d747f20cc15a9705a5f9f84775c01c
      https://github.com/openvswitch/ovs/commit/49dd114138d747f20cc15a9705a5f9f84775c01c
  Author: nickcooper-zhangtonghao <nic at opencloud.tech>
  Date:   2017-02-15 (Wed, 15 Feb 2017)

  Changed paths:
    M ofproto/bond.c

  Log Message:
  -----------
  ofproto/bond: Validate active-slave mac.

That the mac of active-slave is invalid(e.g. 00:00:00:00:00:00)
is incidental. The reason is described as below.

In the bridge_reconfig():
1. bond devices created in port_configure().
2. the bonded interfaces may be disabled even calling bridge_run__(),
   because the interface link is not ready.

The OvS will run bridge_run__() in next loop. In next loop, the
active-slave may be selected. But OvS the bridge_reconfig() again,
the bond_reconfigure() set active-slave mac zero and flag false.
If using the 'ovs-appctl bond/show bond-name' to check active-slave
mac, you will find the mac is zero and mac in the ovsdb is also zero.

The active_slave_mac and active_slave_changed should be initialized
when created.

Signed-off-by: nickcooper-zhangtonghao <nic at opencloud.tech>
Signed-off-by: Andy Zhou <azhou at ovn.org>




More information about the git mailing list